Re: graphlcd-base: udev rules file can't be found for fc37

2022-08-03 Thread Martin Gansser
Many thanks for the fix.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: graphlcd-base: udev rules file can't be found for fc37

2022-08-03 Thread Leigh Scott
Fixed 
https://src.fedoraproject.org/rpms/graphlcd-base/c/eff3f3c0a0817bd5bdfad4d95eabb4a87bab9440?branch=rawhide
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: graphlcd-base: udev rules file can't be found for fc37

2022-08-03 Thread Tomasz Torcz
On Wed, Aug 03, 2022 at 12:58:16PM -, Martin Gansser wrote:
> Hi,
> 
> I want to fix the build of graphlcd-base-2.0.3 for fc37 because the udev 
> rules file cannot be found [1].
> ...
> File not found: 
> /builddir/build/BUILDROOT/graphlcd-base-2.0.3-1.fc37.x86_64/etc/udev/rules.d/*-graphlcd-base.rules
> ..
> I have already added a if condition to the spec file so that for <= fc36 the 
> udev_rules_dir "/usr/lib/udev/rules.d"
> and for fc37 the udev rules dir "/etc/udev/rules.d" is used, but the 
> compiling fails on koji, because it cannot find the rules file.

  This looks incorrect. Package-provided rules files should go into /usr…,
/etc… directory is for sysadmin overrides.  You should use %_udevrulesdir 
coming from systemd RPM macros,
no matter which Fedora version.
You seem to have been using the macro before – it's commented out in 
graphlcd-base.spec file.

  Anyway, the build log shows that software was compiled, but the rule
file was not installed. I see that installation in the Makefile is
guarded with following test:

# Checking for UDEVRULESDIR without DESTDIR (check if build system uses systemd)
ifneq ($(wildcard $(UDEVRULESDIR)/.),)
install -d $(DESTDIR)$(UDEVRULESDIR)
install -m 644 $(UDEVRULE) $(DESTDIR)$(UDEVRULESDIR)

So this is probably a place where installation goes wrong, but I do not
know Makefile syntax enough to guess how.

-- 
Tomasz Torcz   There exists no separation between gods and men:
to...@pipebreaker.pl   one blends softly casual into the other.  — Frank 
Herbert
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


graphlcd-base: udev rules file can't be found for fc37

2022-08-03 Thread Martin Gansser
Hi,

I want to fix the build of graphlcd-base-2.0.3 for fc37 because the udev rules 
file cannot be found [1].
...
File not found: 
/builddir/build/BUILDROOT/graphlcd-base-2.0.3-1.fc37.x86_64/etc/udev/rules.d/*-graphlcd-base.rules
..
I have already added a if condition to the spec file so that for <= fc36 the 
udev_rules_dir "/usr/lib/udev/rules.d"
and for fc37 the udev rules dir "/etc/udev/rules.d" is used, but the compiling 
fails on koji, because it cannot find the rules file.

[1] https://kojipkgs.fedoraproject.org//work/tasks/3103/90423103/build.log
[2] 
https://martinkg.fedorapeople.org/ErrorReports/glcdgraphics/graphlcd-base.spec
[3] 
https://martinkg.fedorapeople.org/ErrorReports/glcdgraphics/graphlcd-base-2.0.3-1.fc36.src.rpm

Any help would be great
Regards
Martin
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue