Re: libcroco retired on Rawhide, breaking builds

2020-08-03 Thread Michael Catanzaro


On Mon, Aug 3, 2020 at 9:55 am, Fabio Valentini  
wrote:

FWIW, I've been resubmitting koji builds for all FTBFS packages that
build locally (with mockbuild --enablerepo local) for the past few
days.
Almost 100 packages that failed due to transient buildroot issues
(broken gcc/annobin, broken gettext, broken binutils, etc.) were now
built successfully.
I'll continue to run my script until only real build issues are left
(and there's more than 1000 packages with CMake issues, so it won't be
much longer now).


Thanks Fabio. I'll apologize again for this screw-up. What I did was 
textbook case of how not to maintain a Fedora package... and during the 
mass rebuild too. :(


___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-03 Thread Michael J Gruber
In support of Kevin's statement:

Out-of-source builds make sense if you want to build from the source multiple 
times, or if you want to ensure that the source is immutable (for the build 
process).

None of this seems to be the goal of the Change which was motivated solely by 
general "you should do out-of-source builds".

In fact, in Fedora we would need to either make the source immutable after 
%prep, or do the %prep step when building the source rpm and then build 
binaries from that srpm, or in keep the prepped source tree in the lookaside 
cache (in addition to the upstream source; this requires the packer to prep).

So, "pointless" describes this Change really well, until there is more to build 
upon this change.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-03 Thread Fabio Valentini
On Mon, Aug 3, 2020 at 3:14 AM Elliott Sales de Andrade
 wrote:
> Thanks. Out of my 84 FTBFS, 75% were due to this breakage. I've
> already re-submitted them and they've passed, but I suspect a
> reasonable number of the failures in the second pass might be related
> to this.
>
> Only 2 were related to the cmake change.

FWIW, I've been resubmitting koji builds for all FTBFS packages that
build locally (with mockbuild --enablerepo local) for the past few
days.
Almost 100 packages that failed due to transient buildroot issues
(broken gcc/annobin, broken gettext, broken binutils, etc.) were now
built successfully.
I'll continue to run my script until only real build issues are left
(and there's more than 1000 packages with CMake issues, so it won't be
much longer now).

Fabio
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-02 Thread Elliott Sales de Andrade
On Sat, 1 Aug 2020 at 14:42, Kevin Fenzi  wrote:
>
> On Sat, Aug 01, 2020 at 06:35:30PM +0100, Richard W.M. Jones wrote:
> > On Sat, Aug 01, 2020 at 03:13:50PM +0200, Fabio Valentini wrote:
> > > On Sat, Aug 1, 2020 at 2:44 PM Richard W.M. Jones  
> > > wrote:
> > > >
> > > > On Sat, Aug 01, 2020 at 03:25:48AM -0400, Elliott Sales de Andrade 
> > > > wrote:
> > > > > libcroco was retired on Rawhide, but the libcroco-0.6.so.3()(64bit) it
> > > > > provides is used by libtextstyle.so.0, part of gettext.
> > > > >
> > > > > gettext is used by many many things. Please unretire libcroco, or
> > > > > rebuild gettext without it.
> > > >
> > > > Yes, can confirm this breaks the whole virt stack, again.  Any
> > > > "Second build" that needs libvirt has been broken by this.
> > > >
> > > > I really think we should redo this whole mass rebuild from the start.
> > > >
> > > > Rich.
> > >
> > > Well, gettext-0.20.2-4.fc33 without the libcroco dependency has now
> > > been successfully built for f33-rebuild:
> > > https://koji.fedoraproject.org/koji/buildinfo?buildID=1574351
> > >
> > > It looks like f33-rebuild doesn't use its own packages for the
> > > buildroot though, so anything using gettext is broken in both f33 and
> > > f33-rebuild :(
> > > Can we get gettext-0.20.2-4.fc33 tagged into the f33? I'd do it
> > > myself, if I was sure not to break anything ... would "koji tag
> > > f33-updates-candidate gettext-0.20.2-4.fc33" be enough?
>
> Yeah, I tagged it in a bit ago, sorry for not updating the list.
>

Thanks. Out of my 84 FTBFS, 75% were due to this breakage. I've
already re-submitted them and they've passed, but I suspect a
reasonable number of the failures in the second pass might be related
to this.

Only 2 were related to the cmake change.

> > I don't know if this was done already, but libvirt is now installable
> > and I was able to build virt-v2v, so it seems I'm now able to build
> > the remaining virt packages.
> >
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=48382603
> >
> > https://kojipkgs.fedoraproject.org//work/tasks/2636/48382636/root.log
> >  => gettext 0.20.2-4.fc33
> > libvirt 6.5.0-1.fc33
>
> We are just checking to make sure all the f33-rebuild packages are
> signed, and then will be merging the tag.
>
> Waiting on 2020-08-01 17:12:08,374 INFO: Calling koji to write 228467 rpms
>
> Fingers crossed.
>
> kevin

-- 
Elliott
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Kevin Kofler
Gary Buhrmaster wrote:
> On Sat, Aug 1, 2020 at 9:23 PM Kevin Kofler 
> wrote:
>> Especially the CMake one was completely pointless.
> 
> The goal was not pointless, but I will assert that the
> implementation was flawed in practice.

The goal was to make more packages do out-of-source builds, which is a 
build-time-only implementation detail that should theoretically have no 
effect whatsoever on the produced packages (though, in practice, at least 
the directory structure of the -debugsource packages will be different). 
Hence, an end user will probably not notice any difference whatsoever, which 
is why I call the change pointless.

I also do not believe that the change really makes things easier for 
packagers, just different. And different is bad when it means that dozens of 
specfiles have to be adapted to such an incompatible change. The boilerplate 
to do an out-of-source build (even with ancient versions of CMake that did 
not have the -S and -B options) was very simple and widely used.

I also think that it is more valuable to be backwards-compatible with older 
versions of Fedora (and where possible, also with RHEL/CentOS and EPEL) than 
to be compatible with other, unrelated distributions that happen to also use 
RPM. The CMake change, on the other hand, improved cross-compatibility with 
other distributions at the expense of backwards compatibility with our own 
distribution.

LTO at least promises tangible benefits for the end user. But maybe it 
should have been opt-in (via the specfile) at first?

Kevin Kofler
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Gary Buhrmaster
On Sat, Aug 1, 2020 at 9:23 PM Kevin Kofler  wrote:
> Especially the CMake one was completely pointless.

The goal was not pointless, but I will assert that the
implementation was flawed in practice.

I would suggest that a lesson to be learned is that changes
that are expected to require updates to > 256(*) packages
OR any of the core set of packages, MUST target
completion of those updates BEFORE the mass rebuild
schedule (and not target the beta release, as this one did).

Such requirements would likely either force the change
to be less impactful to existing packages and packagers(**),
or force the proposers to do the work they committed to
accomplish much earlier in the process (or, perhaps more
likely, push it off for another release).

Hindsight is 20/20, so this is a lesson for the next time
(and there will always be a next time).




(*) Arbitrary power of two.  Pick a different value if
you wish.  The point is when the proposal says
the change may impact > 2**10 packages, that
should have raised a flag of some color.

(**) Many people have suggested alternative
implementations that would have supported
allowing existing packages/packagers more
time to complete the transition(s), and at least
a few were likely viable, although it would have
extended the entire process time frame.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Kevin Kofler
Michael J Gruber wrote:
> I think we should test build with changes like cmake or LTO in isolation
> from the typical mass rebuild which exposes many other problems.

I think we should just not do this kind of changes that mass-break packages 
at all. Especially the CMake one was completely pointless.

Kevin Kofler
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Kevin Fenzi
On Sat, Aug 01, 2020 at 06:35:30PM +0100, Richard W.M. Jones wrote:
> On Sat, Aug 01, 2020 at 03:13:50PM +0200, Fabio Valentini wrote:
> > On Sat, Aug 1, 2020 at 2:44 PM Richard W.M. Jones  wrote:
> > >
> > > On Sat, Aug 01, 2020 at 03:25:48AM -0400, Elliott Sales de Andrade wrote:
> > > > libcroco was retired on Rawhide, but the libcroco-0.6.so.3()(64bit) it
> > > > provides is used by libtextstyle.so.0, part of gettext.
> > > >
> > > > gettext is used by many many things. Please unretire libcroco, or
> > > > rebuild gettext without it.
> > >
> > > Yes, can confirm this breaks the whole virt stack, again.  Any
> > > "Second build" that needs libvirt has been broken by this.
> > >
> > > I really think we should redo this whole mass rebuild from the start.
> > >
> > > Rich.
> > 
> > Well, gettext-0.20.2-4.fc33 without the libcroco dependency has now
> > been successfully built for f33-rebuild:
> > https://koji.fedoraproject.org/koji/buildinfo?buildID=1574351
> > 
> > It looks like f33-rebuild doesn't use its own packages for the
> > buildroot though, so anything using gettext is broken in both f33 and
> > f33-rebuild :(
> > Can we get gettext-0.20.2-4.fc33 tagged into the f33? I'd do it
> > myself, if I was sure not to break anything ... would "koji tag
> > f33-updates-candidate gettext-0.20.2-4.fc33" be enough?

Yeah, I tagged it in a bit ago, sorry for not updating the list. 

> I don't know if this was done already, but libvirt is now installable
> and I was able to build virt-v2v, so it seems I'm now able to build
> the remaining virt packages.
> 
> https://koji.fedoraproject.org/koji/taskinfo?taskID=48382603
> 
> https://kojipkgs.fedoraproject.org//work/tasks/2636/48382636/root.log
>  => gettext 0.20.2-4.fc33
> libvirt 6.5.0-1.fc33

We are just checking to make sure all the f33-rebuild packages are
signed, and then will be merging the tag. 

Waiting on 2020-08-01 17:12:08,374 INFO: Calling koji to write 228467 rpms

Fingers crossed. 

kevin


signature.asc
Description: PGP signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Richard W.M. Jones
On Sat, Aug 01, 2020 at 03:13:50PM +0200, Fabio Valentini wrote:
> On Sat, Aug 1, 2020 at 2:44 PM Richard W.M. Jones  wrote:
> >
> > On Sat, Aug 01, 2020 at 03:25:48AM -0400, Elliott Sales de Andrade wrote:
> > > libcroco was retired on Rawhide, but the libcroco-0.6.so.3()(64bit) it
> > > provides is used by libtextstyle.so.0, part of gettext.
> > >
> > > gettext is used by many many things. Please unretire libcroco, or
> > > rebuild gettext without it.
> >
> > Yes, can confirm this breaks the whole virt stack, again.  Any
> > "Second build" that needs libvirt has been broken by this.
> >
> > I really think we should redo this whole mass rebuild from the start.
> >
> > Rich.
> 
> Well, gettext-0.20.2-4.fc33 without the libcroco dependency has now
> been successfully built for f33-rebuild:
> https://koji.fedoraproject.org/koji/buildinfo?buildID=1574351
> 
> It looks like f33-rebuild doesn't use its own packages for the
> buildroot though, so anything using gettext is broken in both f33 and
> f33-rebuild :(
> Can we get gettext-0.20.2-4.fc33 tagged into the f33? I'd do it
> myself, if I was sure not to break anything ... would "koji tag
> f33-updates-candidate gettext-0.20.2-4.fc33" be enough?

I don't know if this was done already, but libvirt is now installable
and I was able to build virt-v2v, so it seems I'm now able to build
the remaining virt packages.

https://koji.fedoraproject.org/koji/taskinfo?taskID=48382603

https://kojipkgs.fedoraproject.org//work/tasks/2636/48382636/root.log
 => gettext 0.20.2-4.fc33
libvirt 6.5.0-1.fc33

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Kevin Fenzi
On Sat, Aug 01, 2020 at 03:37:37PM -, Michael J Gruber wrote:
> It is tagged as
> 
> f33-rebuild
> f33-updates-candidate
> 
> now but not as
> 
> f33
> 
> and bodhi does not know about it either. Is it possible/advisable to tag it 
> as f33 directly to get the other rebuilds going again?

You can't tag directly into f33, that would break at least gating and
signing. I'll look into getting gettext in... 

kevin


signature.asc
Description: PGP signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Kevin Fenzi
On Sat, Aug 01, 2020 at 03:15:59PM +0200, Fabio Valentini wrote:
> On Sat, Aug 1, 2020 at 3:12 PM Michael J Gruber  
> wrote:
> >
> > Well, that second mass rebuild made things worse for me. 
> > The time between the two was really short - we do need time to fix things 
> > (see below).
> > The second rebuild not only forced us to rebase changes which were in QA
> > (and rewrite the changelog because of date order stubbornness)
> > but - what's worse - made the "buildroot" a moving target.
> > I do understand that we want rebuilds against current libraries
> > but this seemed to break more dependencies than before,
> > maybe because the rebuild was still in progress.

Sorry for not communicating better about the second pass. 

The goal was to just try and rebuild everything that _failed_ in the
first pass. We have a lot of packages that failed due to transient
failures like the s390x package cache having issues on tuesday night and
broken binutils, etc. 

> I agree, adding the "Mass Rebuild Second Attempt" commit and release
> bump was completely unnecessary ... (especially since NEVRs for builds
> that didn't succeed aren't reserved, and are overwritten by any
> successful build with the same NEVR ...)

Normally we would have just resubmitted them, but the eln folks asked us
to do another bump to pick up fixes that were not in the first one. 

The mass rebuild is done now, will get merged soon. 

kevin


signature.asc
Description: PGP signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Michael J Gruber
It is tagged as

f33-rebuild
f33-updates-candidate

now but not as

f33

and bodhi does not know about it either. Is it possible/advisable to tag it as 
f33 directly to get the other rebuilds going again?
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Michael Catanzaro


On Sat, Aug 1, 2020 at 8:30 am, Michael Catanzaro 
 wrote:

I don't think there's anything else that needs to be done now.


OK, I see Fabio's mail that it isn't tagged yet:


Can we get gettext-0.20.2-4.fc33 tagged into the f33? I'd do it
myself, if I was sure not to break anything ... would "koji tag
f33-updates-candidate gettext-0.20.2-4.fc33" be enough?



___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Michael Catanzaro


I got permission from the package owner (Dodji) before retiring it. 
I'll check with you first next time, sorry.


I don't think there's anything else that needs to be done now. First we 
have to wait for the mass rebuild script to finish. Then we see what 
all failed


___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Michael Catanzaro

Sorry, this is my fault.

On Sat, Aug 1, 2020 at 3:25 am, Elliott Sales de Andrade 
 wrote:

gettext is used by many many things. Please unretire libcroco, or
rebuild gettext without it.


It was successfully rebuilt last night by releng, I assume by the mass 
rebuild script. We were trying to rebuild it yesterday, but failed. I 
tested the gettext build before retiring libcroco, but I only did a 
mockbuild and the real build was only failing on armv7hl, so my 
mockbuild had no chance of catching the breakage. Initially, the 
armv7hl build of gettext failed due to a testsuite failure, so I 
thought we should just do a build without the tests and it would be no 
problem. But when we tried that yesterday, a *second* problem appeared 
where libtool was somehow dropping part of a shell command that it 
runs. I have no clue what was going wrong there and was worried I'd 
have to do a deep dive into libtool today to try for a successful 
build. I assume somebody fixed something somewhere, because there is a 
successful build now.


Yes, I know I did this in the wrong order, I should not have touched 
libcroco before I had a successful rebuild of gettext. I also didn't 
realize the mass rebuild was still in progress. Very sorry. :S


___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Fabio Valentini
On Sat, Aug 1, 2020 at 3:12 PM Michael J Gruber  wrote:
>
> Well, that second mass rebuild made things worse for me. The time between the 
> two was really short - we do need time to fix things (see below). The second 
> rebuild not only forced us to rebase changes which were in QA (and rewrite 
> the changelog because of date order stubbornness) but - what's worse - made 
> the "buildroot" a moving target. I do understand that we want rebuilds 
> against current libraries but this seemed to break more dependencies than 
> before, maybe because the rebuild was still in progress.

I agree, adding the "Mass Rebuild Second Attempt" commit and release
bump was completely unnecessary ... (especially since NEVRs for builds
that didn't succeed aren't reserved, and are overwritten by any
successful build with the same NEVR ...)

Fabio
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Fabio Valentini
On Sat, Aug 1, 2020 at 2:44 PM Richard W.M. Jones  wrote:
>
> On Sat, Aug 01, 2020 at 03:25:48AM -0400, Elliott Sales de Andrade wrote:
> > libcroco was retired on Rawhide, but the libcroco-0.6.so.3()(64bit) it
> > provides is used by libtextstyle.so.0, part of gettext.
> >
> > gettext is used by many many things. Please unretire libcroco, or
> > rebuild gettext without it.
>
> Yes, can confirm this breaks the whole virt stack, again.  Any
> "Second build" that needs libvirt has been broken by this.
>
> I really think we should redo this whole mass rebuild from the start.
>
> Rich.

Well, gettext-0.20.2-4.fc33 without the libcroco dependency has now
been successfully built for f33-rebuild:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1574351

It looks like f33-rebuild doesn't use its own packages for the
buildroot though, so anything using gettext is broken in both f33 and
f33-rebuild :(
Can we get gettext-0.20.2-4.fc33 tagged into the f33? I'd do it
myself, if I was sure not to break anything ... would "koji tag
f33-updates-candidate gettext-0.20.2-4.fc33" be enough?

Fabio
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Kalev Lember

On 8/1/20 09:25, Elliott Sales de Andrade wrote:

libcroco was retired on Rawhide, but the libcroco-0.6.so.3()(64bit) it
provides is used by libtextstyle.so.0, part of gettext.

gettext is used by many many things. Please unretire libcroco, or
rebuild gettext without it.


This is unfortunate.

Michael, can you next time discuss with me first before retiring GNOME 
packages that I take care of? Thanks!


I don't have time right now to untangle this mess so someone else has to 
do that.


--
Kalev
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Michael J Gruber
Well, that second mass rebuild made things worse for me. The time between the 
two was really short - we do need time to fix things (see below). The second 
rebuild not only forced us to rebase changes which were in QA (and rewrite the 
changelog because of date order stubbornness) but - what's worse - made the 
"buildroot" a moving target. I do understand that we want rebuilds against 
current libraries but this seemed to break more dependencies than before, maybe 
because the rebuild was still in progress.

On the necessary fixes:
I remember some system-wide changes that were doen really well (e.g. python 
setuptools related): e-mailing affected maintainers with clear information what 
is changing and how to adapt.

Not so with cmake: Perfectly working specs were turned into FTBFS without 
heads-up for affected maintainers (other than on devel). The change description 
offers no information about what exactly changed (before/after of the macros) 
but 3 different approaches to adjust, leaving it up to the maintainers to find 
out which one works (sometimes none of them). Many learned about this just 
because of the mass rebuild, where a build can fail for many reasons rooted in 
other packages. This makes it really difficult to fix your own package.

Plus LTO ...

I think we should test build with changes like cmake or LTO in isolation from 
the typical mass rebuild which exposes many other problems.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Richard W.M. Jones
On Sat, Aug 01, 2020 at 03:25:48AM -0400, Elliott Sales de Andrade wrote:
> libcroco was retired on Rawhide, but the libcroco-0.6.so.3()(64bit) it
> provides is used by libtextstyle.so.0, part of gettext.
> 
> gettext is used by many many things. Please unretire libcroco, or
> rebuild gettext without it.

Yes, can confirm this breaks the whole virt stack, again.  Any
"Second build" that needs libvirt has been broken by this.

I really think we should redo this whole mass rebuild from the start.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


libcroco retired on Rawhide, breaking builds

2020-08-01 Thread Elliott Sales de Andrade
libcroco was retired on Rawhide, but the libcroco-0.6.so.3()(64bit) it
provides is used by libtextstyle.so.0, part of gettext.

gettext is used by many many things. Please unretire libcroco, or
rebuild gettext without it.

-- 
Elliott
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org