Re: sqlcipher soname change in rawhide
On Fri, Aug 26, 2022 at 3:59 PM Fabio Valentini wrote: > > On Fri, Aug 26, 2022, 21:20 Demi Marie Obenour wrote: >> >> On 8/26/22 06:12, Fabio Valentini wrote: >> > On Fri, Aug 26, 2022 at 3:12 AM Carl George wrote: >> >> >> >> sqlcipher has been requested to be built in epel9 [0]. Rather than >> >> branching it from the current rawhide version, I plan to update >> >> rawhide to the latest upstream version first [1]. This involves an >> >> soname change from libsqlcipher-3.34.1.so.0 to >> >> libsqlcipher-3.39.2.so.0. This will require six packages to be >> >> rebuilt. >> >> >> >> [root@f38-container:~]# repoquery --repo >> >> rawhide-source,rawhide-modular-source \ >> >>> --quiet --queryformat '%{name}' --archlist src --whatrequires >> >>> sqlcipher-devel >> >> libgda >> >> python-peewee >> >> sqlitebrowser >> >> [root@f38-container:~]# repoquery --repo >> >> rawhide-source,rawhide-modular-source \ >> >>> --quiet --queryformat '%{name}' --archlist src --whatrequires >> >>> 'pkgconfig(sqlcipher)' >> >> kmymoney >> >> rust-libsqlite3-sys >> >> skrooge >> > >> > Please do not rebuild rust-libsqlite3-sys. It is a source-only package >> > that does not ship any compiled code. >> > All packages built from rust-libsqlite3-sys are noarch (i.e. they >> > can't - by definition - contain architecture-specific binaries). >> > Any built binaries that link against libsqlcipher are only used for >> > tests, but not shipped with built packages. >> >> Rust FFI uses the ABI, not the API, so if rust-libsqlite3-sys is based on >> bindgen >> then the generated Rust code will need to be recreated. > > > Yes, and that happens on-the-fly in the crate's build.rs script, so > rebuilding the package has zero effect, because the bindings are *always* > generated from headers at build-time, and are not included in the package at > all. > > Fabio > > >> -- >> Sincerely, >> Demi Marie Obenour (she/her/hers) >> ___ >> devel mailing list -- devel@lists.fedoraproject.org >> To unsubscribe send an email to devel-le...@lists.fedoraproject.org >> Fedora Code of Conduct: >> https://docs.fedoraproject.org/en-US/project/code-of-conduct/ >> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines >> List Archives: >> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org >> Do not reply to spam, report it: >> https://pagure.io/fedora-infrastructure/new_issue > > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam, report it: > https://pagure.io/fedora-infrastructure/new_issue Thanks for the heads up on rust-libsqlite3-sys. I also realized that python-peewee doesn't link against this either, so I dropped that one from the rebuild too. I've completed the rebuilds in a side tag and merged it. https://bodhi.fedoraproject.org/updates/FEDORA-2022-647b3781fd -- Carl George ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: sqlcipher soname change in rawhide
On Fri, Aug 26, 2022, 21:20 Demi Marie Obenour wrote: > On 8/26/22 06:12, Fabio Valentini wrote: > > On Fri, Aug 26, 2022 at 3:12 AM Carl George wrote: > >> > >> sqlcipher has been requested to be built in epel9 [0]. Rather than > >> branching it from the current rawhide version, I plan to update > >> rawhide to the latest upstream version first [1]. This involves an > >> soname change from libsqlcipher-3.34.1.so.0 to > >> libsqlcipher-3.39.2.so.0. This will require six packages to be > >> rebuilt. > >> > >> [root@f38-container:~]# repoquery --repo > rawhide-source,rawhide-modular-source \ > >>> --quiet --queryformat '%{name}' --archlist src --whatrequires > sqlcipher-devel > >> libgda > >> python-peewee > >> sqlitebrowser > >> [root@f38-container:~]# repoquery --repo > rawhide-source,rawhide-modular-source \ > >>> --quiet --queryformat '%{name}' --archlist src --whatrequires > 'pkgconfig(sqlcipher)' > >> kmymoney > >> rust-libsqlite3-sys > >> skrooge > > > > Please do not rebuild rust-libsqlite3-sys. It is a source-only package > > that does not ship any compiled code. > > All packages built from rust-libsqlite3-sys are noarch (i.e. they > > can't - by definition - contain architecture-specific binaries). > > Any built binaries that link against libsqlcipher are only used for > > tests, but not shipped with built packages. > > Rust FFI uses the ABI, not the API, so if rust-libsqlite3-sys is based on > bindgen > then the generated Rust code will need to be recreated. > Yes, and that happens on-the-fly in the crate's build.rs script, so rebuilding the package has zero effect, because the bindings are *always* generated from headers at build-time, and are not included in the package at all. Fabio -- > Sincerely, > Demi Marie Obenour (she/her/hers) > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam, report it: > https://pagure.io/fedora-infrastructure/new_issue > ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: sqlcipher soname change in rawhide
On 8/26/22 06:12, Fabio Valentini wrote: > On Fri, Aug 26, 2022 at 3:12 AM Carl George wrote: >> >> sqlcipher has been requested to be built in epel9 [0]. Rather than >> branching it from the current rawhide version, I plan to update >> rawhide to the latest upstream version first [1]. This involves an >> soname change from libsqlcipher-3.34.1.so.0 to >> libsqlcipher-3.39.2.so.0. This will require six packages to be >> rebuilt. >> >> [root@f38-container:~]# repoquery --repo >> rawhide-source,rawhide-modular-source \ >>> --quiet --queryformat '%{name}' --archlist src --whatrequires >>> sqlcipher-devel >> libgda >> python-peewee >> sqlitebrowser >> [root@f38-container:~]# repoquery --repo >> rawhide-source,rawhide-modular-source \ >>> --quiet --queryformat '%{name}' --archlist src --whatrequires >>> 'pkgconfig(sqlcipher)' >> kmymoney >> rust-libsqlite3-sys >> skrooge > > Please do not rebuild rust-libsqlite3-sys. It is a source-only package > that does not ship any compiled code. > All packages built from rust-libsqlite3-sys are noarch (i.e. they > can't - by definition - contain architecture-specific binaries). > Any built binaries that link against libsqlcipher are only used for > tests, but not shipped with built packages. Rust FFI uses the ABI, not the API, so if rust-libsqlite3-sys is based on bindgen then the generated Rust code will need to be recreated. -- Sincerely, Demi Marie Obenour (she/her/hers) ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: sqlcipher soname change in rawhide
On Fri, Aug 26, 2022 at 3:12 AM Carl George wrote: > > sqlcipher has been requested to be built in epel9 [0]. Rather than > branching it from the current rawhide version, I plan to update > rawhide to the latest upstream version first [1]. This involves an > soname change from libsqlcipher-3.34.1.so.0 to > libsqlcipher-3.39.2.so.0. This will require six packages to be > rebuilt. > > [root@f38-container:~]# repoquery --repo > rawhide-source,rawhide-modular-source \ > > --quiet --queryformat '%{name}' --archlist src --whatrequires > > sqlcipher-devel > libgda > python-peewee > sqlitebrowser > [root@f38-container:~]# repoquery --repo > rawhide-source,rawhide-modular-source \ > > --quiet --queryformat '%{name}' --archlist src --whatrequires > > 'pkgconfig(sqlcipher)' > kmymoney > rust-libsqlite3-sys > skrooge Please do not rebuild rust-libsqlite3-sys. It is a source-only package that does not ship any compiled code. All packages built from rust-libsqlite3-sys are noarch (i.e. they can't - by definition - contain architecture-specific binaries). Any built binaries that link against libsqlcipher are only used for tests, but not shipped with built packages. Fabio ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: sqlcipher soname change in rawhide
On Thursday, August 25, 2022 Carl George wrote: > [root@f38-container:~]# repoquery --repo > rawhide-source,rawhide-modular-source \ > > --quiet --queryformat '%{name}' --archlist src --whatrequires > > sqlcipher-devel > libgda > python-peewee > sqlitebrowser > [root@f38-container:~]# repoquery --repo > rawhide-source,rawhide-modular-source \ > > --quiet --queryformat '%{name}' --archlist src --whatrequires > > 'pkgconfig(sqlcipher)' > kmymoney > rust-libsqlite3-sys > skrooge You do not need to separately query for the Provides like this. If you keep the regular repository enabled and filter out the src packages after, the Provides are queried, as well. $ sudo dnf repoquery --repo=rawhide{,-source} -q --whatrequires sqlcipher-devel | grep '\.src$' | pkgname | sort -u kmymoney libgda python-peewee rust-libsqlite3-sys skrooge sqlitebrowser -- Thanks, Maxwell G (@gotmax23) Pronouns: He/Him/His signature.asc Description: PGP signature ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
sqlcipher soname change in rawhide
sqlcipher has been requested to be built in epel9 [0]. Rather than branching it from the current rawhide version, I plan to update rawhide to the latest upstream version first [1]. This involves an soname change from libsqlcipher-3.34.1.so.0 to libsqlcipher-3.39.2.so.0. This will require six packages to be rebuilt. [root@f38-container:~]# repoquery --repo rawhide-source,rawhide-modular-source \ > --quiet --queryformat '%{name}' --archlist src --whatrequires sqlcipher-devel libgda python-peewee sqlitebrowser [root@f38-container:~]# repoquery --repo rawhide-source,rawhide-modular-source \ > --quiet --queryformat '%{name}' --archlist src --whatrequires > 'pkgconfig(sqlcipher)' kmymoney rust-libsqlite3-sys skrooge I've worked with Jonathan to do a test run of rebuilding these packages in copr [2], and everything was successful. I will build the new sqlcipher in a side tag and then complete the rebuilds in the side tag myself via proven packager permissions. [0] https://bugzilla.redhat.com/show_bug.cgi?id=2120882 [1] https://src.fedoraproject.org/rpms/sqlcipher/pull-request/3 [2] https://copr.fedorainfracloud.org/coprs/jonathanspw/sqlcipher/builds/ -- Carl George ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue