[Geany-Devel] Windows GTK Runtime 2.24 and config directory

2014-08-22 Thread Enrico Tröger
Hi,

lately, I started building a new Windows installer which includes a
recent GTK 2.24 runtime for Windows which need for future releases.

While most things went fine I noticed one problem:

GTK, in detail Glib, changed the way g_get_user_data_dir() works on Windows:
in older releases, something GLib 2.28 or 2.26 and older,
g_get_user_data_dir() returned c:\users\username\AppData\Roaming, in
newer GLib versions it returns c:\users\username\AppData\Local.

This affects users who already have a config directory located in
...\Roaming and Geany would look in ...\Local now.

This is the change I'm talking about:
https://git.gnome.org/browse/glib/commit/glib/gutils.c?id=9d80c361418f94c609840ec9f83741aede7e482c


How do we want to handle this?

- continue using the ...\Roaming directory (and so not using
g_get_user_data_dir() anymore)

- leave the code as it is, resulting in a new complete config for users

- add some code to check if a config in ...\Roaming exists and if so,
move it to ...\Local


I'd implement the last choice if there are no objections. This is not
nice because we implement again some magic config directory move code
but at least the user won't notice that GLib change.

Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc



signature.asc
Description: OpenPGP digital signature
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] Windows GTK Runtime 2.24 and config directory

2014-08-22 Thread Colomban Wendling
Hey,

Le 22/08/2014 20:23, Enrico Tröger a écrit :
 lately, I started building a new Windows installer which includes a
 recent GTK 2.24 runtime for Windows which need for future releases.

Nice :)

 While most things went fine I noticed one problem:
 
 GTK, in detail Glib, changed the way g_get_user_data_dir() works on Windows:
 in older releases, something GLib 2.28 or 2.26 and older,
 g_get_user_data_dir() returned c:\users\username\AppData\Roaming, in
 newer GLib versions it returns c:\users\username\AppData\Local.
 
 This affects users who already have a config directory located in
 ...\Roaming and Geany would look in ...\Local now.
 
 This is the change I'm talking about:
 https://git.gnome.org/browse/glib/commit/glib/gutils.c?id=9d80c361418f94c609840ec9f83741aede7e482c

Oh my.  And we though it was a supporting library :)

 How do we want to handle this?
 
 - continue using the ...\Roaming directory (and so not using
 g_get_user_data_dir() anymore)
 
 - leave the code as it is, resulting in a new complete config for users
 
 - add some code to check if a config in ...\Roaming exists and if so,
 move it to ...\Local
 
 
 I'd implement the last choice if there are no objections. This is not
 nice because we implement again some magic config directory move code
 but at least the user won't notice that GLib change.

Agreed, both with solution and remark.

Regards,
Colomban



signature.asc
Description: OpenPGP digital signature
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] Windows GTK Runtime 2.24 and config directory

2014-08-22 Thread Lex Trotman
On 23 August 2014 04:23, Enrico Tröger enrico.troe...@uvena.de wrote:
 Hi,

 lately, I started building a new Windows installer which includes a
 recent GTK 2.24 runtime for Windows which need for future releases.

Hi Enrico,

Do you have access to any reputation or signing certificates for
windows applications?
http://blogs.msdn.com/b/ie/archive/2012/08/15/10339518.aspx

Might improve the windows experience.

Cheers
Lex


 While most things went fine I noticed one problem:

 GTK, in detail Glib, changed the way g_get_user_data_dir() works on Windows:
 in older releases, something GLib 2.28 or 2.26 and older,
 g_get_user_data_dir() returned c:\users\username\AppData\Roaming, in
 newer GLib versions it returns c:\users\username\AppData\Local.

 This affects users who already have a config directory located in
 ...\Roaming and Geany would look in ...\Local now.

 This is the change I'm talking about:
 https://git.gnome.org/browse/glib/commit/glib/gutils.c?id=9d80c361418f94c609840ec9f83741aede7e482c


 How do we want to handle this?

 - continue using the ...\Roaming directory (and so not using
 g_get_user_data_dir() anymore)

 - leave the code as it is, resulting in a new complete config for users

 - add some code to check if a config in ...\Roaming exists and if so,
 move it to ...\Local


 I'd implement the last choice if there are no objections. This is not
 nice because we implement again some magic config directory move code
 but at least the user won't notice that GLib change.

 Regards,
 Enrico

 --
 Get my GPG key from http://www.uvena.de/pub.asc


 ___
 Devel mailing list
 Devel@lists.geany.org
 https://lists.geany.org/cgi-bin/mailman/listinfo/devel

___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] Windows GTK Runtime 2.24 and config directory

2014-08-22 Thread Matthew Brush

On 14-08-22 11:23 AM, Enrico Tröger wrote:

Hi,

lately, I started building a new Windows installer which includes a
recent GTK 2.24 runtime for Windows which need for future releases.

[snip]

- add some code to check if a config in ...\Roaming exists and if so,
move it to ...\Local


I'd implement the last choice if there are no objections. This is not
nice because we implement again some magic config directory move code
but at least the user won't notice that GLib change.



Sounds fine to me, even just a one-time dialog telling the user about 
the change would be useful. Either way the code be put inside win32.c 
and guarded with an #ifdef G_OS_WIN32 so it doesn't mess up unrelated 
source files.


FWIW, I don't think this is the first time the config directory moved. 
Even between WinXP and Windows7 the actual directory used had changed, 
causing a little confusion (for me at least).


Cheers,
Matthew Brush

___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel