Re: [Geany-Devel] Infobar file deleted/renamed behaviour

2014-10-22 Thread Thomas Martitz

Am 23.10.2014 um 04:11 schrieb Matthew Brush:

On 14-10-22 06:53 PM, Lex Trotman wrote:

On 23 October 2014 11:53, Matthew Brush  wrote:

Hi All,

Since there's some discussion about infobar behaviour, I thought I'd 
mention

a couple things I've noticed using it in my day-to-day workflow.

When you delete a file from disk, and then assuming the infobar 
kicked in
(see below), it pops up the infobar as expected. The problem is that 
there's

no quick way to say "Ya, ya, I deleted that on purpose, just close the
file". IMO, there should be a "Close" button on the infobar that 
allows you
to bypass the redundant dialog that pops up when trying to close a 
document

that you've been notified about, for example:

-
File "foo.txt" was not found on disk [Resave][Dismiss][Close]

-

Clicking the proposed [Close] button would have the same effect as what
currently requires two steps; clicking the tab close button or Close 
menu
item and then clicking the "Don't Save" button in the dialog that 
pops up.


Does that sound reasonable?


Yes, would just ask for some space between dismiss and close for those
with bad aim (like me :)
BTW which is default (if any)?



The other thing I wondered is, should we not do a "disk check" on a 
file
that hasn't been switched to when it's being closed? I mean we do 
the check
and show the infobar on tab-switch (due to lacking proper/usable 
inotify
support), but if the user doesn't actually switch to the tab, then 
we just
close the file without any warning that the buffer in that document 
has no

disk file anymore and closing it will lose those contents forever.


Sounds like a sensible safe default behaviour, but with a various pref
to turn it off for those whose workflow makes it *really* annoying.



And/or a way to dismiss many together for bulk operations like "Close 
All" and "Close Others" (and obviously when exiting). Sometimes you 
see those dialogs like:


++
|-  Unsaved Changes!  -X-|
++
| The following files are not saved: |
| == |
|   [ ] Resignation_Letter.txt   |
|   [ ] Wedding_Vows_WIP.md  |
|   [ ] Baby_Pictures.xpm|
|   [ ] ...  |
| == |
| Do you want to save them?  |
| -- |
| [ No, Just Exit] [ Yes Please ] [ Cancel ] |
++

We could do something like that.


Nice idea. Perhaps add a check box "[x] Remember this decision", and 
store that in a pref.


Best regards
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] Infobar file deleted/renamed behaviour

2014-10-22 Thread Lex Trotman
On 23 October 2014 13:11, Matthew Brush  wrote:
> On 14-10-22 06:53 PM, Lex Trotman wrote:
>>
>> On 23 October 2014 11:53, Matthew Brush  wrote:
>>>
>>> Hi All,
>>>
>>> Since there's some discussion about infobar behaviour, I thought I'd
>>> mention
>>> a couple things I've noticed using it in my day-to-day workflow.
>>>
>>> When you delete a file from disk, and then assuming the infobar kicked in
>>> (see below), it pops up the infobar as expected. The problem is that
>>> there's
>>> no quick way to say "Ya, ya, I deleted that on purpose, just close the
>>> file". IMO, there should be a "Close" button on the infobar that allows
>>> you
>>> to bypass the redundant dialog that pops up when trying to close a
>>> document
>>> that you've been notified about, for example:
>>>
>>> -
>>> File "foo.txt" was not found on disk[Resave][Dismiss][Close]
>>> 
>>> -
>>>
>>> Clicking the proposed [Close] button would have the same effect as what
>>> currently requires two steps; clicking the tab close button or Close menu
>>> item and then clicking the "Don't Save" button in the dialog that pops
>>> up.
>>>
>>> Does that sound reasonable?
>>
>>
>> Yes, would just ask for some space between dismiss and close for those
>> with bad aim (like me :)
>> BTW which is default (if any)?
>>
>>>
>>> The other thing I wondered is, should we not do a "disk check" on a file
>>> that hasn't been switched to when it's being closed? I mean we do the
>>> check
>>> and show the infobar on tab-switch (due to lacking proper/usable inotify
>>> support), but if the user doesn't actually switch to the tab, then we
>>> just
>>> close the file without any warning that the buffer in that document has
>>> no
>>> disk file anymore and closing it will lose those contents forever.
>>
>>
>> Sounds like a sensible safe default behaviour, but with a various pref
>> to turn it off for those whose workflow makes it *really* annoying.
>>
>
> And/or a way to dismiss many together for bulk operations like "Close All"
> and "Close Others" (and obviously when exiting). Sometimes you see those
> dialogs like:
>
> ++
> |-  Unsaved Changes!  -X-|
> ++
> | The following files are not saved: |
> | == |
> |   [ ] Resignation_Letter.txt   |
> |   [ ] Wedding_Vows_WIP.md  |
> |   [ ] Baby_Pictures.xpm|
> |   [ ] ...  |
> | == |
> | Do you want to save them?  |
> | -- |
> | [ No, Just Exit] [ Yes Please ] [ Cancel ] |
> ++
>
> We could do something like that.

Well one annoying dialog is an improvement on many :)

Cheers
Lex

>
>
> Cheers,
> Matthew Brush
> ___
> Devel mailing list
> Devel@lists.geany.org
> https://lists.geany.org/cgi-bin/mailman/listinfo/devel
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] Infobar file deleted/renamed behaviour

2014-10-22 Thread Matthew Brush

On 14-10-22 06:53 PM, Lex Trotman wrote:

On 23 October 2014 11:53, Matthew Brush  wrote:

Hi All,

Since there's some discussion about infobar behaviour, I thought I'd mention
a couple things I've noticed using it in my day-to-day workflow.

When you delete a file from disk, and then assuming the infobar kicked in
(see below), it pops up the infobar as expected. The problem is that there's
no quick way to say "Ya, ya, I deleted that on purpose, just close the
file". IMO, there should be a "Close" button on the infobar that allows you
to bypass the redundant dialog that pops up when trying to close a document
that you've been notified about, for example:

-
File "foo.txt" was not found on disk[Resave][Dismiss][Close]

-

Clicking the proposed [Close] button would have the same effect as what
currently requires two steps; clicking the tab close button or Close menu
item and then clicking the "Don't Save" button in the dialog that pops up.

Does that sound reasonable?


Yes, would just ask for some space between dismiss and close for those
with bad aim (like me :)
BTW which is default (if any)?



The other thing I wondered is, should we not do a "disk check" on a file
that hasn't been switched to when it's being closed? I mean we do the check
and show the infobar on tab-switch (due to lacking proper/usable inotify
support), but if the user doesn't actually switch to the tab, then we just
close the file without any warning that the buffer in that document has no
disk file anymore and closing it will lose those contents forever.


Sounds like a sensible safe default behaviour, but with a various pref
to turn it off for those whose workflow makes it *really* annoying.



And/or a way to dismiss many together for bulk operations like "Close 
All" and "Close Others" (and obviously when exiting). Sometimes you see 
those dialogs like:


++
|-  Unsaved Changes!  -X-|
++
| The following files are not saved: |
| == |
|   [ ] Resignation_Letter.txt   |
|   [ ] Wedding_Vows_WIP.md  |
|   [ ] Baby_Pictures.xpm|
|   [ ] ...  |
| == |
| Do you want to save them?  |
| -- |
| [ No, Just Exit] [ Yes Please ] [ Cancel ] |
++

We could do something like that.

Cheers,
Matthew Brush
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] Infobar file deleted/renamed behaviour

2014-10-22 Thread Lex Trotman
On 23 October 2014 11:53, Matthew Brush  wrote:
> Hi All,
>
> Since there's some discussion about infobar behaviour, I thought I'd mention
> a couple things I've noticed using it in my day-to-day workflow.
>
> When you delete a file from disk, and then assuming the infobar kicked in
> (see below), it pops up the infobar as expected. The problem is that there's
> no quick way to say "Ya, ya, I deleted that on purpose, just close the
> file". IMO, there should be a "Close" button on the infobar that allows you
> to bypass the redundant dialog that pops up when trying to close a document
> that you've been notified about, for example:
>
> -
> File "foo.txt" was not found on disk[Resave][Dismiss][Close]
> 
> -
>
> Clicking the proposed [Close] button would have the same effect as what
> currently requires two steps; clicking the tab close button or Close menu
> item and then clicking the "Don't Save" button in the dialog that pops up.
>
> Does that sound reasonable?

Yes, would just ask for some space between dismiss and close for those
with bad aim (like me :)
BTW which is default (if any)?

>
> The other thing I wondered is, should we not do a "disk check" on a file
> that hasn't been switched to when it's being closed? I mean we do the check
> and show the infobar on tab-switch (due to lacking proper/usable inotify
> support), but if the user doesn't actually switch to the tab, then we just
> close the file without any warning that the buffer in that document has no
> disk file anymore and closing it will lose those contents forever.

Sounds like a sensible safe default behaviour, but with a various pref
to turn it off for those whose workflow makes it *really* annoying.

Cheers
Lex

>
> Thoughts?
>
> Cheers,
> Matthew Brush
> ___
> Devel mailing list
> Devel@lists.geany.org
> https://lists.geany.org/cgi-bin/mailman/listinfo/devel
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


[Geany-Devel] Infobar file deleted/renamed behaviour

2014-10-22 Thread Matthew Brush

Hi All,

Since there's some discussion about infobar behaviour, I thought I'd 
mention a couple things I've noticed using it in my day-to-day workflow.


When you delete a file from disk, and then assuming the infobar kicked 
in (see below), it pops up the infobar as expected. The problem is that 
there's no quick way to say "Ya, ya, I deleted that on purpose, just 
close the file". IMO, there should be a "Close" button on the infobar 
that allows you to bypass the redundant dialog that pops up when trying 
to close a document that you've been notified about, for example:


-
File "foo.txt" was not found on disk[Resave][Dismiss][Close]

-

Clicking the proposed [Close] button would have the same effect as what 
currently requires two steps; clicking the tab close button or Close 
menu item and then clicking the "Don't Save" button in the dialog that 
pops up.


Does that sound reasonable?

The other thing I wondered is, should we not do a "disk check" on a file 
that hasn't been switched to when it's being closed? I mean we do the 
check and show the infobar on tab-switch (due to lacking proper/usable 
inotify support), but if the user doesn't actually switch to the tab, 
then we just close the file without any warning that the buffer in that 
document has no disk file anymore and closing it will lose those 
contents forever.


Thoughts?

Cheers,
Matthew Brush
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] ntrel - Don't prompt for reload from infobar when there are no unsaved changes

2014-10-22 Thread Thomas Martitz

Am 13.10.2014 15:21, schrieb Colomban Wendling:

Le 13/10/2014 08:06, Thomas Martitz a écrit :

Hi,

this is about commit ab7a0018b2518793f26af2fe20a06a8a1886e031 and the
message reads "
Don't prompt for reload from infobar when there are no unsaved changes".

The patch removes the confirmation dialog when clicking the "Reload"
button from the infobar if the buffer hasn't changed.  It doesn't affect
the reload keybinding or menu item.


What does that mean? I do absolutely want to be asked before reloading
even if the file has no changes or saved ones.

Even when clicking the Reload button from the infobar?



No. The commit msg read like the infobar wouldn't even pop up. The 
infobar requires explicit user action. One instance of explicit user 
action is sufficient. Sorry for the noise.


Best regards
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel