Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-13 Thread Colomban Wendling
Le 12/04/2015 19:20, Dimitar Zhekov a écrit :
 On 10.4.2015 г. 18:36, Colomban Wendling wrote:
 
 waf: Fix the checks for openpty() on FreeBSD
 
 ACK. Please, be sure to use the same check for debugger, it probably
 needs it.

The same commits should already have altered both Scope and Debugger to
use the same checks.

Regards,
Colomban
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] Blank completion popups on Windows

2015-04-13 Thread Lex Trotman
On 14 April 2015 at 07:32, Colomban Wendling lists@herbesfolles.org wrote:
 Hi everyone,

 I don't use my Windows VM very often, but I realized today that the
 completion popups were broken there during the 1.25 cycle [1].

 Could everyone using a development version of Geany under Windows tell
 me whether it works for them or not, and their Windows and GTK versions?
 I myself tried on XP SP3 with GTK 2.24.10.

XP is no longer supported
http://windows.microsoft.com/en-AU/windows/end-support-help so it
doesn't matter.

Cheers
Lex


 I found a way to fix the issue, and although it doesn't make any sense,
 it seem to fix it reliably.  Unfortunately it has a small side effect
 that completion popup will have a minimal height that might be taller
 than necessary when there is only one item in the list.  But this
 cosmetic detail is probably less problematic than a blank popup, right? :)

 But I'd like to know if the problem happens to everyone or not, and
 whether the attached patch fixes the problem for everyone with the issue.

 Thanks in advance!
 Colomban


 [1]
 http://git.geany.org/geany/commit/?id=4d66bd3745eb3759539b116e7784d11d035ebd44

 ___
 Devel mailing list
 Devel@lists.geany.org
 https://lists.geany.org/cgi-bin/mailman/listinfo/devel

___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-13 Thread Dimitar Zhekov

On 13.4.2015 г. 04:11, Matthew Brush wrote:


While on configuring, the README file still lists gtk+ 2.16 as a minimum
requirement for Geany - but it's actually 2.18 with GtkInfoBar now,
right?


I just merged PR #245[0], so 2.24 should be good version to use.


On 13.4.2015 г. 04:12, Lex Trotman wrote:

 2.18!!! c'mon, get with it, Geany is now 2.24 :)

Wow, that may be not a very good news for the Windows users.

In 2.24, the horizontal tabs under Win~1 have this flat or modern or 
whatever look, and you can only distinguish the current tab via a slight 
3D effect. And unlike 3.x, where you can easily set the active tab 
background with CSS, in 2.24 the (in)active horizontal tabs are always 
with the same background AFAICT.


In fact, I have not found a way to change neither the active nor the 
inactive horizontal tab background in 2.24 - even with all backgrounds 
for all widgets set to red, the horizontal tabs are still light gray.


Using color to distinguish the tabs does the job, albeit worse, but 
conflicts with Geany red for modified and green for read-only tab. If 
somebody knows how to change the (in)active horizontal tab background, 
please drop me a note...


On 13.4.2015 г. 04:05, Matthew Brush wrote:

 Remove pre-GTK+ 2.24 preprocessor checks and related code

Looking at the changes, the lowest gtk+ version checked is 2.20, which 
suggests that for Geany there is no difference between 2.22 and 2.24. 
Would it be possible to keep the minimum version 2.22? I have heard it 
has some problems under Windows, but never actually seen any.


--
E-gards: Jimmy
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel