Re: [Geany-Devel] Github Comment Mails
On 22 August 2015 at 09:54, Matthew Brush wrote: > On 15-08-21 02:26 PM, Enrico Tröger wrote: >> >> On 19/08/15 05:46, Matthew Brush wrote: >>> >>> On 15-08-18 08:43 PM, Lex Trotman wrote: On 19 August 2015 at 13:37, Matthew Brush wrote: > > Hi, > > Is it possible to make an archived mailing list which can contain > threads of > comments posted to Github (maybe using Github API)? We have sometimes > when > squash commits it deletes Github comments, but I thought maybe we > could have > some stable backup + URL to link to (ex. in commit messages, on the > mailing > list, etc) which could be searchable and googlable and not be deleted > by > rebase. Or by the remote deleting the branch >>> >>> Yeah, it would be archived and not affected by force pushes, delete >>> branches or editing of comments. >> >> >> Nice idea. >> The mailing list itself would be no problem at all. It's more difficult >> to get the data from Github. >> On https://github.com/geany/geany/settings/hooks there is "services" and >> they support "Email" but it will send mails only on pushes, not what we >> want. >> An alternative would a web hook where you can choose detailed on which >> events the hook is triggered. But then you need something on the >> receiving side which takes the event and transform it into a mail to >> send it to the mailing list. Possible but requires some work. >> >> I just had a quick look at the available other services >> (https://api.github.com/hooks) to find one which support commit and PR >> comments and support something self-hosted (i.e. no new dependency on >> some third-party service) but didn't find anything suitable. >> >> One more option might be to use the Geany Github account and watch the >> Geany repositories with this account to get notifications this way. >> We just need to take care to setup a separate email address in the >> Github account settings for notifications because the primary address >> will be used for account settings/notifications/password resets. Those >> should not be sent to a public mailing list :). >> Should be possible and probably the easiest way. >> >> If you agree, I could work on this. >> > > Sounds like a good idea. > > Did you look at the Github API proper? We could probably hack up a script to > harvest the comments that way (it's really easy to use IIRC, it's just some > URL queries and JSON responses). It might still need a service hook or cron > event or something to trigger, but it might be workable. Could probably just get them daily for this purpose. Cheers Lex > > Cheers, > Matthew Brush > > ___ > Devel mailing list > Devel@lists.geany.org > https://lists.geany.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Github Comment Mails
On 15-08-21 02:26 PM, Enrico Tröger wrote: On 19/08/15 05:46, Matthew Brush wrote: On 15-08-18 08:43 PM, Lex Trotman wrote: On 19 August 2015 at 13:37, Matthew Brush wrote: Hi, Is it possible to make an archived mailing list which can contain threads of comments posted to Github (maybe using Github API)? We have sometimes when squash commits it deletes Github comments, but I thought maybe we could have some stable backup + URL to link to (ex. in commit messages, on the mailing list, etc) which could be searchable and googlable and not be deleted by rebase. Or by the remote deleting the branch Yeah, it would be archived and not affected by force pushes, delete branches or editing of comments. Nice idea. The mailing list itself would be no problem at all. It's more difficult to get the data from Github. On https://github.com/geany/geany/settings/hooks there is "services" and they support "Email" but it will send mails only on pushes, not what we want. An alternative would a web hook where you can choose detailed on which events the hook is triggered. But then you need something on the receiving side which takes the event and transform it into a mail to send it to the mailing list. Possible but requires some work. I just had a quick look at the available other services (https://api.github.com/hooks) to find one which support commit and PR comments and support something self-hosted (i.e. no new dependency on some third-party service) but didn't find anything suitable. One more option might be to use the Geany Github account and watch the Geany repositories with this account to get notifications this way. We just need to take care to setup a separate email address in the Github account settings for notifications because the primary address will be used for account settings/notifications/password resets. Those should not be sent to a public mailing list :). Should be possible and probably the easiest way. If you agree, I could work on this. Sounds like a good idea. Did you look at the Github API proper? We could probably hack up a script to harvest the comments that way (it's really easy to use IIRC, it's just some URL queries and JSON responses). It might still need a service hook or cron event or something to trigger, but it might be workable. Cheers, Matthew Brush ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Github Comment Mails
Le 21/08/2015 23:26, Enrico Tröger a écrit : > One more option might be to use the Geany Github account and watch the > Geany repositories with this account to get notifications this way. > We just need to take care to setup a separate email address in the > Github account settings for notifications because the primary address > will be used for account settings/notifications/password resets. Those > should not be sent to a public mailing list :). > Should be possible and probably the easiest way. Sounds like an interesting solution :) ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Github Comment Mails
On 19/08/15 05:46, Matthew Brush wrote: > On 15-08-18 08:43 PM, Lex Trotman wrote: >> On 19 August 2015 at 13:37, Matthew Brush wrote: >>> Hi, >>> >>> Is it possible to make an archived mailing list which can contain >>> threads of >>> comments posted to Github (maybe using Github API)? We have sometimes >>> when >>> squash commits it deletes Github comments, but I thought maybe we >>> could have >>> some stable backup + URL to link to (ex. in commit messages, on the >>> mailing >>> list, etc) which could be searchable and googlable and not be deleted by >>> rebase. >> >> Or by the remote deleting the branch >> > > Yeah, it would be archived and not affected by force pushes, delete > branches or editing of comments. Nice idea. The mailing list itself would be no problem at all. It's more difficult to get the data from Github. On https://github.com/geany/geany/settings/hooks there is "services" and they support "Email" but it will send mails only on pushes, not what we want. An alternative would a web hook where you can choose detailed on which events the hook is triggered. But then you need something on the receiving side which takes the event and transform it into a mail to send it to the mailing list. Possible but requires some work. I just had a quick look at the available other services (https://api.github.com/hooks) to find one which support commit and PR comments and support something self-hosted (i.e. no new dependency on some third-party service) but didn't find anything suitable. One more option might be to use the Geany Github account and watch the Geany repositories with this account to get notifications this way. We just need to take care to setup a separate email address in the Github account settings for notifications because the primary address will be used for account settings/notifications/password resets. Those should not be sent to a public mailing list :). Should be possible and probably the easiest way. If you agree, I could work on this. Regards, Enrico -- Get my GPG key from http://www.uvena.de/pub.asc signature.asc Description: OpenPGP digital signature ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Geany Portable
Le 20/08/2015 00:27, Matthew Brush a écrit : > Hi All, > > I was working on some changes to Geany that may affect "Geany Portable" > so I figured I'd have a look at the changes it makes to Geany to see how > it handles binary relocation, but I can't seem to find the source > code/changes. > > The link on PortableApps.com[0] seems to indicate that 1.24.1 is > available but when I check the sources on SourceForge, it only has 0.20 > code (and it's not clear if it includes the changes or is just upstream > source). I'm pretty sure Geany's source code would have to be modified > in order to allow it to be "portable", since the location to the Glade > file is fixed at compile-time, which happens to be tightly related to > what I was curious about. It's for Windows, and for windows we use the installation path as the base location for the files. We already need this simply to be able to install to a location that might not be the same as the build-time one. We don't use registry for this, so the installation process has no way of changing it. I'm unclear what GeanyPortable changes over stock Geany, but I guess maybe some environment so e.g. the configuration is not on the local machine or something; but it shouldn't require any change for basic startup. Regards, Colomban PS: On non-Windows, we have a binary relocation feature too, although I'm unsure if it still actually works. ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Simplifying file saving options
[...] >>> It is unsafe due to a long standing bug where a failure deletes the >>> copy of the original data without copying it back to the original >>> file, so you are left with a truncated original file and no backup of >>> the original data. You still have the new data in the Geany buffer of >>> course. But it regularly has caught people out if they closed the >>> buffer after a failure assuming they had the original data safe. >> >> >> Uh, just checked the code and it really seems to be the case. Might fix that >> if I have time. > > That would be great, but it would still be "some time" before the fix > propagates to all machines using GIO so we could not rely on it until > then. If the write of the new data to the file failed, I wonder if the copy of the old data back would work? But worst case it should at least leave the copy around. > >> >>> >>> >>> > >>> > 2. It is now possible to set >>> > >>> > use_gio_unsafe_file_saving=true >>> > use_atomic_file_saving=true >>> > >>> > and to users it's unclear which of the options will be actually used >>> > (it's >>> > the use_atomic_file_saving case because it's checked first in the code). >>> >>> Yeah, an enum not a set of bools would be better, IIUC the current >>> system grew all the options over time rather than being planned. For >>> sure cleaning it up would be good. >>> >>> > >>> > 3. The fallback "ordinary" file saving when >>> > >>> > use_gio_unsafe_file_saving=false >>> > use_atomic_file_saving=false >>> > >>> > doesn't bring any benefit compared to the two above >>> >>> It just overwrites the file, nothing else, one data transfer, fast, no >>> rename, works on *all* filesystems, keeps the files metadata. Whilst >>> its not in any way "safe" its got the best performance. >> >> >> OK, might make sense to keep it then. >> >> Jiri >> >> ___ >> Devel mailing list >> Devel@lists.geany.org >> https://lists.geany.org/cgi-bin/mailman/listinfo/devel >> ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel