Re: [Geany-Devel] Plugin interface

2017-06-22 Thread Matthew Brush
Am I the only one not getting Lars' messages? I looked in my Junk folder 
and they're not there, wondering if it's a misconfiguration on my end or 
something?


Regards,
Matthew Brush

On 2017-06-21 04:39 PM, Lex Trotman wrote:

Hi,

The plugin system has recently been updated but was made backward
compatible, so all the old plugins still run.  So that removed any
incentive for the plugin maintainers (and Geany devs for the core
plugins) to update, so as you say most still use the old system.

The new system supports sub-plugins properly, but the developer who
was working on it has had an attack of the real world and the code
supporting it (at least for Python IIUC) is still in his personal
github.  It may also be able to be extended to other languages such as
JS.

Cheers
Lex

On 22 June 2017 at 03:37, Lars Paulsen  wrote:

Hi all,

I got a simple question:
As I understood from the development manual plugins should use
geany_load_module() instead of plugin_init()...

Is that correct?
I am just wondering because it seems that 90% of the geany plugins use
plugin_init() and co.

Kind Regards,
Lars


___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel



___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] Plugin interface

2017-06-22 Thread Frank Lanitz
On 22.06.2017 19:43, Thomas Martitz wrote:
> Am 22.06.2017 um 17:50 schrieb Lars Paulsen:
>>
>>> But please keep the assigned maintainers in the loop in case of
>>> plugins inside geany-plugins.
>> Shouldn't they get a notification anyway from github as soon as I
>> place a PR?
>> If you prefer, I could additionally announce that PRs here in the
>> devel mailing list? 
> 
> Usually no, since most maintainers are not affiliated with the Geany org
> on github, so they don't get notifications for new PRs, if you don't
> open them on their personal fork.
> 
> The ideal method would be to open the PR on the maintainers site, and
> have the maintainer ask Frank for pulling his collected changes just
> before the next release. Unfortunately, the maintainers are sometimes
> skipped over, and then people wonder why they go inactive (I wouldn't
> like if changes are made behind my back).

I'm not aware of any case a maintainer went away because of such a
scenario.

Cheers,
Frank




signature.asc
Description: OpenPGP digital signature
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] Plugin interface

2017-06-22 Thread Thomas Martitz

Am 22.06.2017 um 17:50 schrieb Lars Paulsen:


But please keep the assigned maintainers in the loop in case of 
plugins inside geany-plugins.
Shouldn't they get a notification anyway from github as soon as I 
place a PR?
If you prefer, I could additionally announce that PRs here in the 
devel mailing list? 


Usually no, since most maintainers are not affiliated with the Geany org 
on github, so they don't get notifications for new PRs, if you don't 
open them on their personal fork.


The ideal method would be to open the PR on the maintainers site, and 
have the maintainer ask Frank for pulling his collected changes just 
before the next release. Unfortunately, the maintainers are sometimes 
skipped over, and then people wonder why they go inactive (I wouldn't 
like if changes are made behind my back).


Best regards.
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] Plugin interface

2017-06-22 Thread Lars Paulsen

Hello Thomas,

yes, I have seen exactly that and I was only confused because there are 
only about 3-5 plugins in geany-plugins using the new interface.

So I thought I better write a mail about. Thanks for the answers.

But please keep the assigned maintainers in the loop in case of 
plugins inside geany-plugins.
Shouldn't they get a notification anyway from github as soon as I place 
a PR?
If you prefer, I could additionally announce that PRs here in the devel 
mailing list?


Kind Regards,
Lars


Am 22.06.2017 um 14:21 schrieb Thomas Martitz:

Am 22.06.2017 um 07:17 schrieb Lars Paulsen:

Hi Lex,

> It has been pointed out that I totally avoided actually explicitly
> answering the question, yes use the new interface.

:-)
Ok, will do that. If I find the time I probably will update the one 
or other existing plugin to the new interface and send a PR. 


Hi Lars,

yes, work on that is appreciated. But please keep the assigned 
maintainers in the loop in case of plugins inside geany-plugins.


Besides, your initial question, and lots more, should be answered in 
the API documentation at [1]. Have you seen that?


[1] http://www.geany.org/manual/reference/

Best regards
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] Plugin interface

2017-06-22 Thread Lex Trotman
> For what's it worth, I'm also waiting for waiting for #1112 [1] too before
> adding peasy to geany-plugins.

Makes sense, if your bindings need introspection there is no point in
releasing them until Geany is set up to generate it.

> So long it's publicly available at here[2].
> I'm not motivated to work on #1112 because nobody would look at it at the
> moment.
>
> I wonder if/when Colomban can be back in action?

Its hard for anybody in a new situation to judge how the future will
evolve, for example I might have more time end of year/next year, but
that doesn't help #1112 which is above my pay grade anyway :)

Cheers
Lex

>
> [1] https://github.com/geany/geany/pull/1112
> [2] https://github.com/kugel-/peasy
>
> Best regards
>
> ___
> Devel mailing list
> Devel@lists.geany.org
> https://lists.geany.org/cgi-bin/mailman/listinfo/devel
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] Plugin interface

2017-06-22 Thread Thomas Martitz

Am 22.06.2017 um 07:17 schrieb Lars Paulsen:

Hi Lex,

> It has been pointed out that I totally avoided actually explicitly
> answering the question, yes use the new interface.

:-)
Ok, will do that. If I find the time I probably will update the one or 
other existing plugin to the new interface and send a PR. 


Hi Lars,

yes, work on that is appreciated. But please keep the assigned 
maintainers in the loop in case of plugins inside geany-plugins.


Besides, your initial question, and lots more, should be answered in the 
API documentation at [1]. Have you seen that?


[1] http://www.geany.org/manual/reference/

Best regards
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] Plugin interface

2017-06-22 Thread Thomas Martitz

Am 22.06.2017 um 01:39 schrieb Lex Trotman:

The new system supports sub-plugins properly, but the developer who
was working on it has had an attack of the real world and the code
supporting it (at least for Python IIUC) is still in his personal
github.  It may also be able to be extended to other languages such as
JS.

Cheers
Lex



I'm here, and I'm fine. I don't think there are open issues beside my 
PRs. I'm on hold as long as nobody looks at my various PRs are not being 
looked at. If there is any open work item, I'm able to work on it.


For what's it worth, I'm also waiting for waiting for #1112 [1] too 
before adding peasy to geany-plugins. So long it's publicly available at 
here[2]. I'm not motivated to work on #1112 because nobody would look at 
it at the moment.


I wonder if/when Colomban can be back in action?

[1] https://github.com/geany/geany/pull/1112
[2] https://github.com/kugel-/peasy

Best regards
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel