Re: olpc-os-builder config file format change
On Mar 2, 2012 6:21 PM, Daniel Drake d...@laptop.org wrote: I propose that we simplify this: remove the global.modules variable, and make the presence of a section become the hint that a module is loaded. For example: Yes please. It's a common mistake to forget to add the module in the modules list. Some modules, however, only need to appear listed there. For those, I propose _retaining_ the global.modules entry. So for example: [global] fedora_release=17 modules=base,xo1,yumcfg [yumcfg] add_excludes_to=fedora-rawhide Simplifies to [global] fedora_release=17 modules=base,xo1 [yumcfg] add_excludes_to=fedora-rawhide You can also do [base] [xo1] but it looks really dorky. cheers, m ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: olpc-os-builder config file format change
On Tue, Mar 6, 2012 at 7:22 AM, Martin Langhoff martin.langh...@gmail.com wrote: You can also do [base] [xo1] but it looks really dorky. Maybe it looks a bit odd, but I think it is the best option, because it retains consistency, makes documentation/training simpler, and will reduce confusion. Daniel ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: olpc-os-builder config file format change
On Tue, Mar 6, 2012 at 9:38 AM, Daniel Drake d...@laptop.org wrote: Maybe it looks a bit odd, but I think it is the best option, because it retains consistency, makes documentation/training simpler, and will reduce confusion. A bit of DWIM won't hurt ;-) m -- martin.langh...@gmail.com mar...@laptop.org -- Software Architect - OLPC - ask interesting questions - don't get distracted with shiny stuff - working code first - http://wiki.laptop.org/go/User:Martinlanghoff ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
olpc-os-builder config file format change
Hi, I'm proposing the following change to olpc-os-builder configuration files for 12.1.0 and onwards: Currently, the set of modules to load is specified by a modules configuration variable in the [global] section. Then, settings for each module can be customised by adding a [section] for each module and specifying the options there. I propose that we simplify this: remove the global.modules variable, and make the presence of a section become the hint that a module is loaded. For example: [global] fedora_release=17 modules=base,xo1,yumcfg [yumcfg] add_excludes_to=fedora-rawhide Would become [global] fedora_release=17 [base] [xo1] [yumcfg] add_excludes_to=fedora-rawhide Reasoning: This is a simplification. Previously, many modules effectively had to be listed twice - once in the module list, and again to supply mandatory configuration. All too often I have seen people (including myself) adding [sections] to customise their build, but forgetting to add the module to the list. And you don't realise your error until quite a while later. Also, this simplifies the ability to pass multiple configuration files to the build system. This will become more interesting as we move towards adding build automation, where the build config file will be the same everywhere, but those who want to bolt-on automatic build publishing at the end will supply an additional config file (loading futher modules) specifying addresses to push the build to, etc. Thoughts/objections? Thanks, Daniel ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: olpc-os-builder config file format change
+1 -- James Cameron http://quozl.linux.org.au/ ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: olpc-os-builder config file format change
On Fri, Mar 2, 2012 at 6:20 PM, Daniel Drake d...@laptop.org wrote: Thoughts/objections? I'm not an OOB user so I will abstatin, but it sounds like a nice simplification and I am interested to hear from actual OOB users. cjl ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
