Re: [PATCH 1/3] rpc: mark GSourceFuncs functions in vireventglibwatch.c as static

2023-12-14 Thread Denis V. Lunev

On 12/14/23 19:32, Fima Shevrin wrote:

From: "Denis V. Lunev" 

They are not exported from the module and thus should be static.

Signed-off-by: Denis V. Lunev 
Signed-off-by: Fima Shevrin 
---
  src/util/vireventglibwatch.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/util/vireventglibwatch.c b/src/util/vireventglibwatch.c
index b7f3a8786a..b21e505731 100644
--- a/src/util/vireventglibwatch.c
+++ b/src/util/vireventglibwatch.c
@@ -71,7 +71,7 @@ virEventGLibFDSourceFinalize(GSource *source G_GNUC_UNUSED)
  }
  
  
-GSourceFuncs virEventGLibFDSourceFuncs = {

+static GSourceFuncs virEventGLibFDSourceFuncs = {
  .prepare = virEventGLibFDSourcePrepare,
  .check = virEventGLibFDSourceCheck,
  .dispatch = virEventGLibFDSourceDispatch,
@@ -194,7 +194,7 @@ virEventGLibSocketSourceFinalize(GSource *source)
  }
  
  
-GSourceFuncs virEventGLibSocketSourceFuncs = {

+static GSourceFuncs virEventGLibSocketSourceFuncs = {
  .prepare = virEventGLibSocketSourcePrepare,
  .check = virEventGLibSocketSourceCheck,
  .dispatch = virEventGLibSocketSourceDispatch,

Can you pls do submission work properly and carefully.

1. While you are sending more than 1 patch in a row,
   please write cover-letter aka "PATCH 0/3" with a
   description of the whole series and motivation
   of it
2. Please also do not forget to increment version
   at least inside cover letter. If you are sending
   patches 2nd time you should use "PATCH v2 0/3"
3. Please track changes inside cover letter, writing
   what has been changed during this particular
   submission.

Thank you in advance,
    Den
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org


[PATCH 1/3] rpc: mark GSourceFuncs functions in vireventglibwatch.c as static

2023-12-14 Thread Fima Shevrin
From: "Denis V. Lunev" 

They are not exported from the module and thus should be static.

Signed-off-by: Denis V. Lunev 
Signed-off-by: Fima Shevrin 
---
 src/util/vireventglibwatch.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/util/vireventglibwatch.c b/src/util/vireventglibwatch.c
index b7f3a8786a..b21e505731 100644
--- a/src/util/vireventglibwatch.c
+++ b/src/util/vireventglibwatch.c
@@ -71,7 +71,7 @@ virEventGLibFDSourceFinalize(GSource *source G_GNUC_UNUSED)
 }
 
 
-GSourceFuncs virEventGLibFDSourceFuncs = {
+static GSourceFuncs virEventGLibFDSourceFuncs = {
 .prepare = virEventGLibFDSourcePrepare,
 .check = virEventGLibFDSourceCheck,
 .dispatch = virEventGLibFDSourceDispatch,
@@ -194,7 +194,7 @@ virEventGLibSocketSourceFinalize(GSource *source)
 }
 
 
-GSourceFuncs virEventGLibSocketSourceFuncs = {
+static GSourceFuncs virEventGLibSocketSourceFuncs = {
 .prepare = virEventGLibSocketSourcePrepare,
 .check = virEventGLibSocketSourceCheck,
 .dispatch = virEventGLibSocketSourceDispatch,
-- 
2.34.1
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org