Re: [OMPI devel] Fwd: [OMPI svn-full] svn:open-mpi r29043 - in trunk: config ompi

[Nathan Hjelm]

Because according to Martin there needed to be profiling versions of all
the MPI_T_* functions. I used the c bindings profiling as an base for
implementing the functions for MPI_T. Not sure what went wrong but I never
tried building without profiling support.

-Nathan

On Mon, Aug 19, 2013 at 02:52:21PM +, Jeff Squyres (jsquyres) wrote:
> @Nathan --
> 
> Why is the MPIT convenience library related to whether profiling is enabled 
> or not?
> 
> 
> Begin forwarded message:
> 
> > From: 
> > Subject: [OMPI svn-full] svn:open-mpi r29043 - in trunk: config ompi
> > Date: August 19, 2013 10:48:24 AM EDT
> > To: 
> > Reply-To: 
> > 
> > Author: rhc (Ralph Castain)
> > Date: 2013-08-19 10:48:23 EDT (Mon, 19 Aug 2013)
> > New Revision: 29043
> > URL: https://svn.open-mpi.org/trac/ompi/changeset/29043
> > 
> > Log:
> > Okay, fix it so it works both --disable-mpi-profile and 
> > --enable-mpi-profile. I'm not sure why mpit's library has to be treated 
> > differently, but it seems that it needs some special care to work in both 
> > scenarios
> > 
> > Refs #3725
> > 
> > Text files modified: 
> >   trunk/config/ompi_configure_options.m4 | 1 +  
> >  
> >   trunk/ompi/Makefile.am | 7 +++
> >  
> >   2 files changed, 8 insertions(+), 0 deletions(-)
> > 
> > Modified: trunk/config/ompi_configure_options.m4
> > ==
> > --- trunk/config/ompi_configure_options.m4  Sun Aug 18 19:40:32 2013
> > (r29042)
> > +++ trunk/config/ompi_configure_options.m4  2013-08-19 10:48:23 EDT (Mon, 
> > 19 Aug 2013)  (r29043)
> > @@ -133,6 +133,7 @@
> > MPIF_H_PMPI_W_FUNCS=
> > fi
> > AC_SUBST(MPIF_H_PMPI_W_FUNCS)
> > +AM_CONDITIONAL(WANT_MPI_PROFILING, test "$WANT_MPI_PROFILING" = 1)
> > 
> > 
> > #
> > 
> > Modified: trunk/ompi/Makefile.am
> > ==
> > --- trunk/ompi/Makefile.am  Sun Aug 18 19:40:32 2013(r29042)
> > +++ trunk/ompi/Makefile.am  2013-08-19 10:48:23 EDT (Mon, 19 Aug 2013)  
> > (r29043)
> > @@ -140,6 +140,13 @@
> > $(MCA_ompi_FRAMEWORK_LIBS) \
> > $(OMPI_MPIEXT_C_LIBS) \
> > $(OMPI_LIBMPI_EXTRA_LIBS)
> > +
> > +if WANT_MPI_PROFILING
> > +libmpi_la_LIBADD += \
> > +mpi/tool/libmpi_mpit.la
> > +endif
> > +
> > +
> > if OMPI_RTE_ORTE
> > libmpi_la_LIBADD += \
> > $(top_ompi_builddir)/orte/libopen-rte.la
> > ___
> > svn-full mailing list
> > svn-f...@open-mpi.org
> > http://www.open-mpi.org/mailman/listinfo.cgi/svn-full
> 
> 
> -- 
> Jeff Squyres
> jsquy...@cisco.com
> For corporate legal information go to: 
> http://www.cisco.com/web/about/doing_business/legal/cri/
> 
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

[OMPI devel] Fwd: [OMPI svn-full] svn:open-mpi r29043 - in trunk: config ompi

[Jeff Squyres (jsquyres)]

@Nathan --

Why is the MPIT convenience library related to whether profiling is enabled or 
not?


Begin forwarded message:

> From: 
> Subject: [OMPI svn-full] svn:open-mpi r29043 - in trunk: config ompi
> Date: August 19, 2013 10:48:24 AM EDT
> To: 
> Reply-To: 
> 
> Author: rhc (Ralph Castain)
> Date: 2013-08-19 10:48:23 EDT (Mon, 19 Aug 2013)
> New Revision: 29043
> URL: https://svn.open-mpi.org/trac/ompi/changeset/29043
> 
> Log:
> Okay, fix it so it works both --disable-mpi-profile and --enable-mpi-profile. 
> I'm not sure why mpit's library has to be treated differently, but it seems 
> that it needs some special care to work in both scenarios
> 
> Refs #3725
> 
> Text files modified: 
>   trunk/config/ompi_configure_options.m4 | 1 +
>
>   trunk/ompi/Makefile.am | 7 +++  
>
>   2 files changed, 8 insertions(+), 0 deletions(-)
> 
> Modified: trunk/config/ompi_configure_options.m4
> ==
> --- trunk/config/ompi_configure_options.m4Sun Aug 18 19:40:32 2013
> (r29042)
> +++ trunk/config/ompi_configure_options.m42013-08-19 10:48:23 EDT (Mon, 
> 19 Aug 2013)  (r29043)
> @@ -133,6 +133,7 @@
> MPIF_H_PMPI_W_FUNCS=
> fi
> AC_SUBST(MPIF_H_PMPI_W_FUNCS)
> +AM_CONDITIONAL(WANT_MPI_PROFILING, test "$WANT_MPI_PROFILING" = 1)
> 
> 
> #
> 
> Modified: trunk/ompi/Makefile.am
> ==
> --- trunk/ompi/Makefile.amSun Aug 18 19:40:32 2013(r29042)
> +++ trunk/ompi/Makefile.am2013-08-19 10:48:23 EDT (Mon, 19 Aug 2013)  
> (r29043)
> @@ -140,6 +140,13 @@
> $(MCA_ompi_FRAMEWORK_LIBS) \
> $(OMPI_MPIEXT_C_LIBS) \
> $(OMPI_LIBMPI_EXTRA_LIBS)
> +
> +if WANT_MPI_PROFILING
> +libmpi_la_LIBADD += \
> +mpi/tool/libmpi_mpit.la
> +endif
> +
> +
> if OMPI_RTE_ORTE
> libmpi_la_LIBADD += \
> $(top_ompi_builddir)/orte/libopen-rte.la
> ___
> svn-full mailing list
> svn-f...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/svn-full


-- 
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to: 
http://www.cisco.com/web/about/doing_business/legal/cri/