Re: [OMPI devel] Libevent changes

2020-07-10 Thread Ralph Castain via devel
We forgot to discuss this at the last telecon - GP, would you please ensure it 
is on next week's agenda?

FWIW: I agree that this should not have been committed. We need to stop doing 
local patches to public packages and instead focus on getting them into the 
upstream (which has still not been committed, I believe?).


> On Jul 6, 2020, at 8:13 AM, Barrett, Brian via devel 
>  wrote:
> 
> https://github.com/open-mpi/ompi/pull/6784 went in while I was on vacation.  
> I'm a little confused; I thought we no longer patched libevent locally?  This 
> is certainly going to be a problem as we move to external dependencies; we 
> won't have a way of pulling in this change (whether using the bundled 
> libevent or not).  I don't think we should have this patch locally in master, 
> because we're going to lose it in the next couple of weeks with the configure 
> changes I'm hopefully near completing.
> 
> Brian
> 




[OMPI devel] Libevent changes

2020-07-06 Thread Barrett, Brian via devel
https://github.com/open-mpi/ompi/pull/6784 went in while I was on vacation.  
I'm a little confused; I thought we no longer patched libevent locally?  This 
is certainly going to be a problem as we move to external dependencies; we 
won't have a way of pulling in this change (whether using the bundled libevent 
or not).  I don't think we should have this patch locally in master, because 
we're going to lose it in the next couple of weeks with the configure changes 
I'm hopefully near completing.

Brian