Re: [OMPI devel] OpenMPI 1.10.0: Arch Linux PkgSrc build suggests configure script patch

2015-09-21 Thread Ralph Castain
Yeah, we tried to catch all those, but obviously must have missed this one. 
I’ll add it to the mix

Thanks!
Ralph

> On Sep 20, 2015, at 9:01 PM, Kevin Buckley 
>  wrote:
> 
> Watcha,
> 
> we recently updated the OpenMPI installation on our School's ArchLinux
> machines, where OpenMPI is built as a PkgSrc package, to 1.10.0
> 
> In running through the build, we were told that PkgSrc wasn't too keen on
> the use of the == with a single "if test" construct and so I needed to apply
> the following patch
> 
> --- configure.orig  2015-08-24 23:33:14.0 +
> +++ configure
> @@ -60570,8 +60570,8 @@ _ACEOF
> $as_echo "$MPI_OFFSET_DATATYPE" >&6; }
> 
> 
> -if test "$ompi_fortran_happy" == "1" && \
> -   test "$OMPI_WANT_FORTRAN_BINDINGS" == "1"; then
> +if test "$ompi_fortran_happy" = "1" && \
> +   test "$OMPI_WANT_FORTRAN_BINDINGS" = "1"; then
> 
> # Get the kind value for Fortran MPI_INTEGER_KIND (corresponding
> # to whatever is the same size as a F77 INTEGER -- for the
> 
> 
> Seem to recall that this is "good practice" and indeed, can see that
> other "if test" stanzas in the configure script have been fixed to match,
> so perhaps this one has just slipped through the net and/or not been
> reported by anyone else as yet.
> 
> --
> Kevin M. Buckley
> 
> eScience Consultant
> School of Engineering and Computer Science
> Victoria University of Wellington
> New Zealand
> ___
> devel mailing list
> de...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post: 
> http://www.open-mpi.org/community/lists/devel/2015/09/18090.php



[OMPI devel] OpenMPI 1.10.0: Arch Linux PkgSrc build suggests configure script patch

2015-09-21 Thread Kevin Buckley
Watcha,

we recently updated the OpenMPI installation on our School's ArchLinux
machines, where OpenMPI is built as a PkgSrc package, to 1.10.0

In running through the build, we were told that PkgSrc wasn't too keen on
the use of the == with a single "if test" construct and so I needed to apply
the following patch

--- configure.orig  2015-08-24 23:33:14.0 +
+++ configure
@@ -60570,8 +60570,8 @@ _ACEOF
 $as_echo "$MPI_OFFSET_DATATYPE" >&6; }


-if test "$ompi_fortran_happy" == "1" && \
-   test "$OMPI_WANT_FORTRAN_BINDINGS" == "1"; then
+if test "$ompi_fortran_happy" = "1" && \
+   test "$OMPI_WANT_FORTRAN_BINDINGS" = "1"; then

 # Get the kind value for Fortran MPI_INTEGER_KIND (corresponding
 # to whatever is the same size as a F77 INTEGER -- for the


Seem to recall that this is "good practice" and indeed, can see that
other "if test" stanzas in the configure script have been fixed to match,
so perhaps this one has just slipped through the net and/or not been
reported by anyone else as yet.

--
Kevin M. Buckley

eScience Consultant
School of Engineering and Computer Science
Victoria University of Wellington
New Zealand