[OpenSIPS-Devel] [ opensips-Bugs-2822319 ] presence: active - pending is not allowed transition
Bugs item #2822319, was opened at 2009-07-16 11:21 Message generated for change (Comment added) made by anca_vamanu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=2822319group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Open Resolution: Accepted Priority: 5 Private: No Submitted By: Iñaki Baz Castillo (ibc_sf) Assigned to: Anca Vamanu (anca_vamanu) Summary: presence: active - pending is not allowed transition Initial Comment: imagine alice is subscribed to presence on bob. bob allows it (via XCAP) so alice sees his status (open in this case). alice displays a happy icon meaning online in the buddy list so alice (the human) knows that bob is online. Now bob uses XCAP to block alice. This could be by addid alice in a block action or by removing her from the allow rules. So the OpenSIPS presence agent sends a NOTIFY to alice containing: Subscription-State: pending;expires=2107 Does it make sense to receive a NOTIFY with Subscription-State: pending if previously the watcher received (in the same subscription dialog) a NOTIFY with Subscription-State: active? Is it a valid transition from active to pending? The fact is that I've tested varios common softphones and they don't react on the above case (and remain showing bob as online). I've checked RFC 3265 and it's not clear if active-pending makes sense, however RFC 3857 makes it clear: http://tools.ietf.org/html/rfc3857#section-4.7.1 subscribe, policy= +--+ reject| |+ +|terminated|-+ | | | | | | | | | |noresource| | +--+ |rejected | | ^noresource |deactivated | | |rejected|probation | | |deactivated |timeout |noresource | |probation | |rejected | |giveup | |giveup | || |approved +---+ +---++---+ | | |subscribe| |approved| | | | init ||pending|---|active | | | |no policy| || | | | | | || | | +---+ +---++---+ | | |^ | | subscribe, || | +---+ | policy = accept |+---+ | || | | ||waiting|--+ +---| | timeout | | +---+ Figure 1: Subscription State Machine This is, active-pending is not allowed. It must transition to terminated state with some appropiate reason parameter. IMHO it should be terminated;status=deactivated: http://tools.ietf.org/html/rfc3265#section-3.2.4 deactivated: The subscription has been terminated, but the subscriber SHOULD retry immediately with a new subscription. One primary use of such a status code is to allow migration of subscriptions between nodes. The retry-after parameter has no semantics for deactivated. -- Comment By: Anca Vamanu (anca_vamanu) Date: 2009-07-20 12:52 Message: Hi Inaki, Sorry I did not pay attention when I wrote the post. I really wanted to write there about the transition from active to terminated;reason=deactivated. I make the commit on Friday so you can update and test. However, the Subscription will remain in this status=terminated;reason=deactivated until the OpenSIPS PA will receive an MI command announcing it that the document has changed and then it will reanalyze the statuses. Do you see a problem in this behavior? regards, Anca -- Comment By: Iñaki Baz Castillo (ibc_sf) Date: 2009-07-17 22:42 Message: Hi Anca, you talk about a transition from pending to terminated;reason=deactivated, but what I mean is that if OpenSIPS PA receives a MI notification from the XCAP server and a watcher which was previously allowed is not no (now is blocked or doesn't appear as allowed), then PA should generate a NOTIFY with Subscription-State:
[OpenSIPS-Devel] [ opensips-Bugs-2822319 ] presence: active - pending is not allowed transition
Bugs item #2822319, was opened at 2009-07-16 10:21 Message generated for change (Comment added) made by ibc_sf You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=2822319group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Open Resolution: Accepted Priority: 5 Private: No Submitted By: Iñaki Baz Castillo (ibc_sf) Assigned to: Anca Vamanu (anca_vamanu) Summary: presence: active - pending is not allowed transition Initial Comment: imagine alice is subscribed to presence on bob. bob allows it (via XCAP) so alice sees his status (open in this case). alice displays a happy icon meaning online in the buddy list so alice (the human) knows that bob is online. Now bob uses XCAP to block alice. This could be by addid alice in a block action or by removing her from the allow rules. So the OpenSIPS presence agent sends a NOTIFY to alice containing: Subscription-State: pending;expires=2107 Does it make sense to receive a NOTIFY with Subscription-State: pending if previously the watcher received (in the same subscription dialog) a NOTIFY with Subscription-State: active? Is it a valid transition from active to pending? The fact is that I've tested varios common softphones and they don't react on the above case (and remain showing bob as online). I've checked RFC 3265 and it's not clear if active-pending makes sense, however RFC 3857 makes it clear: http://tools.ietf.org/html/rfc3857#section-4.7.1 subscribe, policy= +--+ reject| |+ +|terminated|-+ | | | | | | | | | |noresource| | +--+ |rejected | | ^noresource |deactivated | | |rejected|probation | | |deactivated |timeout |noresource | |probation | |rejected | |giveup | |giveup | || |approved +---+ +---++---+ | | |subscribe| |approved| | | | init ||pending|---|active | | | |no policy| || | | | | | || | | +---+ +---++---+ | | |^ | | subscribe, || | +---+ | policy = accept |+---+ | || | | ||waiting|--+ +---| | timeout | | +---+ Figure 1: Subscription State Machine This is, active-pending is not allowed. It must transition to terminated state with some appropiate reason parameter. IMHO it should be terminated;status=deactivated: http://tools.ietf.org/html/rfc3265#section-3.2.4 deactivated: The subscription has been terminated, but the subscriber SHOULD retry immediately with a new subscription. One primary use of such a status code is to allow migration of subscriptions between nodes. The retry-after parameter has no semantics for deactivated. -- Comment By: Iñaki Baz Castillo (ibc_sf) Date: 2009-07-20 12:11 Message: However, the Subscription will remain in this status=terminated;reason=deactivated until the OpenSIPS PA will receive and MI command announcing it that the document has changed and then it will reanalyze the statuses. Do you see a problem in this behavior? Hum, wouldn't be just easier if PA sends the NOTIFY terminated;reason=deactivated and deletes the subscription? When the client receives such a NOTIFY it will try to retry the subscription again and then OpenSIPS PA should create a new subscription in state pending. But if the new SUBSCRIBE from the client receives again terminated;reason=deactivated it would retry again and again. IMHO terminated;reason=deactivated only makes sense when the subscription was previously active. -- Comment By: Anca Vamanu (anca_vamanu) Date: 2009-07-20 11:52 Message: Hi Inaki, Sorry I did not pay attention when I wrote the post. I really wanted to write
[OpenSIPS-Devel] SF.net SVN: opensips:[5889] trunk/pvar.c
Revision: 5889 http://opensips.svn.sourceforge.net/opensips/?rev=5889view=rev Author: bogdan_iancu Date: 2009-07-20 10:12:01 + (Mon, 20 Jul 2009) Log Message: --- - fixed bug in $ct[] when value is START. As the regexp comps from script do change the value of a variable (to make it null terminated), the scritp var cannot return a statis string (as $ct did for STAR value so far). Reported by Thomas Gelf. Modified Paths: -- trunk/pvar.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[5890] trunk/modules/pua_dialoginfo
Revision: 5890 http://opensips.svn.sourceforge.net/opensips/?rev=5890view=rev Author: anca_vamanu Date: 2009-07-20 11:41:31 + (Mon, 20 Jul 2009) Log Message: --- - added display name information in the dialoginfo body (reported by elm0 at #opensips) Modified Paths: -- trunk/modules/pua_dialoginfo/dialog_publish.c trunk/modules/pua_dialoginfo/pua_dialoginfo.c trunk/modules/pua_dialoginfo/pua_dialoginfo.h This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-2823259 ] postgres insert into dialog generates error
Bugs item #2823259, was opened at 2009-07-17 22:10 Message generated for change (Settings changed) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=2823259group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Patrick F. (padraigf65) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: postgres insert into dialog generates error Initial Comment: postgres[38330]: [4-1] ERROR: syntax error at end of input at character 446 This is the statement from postgres logfile insert into dialog (hash_entry,hash_id,callid,from_uri,from_tag,to_uri,to_tag,caller_sock,callee_sock,start_time,state,timeout,caller_cseq,callee_cseq,caller_route_ set,callee_route_set,caller_contact,callee_contact ) values (3192,901188333,'xxx-x...@xx','sip:551...@192.168.113.92','8a05ee72','sip:551313 @192.168.93.27','80380344-69E','udp:192.168.93.27:5060','udp:192.168.93.27:5060',1247856162,3,1247856161,'1','1',NULL -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2009-07-20 14:43 Message: Hi Patrick. Do you get any other error in the opensips logs? like error while preparing insert operation ? Bogdan -- Comment By: Patrick F. (padraigf65) Date: 2009-07-17 22:11 Message: version: opensips 1.5.2-notls (x86_64/freebsd) flags: STATS: Off, USE_IPV6, USE_TCP, DISABLE_NAGLE, USE_MCAST, SHM_MEM, SHM_MMAP, PKG_MALLOC, F_MALLOC, FAST_LOCK-ADAPTIVE_WAIT Version info: ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535 poll method support: poll, select, kqueue. svnrevision: 2:5888M @(#) $Id: main.c 5887 2009-07-16 11:47:46Z bogdan_iancu $ main.c compiled on 14:30:11 Jul 17 2009 with gcc 4.2.1 -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=2823259group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[5891] trunk
Revision: 5891 http://opensips.svn.sourceforge.net/opensips/?rev=5891view=rev Author: bogdan_iancu Date: 2009-07-20 12:53:09 + (Mon, 20 Jul 2009) Log Message: --- - updating SVN props and IDs Modified Paths: -- trunk/packaging/debian/opensips.postinst trunk/packaging/debian-etch/opensips.postinst trunk/packaging/debian-sarge/opensips.postinst trunk/scripts/opensipsdbctl trunk/scripts/opensipsdbctl.db_berkeley trunk/scripts/opensipsdbctl.dbtext trunk/scripts/opensipsdbctl.mysql trunk/scripts/opensipsdbctl.pgsql trunk/scripts/osipsconsole trunk/test/21.cfg trunk/utils/db_berkeley/Makefile trunk/utils/opensipsunix/Makefile trunk/utils/opensipsunix/opensipsunix.8 trunk/utils/opensipsunix/opensipsunix.c Property Changed: trunk/packaging/debian/changelog trunk/packaging/debian/control trunk/packaging/debian/copyright trunk/packaging/debian/opensips.README.Debian trunk/packaging/debian/opensips.init trunk/packaging/debian/opensips.postinst trunk/packaging/debian/rules trunk/packaging/debian-etch/changelog trunk/packaging/debian-etch/control trunk/packaging/debian-etch/copyright trunk/packaging/debian-etch/opensips.README.Debian trunk/packaging/debian-etch/opensips.init trunk/packaging/debian-etch/opensips.postinst trunk/packaging/debian-etch/rules trunk/packaging/debian-sarge/changelog trunk/packaging/debian-sarge/control trunk/packaging/debian-sarge/copyright trunk/packaging/debian-sarge/opensips.README.Debian trunk/packaging/debian-sarge/opensips.init trunk/packaging/debian-sarge/opensips.postinst trunk/packaging/debian-sarge/rules trunk/packaging/fedora/opensips.init trunk/packaging/fedora/opensips.spec trunk/packaging/freebsd/Makefile trunk/packaging/freebsd/files/patch-Makefile trunk/packaging/freebsd/files/patch-Makefile-mysql trunk/packaging/freebsd/files/patch-Makefile.defs trunk/packaging/freebsd/pkg-descr trunk/packaging/gentoo/opensips-1.5.0.ebuild trunk/packaging/netbsd/DESCR trunk/packaging/netbsd/Makefile trunk/packaging/openbsd/Makefile trunk/packaging/openbsd/pkg/DESCR trunk/packaging/rpm/opensips.init trunk/packaging/rpm/opensips.init.SuSE trunk/packaging/rpm/opensips.spec.CentOS trunk/packaging/rpm/opensips.spec.SuSE trunk/packaging/solaris/berkeley-postinstall trunk/packaging/solaris/carrierroute-postinstall trunk/packaging/solaris/identity-postinstall trunk/packaging/solaris/ldap-postinstall trunk/packaging/solaris/mysql-postinstall trunk/packaging/solaris/pgsql-postinstall trunk/packaging/solaris/prototype trunk/packaging/solaris/regex-postinstall trunk/packaging/solaris/snmp-postinstall trunk/packaging/solaris/xmlrpc-postinstall trunk/parser/case_acce.h trunk/parser/case_allo.h trunk/parser/case_auth.h trunk/parser/case_call.h trunk/parser/case_cont.h trunk/parser/case_cseq.h trunk/parser/case_dive.h trunk/parser/case_even.h trunk/parser/case_expi.h trunk/parser/case_from.h trunk/parser/case_max.h trunk/parser/case_min_.h trunk/parser/case_orga.h trunk/parser/case_p_as.h trunk/parser/case_path.h trunk/parser/case_prio.h trunk/parser/case_priv.h trunk/parser/case_prox.h trunk/parser/case_reco.h trunk/parser/case_refe.h trunk/parser/case_remo.h trunk/parser/case_requ.h trunk/parser/case_retr.h trunk/parser/case_rout.h trunk/parser/case_sess.h trunk/parser/case_sip.h trunk/parser/case_subj.h trunk/parser/case_supp.h trunk/parser/case_to.h trunk/parser/case_unsu.h trunk/parser/case_user.h trunk/parser/case_via.h trunk/parser/case_www.h trunk/parser/contact/contact.c trunk/parser/contact/contact.h trunk/parser/contact/parse_contact.c trunk/parser/contact/parse_contact.h trunk/parser/digest/digest.c trunk/parser/digest/digest.h trunk/parser/digest/digest_keys.h trunk/parser/digest/digest_parser.c trunk/parser/digest/digest_parser.h trunk/parser/digest/param_parser.c trunk/parser/digest/param_parser.h trunk/parser/hf.c trunk/parser/hf.h trunk/parser/keys.h trunk/parser/msg_parser.c trunk/parser/msg_parser.h trunk/parser/parse_allow.c trunk/parser/parse_allow.h trunk/parser/parse_content.c trunk/parser/parse_content.h trunk/parser/parse_cseq.c trunk/parser/parse_cseq.h trunk/parser/parse_def.h trunk/parser/parse_disposition.c trunk/parser/parse_disposition.h trunk/parser/parse_diversion.c trunk/parser/parse_diversion.h trunk/parser/parse_event.c trunk/parser/parse_event.h trunk/parser/parse_expires.c trunk/parser/parse_expires.h trunk/parser/parse_fline.c trunk/parser/parse_fline.h trunk/parser/parse_from.c trunk/parser/parse_from.h
[OpenSIPS-Devel] SF.net SVN: opensips:[5893] trunk/parser/sdp/sdp.c
Revision: 5893 http://opensips.svn.sourceforge.net/opensips/?rev=5893view=rev Author: bogdan_iancu Date: 2009-07-20 12:58:52 + (Mon, 20 Jul 2009) Log Message: --- - fixed bogus len calculation of the sdp cloaning - mem overflow. Modified Paths: -- trunk/parser/sdp/sdp.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[5894] trunk
Revision: 5894 http://opensips.svn.sourceforge.net/opensips/?rev=5894view=rev Author: bogdan_iancu Date: 2009-07-20 13:04:45 + (Mon, 20 Jul 2009) Log Message: --- - svn props and Ids updated Property Changed: trunk/db/README trunk/db/db.c trunk/db/db.h trunk/db/db_cap.h trunk/db/db_con.h trunk/db/db_id.c trunk/db/db_id.h trunk/db/db_key.h trunk/db/db_op.h trunk/db/db_pool.c trunk/db/db_pool.h trunk/db/db_query.c trunk/db/db_query.h trunk/db/db_res.c trunk/db/db_res.h trunk/db/db_row.c trunk/db/db_row.h trunk/db/db_ut.c trunk/db/db_ut.h trunk/db/db_val.h trunk/db/example/Makefile trunk/db/example/README trunk/db/example/dbexample.c trunk/db/schema/Makefile trunk/db/schema/acc.xml trunk/db/schema/address.xml trunk/db/schema/aliases.xml trunk/db/schema/carrierfailureroute.xml trunk/db/schema/carrierroute.xml trunk/db/schema/closeddial.xml trunk/db/schema/cpl.xml trunk/db/schema/dbaliases.xml trunk/db/schema/dialog.xml trunk/db/schema/dialplan.xml trunk/db/schema/dispatcher.xml trunk/db/schema/domain.xml trunk/db/schema/domainpolicy.xml trunk/db/schema/dr_gateways.xml trunk/db/schema/dr_groups.xml trunk/db/schema/dr_gw_lists.xml trunk/db/schema/dr_rules.xml trunk/db/schema/entities.xml trunk/db/schema/globalblacklist.xml trunk/db/schema/grp.xml trunk/db/schema/gw.xml trunk/db/schema/imc_members.xml trunk/db/schema/imc_rooms.xml trunk/db/schema/lcr.xml trunk/db/schema/load_balancer.xml trunk/db/schema/location.xml trunk/db/schema/missed_calls.xml trunk/db/schema/nh_sockets.xml trunk/db/schema/opensips-acc.xml trunk/db/schema/opensips-alias_db.xml trunk/db/schema/opensips-auth_db.xml trunk/db/schema/opensips-avpops.xml trunk/db/schema/opensips-carrierroute.xml trunk/db/schema/opensips-closeddial.xml trunk/db/schema/opensips-cpl.xml trunk/db/schema/opensips-dialog.xml trunk/db/schema/opensips-dialplan.xml trunk/db/schema/opensips-dispatcher.xml trunk/db/schema/opensips-domain.xml trunk/db/schema/opensips-domainpolicy.xml trunk/db/schema/opensips-drouting.xml trunk/db/schema/opensips-extensions.xml trunk/db/schema/opensips-group.xml trunk/db/schema/opensips-imc.xml trunk/db/schema/opensips-lcr.xml trunk/db/schema/opensips-load_balancer.xml trunk/db/schema/opensips-msilo.xml trunk/db/schema/opensips-nathelper.xml trunk/db/schema/opensips-pdt.xml trunk/db/schema/opensips-permissions.xml trunk/db/schema/opensips-presence.xml trunk/db/schema/opensips-registrar.xml trunk/db/schema/opensips-rls.xml trunk/db/schema/opensips-siptrace.xml trunk/db/schema/opensips-speeddial.xml trunk/db/schema/opensips-standard.xml trunk/db/schema/opensips-uri_db.xml trunk/db/schema/opensips-userblacklist.xml trunk/db/schema/opensips-usrloc.xml trunk/db/schema/pdt.xml trunk/db/schema/pr_active_watchers.xml trunk/db/schema/pr_presentity.xml trunk/db/schema/pr_pua.xml trunk/db/schema/pr_watchers.xml trunk/db/schema/pr_xcap.xml trunk/db/schema/re_grp.xml trunk/db/schema/rls_presentity.xml trunk/db/schema/rls_watchers.xml trunk/db/schema/route_tree.xml trunk/db/schema/silo.xml trunk/db/schema/sip_trace.xml trunk/db/schema/speed_dial.xml trunk/db/schema/subscriber.xml trunk/db/schema/template.xml trunk/db/schema/trusted.xml trunk/db/schema/uri.xml trunk/db/schema/userblacklist.xml trunk/db/schema/usr_preferences.xml trunk/db/schema/version.xml trunk/doc/dbschema/bookinfo.xml trunk/doc/dbschema/catalog.xml trunk/doc/dbschema/dtd/dbschema.dtd trunk/doc/dbschema/xsl/common.xsl trunk/doc/dbschema/xsl/db_berkeley.xsl trunk/doc/dbschema/xsl/dbschema2docbook.xsl trunk/doc/dbschema/xsl/dbtext.xsl trunk/doc/dbschema/xsl/docbook.xsl trunk/doc/dbschema/xsl/mysql.xsl trunk/doc/dbschema/xsl/oracle.xsl trunk/doc/dbschema/xsl/postgres.xsl trunk/doc/dbschema/xsl/sql.xsl trunk/doc/doxygen/opensips-doxygen trunk/doc/entities.xml trunk/doc/module-docbook.css trunk/etc/dictionary.opensips trunk/etc/tls/README trunk/etc/tls/ca.conf trunk/etc/tls/request.conf trunk/etc/tls/rootCA/certs/01.pem trunk/etc/tls/rootCA/private/cakey.pem trunk/etc/tls/user/user-cert.pem trunk/examples/acc.cfg trunk/examples/ctd.sh trunk/examples/exec_s3.cfg trunk/examples/exec_s4.cfg trunk/examples/exec_s5.cfg trunk/examples/flag_reply.cfg trunk/examples/fork.cfg trunk/examples/logging.cfg trunk/examples/msilo.cfg trunk/examples/nathelper.cfg trunk/examples/pstn.cfg trunk/examples/redirect.cfg trunk/examples/replicate.cfg trunk/examples/serial_183.cfg trunk/examples/web_im/README
Re: [OpenSIPS-Devel] Some ways to crash OpenSIPS with current SVN
Dan Pascu write: Could you, just to rule hardware issues out, run a memory test (using memtest86+)? My nightmare seems to be over! After Bogdan's changes in revision 5889 and 5893 OpenSIPS is finally rock-solid once again! At least I did not (yet) find any method to crash it again. Many thanks for his patience and for the time he dedicated to remotely debug this issues with me! Best regards, Thomas Gelf ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] SF.net SVN: opensips:[5847] trunk/modules/nat_traversal/nat_traversal.c
Dan Pascu wrote: That is no wonder. 5783 contained a bug that made segfaults certain (it operated on a different variable than intended). This is why 5784 was made immediately after it. You should not use 5783 at all. The fix Bogdan made, is given by the combination of 5783+5784. What you should use is current trunk with system malloc so we can see if it fixes your problem. Alternatively you can use anything before 5783 also with the system malloc. Right now I'm pretty sure this crashes have been somehow related to the crashes mentioned in my thread Some ways to crash OpenSIPS with current SVN - so I think we can forget about this one... ...at least unless I manage it to discover something new ;-) Cheers, Thomas ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Some ways to crash OpenSIPS with current SVN
Thomas Gelf wrote: My nightmare seems to be over! After Bogdan's changes in revision 5889 and 5893 OpenSIPS is finally rock-solid once again! At least I did not (yet) find any method to crash it again. Many thanks for his patience and for the time he dedicated to remotely debug this issues with me! Best regards, Thomas Gelf One additional note: the reason this happened more or less only to me lies in the fact that QoS is currently the only module using the SDP parser - and it seems that not many people have activated this module (I'm using it to remotely query more details about active calls). The other fix (5889) is for a problem recently introduced - so probably no one is using it in production yet. I'm doing some $ct-voodoo to protect myself against some possible attacks using specially crafted REGISTER requests - and got bitten by the $ct-improving patch. Cheers, Thomas ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[5895] trunk/modules/dialplan
Revision: 5895 http://opensips.svn.sourceforge.net/opensips/?rev=5895view=rev Author: bogdan_iancu Date: 2009-07-20 14:11:05 + (Mon, 20 Jul 2009) Log Message: --- - fixed the types of variables that at accepted as input and output. - svn props updated Modified Paths: -- trunk/modules/dialplan/Makefile trunk/modules/dialplan/README trunk/modules/dialplan/dialplan.c trunk/modules/dialplan/doc/dialplan.xml trunk/modules/dialplan/doc/dialplan_admin.xml trunk/modules/dialplan/doc/dialplan_devel.xml Property Changed: trunk/modules/dialplan/Makefile trunk/modules/dialplan/README trunk/modules/dialplan/doc/dialplan.xml trunk/modules/dialplan/doc/dialplan_admin.xml trunk/modules/dialplan/doc/dialplan_devel.xml trunk/modules/dialplan/trex.c trunk/modules/dialplan/trex.h This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[5896] trunk/modules/tm
Revision: 5896 http://opensips.svn.sourceforge.net/opensips/?rev=5896view=rev Author: bogdan_iancu Date: 2009-07-20 14:37:03 + (Mon, 20 Jul 2009) Log Message: --- - fixed retransmiassion for local generated ACKs.. - more SVN props and IDs updated Modified Paths: -- trunk/modules/tm/uac.c Property Changed: trunk/modules/tm/Makefile trunk/modules/tm/README trunk/modules/tm/callid.c trunk/modules/tm/callid.h trunk/modules/tm/config.h trunk/modules/tm/dlg.c trunk/modules/tm/dlg.h trunk/modules/tm/doc/tm.xml trunk/modules/tm/doc/tm_admin.xml trunk/modules/tm/doc/tm_devel.xml trunk/modules/tm/doc/tm_faq.xml trunk/modules/tm/fix_lumps.h trunk/modules/tm/h_table.c trunk/modules/tm/h_table.h trunk/modules/tm/lock.c trunk/modules/tm/lock.h trunk/modules/tm/mi.c trunk/modules/tm/mi.h trunk/modules/tm/sip_msg.c trunk/modules/tm/sip_msg.h trunk/modules/tm/t_cancel.c trunk/modules/tm/t_cancel.h trunk/modules/tm/t_dlg.c trunk/modules/tm/t_dlg.h trunk/modules/tm/t_fifo.c trunk/modules/tm/t_fifo.h trunk/modules/tm/t_funcs.c trunk/modules/tm/t_funcs.h trunk/modules/tm/t_fwd.c trunk/modules/tm/t_fwd.h trunk/modules/tm/t_hooks.c trunk/modules/tm/t_hooks.h trunk/modules/tm/t_lookup.c trunk/modules/tm/t_lookup.h trunk/modules/tm/t_msgbuilder.c trunk/modules/tm/t_msgbuilder.h trunk/modules/tm/t_reply.c trunk/modules/tm/t_reply.h trunk/modules/tm/t_stats.h trunk/modules/tm/timer.c trunk/modules/tm/timer.h trunk/modules/tm/tm.c trunk/modules/tm/tm_load.h trunk/modules/tm/uac.c trunk/modules/tm/uac.h trunk/modules/tm/ut.h This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[5897] trunk
Revision: 5897 http://opensips.svn.sourceforge.net/opensips/?rev=5897view=rev Author: bogdan_iancu Date: 2009-07-20 14:52:34 + (Mon, 20 Jul 2009) Log Message: --- - fixed compiling with or without PKG_MALLOC definition Modified Paths: -- trunk/core_stats.c trunk/core_stats.h trunk/main.c trunk/mem/mem.c trunk/mem/mem.h Property Changed: trunk/core_stats.c trunk/core_stats.h trunk/main.c trunk/mem/f_malloc.c trunk/mem/f_malloc.h trunk/mem/mem.c trunk/mem/mem.h trunk/mem/meminfo.h trunk/mem/memtest.c trunk/mem/q_malloc.c trunk/mem/q_malloc.h trunk/mem/shm_mem.c trunk/mem/shm_mem.h trunk/mem/vq_malloc.c trunk/mem/vq_malloc.h This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Unable to disable PKG_MALLOC
Hi Thomas, This should be fixed on SVN trunk... :) Regards, Bogdan Thomas Gelf wrote: Error seems to be introduced with changes in revision 5653. I had to revert changes in 5653-5655 and finally also disabled STATISTICS to be able to use system malloc. Best regards, Thomas Gelf ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Unable to disable PKG_MALLOC
Thank you, now it compiles also without -DPKG_MALLOC. Regards, Thomas Bogdan-Andrei Iancu wrote: Hi Thomas, This should be fixed on SVN trunk... :) Regards, Bogdan Thomas Gelf wrote: Error seems to be introduced with changes in revision 5653. I had to revert changes in 5653-5655 and finally also disabled STATISTICS to be able to use system malloc. Best regards, Thomas Gelf ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[5898] trunk/modules/db_postgres
Revision: 5898 http://opensips.svn.sourceforge.net/opensips/?rev=5898view=rev Author: bogdan_iancu Date: 2009-07-20 16:41:39 + (Mon, 20 Jul 2009) Log Message: --- - fixed improper len calculation for postgres NULL token. Closes bug #2823259 Modified Paths: -- trunk/modules/db_postgres/val.c Property Changed: trunk/modules/db_postgres/Makefile trunk/modules/db_postgres/README trunk/modules/db_postgres/db_postgres.c trunk/modules/db_postgres/dbase.c trunk/modules/db_postgres/dbase.h trunk/modules/db_postgres/doc/db_postgres.xml trunk/modules/db_postgres/doc/db_postgres_admin.xml trunk/modules/db_postgres/pg_con.c trunk/modules/db_postgres/pg_con.h trunk/modules/db_postgres/pg_type.h trunk/modules/db_postgres/res.c trunk/modules/db_postgres/res.h trunk/modules/db_postgres/val.c trunk/modules/db_postgres/val.h This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-2823259 ] postgres insert into dialog generates error
Bugs item #2823259, was opened at 2009-07-17 22:10 Message generated for change (Settings changed) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=2823259group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.5.x Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Patrick F. (padraigf65) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: postgres insert into dialog generates error Initial Comment: postgres[38330]: [4-1] ERROR: syntax error at end of input at character 446 This is the statement from postgres logfile insert into dialog (hash_entry,hash_id,callid,from_uri,from_tag,to_uri,to_tag,caller_sock,callee_sock,start_time,state,timeout,caller_cseq,callee_cseq,caller_route_ set,callee_route_set,caller_contact,callee_contact ) values (3192,901188333,'xxx-x...@xx','sip:551...@192.168.113.92','8a05ee72','sip:551313 @192.168.93.27','80380344-69E','udp:192.168.93.27:5060','udp:192.168.93.27:5060',1247856162,3,1247856161,'1','1',NULL -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2009-07-20 19:42 Message: Hi Patrick, the fix is available on SVN - please upload and test again. Thanks and regards, Bogdan -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2009-07-20 14:43 Message: Hi Patrick. Do you get any other error in the opensips logs? like error while preparing insert operation ? Bogdan -- Comment By: Patrick F. (padraigf65) Date: 2009-07-17 22:11 Message: version: opensips 1.5.2-notls (x86_64/freebsd) flags: STATS: Off, USE_IPV6, USE_TCP, DISABLE_NAGLE, USE_MCAST, SHM_MEM, SHM_MMAP, PKG_MALLOC, F_MALLOC, FAST_LOCK-ADAPTIVE_WAIT Version info: ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535 poll method support: poll, select, kqueue. svnrevision: 2:5888M @(#) $Id: main.c 5887 2009-07-16 11:47:46Z bogdan_iancu $ main.c compiled on 14:30:11 Jul 17 2009 with gcc 4.2.1 -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=2823259group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[5899] branches/1.5/modules/db_postgres/val.c
Revision: 5899 http://opensips.svn.sourceforge.net/opensips/?rev=5899view=rev Author: bogdan_iancu Date: 2009-07-20 16:42:27 + (Mon, 20 Jul 2009) Log Message: --- backport from trunk (rev #5898): - fixed improper len calculation for postgres NULL token. Closes bug #2823259 Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=5898view=rev Modified Paths: -- branches/1.5/modules/db_postgres/val.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] New MediaProxy release 2.3.5
Hello,
There is a new release of MediaProxy available, it contains various
bug fixes and compatibility with newer software. To upgrade your
debian installation:
sudo apt-get update
sudo apt-get install mediaproxy-dispatcher mediaproxy-relay mediaproxy-
web-sessions
Or download the tar file from:
http://download.ag-projects.com/MediaProxy/
The changelog follows:
mediaproxy (2.3.5) unstable; urgency=low
* Replaced startSyslog with start_syslog to match latest python-
application
* Improved detection for linux platforms to include non intel
architectures
* Handle exhausted ports gracefully at relay
* Use start_time instead of to_tag to determine if accounting
should be
performed and the dialog ended in OpenSIPS for an expired
session, as
start_time only gets set if the relay saw SDP from both endpoints
* Fixed test to allow the relay to run on linux on non-intel
architectures
* Only include used stream types in RADIUS Sip-Applications field
* Replaced reference to LGPL with GPL in debian/copyright
* Added ${misc:Depends} to debian/control to fix lintian warnings
* Removed var/run/mediaproxy from debian/*.dirs to fix lintian errors
* Added __repr__ method to PortRange class
* Adapted code to work with python-application-1.1.2 or newer
* Added package dependency checks for the minimum required versions
* Updated minimum dependency requirements in debian/control and
INSTALL
* Bumped debian standards version to 3.8.2
Kind regards,
Adrian Georgescu
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-2824390 ] opensips 1.5.2 crashes when acc radius enabled
Bugs item #2824390, was opened at 2009-07-20 17:23 Message generated for change (Tracker Item Submitted) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=2824390group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: opensips 1.5.2 crashes when acc radius enabled Initial Comment: Centos 5.3 x86_64, Opensips 1.5.2 with acc and radius logging enabled (compiled with freeradius-client 1.1.6 lib). Opensips listens on mulitple interfaces; I try a call between two phones (no nat involved); opensips core dumps with the following backtrace: Core was generated by `/usr/local/opensips/sbin/opensips -f /usr/local/opensips/etc/opensips/opensips.'. Program terminated with signal 11, Segmentation fault. [New process 446] #0 0x2b9891b57275 in rc_get_ipaddr (host=value optimized out) at ip_util.c:148 148 return ntohl((*(uint32_t *) hp-h_addr)); -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=2824390group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] fr_inv_timer: description in the documentation is misleading
Hi, From http://www.opensips.org/html/docs/modules/1.5.x/tm.html#id228479: fr_inv_timer (integer) Timer which hits if no final reply for an INVITE arrives after a provisional message was received (in seconds). This timer is started after the first provisional response. Thus, fast failover (no 100 trying from gateway) can be achieved by setting fr_timer to low values. See example below Isn't there a contradiction between 2nd and 3rd sentences? If the timer is really started after the first provisional response (e.g. 100), it can't affect the time we wait for the receipt of 100 from the gateway. Of course source code will clarify this for me, but I just want to point out this mismatch. Thanks! -- Sincerely, Andrew Pogrebennyk ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [OpenSIPS-Users] fr_inv_timer: description in the documentation is misleading
Hi Andrew, Andrew Pogrebennyk wrote: Hi, From http://www.opensips.org/html/docs/modules/1.5.x/tm.html#id228479: fr_inv_timer (integer) Timer which hits if no final reply for an INVITE arrives after a provisional message was received (in seconds). This timer is started after the first provisional response. yes, the fr_inv_timer starts after receiving a provisional reply. Thus, fast failover (no 100 trying from gateway) can be achieved by setting fr_timer to low values. fr_timer is between the request being sent out and the first reply being received. After receiving the first provisional reply, the fr_inv_timer takes over the fr_timer. Note there are 2 timers : fr_timer and fr_inv_timer ! Regards, Bogdan See example below Isn't there a contradiction between 2nd and 3rd sentences? If the timer is really started after the first provisional response (e.g. 100), it can't affect the time we wait for the receipt of 100 from the gateway. Of course source code will clarify this for me, but I just want to point out this mismatch. Thanks! ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-2823714 ] freebsd port
Patches item #2823714, was opened at 2009-07-19 00:53 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=2823714group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: packaging Group: 1.5.x Status: Open Resolution: Accepted Priority: 5 Private: No Submitted By: Michal Buchtik (buchtajz) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: freebsd port Initial Comment: updated freebsd port to version 1.5.2 -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2009-07-20 21:03 Message: Hi Michal, Thanks, I will upload it asap. Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=2823714group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[5900] branches/1.5/packaging/freebsd
Revision: 5900 http://opensips.svn.sourceforge.net/opensips/?rev=5900view=rev Author: bogdan_iancu Date: 2009-07-20 18:39:29 + (Mon, 20 Jul 2009) Log Message: --- updated the freebsd port to 1.5.2 Credits go to Michal Buchtik Closes patch #2823714 Modified Paths: -- branches/1.5/packaging/freebsd/Makefile branches/1.5/packaging/freebsd/distinfo branches/1.5/packaging/freebsd/files/patch-Makefile branches/1.5/packaging/freebsd/files/patch-Makefile-mysql branches/1.5/packaging/freebsd/files/patch-Makefile.defs This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-2823714 ] freebsd port
Patches item #2823714, was opened at 2009-07-19 00:53 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=2823714group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: packaging Group: 1.5.x Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: Michal Buchtik (buchtajz) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: freebsd port Initial Comment: updated freebsd port to version 1.5.2 -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2009-07-20 21:41 Message: done -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2009-07-20 21:03 Message: Hi Michal, Thanks, I will upload it asap. Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=2823714group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
