[OpenSIPS-Devel] rls_handle_subscribe() return code when list is not found
from rls tutorial document:
http://www.opensips.org/Resources/Rls
i get impression that rls_handle_subscribe() should return
to_presence_code, if resource list document is not found in xcap server.
however, when i read the code, it has:
if(doc== NULL|| service_node==NULL)
{
LM_DBG(list not found - search for uri =
%.*s\n,subs.pres_uri.len,
subs.pres_uri.s);
reply_code = 404;
reply_str = pu_404_rpl;
goto error;
}
is this a bug? if not, i don't see how a normal handle_subscribe()
can be tried if rls document doesn't exit.
-- juha
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] rls_handle_subscribe() return code when list is not found
2009/8/28 Juha Heinanen j...@tutpro.com:
from rls tutorial document:
http://www.opensips.org/Resources/Rls
i get impression that rls_handle_subscribe() should return
to_presence_code, if resource list document is not found in xcap server.
however, when i read the code, it has:
if(doc== NULL|| service_node==NULL)
{
LM_DBG(list not found - search for uri =
%.*s\n,subs.pres_uri.len,
subs.pres_uri.s);
reply_code = 404;
reply_str = pu_404_rpl;
goto error;
}
is this a bug? if not, i don't see how a normal handle_subscribe()
can be tried if rls document doesn't exit.
I haven't inspected the code, but rls_handle_subscribe() does what
it's supposed to do (return the preconfigured to $rc when no RL doc is
found).
--
Iñaki Baz Castillo
i...@aliax.net
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] rls_handle_subscribe() return code when list is not found
Iñaki Baz Castillo writes: I haven't inspected the code, but rls_handle_subscribe() does what it's supposed to do (return the preconfigured to $rc when no RL doc is found). inaki, are you sure that it returns pre-configured $rc even when Supported: header includes 'eventlist', but there is no presence list document in xcap server? if there is no 'eventlist' in Supported header, then pre-configured $rc is returned as it should. my understand from reading the code and from doing some tests is that in the above mentioned combination things, -1 is incorrectly returned. -- juha ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] rls_handle_subscribe() return code when list is not found
Hi Juha, You are right, a Subscribe that contains Supported:eventlist header but for which a list definition is not found, is replied with 404 and not sent to the presence server. It has been the way described in the documentation but changed in a commit on 12 November last year: http://opensips.svn.sourceforge.net/viewvc/opensips?view=revrevision=4944. I have now looked through the RFC and to be honest, I think that I shouldn't have done the change and still let the Subscribe go to the presence server. I don't remember which was the reason to change it at that moment, but I remember it came after a discussion with Dan Pascu when he gave me a strong argument to do so. I am willing to change it back, but will first wait for Dan's input on this. Thanks and regards, Anca Juha Heinanen wrote: Iñaki Baz Castillo writes: I haven't inspected the code, but rls_handle_subscribe() does what it's supposed to do (return the preconfigured to $rc when no RL doc is found). inaki, are you sure that it returns pre-configured $rc even when Supported: header includes 'eventlist', but there is no presence list document in xcap server? if there is no 'eventlist' in Supported header, then pre-configured $rc is returned as it should. my understand from reading the code and from doing some tests is that in the above mentioned combination things, -1 is incorrectly returned. -- juha ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[6040] trunk/modules/rls/subscribe.c
Revision: 6040 http://opensips.svn.sourceforge.net/opensips/?rev=6040view=rev Author: anca_vamanu Date: 2009-08-28 11:33:40 + (Fri, 28 Aug 2009) Log Message: --- - revert change made in commit rev #4944: return to_presence code for Subscribe messages that contain Supported:eventlist header but for which a list definition is not found Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=4944view=rev Modified Paths: -- trunk/modules/rls/subscribe.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[6041] branches/1.5/modules/rls/subscribe.c
Revision: 6041 http://opensips.svn.sourceforge.net/opensips/?rev=6041view=rev Author: anca_vamanu Date: 2009-08-28 11:38:22 + (Fri, 28 Aug 2009) Log Message: --- - revert change made in commit rev #4944: return to_presence code for Subscribe messages that contain Supported:eventlist header but for which a list definition is not found Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=4944view=rev Modified Paths: -- branches/1.5/modules/rls/subscribe.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[6041] branches/1.5/modules/rls/subscribe.c
Anca Vamanu writes: - revert change made in commit rev #4944: return to_presence code for - Subscribe messages that contain Supported:eventlist header but for - which a list definition is not found anca, in case of in-dialog subscribe, the module still returns 404 if document is not found. isn't the idea that rls_handle_subscribe() can be called also for in-dialog requests and get 'to_presence_code' back if the in-dialog subscribe was not for rls server? -- juha ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[6041] branches/1.5/modules/rls/subscribe.c
anca, regarding in-dialog subscribe requests, perhaps it could be checked in the script if the request is for rls server or not, for example, checking that request uri matches server_address. if so, then rls_handle_subscribe would not need to handle non-list subscribes. -- juha ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[6042] trunk/modules/rls/subscribe.c
Revision: 6042 http://opensips.svn.sourceforge.net/opensips/?rev=6042view=rev Author: anca_vamanu Date: 2009-08-28 12:35:59 + (Fri, 28 Aug 2009) Log Message: --- - if an indialog Subscribe does not match a known dialog, send the Subscribe to presence server (reported by Juha Heinanen) Modified Paths: -- trunk/modules/rls/subscribe.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] SF.net SVN: opensips:[6041] branches/1.5/modules/rls/subscribe.c
Hi Juha, You are right, I fixed that. Thanks, Anca Juha Heinanen wrote: anca, regarding in-dialog subscribe requests, perhaps it could be checked in the script if the request is for rls server or not, for example, checking that request uri matches server_address. if so, then rls_handle_subscribe would not need to handle non-list subscribes. -- juha ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[6043] branches/1.5/modules/rls/subscribe.c
Revision: 6043 http://opensips.svn.sourceforge.net/opensips/?rev=6043view=rev Author: anca_vamanu Date: 2009-08-28 12:40:44 + (Fri, 28 Aug 2009) Log Message: --- - if an indialog Subscribe does not match a known dialog, send the Subscribe to presence server (reported by Juha Heinanen) Modified Paths: -- branches/1.5/modules/rls/subscribe.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[6043] branches/1.5/modules/rls/subscribe.c
Anca Vamanu writes: - if an indialog Subscribe does not match a known dialog, send the - Subscribe to presence server (reported by Juha Heinanen) anca, thanks for the fix. after thinking a bit more this, it should be possible to distinguish in script if an initial subscribe possibly is for rls server, because normal subscribes are for uris of local users. so if target of subscribe is not for a local user, handle it with rls_handle_subscribe and return 404 if it fails. -- juha ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] SF.net SVN: opensips:[6043] branches/1.5/modules/rls/subscribe.c
On Aug 28, 2009, at 3:01 PM, Juha Heinanen wrote: Anca Vamanu writes: - if an indialog Subscribe does not match a known dialog, send the - Subscribe to presence server (reported by Juha Heinanen) anca, thanks for the fix. after thinking a bit more this, it should be possible to distinguish in script if an initial subscribe possibly is for rls server, because normal subscribes are for uris of local users. You can subscribe also to users of remote domains and they are not local. so if target of subscribe is not for a local user, handle it with rls_handle_subscribe and return 404 if it fails. This is wrong for the reason above. There was a reason for handling the way it was, too bad Dan is in holiday and could not comment. Adrian -- juha ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel -- Adrian ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] SF.net SVN: opensips:[6043] branches/1.5/modules/rls/subscribe.c
Adrian Georgescu writes: You can subscribe also to users of remote domains and they are not local. sure, but in that case, i'm not calling handle_subscribe, but just t_relay the request. so if target of subscribe is not for a local user, handle it with rls_handle_subscribe and return 404 if it fails. This is wrong for the reason above. sorry, i meant, user part of uri does not belong to existing user, but host part is a local domain. There was a reason for handling the way it was, too bad Dan is in holiday and could not comment. the way it was does not work if you plan to call handle_subscribe after rls_handle_subscribe. there is two possible implementations of rls_handle_subscribe: - do not do any smarts in the implementation, but leave it to the script to figure out when to call rls_subscribe - do smarts the way they are done now they way the smarts were done earlier, was not correct. -- juha ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-2846288 ] benchmark module fixes
Patches item #2846288, was opened at 2009-08-28 17:00 Message generated for change (Tracker Item Submitted) made by viraptor You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=2846288group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Stanislaw Pitucha (viraptor) Assigned to: Nobody/Anonymous (nobody) Summary: benchmark module fixes Initial Comment: Trivial fixes: - default bm_granularity changed to 100 (to match documentation) - time difference calculation fix diff taken against 1.5.2 -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=2846288group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
