[OpenSIPS-Devel] [ opensips-Bugs-3101083 ] Presence module: fallback2db setting broken
Bugs item #3101083, was opened at 2010-11-01 23:05 Message generated for change (Comment added) made by anca_vamanu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3101083group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.6.x Status: Closed Resolution: Invalid Priority: 5 Private: No Submitted By: Vallimamod Abdullah (vabdulla) Assigned to: Nobody/Anonymous (nobody) Summary: Presence module: fallback2db setting broken Initial Comment: Hello, I have noticed that the fallback2db option of presence module is not honored when a record is found in presence hash table. After checking the code, I found in presence/notify.c, in function get_p_notify_body() that if search_phtable() does not return NULL in line 989 (record found) the result is discarded and the search is done in database. On the contrary, if there is no record in hash, no search is made in db. I will try to come up with a patch but I am still trying to understand the code... Regards, Vallimamod Abdullah . -- Comment By: Anca Vamanu (anca_vamanu) Date: 2010-11-02 18:24 Message: Hi Vallimamod, But when there is a record in hash table and fallback2db is disabled, the DB is still searched, which is not the expected behavior. The hash tables for publish info contains only an indication if the record exists in database, but it does not store the body. So the search in database must be made even if fallback2db is not set. The publish hash table, for when fallback2db is not set, says only if searches need to be done in database or not. Regards, -- Comment By: Vallimamod Abdullah (vabdulla) Date: 2010-11-01 23:12 Message: Actually, to correct myself, the search in DB is indeed made when no record is found in hash and fallback2db enabled. But when there is a record in hash table and fallback2db is disabled, the DB is still searched, which is not the expected behaviour. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3101083group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3101083 ] Presence module: fallback2db setting broken
Bugs item #3101083, was opened at 2010-11-01 22:05 Message generated for change (Comment added) made by vabdulla You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3101083group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.6.x Status: Closed Resolution: Invalid Priority: 5 Private: No Submitted By: Vallimamod Abdullah (vabdulla) Assigned to: Nobody/Anonymous (nobody) Summary: Presence module: fallback2db setting broken Initial Comment: Hello, I have noticed that the fallback2db option of presence module is not honored when a record is found in presence hash table. After checking the code, I found in presence/notify.c, in function get_p_notify_body() that if search_phtable() does not return NULL in line 989 (record found) the result is discarded and the search is done in database. On the contrary, if there is no record in hash, no search is made in db. I will try to come up with a patch but I am still trying to understand the code... Regards, Vallimamod Abdullah . -- Comment By: Vallimamod Abdullah (vabdulla) Date: 2010-11-02 17:36 Message: Thanks for the precision Anca. I came to the same conclusion after reading the code in more details. Regards, Vallimamod . -- Comment By: Anca Vamanu (anca_vamanu) Date: 2010-11-02 17:24 Message: Hi Vallimamod, But when there is a record in hash table and fallback2db is disabled, the DB is still searched, which is not the expected behavior. The hash tables for publish info contains only an indication if the record exists in database, but it does not store the body. So the search in database must be made even if fallback2db is not set. The publish hash table, for when fallback2db is not set, says only if searches need to be done in database or not. Regards, -- Comment By: Vallimamod Abdullah (vabdulla) Date: 2010-11-01 22:12 Message: Actually, to correct myself, the search in DB is indeed made when no record is found in hash and fallback2db enabled. But when there is a record in hash table and fallback2db is disabled, the DB is still searched, which is not the expected behaviour. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3101083group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] About b2b_entities
Hi, I'm using v1.6 from SVN, and I would like to report an UPDATE in my b2b client module, but entities reply on INVITE with 491 error code. Here is my test (from RFC 3311): Caller INVITE--- B2B ---180 --UPDATE-- -- 491--- In sources, this reply happen when the call state is proceeding, but I don't think it is RFC compliant ? I saw you added DB binding in entities, but this feature is set by default. Would you make it configurable (use it or not) ? Thanks you, Regards, -- Olivier Détour ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] About b2b_entities
Hi Olivier, On 11/02/2010 06:46 PM, Olivier Détour wrote: Hi, I'm using v1.6 from SVN, and I would like to report an UPDATE in my b2b client module, but entities reply on INVITE with 491 error code. Here is my test (from RFC 3311): Caller INVITE--- B2B ---180 --UPDATE-- -- 491--- In sources, this reply happen when the call state is proceeding, but I don't think it is RFC compliant ? This is an issue I know about, I will have to fix it. I will let you know when it's done. I saw you added DB binding in entities, but this feature is set by default. Would you make it configurable (use it or not) ? I can make it configurable sure.. Thanks you, Regards, Regards, -- Anca Vamanu www.voice-system.ro ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[7343] trunk/modules/b2b_logic/b2b_logic.c
Revision: 7343 http://opensips.svn.sourceforge.net/opensips/?rev=7343view=rev Author: osas Date: 2010-11-02 18:56:05 + (Tue, 02 Nov 2010) Log Message: --- b2b_logic: print peer key for b2bl entities for b2b_list Modified Paths: -- trunk/modules/b2b_logic/b2b_logic.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
