[OpenSIPS-Devel] [ opensips-Bugs-3411386 ] leaks in load_balancer (mostly when already OOM)
Bugs item #3411386, was opened at 2011-09-19 10:54 Message generated for change (Tracker Item Submitted) made by wdoekes You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3411386group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Open Resolution: None Priority: 5 Private: No Submitted By: Walter Doekes (wdoekes) Assigned to: Nobody/Anonymous (nobody) Summary: leaks in load_balancer (mostly when already OOM) Initial Comment: Hi, when investigaging OOM issues, I found a couple of missing pkg_free's in load_balancer.c. Most of those free's would only be missed if the system was already out of memory, in which case you're screwed anyway, but I do have a couple of points where I'm unsure that the memory gets freed properly at all. Please take a look at the annotated diff. Regards, Walter Doekes -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3411386group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3411386 ] leaks in load_balancer (mostly when already OOM)
Bugs item #3411386, was opened at 2011-09-19 10:54 Message generated for change (Comment added) made by wdoekes You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3411386group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Open Resolution: None Priority: 5 Private: No Submitted By: Walter Doekes (wdoekes) Assigned to: Nobody/Anonymous (nobody) Summary: leaks in load_balancer (mostly when already OOM) Initial Comment: Hi, when investigaging OOM issues, I found a couple of missing pkg_free's in load_balancer.c. Most of those free's would only be missed if the system was already out of memory, in which case you're screwed anyway, but I do have a couple of points where I'm unsure that the memory gets freed properly at all. Please take a look at the annotated diff. Regards, Walter Doekes -- Comment By: Walter Doekes (wdoekes) Date: 2011-09-19 10:55 Message: P.S. These issues are in 1.6 as well -- which I'm running. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3411386group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3411398 ] load_balancer leaks when doing lb_reload
Bugs item #3411398, was opened at 2011-09-19 11:26 Message generated for change (Tracker Item Submitted) made by wdoekes You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3411398group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Open Resolution: None Priority: 5 Private: No Submitted By: Walter Doekes (wdoekes) Assigned to: Nobody/Anonymous (nobody) Summary: load_balancer leaks when doing lb_reload Initial Comment: Hi, a couple of load_balancer leaks occur when doing lb_reload. Do a while loop around a fifo lb_reload and watch it consume all available mem. This patch fixes it. Regards, Walter Doekes OSSO B.V. P.S. Bugs are also in 1.6. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3411398group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3411434 ] lack of free_to_params in many places
Bugs item #3411434, was opened at 2011-09-19 13:28 Message generated for change (Tracker Item Submitted) made by wdoekes You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3411434group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: trunk Status: Open Resolution: None Priority: 5 Private: No Submitted By: Walter Doekes (wdoekes) Assigned to: Nobody/Anonymous (nobody) Summary: lack of free_to_params in many places Initial Comment: Hi, free_to_params is not called (implicitly) nearly as often as it should. See attached patch. Note: I removed the free_to_params from parse_to_params as it could cause double frees. Convention seems to be that one should call it. Note: I only tested the parse_to functionality. Other parts of the patch are checked for compilation errors only. Version 1.6 is also affected (as probably others too). Regards, Walter Doekes OSSO B.V. See also: http://sip-router.org/tracker/index.php?do=detailstask_id=155 -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3411434group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3411442 ] Segmentation fault in push_reply_in_dialog
Bugs item #3411442, was opened at 2011-09-19 15:56
Message generated for change (Tracker Item Submitted) made by sybasesql
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3411442group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: 1.7.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Sergey Lavrov (sybasesql)
Assigned to: Nobody/Anonymous (nobody)
Summary: Segmentation fault in push_reply_in_dialog
Initial Comment:
opensips-1.7.0 rev 8357
OS: centos 5.6 x86_64
I have Segmentation fault:
#0 0x2ac79c880dd2 in push_reply_in_dialog (rpl=0x8229b0, t=0x2ac7a2e42b70,
dlg=0x2ac7a2e42200, mangled_from=0x7fff31d9c940, mangled_to=0x7fff31d9c930) at
dlg_handlers.c:350
350 if ( dlg-legs[leg].tag.len==tag.len
---
(gdb) bt
#0 0x2ac79c880dd2 in push_reply_in_dialog (rpl=0x8229b0, t=0x2ac7a2e42b70,
dlg=0x2ac7a2e42200, mangled_from=0x7fff31d9c940, mangled_to=0x7fff31d9c930) at
dlg_handlers.c:350
#1 0x2ac79c8822be in dlg_onreply (t=0x2ac7a2e42b70, type=value optimized
out, param=value optimized out) at dlg_handlers.c:434
#2 0x2ac79c42f54b in run_trans_callbacks (type=8, trans=0x2ac7a2e42b70,
req=0x2ac7a3035fd8, rpl=0x8229b0, code=180) at t_hooks.c:212
#3 0x2ac79c43c480 in relay_reply (t=0x2ac7a2e42b70, p_msg=0x8229b0,
branch=1200, msg_status=180, cancel_bitmap=0x7fff31d9cc28) at t_reply.c:1166
#4 0x2ac79c43caac in reply_received (p_msg=0x8229b0) at t_reply.c:1512
#5 0x004222fd in forward_reply (msg=0x8229b0) at forward.c:568
#6 0x0044fb81 in receive_msg (
buf=0x753020 SIP/2.0 180 Ringing\r\nVia: SIP/2.0/UDP
x.x.x.x;branch=z9hG4bK258b.677fa944.0;i=481\r\nVia: SIP/2.0/TCP
y.y.y.y:5060;received=y.y.y.y;branch=z9hG4bK-d8754z-d0ea2355dab67205-1---d8754z-;rpor...,
len=878, rcv_info=0x7fff31d9cd70) at receive.c:203
#7 0x0048f698 in udp_rcv_loop () at udp_server.c:419
#8 0x0042a57c in main_loop (argc=value optimized out, argv=value
optimized out) at main.c:885
#9 main (argc=value optimized out, argv=value optimized out) at main.c:1503
---
(gdb) bt full
#0 0x2ac79c880dd2 in push_reply_in_dialog (rpl=0x8229b0, t=0x2ac7a2e42b70,
dlg=0x2ac7a2e42200, mangled_from=0x7fff31d9c940, mangled_to=0x7fff31d9c930) at
dlg_handlers.c:350
tag = {
s = 0x75322a 1174779552\r\nCall-ID:
ZTMwNzdhN2M2YjA4ODM4MmRiYTJkOGQ1MDVmNzlhOTA.\r\nCSeq: 1 INVITE\r\nContact:
sip:manager2@89.31.18.41:1026\r\nAllow: INVITE, INFO, PRACK, ACK, BYE,
CANCEL, OPTIONS, NOTIFY, REGISTER, SU..., len = 10}
contact = {s = 0x2ac7a3171158 \330w, len = -1668799477}
rr_set = {s = 0x2 Address 0x2 out of bounds, len = -1558833544}
leg = 1
skip_rrs = value optimized out
__FUNCTION__ = push_reply_in_dialog
#1 0x2ac79c8822be in dlg_onreply (t=0x2ac7a2e42b70, type=value optimized
out, param=value optimized out) at dlg_handlers.c:434
rpl = 0x8229b0
req = 0x2ac7a3035fd8
dlg = 0x2ac7a2e42200
new_state = value optimized out
old_state = value optimized out
unref = value optimized out
event = value optimized out
mangled_from = {s = 0x0, len = 0}
mangled_to = {s = 0x0, len = 0}
req_out_buff = 0xb4
__FUNCTION__ = dlg_onreply
#2 0x2ac79c42f54b in run_trans_callbacks (type=8, trans=0x2ac7a2e42b70,
req=0x2ac7a3035fd8, rpl=0x8229b0, code=180) at t_hooks.c:212
params = {req = 0x2ac7a3035fd8, rpl = 0x8229b0, code = 180, param =
0x2ac7a2bc9930, extra1 = 0x0, extra2 = 0x0}
cbp = 0x2ac7a2bc9920
backup = 0x763030
trans_backup = 0x2ac7a2e42b70
__FUNCTION__ = run_trans_callbacks
#3 0x2ac79c43c480 in relay_reply (t=0x2ac7a2e42b70, p_msg=0x8229b0,
branch=1200, msg_status=180, cancel_bitmap=0x7fff31d9cc28) at t_reply.c:1166
relay = 1200
save_clone = 0
buf = value optimized out
res_len = 0
relayed_code = 180
relayed_msg = value optimized out
bm = {to_tag_val = {s = 0x1 Address 0x1 out of bounds, len = 8530352}}
totag_retr = value optimized out
reply_status = RPS_PROVISIONAL
uas_rb = 0x2ac7a2e42c70
cb_s = {s = 0x8229b0 \002\002\061, len = 8108712}
text = {s = 0x8277a8 \001, len = 878}
__FUNCTION__ = relay_reply
#4 0x2ac79c43caac in reply_received (p_msg=0x8229b0) at t_reply.c:1512
msg_status = 180
last_uac_status = value optimized out
branch = 8587360
reply_status = value optimized out
timer = value optimized out
cancel_bitmap = 0
uac = 0x2ac7a2e42d48
t = 0x2ac7a2e42b70
backup_list = 0x0
__FUNCTION__ = reply_received
#5 0x004222fd in forward_reply (msg=0x8229b0) at forward.c:568
[OpenSIPS-Devel] [ opensips-Bugs-3411444 ] Segmentation fault in dialog_update_db
Bugs item #3411444, was opened at 2011-09-19 15:59
Message generated for change (Tracker Item Submitted) made by sybasesql
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3411444group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: 1.7.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Sergey Lavrov (sybasesql)
Assigned to: Nobody/Anonymous (nobody)
Summary: Segmentation fault in dialog_update_db
Initial Comment:
opensips-1.7.0 rev 8357
OS: CentOS 5.6 x86_64
Core was generated by `/usr/sbin/opensips'.
Program terminated with signal 11, Segmentation fault.
#0 0x2ac79c877917 in dialog_update_db (ticks=value optimized out,
param=value optimized out) at dlg_db_handler.c:1060
1060SET_STR_VALUE(values+18,
cell-legs[DLG_CALLER_LEG].r_cseq);
---
(gdb) bt
#0 0x2ac79c877917 in dialog_update_db (ticks=value optimized out,
param=value optimized out) at dlg_db_handler.c:1060
#1 0x2ac79c870ac7 in mod_destroy () at dialog.c:756
#2 0x0046a5cc in destroy_modules () at sr_module.c:371
#3 0x00425372 in cleanup (show_status=1) at main.c:344
#4 0x00425dcb in handle_sigs () at main.c:545
#5 0x0042a295 in main_loop (argc=value optimized out,
argv=0x2ac7a1d1cd70) at main.c:996
#6 main (argc=value optimized out, argv=0x2ac7a1d1cd70) at main.c:1503
---
(gdb) bt full
#0 0x2ac79c877917 in dialog_update_db (ticks=value optimized out,
param=value optimized out) at dlg_db_handler.c:1060
index = 2075
values = {{type = DB_INT, nul = 0, free = 124133132, val = {int_val =
2075, double_val = 1.0251862151205866e-320, time_val = 2075, string_val = 0x81b
Address 0x81b out of bounds, str_val = {
s = 0x81b Address 0x81b out of bounds, len = -399977312},
blob_val = {s = 0x81b Address 0x81b out of bounds, len = -399977312},
bitmap_val = 2075}}, {type = DB_INT, nul = 0, free = -399957912, val = {
int_val = 1446169044, double_val = 7.1450244271947809e-315,
time_val = 1446169044, string_val = 0x5632c9d4 Address 0x5632c9d4 out of
bounds, str_val = {s = 0x5632c9d4 Address 0x5632c9d4 out of bounds, len =
33188},
blob_val = {s = 0x5632c9d4 Address 0x5632c9d4 out of bounds,
len = 33188}, bitmap_val = 1446169044}}, {type = DB_STR, nul = 55, free =
836356976, val = {int_val = 16, double_val = 1.0185579797423812e-312,
time_val = 206158430224, string_val = 0x300010 Address
0x300010 out of bounds, str_val = {s = 0x300010 Address 0x300010
out of bounds, len = 836356976}, blob_val = {
s = 0x300010 Address 0x300010 out of bounds, len =
836356976}, bitmap_val = 16}}, {type = DB_STR, nul = 32767, free = -397064800,
val = {int_val = -397081856, double_val = 1.1863557979041877e-312,
time_val = 240121086720, string_val = 0x37e8550300
V\020\062\350\067, str_val = {s = 0x37e8550300 V\020\062\350\067, len =
-400077266}, blob_val = {s = 0x37e8550300 V\020\062\350\067, len =
-400077266},
bitmap_val = 3897885440}}, {type = DB_STR, nul = 0, free = 8, val
= {int_val = 0, double_val = 0, time_val = 0, string_val = 0x0, str_val = {s =
0x0, len = 123765312}, blob_val = {s = 0x0, len = 123765312},
bitmap_val = 0}}, {type = DB_STR, nul = 55, free = -1642617560,
val = {int_val = 1, double_val = 4.9406564584124654e-324, time_val = 1,
string_val = 0x1 Address 0x1 out of bounds, str_val = {
s = 0x1 Address 0x1 out of bounds, len = -399980033},
blob_val = {s = 0x1 Address 0x1 out of bounds, len = -399980033}, bitmap_val
= 1}}, {type = DB_STR, nul = 32767, free = -397067808, val = {int_val =
7518184,
double_val = 3.7144764335133263e-317, time_val = 7518184,
string_val = 0x72b7e8 x\264'\241\307*, str_val = {s = 0x72b7e8
x\264'\241\307*, len = 600}, blob_val = {s = 0x72b7e8 x\264'\241\307*, len
= 600},
bitmap_val = 7518184}}, {type = DB_STR, nul = 55, free =
836357232, val = {int_val = 608, double_val = 2.7808754840900286e-310, time_val
= 56285546414688,
string_val = 0x33310260 Address 0x33310260 out of
bounds, str_val = {s = 0x33310260 Address 0x33310260 out of bounds,
len = 124141312}, blob_val = {
s = 0x33310260 Address 0x33310260 out of bounds, len
= 124141312}, bitmap_val = 608}}, {type = DB_STR, nul = 0, free = 130, val =
{int_val = 8208, double_val = 4.0552908210649516e-320, time_val = 8208,
string_val = 0x2010 Address 0x2010 out of bounds, str_val = {s
= 0x2010 Address 0x2010 out of bounds, len = 124133104}, blob_val = {s =
0x2010 Address 0x2010 out of bounds, len = 124133104}, bitmap_val = 8208}}, {
type = DB_INT, nul = 0, free = -400079495, val = {int_val
[OpenSIPS-Devel] [ opensips-Bugs-3411483 ] backport of more missing free_to_params
Bugs item #3411483, was opened at 2011-09-19 15:45 Message generated for change (Tracker Item Submitted) made by wdoekes You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3411483group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.6.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Walter Doekes (wdoekes) Assigned to: Nobody/Anonymous (nobody) Summary: backport of more missing free_to_params Initial Comment: Hi, in this report I mention that a couple of times free_to_params is not called: https://sourceforge.net/tracker/?func=detailaid=3411434group_id=232389atid=1086410 After backporting those changes to 1.6, there are a couple of changes that had already been done, but haven't been backported. Attached, a patch that fixes a couple of those. (I skipped fixing these modules, because I don't use them: rls, pua_xmpp, b2b_entities, msilo. They could use some fixing as well.) Regards, Walter Doekes OSSO B.V. Some issues had already been fixed in trunk. Attached is an additional patch against the 1.6 branch of the items that -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3411483group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-3411509 ] Check for stale nonce in pre_auth
Patches item #3411509, was opened at 2011-09-19 19:12 Message generated for change (Tracker Item Submitted) made by peter_lemenkov You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3411509group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Open Resolution: None Priority: 5 Private: No Submitted By: Peter Lemenkov (peter_lemenkov) Assigned to: Nobody/Anonymous (nobody) Summary: Check for stale nonce in pre_auth Initial Comment: Check for stale nonce in pre_auth, before actual auth request. It decreases dramatically the number of requests to the actual auth backend thus improving performance greatly. Take a look at the following plot where the results of this patch can be seen clearly: http://twitpic.com/3k66ri The similar approach was implemented already in Kamailio. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3411509group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-3411513 ] Consistently use rtpproxy switches
Patches item #3411513, was opened at 2011-09-19 19:17 Message generated for change (Tracker Item Submitted) made by peter_lemenkov You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3411513group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Peter Lemenkov (peter_lemenkov) Assigned to: Nobody/Anonymous (nobody) Summary: Consistently use rtpproxy switches Initial Comment: The flag for marking party as being behind the symmetric proxy is 'S', not 'W' as it was implemented in nathelper. Moreover 'W' has also different meaning in rtpproxy protocol syntax. Unfortunately this is obviously an incompatible change, however I think that elimination one source of confusing worth applying this, -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3411513group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-3411514 ] Permit unknown modifiers in nathelper's module
Patches item #3411514, was opened at 2011-09-19 19:19 Message generated for change (Tracker Item Submitted) made by peter_lemenkov You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3411514group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Peter Lemenkov (peter_lemenkov) Assigned to: Nobody/Anonymous (nobody) Summary: Permit unknown modifiers in nathelper's module Initial Comment: Sometimes we need to pass some extra modifiers not recognized and thus not supported by nathelper's module yet. This patch allows it. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3411514group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] New CDRTool release 8.2.0
There is a new release of CDRTool application with bug fixes and improvements. cdrtool (8.2.0) unstable; urgency=low [ Rating Engine ] * Fixed selecting calls with no price * Fixed normalizing the flow column * Added destinations.region field to documentation * Removed define_syslog_variables() for php 5.3 [ Web Interface ] * Added search and group by call flow * Fixed search and group by an empty field * Fixed searching for an empty billing party * Fixed fieldname time_stamp for text export SIP trace on MSP * Hide media graph if there are no streams * Added search option for calls with no media For how to upgrade your installation see: http://cdrtool.ag-projects.com/wiki/Install Regards, Adrian ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
