Re: [OpenSIPS-Devel] [OpenSIPS-Users] [Release] Planing 1.8.1 minor release
Hello All! 2012/8/13 Bogdan-Andrei Iancu bog...@opensips.org: Hello all, We plan to have 1.8.1 minor version released by Wednesday 15th of August. Once again, a minor release includes only bug fixes (on the 1.8 major branch). Great news! Speaking of me - so far I've got only three patches in a queue which could be interested for you. Two of them are just cherry-picked from trunk (so I'm not sure whether this should bother you or not). The remaining one is rather big one - a completely rewritten Oracle DB module, which is still in a w.i.p. stage and still not ready for a merge. Just for the record - currently available db_oracle module works fine now (all our critical patches were already merged - thanks for that!) so this one isn't required for normal operation. We plan to split it into smaller patches and improve it a bit - it contains some hardcoded magic and several questionable changes thus it's not ready for mass usage. First two patches (simply backported from trunk so technically OpenSIPS already has them): * https://github.com/lemenkov/OpenSIPS/commit/0c03a3e * https://github.com/lemenkov/OpenSIPS/commit/a8aebfb Oracle-related one (not ready yet - just for the reference) * https://github.com/lemenkov/OpenSIPS/commit/56b1863 And a complete tree (with unrelated stuff): * https://github.com/lemenkov/OpenSIPS/commits/1.8.x-ipport PS I still hope that you will consider switching OpenSIPS to Git someday. -- With best regards, Peter Lemenkov. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3557213 ] Stuck Transactions/Memory Leak with B2B top hiding
Bugs item #3557213, was opened at 2012-08-13 22:38 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557213group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: None Priority: 8 Private: No Submitted By: Ryan Bullock (rrb3942) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: Stuck Transactions/Memory Leak with B2B top hiding Initial Comment: I am experiencing a memory leak when using the B2B modules with the internal top hiding scenario. It appears to be related to struck/un-freed transactions, as the opensips mi will report many thousands of inuse_transactions when the reality is only a handful. An example is we currently show 15000+ inuse_transactions while only a handful of calls are actually in progress. These transactions appear to build up over time. Opensips information: version: opensips 1.8.0-notls (x86_64/linux) flags: STATS: Off, USE_IPV6, USE_TCP, DISABLE_NAGLE, USE_MCAST, SHM_MEM, SHM_MMAP, PKG_MALLOC, DBG_QM_MALLOC, FAST_LOCK-ADAPTIVE_WAIT ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535 poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. svnrevision: 2:9164M @(#) $Id: main.c 8772 2012-03-08 11:16:13Z bogdan_iancu $ main.c compiled on 12:24:36 Aug 3 2012 with gcc 4.4.6 I currently have the memdump option enabled and am waiting for another buildup of transactions to gather the memdump information. I can supply access to the dump and the opensips configuration file via email. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-08-14 02:03 Message: Ryan, I will try to see if I can reproduce this. You can simple topo hiding scenario, with successful calls, nothing special, right ? Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557213group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-3530859 ] Handle case where reply after engage_mediaproxy has no body
Patches item #3530859, was opened at 2012-05-30 09:24 Message generated for change (Comment added) made by saghul You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3530859group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Closed Resolution: Wont Fix Priority: 5 Private: No Submitted By: Dynamic Packet (dpacket) Assigned to: saghul (saghul) Summary: Handle case where reply after engage_mediaproxy has no body Initial Comment: Currently if you remove the body via strip_body() of an in-dialog reply which is using engage_mediaproxy() you end up with junk in the body. IT seems the reply is still processed and the lump with the ip and port of the mediaproxy is appended as junk. This patch skips processing the reply if there is no body or it has been removed. Let me know your thoughts Saul and others so we can get this applied to trunk and possibly 1.8.x or even older branches. -- Comment By: saghul (saghul) Date: 2012-08-14 02:09 Message: Doesn't work in all cases. Proposed more generic solution: http://lists.opensips.org/pipermail/users/2012-August/022495.html -- Comment By: Dynamic Packet (dpacket) Date: 2012-05-30 11:20 Message: Attached new patch to check for body being deleted inside get_sdp_message() . -- Comment By: saghul (saghul) Date: 2012-05-30 10:14 Message: As discussed on IRC, the proper fix for this would be as follows: Modify the get_sdp_message function (in the mediaproxy module) so that it returns false also when the body was removed with a lump. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3530859group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3557317 ] do_routing crashes in Check Only mode
Bugs item #3557317, was opened at 2012-08-14 03:23
Message generated for change (Tracker Item Submitted) made by parantido
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557317group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.8.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Parantido Julius De Rica (parantido)
Assigned to: Nobody/Anonymous (nobody)
Summary: do_routing crashes in Check Only mode
Initial Comment:
Hi,
do_routing function (from drouting modules) crash when C and F flags used:
if(do_routing(, CF)) {
route(1);
}
The statement above is able to crash my opensips (SIGSEGV 11) every time being
executed.
I'm able to reproduce crash with latest (opensips-1.8.0_src.tar.gz) and trunk
release.
Attached to this bug report you'll find gdb bt-full output.
Regards
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557317group_id=232389
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3557044 ] dispatcher: unable to set setid_pvar
Bugs item #3557044, was opened at 2012-08-13 15:39 Message generated for change (Settings changed) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557044group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Open Resolution: Accepted Priority: 5 Private: No Submitted By: Ovidiu Sas (osas) Assigned to: Liviu Chircu (liviuchircu) Summary: dispatcher: unable to set setid_pvar Initial Comment: While setting the setid_pvar pvar, opensips is failing to start: ... modparam(dispatcher, setid_pvar, $var(setid)) ... Aug 13 18:32:21 deb o[30828]: ERROR:core:pv_parse_spec: pvar not found Aug 13 18:32:21 deb o[30828]: ERROR:core:pv_parse_spec: wrong char [$/36] in [$] at [0 (0)] Aug 13 18:32:21 deb o[30828]: ERROR:dispatcher:mod_init: [$var(setid)]- invalid setid_pvname Aug 13 18:32:21 deb o[30828]: ERROR:core:init_mod: failed to initialize module dispatcher -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557044group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9202] trunk/modules/dispatcher/dispatcher.c
Revision: 9202 http://opensips.svn.sourceforge.net/opensips/?rev=9202view=rev Author: liviuchircu Date: 2012-08-14 10:43:15 + (Tue, 14 Aug 2012) Log Message: --- Fixed setid_pvar parsing. Modified Paths: -- trunk/modules/dispatcher/dispatcher.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9203] branches/1.8/modules/dispatcher/dispatcher.c
Revision: 9203 http://opensips.svn.sourceforge.net/opensips/?rev=9203view=rev Author: liviuchircu Date: 2012-08-14 10:47:59 + (Tue, 14 Aug 2012) Log Message: --- Backport from trunk (rev #9202). Fixed setid_pvar parsing. Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=9202view=rev Modified Paths: -- branches/1.8/modules/dispatcher/dispatcher.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3557044 ] dispatcher: unable to set setid_pvar
Bugs item #3557044, was opened at 2012-08-13 15:39 Message generated for change (Comment added) made by liviuchircu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557044group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Ovidiu Sas (osas) Assigned to: Liviu Chircu (liviuchircu) Summary: dispatcher: unable to set setid_pvar Initial Comment: While setting the setid_pvar pvar, opensips is failing to start: ... modparam(dispatcher, setid_pvar, $var(setid)) ... Aug 13 18:32:21 deb o[30828]: ERROR:core:pv_parse_spec: pvar not found Aug 13 18:32:21 deb o[30828]: ERROR:core:pv_parse_spec: wrong char [$/36] in [$] at [0 (0)] Aug 13 18:32:21 deb o[30828]: ERROR:dispatcher:mod_init: [$var(setid)]- invalid setid_pvname Aug 13 18:32:21 deb o[30828]: ERROR:core:init_mod: failed to initialize module dispatcher -- Comment By: Liviu Chircu (liviuchircu) Date: 2012-08-14 03:49 Message: Hello, I've commited a fix for this in the svn trunk and 1.8 branch. Regards, Liviu -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557044group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [OpenSIPS-Users] [Release] Planing 1.8.1 minor release
Hi Peter, Vlad will take care and do the backport for the 2 patched - thanks for pointing this out. Regarding GIT, I have also Saul pushing into this :D Regards, Bogdan-Andrei Iancu OpenSIPS Founder and Developer http://www.opensips-solutions.com On 08/14/2012 11:08 AM, Peter Lemenkov wrote: Hello All! 2012/8/13 Bogdan-Andrei Iancubog...@opensips.org: Hello all, We plan to have 1.8.1 minor version released by Wednesday 15th of August. Once again, a minor release includes only bug fixes (on the 1.8 major branch). Great news! Speaking of me - so far I've got only three patches in a queue which could be interested for you. Two of them are just cherry-picked from trunk (so I'm not sure whether this should bother you or not). The remaining one is rather big one - a completely rewritten Oracle DB module, which is still in a w.i.p. stage and still not ready for a merge. Just for the record - currently available db_oracle module works fine now (all our critical patches were already merged - thanks for that!) so this one isn't required for normal operation. We plan to split it into smaller patches and improve it a bit - it contains some hardcoded magic and several questionable changes thus it's not ready for mass usage. First two patches (simply backported from trunk so technically OpenSIPS already has them): * https://github.com/lemenkov/OpenSIPS/commit/0c03a3e * https://github.com/lemenkov/OpenSIPS/commit/a8aebfb Oracle-related one (not ready yet - just for the reference) * https://github.com/lemenkov/OpenSIPS/commit/56b1863 And a complete tree (with unrelated stuff): * https://github.com/lemenkov/OpenSIPS/commits/1.8.x-ipport PS I still hope that you will consider switching OpenSIPS to Git someday. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9204] trunk/modules/drouting/drouting.c
Revision: 9204 http://opensips.svn.sourceforge.net/opensips/?rev=9204view=rev Author: bogdan_iancu Date: 2012-08-14 13:16:32 + (Tue, 14 Aug 2012) Log Message: --- fixed crash on using both C and F flags in do_routing. Reported by Parantido Julius De Rica Closes bug report #3557317 Modified Paths: -- trunk/modules/drouting/drouting.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3557317 ] do_routing crashes in Check Only mode
Bugs item #3557317, was opened at 2012-08-14 03:23
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557317group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.8.x
Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Parantido Julius De Rica (parantido)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: do_routing crashes in Check Only mode
Initial Comment:
Hi,
do_routing function (from drouting modules) crash when C and F flags used:
if(do_routing(, CF)) {
route(1);
}
The statement above is able to crash my opensips (SIGSEGV 11) every time being
executed.
I'm able to reproduce crash with latest (opensips-1.8.0_src.tar.gz) and trunk
release.
Attached to this bug report you'll find gdb bt-full output.
Regards
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-08-14 06:18
Message:
Hi Parantido,
Thanks for the report - I fixed the problem, both trunk and 1.8 were
updated.
Regards,
Bogdan
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557317group_id=232389
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3557213 ] Stuck Transactions/Memory Leak with B2B top hiding
Bugs item #3557213, was opened at 2012-08-13 22:38 Message generated for change (Comment added) made by vladut-paiu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557213group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: None Priority: 8 Private: No Submitted By: Ryan Bullock (rrb3942) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: Stuck Transactions/Memory Leak with B2B top hiding Initial Comment: I am experiencing a memory leak when using the B2B modules with the internal top hiding scenario. It appears to be related to struck/un-freed transactions, as the opensips mi will report many thousands of inuse_transactions when the reality is only a handful. An example is we currently show 15000+ inuse_transactions while only a handful of calls are actually in progress. These transactions appear to build up over time. Opensips information: version: opensips 1.8.0-notls (x86_64/linux) flags: STATS: Off, USE_IPV6, USE_TCP, DISABLE_NAGLE, USE_MCAST, SHM_MEM, SHM_MMAP, PKG_MALLOC, DBG_QM_MALLOC, FAST_LOCK-ADAPTIVE_WAIT ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535 poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. svnrevision: 2:9164M @(#) $Id: main.c 8772 2012-03-08 11:16:13Z bogdan_iancu $ main.c compiled on 12:24:36 Aug 3 2012 with gcc 4.4.6 I currently have the memdump option enabled and am waiting for another buildup of transactions to gather the memdump information. I can supply access to the dump and the opensips configuration file via email. -- Comment By: Vladut-Stefan Paiu (vladut-paiu) Date: 2012-08-14 07:47 Message: Hello Ryan, I cannot seem to reproduce your topology hiding bug. Can you privately send me your OpenSIPS configuration file, via email ? Also, access to the memory dump would be useful. Regards, Vlad -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-08-14 02:03 Message: Ryan, I will try to see if I can reproduce this. You can simple topo hiding scenario, with successful calls, nothing special, right ? Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557213group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3557213 ] Stuck Transactions/Memory Leak with B2B top hiding
Bugs item #3557213, was opened at 2012-08-13 22:38 Message generated for change (Comment added) made by nikbyte You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557213group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: None Priority: 8 Private: No Submitted By: Ryan Bullock (rrb3942) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: Stuck Transactions/Memory Leak with B2B top hiding Initial Comment: I am experiencing a memory leak when using the B2B modules with the internal top hiding scenario. It appears to be related to struck/un-freed transactions, as the opensips mi will report many thousands of inuse_transactions when the reality is only a handful. An example is we currently show 15000+ inuse_transactions while only a handful of calls are actually in progress. These transactions appear to build up over time. Opensips information: version: opensips 1.8.0-notls (x86_64/linux) flags: STATS: Off, USE_IPV6, USE_TCP, DISABLE_NAGLE, USE_MCAST, SHM_MEM, SHM_MMAP, PKG_MALLOC, DBG_QM_MALLOC, FAST_LOCK-ADAPTIVE_WAIT ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535 poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. svnrevision: 2:9164M @(#) $Id: main.c 8772 2012-03-08 11:16:13Z bogdan_iancu $ main.c compiled on 12:24:36 Aug 3 2012 with gcc 4.4.6 I currently have the memdump option enabled and am waiting for another buildup of transactions to gather the memdump information. I can supply access to the dump and the opensips configuration file via email. -- Comment By: Nick Altmann (nikbyte) Date: 2012-08-14 08:18 Message: Cannot attach file. Look it here: http://img39.imageshack.us/img39/5275/memorys.png Also just simple topo hiding, nothing special. -- Comment By: Nick Altmann (nikbyte) Date: 2012-08-14 08:13 Message: Vlad, I also expect problems with memory. Look at screenshot. I cannot collect statistics now, but memory leak is there. Every day I restart opensips to free memory. -- Comment By: Vladut-Stefan Paiu (vladut-paiu) Date: 2012-08-14 07:47 Message: Hello Ryan, I cannot seem to reproduce your topology hiding bug. Can you privately send me your OpenSIPS configuration file, via email ? Also, access to the memory dump would be useful. Regards, Vlad -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-08-14 02:03 Message: Ryan, I will try to see if I can reproduce this. You can simple topo hiding scenario, with successful calls, nothing special, right ? Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557213group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3556910 ] B2B and preloaded routes. Again.
Bugs item #3556910, was opened at 2012-08-13 04:06
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3556910group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.8.x
Status: Open
Resolution: Invalid
Priority: 5
Private: No
Submitted By: Nick Altmann (nikbyte)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: B2B and preloaded routes. Again.
Initial Comment:
Requests with preloaded routes like this (one or two per request):
Route: sip:my_domain.com:5060;lr
b2b doesn't accept as b2b session.
Previously we hack it to accept preloaded routes with self ip, but what to do
with self domain? Any hacks?
The code, responsible for detection:
if(msg-route)
{
LM_DBG(Found route headers\n);
route_hdr = msg-route;
/* we accept Route hdrs only if preloaded route with out IPs */
if (parse_rr(route_hdr) 0) {
LM_ERR(failed to parse Route HF\n);
return -1;
}
rt = (rr_t*)route_hdr-parsed;
/* check if first route is local*/
if (
parse_uri(rt-nameaddr.uri.s,rt-nameaddr.uri.len,puri)!=0 ) {
LM_ERR(Route uri is not valid %.*s\n,
rt-nameaddr.uri.len,rt-nameaddr.uri.s);
return -1;
}
if (check_self( puri.host, puri.port_no?puri.port_no:SIP_PORT,
puri.proto?puri.proto:PROTO_UDP)!= 1 ) {
LM_DBG(First Route uri is not mine\n);
return 1; /* not for b2b */
}
/* check if second route is local*/
rt = rt-next;
if (rt==NULL) {
if (msg-route-sibling) {
route_hdr = msg-route-sibling;
if (parse_rr(route_hdr) 0) {
LM_ERR(failed to parse second Route
HF\n);
return -1;
}
rt = (rr_t*)route_hdr-parsed;
}
}
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-08-14 08:49
Message:
Hi Nick,
have you either added my_domain.com as alias , either placed it into
domain module ?
The check_self() looks into both aliases and domain module.
Regards,
Bogdan
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3556910group_id=232389
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3556910 ] B2B and preloaded routes. Again.
Bugs item #3556910, was opened at 2012-08-13 04:06
Message generated for change (Comment added) made by nikbyte
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3556910group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.8.x
Status: Open
Resolution: Invalid
Priority: 5
Private: No
Submitted By: Nick Altmann (nikbyte)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: B2B and preloaded routes. Again.
Initial Comment:
Requests with preloaded routes like this (one or two per request):
Route: sip:my_domain.com:5060;lr
b2b doesn't accept as b2b session.
Previously we hack it to accept preloaded routes with self ip, but what to do
with self domain? Any hacks?
The code, responsible for detection:
if(msg-route)
{
LM_DBG(Found route headers\n);
route_hdr = msg-route;
/* we accept Route hdrs only if preloaded route with out IPs */
if (parse_rr(route_hdr) 0) {
LM_ERR(failed to parse Route HF\n);
return -1;
}
rt = (rr_t*)route_hdr-parsed;
/* check if first route is local*/
if (
parse_uri(rt-nameaddr.uri.s,rt-nameaddr.uri.len,puri)!=0 ) {
LM_ERR(Route uri is not valid %.*s\n,
rt-nameaddr.uri.len,rt-nameaddr.uri.s);
return -1;
}
if (check_self( puri.host, puri.port_no?puri.port_no:SIP_PORT,
puri.proto?puri.proto:PROTO_UDP)!= 1 ) {
LM_DBG(First Route uri is not mine\n);
return 1; /* not for b2b */
}
/* check if second route is local*/
rt = rt-next;
if (rt==NULL) {
if (msg-route-sibling) {
route_hdr = msg-route-sibling;
if (parse_rr(route_hdr) 0) {
LM_ERR(failed to parse second Route
HF\n);
return -1;
}
rt = (rr_t*)route_hdr-parsed;
}
}
--
Comment By: Nick Altmann (nikbyte)
Date: 2012-08-14 08:51
Message:
Thank you. I'll try to enable domain module and write here later.
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-08-14 08:49
Message:
Hi Nick,
have you either added my_domain.com as alias , either placed it into
domain module ?
The check_self() looks into both aliases and domain module.
Regards,
Bogdan
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3556910group_id=232389
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3554323 ] Duration populated with created time on call timeout
Bugs item #3554323, was opened at 2012-08-04 10:22
Message generated for change (Comment added) made by rrb3942
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3554323group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.8.x
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Ryan Bullock (rrb3942)
Assigned to: Vladut-Stefan Paiu (vladut-paiu)
Summary: Duration populated with created time on call timeout
Initial Comment:
When doing CDR accounting to a Mysql database, when a call is terminated due to
a failed dialog options ping (receives response of 481) the database duration
field is populated with the unix timestamp of the dialog created time. The
'created' and 'setuptime' fields do not appear to get populated as well.
This does not appear to happen when CDR accounting to syslog, as the same
records accounted to syslog have the correct duration, created, and setuptime.
Opensips information:
version: opensips 1.8.0-notls (x86_64/linux)
flags: STATS: Off, USE_IPV6, USE_TCP, DISABLE_NAGLE, USE_MCAST, SHM_MEM,
SHM_MMAP, PKG_MALLOC, DBG_QM_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16,
MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
svnrevision: 2:9164M
@(#) $Id: main.c 8772 2012-03-08 11:16:13Z bogdan_iancu $
main.c compiled on 12:53:09 Aug 3 2012 with gcc 4.4.6
I do have extra, and extra_bye variables which are the same for the database
and syslog.
Thanks.
--
Comment By: Ryan Bullock (rrb3942)
Date: 2012-08-14 09:16
Message:
Isolated just the fixes for this bug and tested them. Works great, all the
fields are correctly populated in the database.
No signs of the getting created issue, so that appears to be separate. I
will see if I can reproduce that in a simpler configuration.
The fix for the initial bug in this report looks good to me, this can be
closed.
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-08-14 03:20
Message:
Ryan,
Please open a separate report for the new issue. Also test and confirm the
fix for original report (with acc data).
Best regards,
--
Comment By: Ryan Bullock (rrb3942)
Date: 2012-08-13 11:05
Message:
Looking through my logs a big closer for the period I also found:
ERROR:dialog:dlg_validate_dialog: Script error - validate function before
having a dialog
ERROR:dialog:fix_route_dialog: Script error - validate function before
having a dialog
Which is odd, because my calls to validate_dialog() and fix_route_dialog()
are wrapped as follows:
route[dialog_fixup] {
if ($DLG_status==NULL !match_dialog()) {
return(-1);
} else {
if (!validate_dialog()) {
fix_route_dialog();
}
}
return(1);
}
Which means it should be impossible to call them even if the dialog does
not exists somehow.
So yeah, looks like I stumbled upon something else on accident their as
well. Should I open a separate bug for this? Right now I am not sure what
is causing it, only that it does not appear to happen under 9164.
I will try making a separate patch for the accounting changes and applying
that to my current copy of opensips build and seeing how that goes.
--
Comment By: Vladut-Stefan Paiu (vladut-paiu)
Date: 2012-08-13 01:58
Message:
Hello,
In 9164, segfaults were possible since indeed some invalid pointers might
have been passed to the mysql query.
I tried to test your issue in 9198 and I can't seem to replicate it. The
issue you are describing seems to be related to the dialog module, since it
does not find the creation time in the dialog variables. So it doesn't seem
at all related to the previous fix.
Can you please attach a full OpenSIPS debug for such a call, as well as the
acc dialog parameters you are using in your script ?
Regards,
Vlad
--
Comment By: Ryan Bullock (rrb3942)
Date: 2012-08-12 20:12
Message:
Hello Vlad,
Tried svn revision 9198 for the 1.8 trunk and started getting this message
in my logs:
ERROR:acc:acc_get_created: error getting dialog creation time
ERROR:acc:acc_log_cdrs: cannot get created
ERROR:acc:acc_dlg_callback: Cannot log values
We account to both logs and db, and this revision seems to cause a problem
with getting the creation time. Wasn't sure what was causing this, so I
reverted back to revision 9164.
Another issue related to this on revision 9164 is a segfault. Not sure
[OpenSIPS-Devel] [ opensips-Bugs-3557213 ] Stuck Transactions/Memory Leak with B2B top hiding
Bugs item #3557213, was opened at 2012-08-13 22:38 Message generated for change (Comment added) made by rrb3942 You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557213group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: None Priority: 8 Private: No Submitted By: Ryan Bullock (rrb3942) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: Stuck Transactions/Memory Leak with B2B top hiding Initial Comment: I am experiencing a memory leak when using the B2B modules with the internal top hiding scenario. It appears to be related to struck/un-freed transactions, as the opensips mi will report many thousands of inuse_transactions when the reality is only a handful. An example is we currently show 15000+ inuse_transactions while only a handful of calls are actually in progress. These transactions appear to build up over time. Opensips information: version: opensips 1.8.0-notls (x86_64/linux) flags: STATS: Off, USE_IPV6, USE_TCP, DISABLE_NAGLE, USE_MCAST, SHM_MEM, SHM_MMAP, PKG_MALLOC, DBG_QM_MALLOC, FAST_LOCK-ADAPTIVE_WAIT ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535 poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. svnrevision: 2:9164M @(#) $Id: main.c 8772 2012-03-08 11:16:13Z bogdan_iancu $ main.c compiled on 12:24:36 Aug 3 2012 with gcc 4.4.6 I currently have the memdump option enabled and am waiting for another buildup of transactions to gather the memdump information. I can supply access to the dump and the opensips configuration file via email. -- Comment By: Ryan Bullock (rrb3942) Date: 2012-08-14 09:42 Message: Only differences I can think of: We use the 'b2bl_from_spec_param'. We are storing the b2b states in a database. We do modify some headers in the local_route. We do sequential routing through the b2b, as in we have a proxy that hunts and sends its requests through the b2b2. I will send you the configuration shortly, it is pretty straight forward. I will not have the memdump until tonight, when I can force the dump out. Once I have it I will post it someplace where I can get you access and send that via email. Is their anything else I can get that would help with troubleshooting this? -- Comment By: Nick Altmann (nikbyte) Date: 2012-08-14 08:18 Message: Cannot attach file. Look it here: http://img39.imageshack.us/img39/5275/memorys.png Also just simple topo hiding, nothing special. -- Comment By: Nick Altmann (nikbyte) Date: 2012-08-14 08:13 Message: Vlad, I also expect problems with memory. Look at screenshot. I cannot collect statistics now, but memory leak is there. Every day I restart opensips to free memory. -- Comment By: Vladut-Stefan Paiu (vladut-paiu) Date: 2012-08-14 07:47 Message: Hello Ryan, I cannot seem to reproduce your topology hiding bug. Can you privately send me your OpenSIPS configuration file, via email ? Also, access to the memory dump would be useful. Regards, Vlad -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-08-14 02:03 Message: Ryan, I will try to see if I can reproduce this. You can simple topo hiding scenario, with successful calls, nothing special, right ? Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557213group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3554323 ] Duration populated with created time on call timeout
Bugs item #3554323, was opened at 2012-08-04 10:22
Message generated for change (Settings changed) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3554323group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.8.x
Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Ryan Bullock (rrb3942)
Assigned to: Vladut-Stefan Paiu (vladut-paiu)
Summary: Duration populated with created time on call timeout
Initial Comment:
When doing CDR accounting to a Mysql database, when a call is terminated due to
a failed dialog options ping (receives response of 481) the database duration
field is populated with the unix timestamp of the dialog created time. The
'created' and 'setuptime' fields do not appear to get populated as well.
This does not appear to happen when CDR accounting to syslog, as the same
records accounted to syslog have the correct duration, created, and setuptime.
Opensips information:
version: opensips 1.8.0-notls (x86_64/linux)
flags: STATS: Off, USE_IPV6, USE_TCP, DISABLE_NAGLE, USE_MCAST, SHM_MEM,
SHM_MMAP, PKG_MALLOC, DBG_QM_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16,
MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
svnrevision: 2:9164M
@(#) $Id: main.c 8772 2012-03-08 11:16:13Z bogdan_iancu $
main.c compiled on 12:53:09 Aug 3 2012 with gcc 4.4.6
I do have extra, and extra_bye variables which are the same for the database
and syslog.
Thanks.
--
Comment By: Ryan Bullock (rrb3942)
Date: 2012-08-14 09:16
Message:
Isolated just the fixes for this bug and tested them. Works great, all the
fields are correctly populated in the database.
No signs of the getting created issue, so that appears to be separate. I
will see if I can reproduce that in a simpler configuration.
The fix for the initial bug in this report looks good to me, this can be
closed.
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-08-14 03:20
Message:
Ryan,
Please open a separate report for the new issue. Also test and confirm the
fix for original report (with acc data).
Best regards,
--
Comment By: Ryan Bullock (rrb3942)
Date: 2012-08-13 11:05
Message:
Looking through my logs a big closer for the period I also found:
ERROR:dialog:dlg_validate_dialog: Script error - validate function before
having a dialog
ERROR:dialog:fix_route_dialog: Script error - validate function before
having a dialog
Which is odd, because my calls to validate_dialog() and fix_route_dialog()
are wrapped as follows:
route[dialog_fixup] {
if ($DLG_status==NULL !match_dialog()) {
return(-1);
} else {
if (!validate_dialog()) {
fix_route_dialog();
}
}
return(1);
}
Which means it should be impossible to call them even if the dialog does
not exists somehow.
So yeah, looks like I stumbled upon something else on accident their as
well. Should I open a separate bug for this? Right now I am not sure what
is causing it, only that it does not appear to happen under 9164.
I will try making a separate patch for the accounting changes and applying
that to my current copy of opensips build and seeing how that goes.
--
Comment By: Vladut-Stefan Paiu (vladut-paiu)
Date: 2012-08-13 01:58
Message:
Hello,
In 9164, segfaults were possible since indeed some invalid pointers might
have been passed to the mysql query.
I tried to test your issue in 9198 and I can't seem to replicate it. The
issue you are describing seems to be related to the dialog module, since it
does not find the creation time in the dialog variables. So it doesn't seem
at all related to the previous fix.
Can you please attach a full OpenSIPS debug for such a call, as well as the
acc dialog parameters you are using in your script ?
Regards,
Vlad
--
Comment By: Ryan Bullock (rrb3942)
Date: 2012-08-12 20:12
Message:
Hello Vlad,
Tried svn revision 9198 for the 1.8 trunk and started getting this message
in my logs:
ERROR:acc:acc_get_created: error getting dialog creation time
ERROR:acc:acc_log_cdrs: cannot get created
ERROR:acc:acc_dlg_callback: Cannot log values
We account to both logs and db, and this revision seems to cause a problem
with getting the creation time. Wasn't sure what was causing this, so I
reverted back to revision 9164.
Another issue related to this on revision 9164 is a segfault.
[OpenSIPS-Devel] [ opensips-Bugs-3557213 ] Stuck Transactions/Memory Leak with B2B top hiding
Bugs item #3557213, was opened at 2012-08-13 22:38 Message generated for change (Comment added) made by nikbyte You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557213group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: None Priority: 8 Private: No Submitted By: Ryan Bullock (rrb3942) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: Stuck Transactions/Memory Leak with B2B top hiding Initial Comment: I am experiencing a memory leak when using the B2B modules with the internal top hiding scenario. It appears to be related to struck/un-freed transactions, as the opensips mi will report many thousands of inuse_transactions when the reality is only a handful. An example is we currently show 15000+ inuse_transactions while only a handful of calls are actually in progress. These transactions appear to build up over time. Opensips information: version: opensips 1.8.0-notls (x86_64/linux) flags: STATS: Off, USE_IPV6, USE_TCP, DISABLE_NAGLE, USE_MCAST, SHM_MEM, SHM_MMAP, PKG_MALLOC, DBG_QM_MALLOC, FAST_LOCK-ADAPTIVE_WAIT ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535 poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. svnrevision: 2:9164M @(#) $Id: main.c 8772 2012-03-08 11:16:13Z bogdan_iancu $ main.c compiled on 12:24:36 Aug 3 2012 with gcc 4.4.6 I currently have the memdump option enabled and am waiting for another buildup of transactions to gather the memdump information. I can supply access to the dump and the opensips configuration file via email. -- Comment By: Nick Altmann (nikbyte) Date: 2012-08-14 09:56 Message: We use the 'b2bl_from_spec_param'. I use it too. We are storing the b2b states in a database. I store it in pgsql too. We do modify some headers in the local_route. I also modify headers in local_route We do sequential routing through the b2b, as in we have a proxy that hunts and sends its requests through the b2b2. I'm too. -- Comment By: Ryan Bullock (rrb3942) Date: 2012-08-14 09:42 Message: Only differences I can think of: We use the 'b2bl_from_spec_param'. We are storing the b2b states in a database. We do modify some headers in the local_route. We do sequential routing through the b2b, as in we have a proxy that hunts and sends its requests through the b2b2. I will send you the configuration shortly, it is pretty straight forward. I will not have the memdump until tonight, when I can force the dump out. Once I have it I will post it someplace where I can get you access and send that via email. Is their anything else I can get that would help with troubleshooting this? -- Comment By: Nick Altmann (nikbyte) Date: 2012-08-14 08:18 Message: Cannot attach file. Look it here: http://img39.imageshack.us/img39/5275/memorys.png Also just simple topo hiding, nothing special. -- Comment By: Nick Altmann (nikbyte) Date: 2012-08-14 08:13 Message: Vlad, I also expect problems with memory. Look at screenshot. I cannot collect statistics now, but memory leak is there. Every day I restart opensips to free memory. -- Comment By: Vladut-Stefan Paiu (vladut-paiu) Date: 2012-08-14 07:47 Message: Hello Ryan, I cannot seem to reproduce your topology hiding bug. Can you privately send me your OpenSIPS configuration file, via email ? Also, access to the memory dump would be useful. Regards, Vlad -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-08-14 02:03 Message: Ryan, I will try to see if I can reproduce this. You can simple topo hiding scenario, with successful calls, nothing special, right ? Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557213group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3557213 ] Stuck Transactions/Memory Leak with B2B top hiding
Bugs item #3557213, was opened at 2012-08-13 22:38 Message generated for change (Comment added) made by rrb3942 You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557213group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: None Priority: 8 Private: No Submitted By: Ryan Bullock (rrb3942) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: Stuck Transactions/Memory Leak with B2B top hiding Initial Comment: I am experiencing a memory leak when using the B2B modules with the internal top hiding scenario. It appears to be related to struck/un-freed transactions, as the opensips mi will report many thousands of inuse_transactions when the reality is only a handful. An example is we currently show 15000+ inuse_transactions while only a handful of calls are actually in progress. These transactions appear to build up over time. Opensips information: version: opensips 1.8.0-notls (x86_64/linux) flags: STATS: Off, USE_IPV6, USE_TCP, DISABLE_NAGLE, USE_MCAST, SHM_MEM, SHM_MMAP, PKG_MALLOC, DBG_QM_MALLOC, FAST_LOCK-ADAPTIVE_WAIT ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535 poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. svnrevision: 2:9164M @(#) $Id: main.c 8772 2012-03-08 11:16:13Z bogdan_iancu $ main.c compiled on 12:24:36 Aug 3 2012 with gcc 4.4.6 I currently have the memdump option enabled and am waiting for another buildup of transactions to gather the memdump information. I can supply access to the dump and the opensips configuration file via email. -- Comment By: Ryan Bullock (rrb3942) Date: 2012-08-14 21:44 Message: Config file was sent to both Vlad and Bogdan via email earlier today and I just sent login information to obtain the memdump as well. If you did not receive the emails please let me know and I can try re-sending. Thanks for the help. Regards, Ryan -- Comment By: Nick Altmann (nikbyte) Date: 2012-08-14 09:56 Message: We use the 'b2bl_from_spec_param'. I use it too. We are storing the b2b states in a database. I store it in pgsql too. We do modify some headers in the local_route. I also modify headers in local_route We do sequential routing through the b2b, as in we have a proxy that hunts and sends its requests through the b2b2. I'm too. -- Comment By: Ryan Bullock (rrb3942) Date: 2012-08-14 09:42 Message: Only differences I can think of: We use the 'b2bl_from_spec_param'. We are storing the b2b states in a database. We do modify some headers in the local_route. We do sequential routing through the b2b, as in we have a proxy that hunts and sends its requests through the b2b2. I will send you the configuration shortly, it is pretty straight forward. I will not have the memdump until tonight, when I can force the dump out. Once I have it I will post it someplace where I can get you access and send that via email. Is their anything else I can get that would help with troubleshooting this? -- Comment By: Nick Altmann (nikbyte) Date: 2012-08-14 08:18 Message: Cannot attach file. Look it here: http://img39.imageshack.us/img39/5275/memorys.png Also just simple topo hiding, nothing special. -- Comment By: Nick Altmann (nikbyte) Date: 2012-08-14 08:13 Message: Vlad, I also expect problems with memory. Look at screenshot. I cannot collect statistics now, but memory leak is there. Every day I restart opensips to free memory. -- Comment By: Vladut-Stefan Paiu (vladut-paiu) Date: 2012-08-14 07:47 Message: Hello Ryan, I cannot seem to reproduce your topology hiding bug. Can you privately send me your OpenSIPS configuration file, via email ? Also, access to the memory dump would be useful. Regards, Vlad -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-08-14 02:03 Message: Ryan, I will try to see if I can reproduce this. You can simple topo hiding scenario, with successful calls, nothing special, right ? Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557213group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
