[OpenSIPS-Devel] [ opensips-Bugs-3577353 ] startup_route not executed
Bugs item #3577353, was opened at 2012-10-15 08:46 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3577353group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: 1.8.x Status: Open Resolution: Accepted Priority: 5 Private: No Submitted By: Dragos Oancea (dragosoancea) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: startup_route not executed Initial Comment: Hi I can confirm the exact same confusing behavior described here: http://lists.opensips.org/pipermail/users/2012-June/022120.html Regards, Dragos -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-16 02:50 Message: Please test the attached fix. Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3577353group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3577353 ] startup_route not executed
Bugs item #3577353, was opened at 2012-10-15 08:46 Message generated for change (Comment added) made by dragosoancea You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3577353group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: 1.8.x Status: Open Resolution: Accepted Priority: 5 Private: No Submitted By: Dragos Oancea (dragosoancea) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: startup_route not executed Initial Comment: Hi I can confirm the exact same confusing behavior described here: http://lists.opensips.org/pipermail/users/2012-June/022120.html Regards, Dragos -- Comment By: Dragos Oancea (dragosoancea) Date: 2012-10-16 07:15 Message: Tested. Works as expected. Regards, Dragos -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-16 02:50 Message: Please test the attached fix. Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3577353group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9328] trunk/modules/dialog/dlg_vals.c
Revision: 9328 http://opensips.svn.sourceforge.net/opensips/?rev=9328view=rev Author: osas Date: 2012-10-16 16:02:56 + (Tue, 16 Oct 2012) Log Message: --- dialog: code cleanup (remove duplicate define for dlg_val_lock/dlg_val_unlock) - dlg_val_lock is actualy dlg_lock_dlg from dlg_hash.h - dlg_val_unlock is actualy dlg_unlock_dlg from dlg_hash.h Modified Paths: -- trunk/modules/dialog/dlg_vals.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9329] trunk
Revision: 9329 http://opensips.svn.sourceforge.net/opensips/?rev=9329view=rev Author: bogdan_iancu Date: 2012-10-16 17:23:32 + (Tue, 16 Oct 2012) Log Message: --- - fixed bug in waiting (by other opensips procs) for the startup route to be executed - fixed triggering of startup route if no UDP interface was configured Reported by Dragos Oancea Closes bug #3577353 Modified Paths: -- trunk/main.c trunk/tcp_init.h trunk/tcp_main.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9330] branches/1.8
Revision: 9330 http://opensips.svn.sourceforge.net/opensips/?rev=9330view=rev Author: bogdan_iancu Date: 2012-10-16 17:25:38 + (Tue, 16 Oct 2012) Log Message: --- backport from trunk (rev #9329): - fixed bug in waiting (by other opensips procs) for the startup route to be executed - fixed triggering of startup route if no UDP interface was configured Reported by Dragos Oancea Closes bug #3577353 Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=9329view=rev Modified Paths: -- branches/1.8/main.c branches/1.8/tcp_init.h branches/1.8/tcp_main.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3577353 ] startup_route not executed
Bugs item #3577353, was opened at 2012-10-15 08:46 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3577353group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: 1.8.x Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Dragos Oancea (dragosoancea) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: startup_route not executed Initial Comment: Hi I can confirm the exact same confusing behavior described here: http://lists.opensips.org/pipermail/users/2012-June/022120.html Regards, Dragos -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-16 10:26 Message: OK, fix uploaded on SVN trunk, 1.8 and 1.7 Regards, Bogdan -- Comment By: Dragos Oancea (dragosoancea) Date: 2012-10-16 07:15 Message: Tested. Works as expected. Regards, Dragos -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-16 02:50 Message: Please test the attached fix. Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3577353group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9331] branches/1.7
Revision: 9331 http://opensips.svn.sourceforge.net/opensips/?rev=9331view=rev Author: bogdan_iancu Date: 2012-10-16 17:26:53 + (Tue, 16 Oct 2012) Log Message: --- backport from trunk (rev #9329): - fixed bug in waiting (by other opensips procs) for the startup route to be executed - fixed triggering of startup route if no UDP interface was configured Reported by Dragos Oancea Closes bug #3577353 Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=9329view=rev Modified Paths: -- branches/1.7/main.c branches/1.7/tcp_init.h branches/1.7/tcp_main.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9332] trunk/modules/drouting
Revision: 9332 http://opensips.svn.sourceforge.net/opensips/?rev=9332view=rev Author: bogdan_iancu Date: 2012-10-16 17:32:13 + (Tue, 16 Oct 2012) Log Message: --- -improved docs in how weight (for rules and carriers) should be used. Suggested by shimaore. Closes bug #3577322 Modified Paths: -- trunk/modules/drouting/README trunk/modules/drouting/doc/drouting_admin.xml This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3577322 ] modules/drouting: document how to specify weights
Bugs item #3577322, was opened at 2012-10-15 06:56 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3577322group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: docs Group: 1.8.x Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: shimaore (shimaore) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: modules/drouting: document how to specify weights Initial Comment: Although the documentation for the drouting module indicates we can assign weights to gateways or carriers, it does not say how. drouting.xml should be modified to add the specification, and maybe an example: listitemparalist of GWs/carriers (string) [...] For each ID (GW or carrier) you may specify a weight by appending quote=/quote, followed by a numerical weight, to the quotegwid/quote or the quotecarrierid/quote. [...] Example of list: quotegw1,gw4,#cr3/quote quotegw1=10,gw4=10,#cr3=80/quote -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-16 10:33 Message: Thanks for the suggestion, I already put more examples in the docs ! Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3577322group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3576351 ] sip_trace module bug
Bugs item #3576351, was opened at 2012-10-11 07:53 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3576351group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Dragos Oancea (dragosoancea) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: sip_trace module bug Initial Comment: Hi The siptrace module reports a wrong value in the `fromip` field of the sip_trace table. For example , for this INVITE, coming from tls:80.187.x.x:62510 , I would expect the value tls:80.187.x.x:62510 to be added in the `fromip` field, but it's adding tls:80.187.x.x:625 instead . It's missing two digits from the port value. Also , sometimes it would put its local port (in my case 5061) instead of the remote port in the `fromip` or `toip` fields. INVITE sips:+49170738x...@sip.domain.com SIP/2.0 Call-Id: c64e6615c79ab23501ad13f2e1a58918@10.77.26.75 CSeq: 1 INVITE Via: SIP/2.0/TLS 10.77.26.75:59076;branch=z9hG4bK127109c14cd3b59c9ef9909b737982ab Max-Forwards: 70 From: +491713x sips:usern...@sip.domain.com;tag=yRkyOWfbq To: sips:+4917073xx...@sip.domain.com Contact: sips:00@80.187.x.x:62510;transport=tls Allow: ACK,BYE User-Agent: SomeUserAgent Content-Type: application/sdp Content-Length: 138 v=0 o=- 1349965870484 1349965870484 IN IP4 10.77.26.75 s=- c=IN IP4 10.77.26.75 t=0 0 m=audio 37566 RTP/AVP 0 a=rtpmap:0 PCMU/8000 The problem was observed with opensips 1.8.1-tls and opensips-1.7.2-tls . Cheers, Dragos -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-16 10:40 Message: Are you using buffering and merging for multiple INSERTs ? http://www.opensips.org/Resources/DocsCoreFcn18#toc69 Regards, Bogdan -- Comment By: Dragos Oancea (dragosoancea) Date: 2012-10-15 05:32 Message: mysql desc sip_trace ; +-+--+--+-+-++ | Field | Type | Null | Key | Default | Extra | +-+--+--+-+-++ | id | int(10) unsigned | NO | PRI | NULL| auto_increment | | date| datetime | NO | MUL | 1900-01-01 00:00:01 | | | callid | varchar(255) | NO | MUL | | | | traced_user | varchar(128) | NO | MUL | | | | msg | text | NO | | NULL| | | method | varchar(50) | NO | | | | | status | varchar(128) | NO | | | | | fromip | varchar(50) | NO | MUL | | | | toip| varchar(50) | NO | | | | | fromtag | varchar(64) | NO | | | | | direction | varchar(4) | NO | | | | | time_stamp | timestamp| NO | | CURRENT_TIMESTAMP | | +-+--+--+-+-++ 12 rows in set (0.01 sec) They are varchar(50) , there should be enough space. Also , sometimes the same ip:port pair is inserted correctly - for example it could we wrong for the received INVITE, but it could be correct for the relayed BYE . -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-15 05:04 Message: Could you check the table format ? Do desc siptrace and see what are the sizes of the fromip and toip fields in the table - maybe the truncating is done by db. -- Comment By: Dragos Oancea (dragosoancea) Date: 2012-10-15 04:27 Message: Hi Bogdan, INVITE sips:+4917133xx...@sip.domain.com SIP/2.0 Call-Id: 6484f90259156c8d702a1cae0eb49f27@10.208.83.156 CSeq: 1 INVITE Via: SIP/2.0/TLS 10.208.83.156:53912;branch=z9hG4bK2929012bef3d8abb931df26bd8fa498c Max-Forwards: 70 From: +4917073x sips:xx...@sis.secusmart.com;tag=IhJICbbyh To: sips:+4917133xx...@sip.domain.com Contact: sips:xx@80.187.x.x:52316;transport=tls Allow: ACK,BYE User-Agent: SomeUserAgent Content-Type: application/sdp Content-Length: 142 v=0 o=- 1350298945023 1350298945023 IN IP4 10.208.83.156 s=- c=IN IP4 10.208.83.156 t=0 0 m=audio 58639 RTP/AVP 0 a=rtpmap:0 PCMU/8000 | INVITE || tls:80.187.x.x:5231 |
[OpenSIPS-Devel] [ opensips-Patches-3564846 ] Linux futex support for locks
Patches item #3564846, was opened at 2012-09-04 16:33 Message generated for change (Comment added) made by rrb3942 You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3564846group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: trunk Status: Open Resolution: None Priority: 5 Private: No Submitted By: Ryan Bullock (rrb3942) Assigned to: Nobody/Anonymous (nobody) Summary: Linux futex support for locks Initial Comment: This patch adds the option for using futexs under Linux with FAST_LOCK. Implementation was taken from http://people.redhat.com/drepper/futex.pdf, and modified to add support for an Adaptive Wait loop in the case of a single waiter. Uses a modified version of the tsl() fuction from fastlock.h as an atomic xchg operation. It uses gcc builtins for atomic cmpxchg. To use futexes FAST_LOCK and USE_FUTEX must both be defined. Since the logic for using the futex is notably different than FAST_LOCK it is implemented separately in futex_lock.h, however we still require FAST_LOCK be defined to ensure support for the atomic_xchg. In my testing, using opensips in a virtual machine allocated 2 processors and using 16 children in a fairly pathological locking scenario this shows a large performance boost over just FAST_LOCK. Some Benchmark numbers after 5 minutes of runtime with sipp attempting 1000 CPS with 6 second durations: USE_FUTEX Sep 4 15:06:00 labproxy /usr/local/sbin/opensips[17196]: benchmark (timer lock_test [0]): 309 [ msgs/total/min/max/avg - LR: 100/14797/21/2049/147.97 | GB: 599600/98709250/0/20102/987092.50] Sep 4 15:06:00 labproxy /usr/local/sbin/opensips[17202]: benchmark (timer lock_test [0]): 120 [ msgs/total/min/max/avg - LR: 100/15584/85/317/155.84 | GB: 599700/98724834/0/20102/987248.34] Sep 4 15:06:00 labproxy /usr/local/sbin/opensips[17192]: benchmark (timer lock_test [0]): 150 [ msgs/total/min/max/avg - LR: 100/19241/86/4076/192.41 | GB: 599800/98744075/0/20102/987440.75] Sep 4 15:06:00 labproxy /usr/local/sbin/opensips[17205]: benchmark (timer lock_test [0]): 124 [ msgs/total/min/max/avg - LR: 100/22005/74/6166/220.05 | GB: 599900/98766080/0/20102/987660.80] Sep 4 15:06:00 labproxy /usr/local/sbin/opensips[17206]: benchmark (timer lock_test [0]): 105 [ msgs/total/min/max/avg - LR: 100/19022/21/848/190.22 | GB: 60/98785102/0/20102/987851.02] Sep 4 15:06:01 labproxy /usr/local/sbin/opensips[17203]: benchmark (timer lock_test [0]): 155 [ msgs/total/min/max/avg - LR: 100/18633/85/1386/186.33 | GB: 600100/98803735/0/20102/988037.35] Sep 4 15:06:01 labproxy /usr/local/sbin/opensips[17203]: benchmark (timer lock_test [0]): 107 [ msgs/total/min/max/avg - LR: 100/18284/81/2873/182.84 | GB: 600200/98822019/0/20102/988220.19] Sep 4 15:06:01 labproxy /usr/local/sbin/opensips[17207]: benchmark (timer lock_test [0]): 106 [ msgs/total/min/max/avg - LR: 100/16327/83/747/163.27 | GB: 600300/98838346/0/20102/988383.46] Sep 4 15:06:01 labproxy /usr/local/sbin/opensips[17204]: benchmark (timer lock_test [0]): 40 [ msgs/total/min/max/avg - LR: 100/16664/27/5093/166.64 | GB: 600400/98855010/0/20102/988550.10] Sep 4 15:06:01 labproxy /usr/local/sbin/opensips[17205]: benchmark (timer lock_test [0]): 43 [ msgs/total/min/max/avg - LR: 100/4938/26/222/49.38 | GB: 600500/98859948/0/20102/988599.48] FAST_LOCK Sep 4 15:15:44 labproxy /usr/local/sbin/opensips[2360]: benchmark (timer lock_test [0]): 159 [ msgs/total/min/max/avg - LR: 100/16685/78/380/166.85 | GB: 600600/347519878/0/137058/3475198.78] Sep 4 15:15:44 labproxy /usr/local/sbin/opensips[2361]: benchmark (timer lock_test [0]): 153 [ msgs/total/min/max/avg - LR: 100/24353/0/2216/243.53 | GB: 600700/347544231/0/137058/3475442.31] Sep 4 15:15:44 labproxy /usr/local/sbin/opensips[2355]: benchmark (timer lock_test [0]): 95 [ msgs/total/min/max/avg - LR: 100/16816/75/465/168.16 | GB: 600800/347561047/0/137058/3475610.47] Sep 4 15:15:44 labproxy /usr/local/sbin/opensips[2359]: benchmark (timer lock_test [0]): 131 [ msgs/total/min/max/avg - LR: 100/20270/81/3535/202.70 | GB: 600900/347581317/0/137058/3475813.17] Sep 4 15:15:44 labproxy /usr/local/sbin/opensips[2346]: benchmark (timer lock_test [0]): 87 [ msgs/total/min/max/avg - LR: 100/17892/87/872/178.92 | GB: 601000/347599209/0/137058/3475992.09] Sep 4 15:15:44 labproxy /usr/local/sbin/opensips[2361]: benchmark (timer lock_test [0]): 178 [ msgs/total/min/max/avg - LR: 100/16425/81/354/164.25 | GB: 601100/347615634/0/137058/3476156.34] Sep 4 15:15:44 labproxy /usr/local/sbin/opensips[2351]: benchmark (timer lock_test [0]): 45 [ msgs/total/min/max/avg - LR: 100/14298/0/1367/142.98 | GB:
