[OpenSIPS-Devel] VB: [OpenSIPS-Users] [RELEASES] Planing OpenSIPS 1.9.0 major release
Hi ALL, According to 14.1 and 14.2 of RFC 3261 after receiving 491 the UAC will retry again after 2.1-4.0 seconds if it owns the CALL-ID or 0.0.-2.0 if not. So If UAS have an ongoing in-dialog ping and receive another one let it send 491 and drop the request (the end point will retry it later). // Binan. Från: Bogdan-Andrei Iancu Till: OpenSIPS users mailling list Kopia: OpenSIPS devel mailling list Skickat: torsdag, 1 november 2012 12:02 Ämne: Re: [OpenSIPS-Users] [OpenSIPS-Devel] [RELEASES] Planing OpenSIPS 1.9.0 major release Hi Dan, Well, as Ovidiu said, it is prone. BUT, this is not something particular to re-INVITE, but to whatever in-dialog pinging you may have from a mid-proxy. On the other hand, as Ryan pointed out here, the need to check the dialog health from proxy side, without relying on special end-UA features (like SST), is really critical. So, I see two approaches: 1) either simply live with the fact that races may occure and calls may be dropped during a re-INVITE, but at least is a clear drop /cut 2) theoretically we can try to address the race at dialog modules level : (a) If you have ongoing in-dialog transaction, do not do your ping , (b) if you have an ongoing in-dialog ping and receive another in-dilog request from end point, try to delay it until your pinging is done.just some ideas Regards, Bogdan-Andrei Iancu OpenSIPS Founder and Developer http://www.opensips-solutions.com On 10/31/2012 09:03 PM, Dan Pascu wrote: > On 29 Oct 2012, at 12:11, Bogdan-Andrei Iancu wrote: > >> Hi Saul, >> >> We were thinking at re-INVITE pinging from OpenSIPs level towards the caller >> and callee. There will be 2 modes (at least this is the current plan). >> 1) remember all the time the last SDPs from each side and re-use them >>when pining the other sides (just to trick the SDP negotiation) >> 2) start with a lateSDP negotiation on one side and do normal SDP on the >>other side (to avoid SDP storing), but this means at least one of the parties >>should support late SDP negotiations >> 3) open to other suggestions > I think this invites trouble as it is prone to race conditions. If any of the > clients send a re-INVIVITE of their own while OpenSIPs does it's pinging, it > will fail as there is already an active unanswered re-INVITE in progress. The client will be confused as it didn't send another re-INVITE itself and the negative reply to its own re-INVITE will probably just prompt the client to terminate the session thinking there is some issue with it. > > I cannot see this working without a full B2BUA, where OpenSIPs would queue > the client requests if there is a ping in progress and only forward them > after it has finished the ping transaction. > >> About the GRUU stuff, could you detail a bit :D ? >> >> Regards, >> >> Bogdan-Andrei Iancu >> OpenSIPS Founder and Developer >> http://www.opensips-solutions.com >> >> >> On 10/26/2012 06:51 PM, Saúl Ibarra Corretgé wrote: >>> Hi, >>> >>> On Oct 26, 2012, at 5:20 PM, Bogdan-Andrei Iancu wrote: >>> Hi all, I would like to start a discussion about the next OpenSIPS major release - and in this discussion anyone is welcomed with options, ideas, critics and other. Your feedback is important to drive the project into a direction that reflects the user's needs!. So, I will here the starting points, for both release planing and release content. Content --- What was done: http://www.opensips.org/Main/Ver190#toc2 What is planned: http://www.opensips.org/Main/Ver190#toc9 Planned items have priorities (for being addressed); it is a must to have all items done for the next release, as we need to fit into a time frame. Whatever is not done, will be left for the next release (1.10) Planing --- Release candidate: second half of January 2012, depending on the progress with the items to be done. Testing phase: 1 month allocated (it may be extended if critical problems show up) Stable release: second half of February (after the testing phase is done). Once again, your feedback on these matters is important to us. >>> I'll edit the wiki with the items we've been working on for presence. >>> >>> Can you give a bit more detail on the dialog ping with re-INVITEs? >>> re-INVITEs are particularly troublesome, because there can only be one of them at a time. >>> >>> Also, can we add the in-dialog requests when using GRUU bug to the >>> wishlist? :-) >>> >>> Keep up the good work guys! >>> >>> >>> Regards, >>> >>> -- >>> Saúl Ibarra Corretgé >>> AG Projects >>> >>> >>> >>> >>> ___ >>> Devel mailing list >>> Devel@lists.opensips.org >>> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel >>> >> ___
[OpenSIPS-Devel] [ opensips-Bugs-3582691 ] Mem Leak in msg callbacks
Bugs item #3582691, was opened at 2012-11-02 08:58 Message generated for change (Settings changed) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3582691&group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: trunk Status: Open Resolution: None Priority: 7 Private: No Submitted By: Bogdan-Andrei Iancu (bogdan_iancu) >Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: Mem Leak in msg callbacks Initial Comment: msg callbacks + params are not freed in call cases -- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3582691&group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3582691 ] Mem Leak in msg callbacks
Bugs item #3582691, was opened at 2012-11-02 08:58 Message generated for change (Tracker Item Submitted) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3582691&group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: trunk Status: Open Resolution: None Priority: 7 Private: No Submitted By: Bogdan-Andrei Iancu (bogdan_iancu) Assigned to: Nobody/Anonymous (nobody) Summary: Mem Leak in msg callbacks Initial Comment: msg callbacks + params are not freed in call cases -- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3582691&group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [OpenSIPS-Users] [RELEASES] Planing OpenSIPS 1.9.0 major release
On 11/02/2012 02:17 PM, Iñaki Baz Castillo wrote: 2012/11/2 Bogdan-Andrei Iancu: Yes the patch is there, we need to review it. Also Inaki sugested some tunings in the PATH module (to fully support websocket). Well, there is no special needs for the PATH module to support WebSocket. In fact, nothing must be done if it already works ok (but just increasing the path column size to be able to store two URIs). Yes, that's the kind of things I was referring at. Also looking in the patch module code, there are several things that can be improved there (how path is built, mem usag, etc). There are still some faulty things also there - there was recently a fix on TCP handling (proto changing) in PATH hdr. Regards, Bogdan ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3563203 ] do_routing function crash without group id parameter
Bugs item #3563203, was opened at 2012-08-30 01:34
Message generated for change (Comment added) made by red02
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3563203&group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.7.x
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: piero ferraresso (red02)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: do_routing function crash without group id parameter
Initial Comment:
I\'m using opensips v. 1.7.2-TLS on a Debian 6.04 machine.
If I call the function do_routing without specifing the group id parameter -
do_routing(\"\",\"1\") for example - opensips crah (segfault at 0 ip 081399d8
sp bfed0480 error 4 in opensips[8048000+15]).
If I insert the group id - do_routing(\"0\",\"1\") for example - all works fine.
Where do I wrong?
Thanks in advance
Piero Ferraresso
--
>Comment By: piero ferraresso (red02)
Date: 2012-11-02 06:46
Message:
I've just installed the latest version (1.8.2). This time I get this error
on the syslog: "CRITICAL:db_mysql:wrapper_single_mysql_real_query: driver
error (1064): You have an error in your SQL syntax; check the manual that
corresponds to your MySQL server version for the right syntax to use near
'#017 where username='prove'' at line 1
Nov 2 14:30:07 proxysiptest /sbin/opensips[28858]: ERROR:core:db_do_query:
error while submitting query - [select groupid from #017 where
username='prove']".
I've also executed the comands in GDB as you sugget, but after the "frame
0" and "p _h" commands I get: "No symbol "_h" in current context"
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-10-12 06:48
Message:
Hi Piero,
in GDB, in frame 0, could you do:
p _h
p *_h
p _h->table->s
Thanks and regards,
Bogdan
--
Comment By: piero ferraresso (red02)
Date: 2012-10-11 06:37
Message:
I've got the some problem also with the latest stable release (1.8.1.-TLS).
Piero
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-09-18 03:51
Message:
Post the opensips logs (with debug 6) corresponding to the INVITE
processing.
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-09-18 03:50
Message:
Still working (even if db_virtual):
Sep 18 14:49:33 [12557] DBG:core:parse_to_param: tag=fuzyi
Sep 18 14:49:33 [12557] DBG:core:parse_to: end of header reached, state=29
Sep 18 14:49:33 [12557] DBG:core:parse_to: display={"bogdan"},
ruri={sip:bog...@opensips.org}
Sep 18 14:49:33 [12557] DBG:db_virtual:db_virtual_query: f call
Sep 18 14:49:33 [12557] DBG:db_virtual:db_virtual_query: f call handle size
= 2
Sep 18 14:49:33 [12557] DBG:db_virtual:try_reconnect: try reconnect
Sep 18 14:49:33 [12557] DBG:db_virtual:db_virtual_query: flags1 = 3
Sep 18 14:49:33 [12557] DBG:core:db_new_result: allocate 48 bytes for
result set at 0x7cf908
Sep 18 14:49:33 [12557] DBG:db_mysql:db_mysql_get_columns: 1 columns
returned from the query
Sep 18 14:49:33 [12557] DBG:core:db_allocate_columns: allocate 28 bytes for
result columns at 0x7cfb88
Sep 18 14:49:33 [12557] DBG:db_mysql:db_mysql_get_columns:
RES_NAMES(0x7cfb90)[0]=[groupid]
Sep 18 14:49:33 [12557] DBG:db_mysql:db_mysql_get_columns: use DB_INT
result type
Sep 18 14:49:33 [12557] DBG:db_mysql:db_mysql_convert_rows: no rows
returned from the query
Sep 18 14:49:33 [12557] DBG:db_virtual:db_virtual_query: curent_con = 0
Sep 18 14:49:33 [12557] ERROR:drouting:get_group_id: no group for user
"bogdan"@"opensips.org"
Sep 18 14:49:33 [12557] DBG:db_virtual:db_virtual_free_result: f call
Sep 18 14:49:33 [12557] DBG:db_virtual:db_virtual_free_result: f call
handle size = 2
Sep 18 14:49:33 [12557] DBG:db_virtual:try_reconnect: try reconnect
Sep 18 14:49:33 [12557] DBG:db_virtual:db_virtual_free_result: flags1 = 3
Sep 18 14:49:33 [12557] DBG:core:db_free_columns: freeing result columns at
0x7cfb88
Sep 18 14:49:33 [12557] DBG:core:db_free_rows: freeing 0 rows
Sep 18 14:49:33 [12557] DBG:core:db_free_result: freeing result set at
0x7cf908
Sep 18 14:49:33 [12557] DBG:db_virtual:db_virtual_free_result: curent_con =
0
Sep 18 14:49:33 [12557] ERROR:drouting:do_routing: failed to get group id
Sep 18 14:49:33 [12557] DBG:core:buf_init: initializing...
DR failed !!
Sep 18 14:49:33 [12557] DBG:core:destroy_avp_list: destroying list (nil)
--
Comment By: piero ferraresso (red02)
Date: 2012-09-18 02:34
Message:
This is my actual configuration:
#db_default_url="virtua
Re: [OpenSIPS-Devel] [OpenSIPS-Users] [RELEASES] Planing OpenSIPS 1.9.0 major release
2012/11/2 Bogdan-Andrei Iancu : > Yes the patch is there, we need to review it. Also Inaki sugested some > tunings in the PATH module (to fully support websocket). Well, there is no special needs for the PATH module to support WebSocket. In fact, nothing must be done if it already works ok (but just increasing the path column size to be able to store two URIs). Regards. -- Iñaki Baz Castillo ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [OpenSIPS-Users] [RELEASES] Planing OpenSIPS 1.9.0 major release
2012/11/2 Binan AL Halabi : > > Hi All, > > If oversip uses Path extension OpenSIPS must support it. > > 1- Sending Path header values in 200 ok REGISTER response Even if this is required by RFC, the fact is that it's not needed at all for this stuff to work. > 2- Path header files syntax must confom to Route syntax Right. > 3- When look up the opensips must copies the stored path header fileds into > Route header fileds - preloaded route. > Reference: RFC 3327 Right. > Here i think adding one Route header pointing to OverSIP (second Path URI) > is enough in simple case (UA OverSIP--- OpenSIPS). > OverSIP removes the Route header and route the request based on RURI (first > Path URI). Also right, but due the design of OverSIP (basically an Outbound EDGE proxy) it was easier for me to always use double Record-Route and double Path header. In Outbound (RFC 5626) the Record-Route header added by the EDGE proxy contains a username in the URI that identifies the client connection. For some reasons it was easier always to use double Path. Anyhow, consider also the case in which there are two proxies between clients and OpenSIPS, so increasing the size of the "path" column is required. -- Iñaki Baz Castillo ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9421] branches/1.8/modules/dialog/dlg_handlers.c
Revision: 9421 http://opensips.svn.sourceforge.net/opensips/?rev=9421&view=rev Author: vladut-paiu Date: 2012-11-02 08:02:36 + (Fri, 02 Nov 2012) Log Message: --- backport from trunk (rev #9420) fixed bug introduced in earlier dialog fix :| Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=9420&view=rev Modified Paths: -- branches/1.8/modules/dialog/dlg_handlers.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9420] trunk/modules/dialog/dlg_handlers.c
Revision: 9420 http://opensips.svn.sourceforge.net/opensips/?rev=9420&view=rev Author: vladut-paiu Date: 2012-11-02 07:59:38 + (Fri, 02 Nov 2012) Log Message: --- fixed bug introduced in earlier dialog fix :| Modified Paths: -- trunk/modules/dialog/dlg_handlers.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
