[OpenSIPS-Devel] [Tutorials] New OpenSIPs tutorials available
Hi, Thanks to external contributions, there are new tutorials available for OpenSIPS : a) A compilation of various tutorials covering topics like software installation (including MediaProxy on CentOS), authentication, clustering and comparing OpenSIPS with Asterisk provided by SmartVox, thanks to John Quick. http://www.opensips.org/Resources/DocsTutorials#toc21 b) How to configure a cluster of OpenSIPS load balancers which communicates via Redis (in Spanish thanks to VozToVoice). http://www.opensips.org/Resources/DocsTutorials#toc22 Many Thanks for the work and contribution to the OpenSIPS community! Best regards, -- Bogdan-Andrei Iancu OpenSIPS Founder and Developer http://www.opensips-solutions.com ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9547] trunk/route.c
Revision: 9547 http://opensips.svn.sourceforge.net/opensips/?rev=9547view=rev Author: razvancrainea Date: 2013-01-15 12:23:36 + (Tue, 15 Jan 2013) Log Message: --- bug fix: event_route index starts with 1 Modified Paths: -- trunk/route.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9548] trunk/route.c
Revision: 9548 http://opensips.svn.sourceforge.net/opensips/?rev=9548view=rev Author: razvancrainea Date: 2013-01-15 12:25:49 + (Tue, 15 Jan 2013) Log Message: --- previous commit stands also for route checking, not onlyu fixing Modified Paths: -- trunk/route.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9549] trunk/modules/db_mysql
Revision: 9549 http://opensips.svn.sourceforge.net/opensips/?rev=9549view=rev Author: razvancrainea Date: 2013-01-15 14:12:09 + (Tue, 15 Jan 2013) Log Message: --- Added an event that is triggered when MySQL changes it's connection status Modified Paths: -- trunk/modules/db_mysql/README trunk/modules/db_mysql/db_mysql.c trunk/modules/db_mysql/db_mysql.h trunk/modules/db_mysql/dbase.c trunk/modules/db_mysql/doc/db_mysql_admin.xml This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Please stop retagging versions and releasing new tarballs under the same version number.
Hi Peter, Indeed, the src tarballs are daily re-generated in order to reflect changes on SVN - we ended up with this procedure as users are constantly asking for up 2 date tarballs for installing. And we are not making a new release for each svn commit :) Also I understand that you want a stable tarball for the specs. What should be the solution here ? to have one tarball to reflect the release time (and not to be updated in time) and another dynamic one for download purposes ? I'm open to any suggestions :) Regards, Bogdan-Andrei Iancu OpenSIPS Founder and Developer http://www.opensips-solutions.com On 01/14/2013 11:53 AM, Peter Lemenkov wrote: Hello All. I've just found that there are several different tarballs with what is called OpenSIPS 1.8.2. Latest one was released in January and contains all bugfixes (as far as I can see) from a 1.8 branch. This isn't a good release strategy and really drives maintainers mad. Could you please stop doing so. If you need to release some critical bugfixes in a 1.8.x branch then don't be shy - tag it 1.8.3, 1.8.4, and so on. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9550] trunk/modules/tm/uac.c
Revision: 9550 http://opensips.svn.sourceforge.net/opensips/?rev=9550view=rev Author: bogdan_iancu Date: 2013-01-15 15:10:15 + (Tue, 15 Jan 2013) Log Message: --- some DBG() cleanup Modified Paths: -- trunk/modules/tm/uac.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Please stop retagging versions and releasing new tarballs under the same version number.
On Jan 15, 2013, at 4:02 PM, Bogdan-Andrei Iancu wrote: Hi Peter, Indeed, the src tarballs are daily re-generated in order to reflect changes on SVN - we ended up with this procedure as users are constantly asking for up 2 date tarballs for installing. And we are not making a new release for each svn commit :) Also I understand that you want a stable tarball for the specs. What should be the solution here ? to have one tarball to reflect the release time (and not to be updated in time) and another dynamic one for download purposes ? I'm open to any suggestions :) Here is a proposal: There could be 2 types of files: releases and svn snapshots. Releases look like opensips-1.8.3.tar.gz and svn snapshot like opensips-1.8-svn1234.tar.gz Regards, -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-3591017 ] Remove headers by wildcard
Patches item #3591017, was opened at 2012-11-29 05:13 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3591017group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: https://www.google.com/accounts () Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: Remove headers by wildcard Initial Comment: changes sipmsgops.c. uses fnmatch() to remove headers by wildcard. usage example: remove_hf_wc(P-hint*); // removes all headers that start with P-hint remove_hf_wc(*orig-ip*); //removes all headers that that have orig-ip in their name -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2013-01-15 07:22 Message: Patch uploaded, function named remove_hf_wildcard() Thanks! -- Comment By: bratner (ratner2) Date: 2012-12-13 04:52 Message: on afterthought it is funny to use wc as suffix. I will thing of a better one. I chose to use filebased wildcards for 2 reasons. 1. It does what i need ( X-Custom-1, X-Custom-userdata, X-Custom-watever removed by 'X-Custom*' ) 2. I assumed it will be faster and less memory consuming then any regexp. On the other hand I would love to make remove_hf_regex as well. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-12-07 02:54 Message: Hi, First, I would suggest changing a bit the name of the function - having the wc token is not the most fortunate choice :) Secondly, I see you use file-name like wildcard - what about a more generic approach and using regexp ? Regards, Bogdan -- Comment By: https://www.google.com/accounts () Date: 2012-11-29 05:26 Message: attached a patch agains opensips_1_8 as well as trunk -- Comment By: https://www.google.com/accounts () Date: 2012-11-29 05:14 Message: by bratner : ratn...@gmail.com -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3591017group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3590367 ] DISPATCHER. Commit #9448 breaks dispatcher pings
Bugs item #3590367, was opened at 2012-11-27 06:22 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3590367group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Closed Resolution: Invalid Priority: 5 Private: No Submitted By: Nick Altmann (nikbyte) Assigned to: Vladut-Stefan Paiu (vladut-paiu) Summary: DISPATCHER. Commit #9448 breaks dispatcher pings Initial Comment: After this commit dispatcher pings are going from incorrect interface on multihomed opensips. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2013-01-15 07:28 Message: it proved to be configuration error. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-12-18 03:13 Message: Nick, I was not able to replicate your case - using trunk, once the mhomed is enabled, the correct outbound interface is used. So are you sure mhomed is used? Regards, Bogdan -- Comment By: Nick Altmann (nikbyte) Date: 2012-12-17 19:25 Message: 1, Only destination like sip:8.8.8.8:5060;transport=udp, socket column is empty. 2. mhomed=yes 3. No errors in log. Before patch OPTIONS go from external interface, after patch they're go from internal. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-12-17 11:18 Message: Nick, 1) do you set any socket info in the dispatcher table for the destinations you are probing ? 2) do you have the mhomed parameter enabled in core ? 3) do you see in logs any ERRORs related to dispatcher probing ? Regards, Bogdan -- Comment By: Nick Altmann (nikbyte) Date: 2012-11-28 09:46 Message: Common setup, dispatcher module with hosts from RFC1918 network and hosts from external network. Two network interfaces - internal and external. Before this commit internal gateways pings from internal ip, external pings from external ip. After commit it tries to send packets to external gateways from internal interface. -- Comment By: Vladut-Stefan Paiu (vladut-paiu) Date: 2012-11-28 09:43 Message: Hello Nick, Could you please give us a little more information about your setup and scenario ? Regards, Vlad -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3590367group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Please stop retagging versions and releasing new tarballs under the same version number.
Makes sense to me, if fine with Peter too. Regards, Bogdan-Andrei Iancu OpenSIPS Founder and Developer http://www.opensips-solutions.com On 01/15/2013 05:19 PM, Saúl Ibarra Corretgé wrote: On Jan 15, 2013, at 4:02 PM, Bogdan-Andrei Iancu wrote: Hi Peter, Indeed, the src tarballs are daily re-generated in order to reflect changes on SVN - we ended up with this procedure as users are constantly asking for up 2 date tarballs for installing. And we are not making a new release for each svn commit :) Also I understand that you want a stable tarball for the specs. What should be the solution here ? to have one tarball to reflect the release time (and not to be updated in time) and another dynamic one for download purposes ? I'm open to any suggestions :) Here is a proposal: There could be 2 types of files: releases and svn snapshots. Releases look like opensips-1.8.3.tar.gz and svn snapshot like opensips-1.8-svn1234.tar.gz Regards, -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9552] trunk/modules/aaa_radius
Revision: 9552 http://opensips.svn.sourceforge.net/opensips/?rev=9552view=rev Author: bogdan_iancu Date: 2013-01-15 15:50:48 + (Tue, 15 Jan 2013) Log Message: --- added new module param syslog_name to control the logging from the radius client library Credits go to Boris Ratner ( ratner2 on SF) Closes patch #3597026 Modified Paths: -- trunk/modules/aaa_radius/README trunk/modules/aaa_radius/aaa_radius.c trunk/modules/aaa_radius/doc/aaa_radius_admin.xml This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-3597026 ] aaa_radius: client library errors go to syslog
Patches item #3597026, was opened at 2012-12-17 12:57 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3597026group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: bratner (ratner2) Assigned to: Nobody/Anonymous (nobody) Summary: aaa_radius: client library errors go to syslog Initial Comment: Some old changes i made to aaa_radius to be able to see errors that the client library (radius-client-ng) was spitting out into nothingness unless syslog was open with rc_openlog(). So I added params to aaa_radius so you can turn on the logging and set the indent string for syslog. Then I could properly debug my dictionaries and sets and turn the logging off for production. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2013-01-15 07:52 Message: Hi , I uploaded the patch, but with some changes - I dropped the use_syslog param, as a bit redundant. Everything is controlled by syslog_name which is by default empty. If empty, the logging is not used. Thanks and regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3597026group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9553] trunk/modules/perl/perlfunc.c
Revision: 9553 http://opensips.svn.sourceforge.net/opensips/?rev=9553view=rev Author: bogdan_iancu Date: 2013-01-15 16:00:06 + (Tue, 15 Jan 2013) Log Message: --- Fixes perl_exec2() in perlfunc.c. The message object that is passed to the perl-script was left hanging after every call to perl_exec() in the opensips script. Moved the declaration of OpenSIPS::Message object to the SAVETMPS/FREETMPS segment so it will be freed before the function returns. Tested by using Devel::Gladiator. Credits go to Boris Ratner ( ratner2 on SF) Closes patch #3599210 Modified Paths: -- trunk/modules/perl/perlfunc.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9554] branches/1.8/modules/perl/perlfunc.c
Revision: 9554 http://opensips.svn.sourceforge.net/opensips/?rev=9554view=rev Author: bogdan_iancu Date: 2013-01-15 16:01:39 + (Tue, 15 Jan 2013) Log Message: --- backport from trunk (rev #9553) Fixes perl_exec2() in perlfunc.c. The message object that is passed to the perl-script was left hanging after every call to perl_exec() in the opensips script. Moved the declaration of OpenSIPS::Message object to the SAVETMPS/FREETMPS segment so it will be freed before the function returns. Tested by using Devel::Gladiator. Credits go to Boris Ratner ( ratner2 on SF) Closes patch #3599210 Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=9553view=rev Modified Paths: -- branches/1.8/modules/perl/perlfunc.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-3599210 ] fix memory leak in perl.so
Patches item #3599210, was opened at 2013-01-02 05:24 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3599210group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: bratner (ratner2) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: fix memory leak in perl.so Initial Comment: fixes perl_exec2() in perlfunc.c. The message object that is passed to the perl-script was left hanging after every call to perl_exec() in the opensips script. Moved the declaration of OpenSIPS::Message object to the SAVETMPS/FREETMPS segment so it will be freed before the function returns. Tested by using Devel::Gladiator. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2013-01-15 08:01 Message: Fix uploaded on SVN trunk, 1.8 and 1.7 . Thanks and regards, Bogdan -- Comment By: bratner (ratner2) Date: 2013-01-02 05:29 Message: --- modules/perl/perlfunc.c (revision 9540) +++ modules/perl/perlfunc.c (working copy) @@ -127,14 +127,16 @@ return -1; } - m = sv_newmortal(); - sv_setref_pv(m, OpenSIPS::Message, (void *)_msg); - SvREADONLY_on(SvRV(m)); ENTER; /* everything created after here */ SAVETMPS; /* ...is a temporary variable. */ PUSHMARK(SP); /* remember the stack pointer*/ + + m = sv_newmortal(); /* create a mortal SV to be killed on FREETMPS */ + sv_setref_pv(m, OpenSIPS::Message, (void *)_msg); /* bless the message with a class */ + SvREADONLY_on(SvRV(m)); /* set the content of m to be readonly */ + XPUSHs(m); /* Our reference to the stack... */ if (mystr) @@ -151,6 +153,5 @@ PUTBACK; FREETMPS; /* free that return value*/ LEAVE; /* ...and the XPUSHed mortal args.*/ - return retval; } -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3599210group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9555] branches/1.7/modules/perl/perlfunc.c
Revision: 9555 http://opensips.svn.sourceforge.net/opensips/?rev=9555view=rev Author: bogdan_iancu Date: 2013-01-15 16:02:24 + (Tue, 15 Jan 2013) Log Message: --- backport from trunk (rev #9553) Fixes perl_exec2() in perlfunc.c. The message object that is passed to the perl-script was left hanging after every call to perl_exec() in the opensips script. Moved the declaration of OpenSIPS::Message object to the SAVETMPS/FREETMPS segment so it will be freed before the function returns. Tested by using Devel::Gladiator. Credits go to Boris Ratner ( ratner2 on SF) Closes patch #3599210 Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=9553view=rev Modified Paths: -- branches/1.7/modules/perl/perlfunc.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9556] trunk/modules/perlvdb
Revision: 9556 http://opensips.svn.sourceforge.net/opensips/?rev=9556view=rev Author: bogdan_iancu Date: 2013-01-15 16:26:09 + (Tue, 15 Jan 2013) Log Message: --- Several fixes: 1. change the the declared module name to db_perlvdb. Otherwise it is not found as db_ module. 2. change the init db url type to actually be str 3. many changes that fix various memory leaks (perl object leaks) 4. fix result cleanup memory leaks Credits go to Boris Ratner ( ratner2 on SF) Closes patch #3599314 Modified Paths: -- trunk/modules/perlvdb/perlvdb.c trunk/modules/perlvdb/perlvdb_conv.c trunk/modules/perlvdb/perlvdb_oohelpers.c trunk/modules/perlvdb/perlvdbfunc.c trunk/modules/perlvdb/perlvdbfunc.h This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-3599314 ] Make perlvdb work with alias_db and without leaks
Patches item #3599314, was opened at 2013-01-03 04:39
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086412aid=3599314group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: bratner (ratner2)
Assigned to: Nobody/Anonymous (nobody)
Summary: Make perlvdb work with alias_db and without leaks
Initial Comment:
Several fixes:
1. change the the declared module name to db_perlvdb. Otherwise it is not found
as db_ module.
2. change the init db url type to actually be str
3. many changes that fix various memory leaks (perl object leaks)
4. fix result cleanup memory leaks
What works: Probably anything that does only query.
I use it for alias_db like this:
in opensips.cfg#perl stuff
loadmodule perl.so
modparam(perl, modpath, /usr/lib/opensips/perl)
modparam(perl, filename, /usr/lib/opensips/perl/vdbtest.pm)
loadmodule perlvdb.so
#alias lookup module
loadmodule alias_db.so
modparam(alias_db, db_url, perlvdb:OpenSIPS::VDB::Adapter::Alias)
...
...
alias_db_lookup(OpenSIPS::VDB::VTab::MyCode,d ); # Lookup the new
user@domain for the incoming RURI
in /usr/lib/opensips/perl/vdbtest.pm:
use OpenSIPS::VDB::Adapter::Alias;
use OpenSIPS::VDB::VTab::MyCode;
use OpenSIPS;
1;
in /usr/lib/opensips/perl/OpenSIPS/VDB/VTab/MyCode.pm:
package OpenSIPS::VDB::VTab::MyCode;
@ISA = qw ( OpenSIPS::VDB::VTab OpenSIPS::Utils::Debug );
use OpenSIPS;
sub init {
OpenSIPS::log(L_NOTICE, Init in MyCode);
}
sub query {
OpenSIPS::log(L_NOTICE, Query in MyCode);
my $self = shift;
my $alias_username = shift;
my $alias_domain = shift;
OpenSIPS::log(L_NOTICE, Finishing up the query in CP);
return { username = newuser, domain = newdomain };
}
1;
Any comments, bugs, requests to ratn...@gmail.com
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2013-01-15 08:29
Message:
I uploaded the patch to trunk only (it may need more testing before moving
to stable 1.8). I had to change the init db function as the change char -
str was not correct - the processing inside the function was still
expecting a CHAR (nul terminated) - this may have lead to memory
overflow.
I will also rename the whole module to db_perlvdb
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086412aid=3599314group_id=232389
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-3599314 ] Make perlvdb work with alias_db and without leaks
Patches item #3599314, was opened at 2013-01-03 04:39
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086412aid=3599314group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: bratner (ratner2)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: Make perlvdb work with alias_db and without leaks
Initial Comment:
Several fixes:
1. change the the declared module name to db_perlvdb. Otherwise it is not found
as db_ module.
2. change the init db url type to actually be str
3. many changes that fix various memory leaks (perl object leaks)
4. fix result cleanup memory leaks
What works: Probably anything that does only query.
I use it for alias_db like this:
in opensips.cfg#perl stuff
loadmodule perl.so
modparam(perl, modpath, /usr/lib/opensips/perl)
modparam(perl, filename, /usr/lib/opensips/perl/vdbtest.pm)
loadmodule perlvdb.so
#alias lookup module
loadmodule alias_db.so
modparam(alias_db, db_url, perlvdb:OpenSIPS::VDB::Adapter::Alias)
...
...
alias_db_lookup(OpenSIPS::VDB::VTab::MyCode,d ); # Lookup the new
user@domain for the incoming RURI
in /usr/lib/opensips/perl/vdbtest.pm:
use OpenSIPS::VDB::Adapter::Alias;
use OpenSIPS::VDB::VTab::MyCode;
use OpenSIPS;
1;
in /usr/lib/opensips/perl/OpenSIPS/VDB/VTab/MyCode.pm:
package OpenSIPS::VDB::VTab::MyCode;
@ISA = qw ( OpenSIPS::VDB::VTab OpenSIPS::Utils::Debug );
use OpenSIPS;
sub init {
OpenSIPS::log(L_NOTICE, Init in MyCode);
}
sub query {
OpenSIPS::log(L_NOTICE, Query in MyCode);
my $self = shift;
my $alias_username = shift;
my $alias_domain = shift;
OpenSIPS::log(L_NOTICE, Finishing up the query in CP);
return { username = newuser, domain = newdomain };
}
1;
Any comments, bugs, requests to ratn...@gmail.com
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2013-01-15 08:29
Message:
BTW, please test my change in db init and confirm if ok
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2013-01-15 08:29
Message:
I uploaded the patch to trunk only (it may need more testing before moving
to stable 1.8). I had to change the init db function as the change char -
str was not correct - the processing inside the function was still
expecting a CHAR (nul terminated) - this may have lead to memory
overflow.
I will also rename the whole module to db_perlvdb
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086412aid=3599314group_id=232389
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9557] trunk/modules
Revision: 9557 http://opensips.svn.sourceforge.net/opensips/?rev=9557view=rev Author: bogdan_iancu Date: 2013-01-15 17:57:03 + (Tue, 15 Jan 2013) Log Message: --- - renamed module to follow the name convention for DB modules Added Paths: --- trunk/modules/db_perlvdb/ Removed Paths: - trunk/modules/perlvdb/ This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9558] trunk/modules/db_perlvdb
Revision: 9558 http://opensips.svn.sourceforge.net/opensips/?rev=9558view=rev Author: bogdan_iancu Date: 2013-01-15 18:01:16 + (Tue, 15 Jan 2013) Log Message: --- - updates to reflex the module renaming Modified Paths: -- trunk/modules/db_perlvdb/Makefile trunk/modules/db_perlvdb/doc/perlvdb_admin.xml trunk/modules/db_perlvdb/doc/perlvdb_devel.xml This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9559] trunk
Revision: 9559 http://opensips.svn.sourceforge.net/opensips/?rev=9559view=rev Author: bogdan_iancu Date: 2013-01-15 18:04:46 + (Tue, 15 Jan 2013) Log Message: --- - renamed perlvdb - db_perlvdb Modified Paths: -- trunk/Makefile trunk/Makefile.conf This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-3599314 ] Make perlvdb work with alias_db and without leaks
Patches item #3599314, was opened at 2013-01-03 04:39
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086412aid=3599314group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: bratner (ratner2)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: Make perlvdb work with alias_db and without leaks
Initial Comment:
Several fixes:
1. change the the declared module name to db_perlvdb. Otherwise it is not found
as db_ module.
2. change the init db url type to actually be str
3. many changes that fix various memory leaks (perl object leaks)
4. fix result cleanup memory leaks
What works: Probably anything that does only query.
I use it for alias_db like this:
in opensips.cfg#perl stuff
loadmodule perl.so
modparam(perl, modpath, /usr/lib/opensips/perl)
modparam(perl, filename, /usr/lib/opensips/perl/vdbtest.pm)
loadmodule perlvdb.so
#alias lookup module
loadmodule alias_db.so
modparam(alias_db, db_url, perlvdb:OpenSIPS::VDB::Adapter::Alias)
...
...
alias_db_lookup(OpenSIPS::VDB::VTab::MyCode,d ); # Lookup the new
user@domain for the incoming RURI
in /usr/lib/opensips/perl/vdbtest.pm:
use OpenSIPS::VDB::Adapter::Alias;
use OpenSIPS::VDB::VTab::MyCode;
use OpenSIPS;
1;
in /usr/lib/opensips/perl/OpenSIPS/VDB/VTab/MyCode.pm:
package OpenSIPS::VDB::VTab::MyCode;
@ISA = qw ( OpenSIPS::VDB::VTab OpenSIPS::Utils::Debug );
use OpenSIPS;
sub init {
OpenSIPS::log(L_NOTICE, Init in MyCode);
}
sub query {
OpenSIPS::log(L_NOTICE, Query in MyCode);
my $self = shift;
my $alias_username = shift;
my $alias_domain = shift;
OpenSIPS::log(L_NOTICE, Finishing up the query in CP);
return { username = newuser, domain = newdomain };
}
1;
Any comments, bugs, requests to ratn...@gmail.com
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2013-01-15 10:06
Message:
module name also changed - an overall testing would be appreciated.
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2013-01-15 08:29
Message:
BTW, please test my change in db init and confirm if ok
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2013-01-15 08:29
Message:
I uploaded the patch to trunk only (it may need more testing before moving
to stable 1.8). I had to change the init db function as the change char -
str was not correct - the processing inside the function was still
expecting a CHAR (nul terminated) - this may have lead to memory
overflow.
I will also rename the whole module to db_perlvdb
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086412aid=3599314group_id=232389
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9560] trunk/modules/event_route/
Revision: 9560 http://opensips.svn.sourceforge.net/opensips/?rev=9560view=rev Author: osas Date: 2013-01-15 19:37:29 + (Tue, 15 Jan 2013) Log Message: --- event_route: set svn:ignore Property Changed: trunk/modules/event_route/ This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9561] trunk/Makefile.defs
Revision: 9561 http://opensips.svn.sourceforge.net/opensips/?rev=9561view=rev Author: osas Date: 2013-01-15 19:57:44 + (Tue, 15 Jan 2013) Log Message: --- Makefile.defs: set proper path to docbook.xsl Modified Paths: -- trunk/Makefile.defs This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3601037 ] MI_HTTP
Bugs item #3601037, was opened at 2013-01-15 15:02 Message generated for change (Comment added) made by digipigeon You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3601037group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Digipigeon (digipigeon) Assigned to: Nobody/Anonymous (nobody) Summary: MI_HTTP Initial Comment: There appears to be an issue where the http connection hangs, I have experienced the problem on the latest revision, 9561. I believe that this change is reacently introduced as the previous version which was working fine was when ticket 3590411 was closed on 2012-11-27. -- Comment By: Digipigeon (digipigeon) Date: 2013-01-15 16:35 Message: Hello Ovidiu, When the fix was applied to ticket 3590411 - Everything was working at this point, at some point after this there must have been an error introduced. Connections would have been less than 10 at this point in time. Command used: profile_get_values It was connected via script that has been stable and is still stable on non-upgraded versions, this runs through a curl type connection from php. We probably process 10,000 requests per node per day. Regards Jonathan -- Comment By: Ovidiu Sas (osas) Date: 2013-01-15 16:23 Message: The fix for 3590411 could not introduce an http connection hang. Please provide more details about the hang: - which mi commands did you use? - how many simultaneous connections do you have? - do you connect via a browser or do you have a script that connects to opensips? - how often do you run mi commands over mi_http interface? Thanks, Ovidiu -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3601037group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3601037 ] MI_HTTP
Bugs item #3601037, was opened at 2013-01-15 15:02 Message generated for change (Comment added) made by osas You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3601037group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Digipigeon (digipigeon) Assigned to: Nobody/Anonymous (nobody) Summary: MI_HTTP Initial Comment: There appears to be an issue where the http connection hangs, I have experienced the problem on the latest revision, 9561. I believe that this change is reacently introduced as the previous version which was working fine was when ticket 3590411 was closed on 2012-11-27. -- Comment By: Ovidiu Sas (osas) Date: 2013-01-15 16:47 Message: Hello Jonathan, The fix for the memory leak is this one: http://opensips.svn.sourceforge.net/viewvc/opensips/branches/1.8/modules/mi_http/http_fnc.c?r1=9459r2=9458pathrev=9459 And this is the only one that was applied. You could reverse the fix and test the latest revision without the fix. Do you see any errors in the logs? When this is happening, does opensips recovers itself from it? How do you detect this hung? When the hung happens, it happens for all scripts (you mentioned that there are several scripts pooling the profiles)? How often (per script) do you pull the profile values? -ovidiu -- Comment By: Digipigeon (digipigeon) Date: 2013-01-15 16:35 Message: Hello Ovidiu, When the fix was applied to ticket 3590411 - Everything was working at this point, at some point after this there must have been an error introduced. Connections would have been less than 10 at this point in time. Command used: profile_get_values It was connected via script that has been stable and is still stable on non-upgraded versions, this runs through a curl type connection from php. We probably process 10,000 requests per node per day. Regards Jonathan -- Comment By: Ovidiu Sas (osas) Date: 2013-01-15 16:23 Message: The fix for 3590411 could not introduce an http connection hang. Please provide more details about the hang: - which mi commands did you use? - how many simultaneous connections do you have? - do you connect via a browser or do you have a script that connects to opensips? - how often do you run mi commands over mi_http interface? Thanks, Ovidiu -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3601037group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
