Re: [OpenSIPS-Devel] [opensips] mod_fix: new helper fixup function that returns string and/or int value from a gparam_t (7870f22)
Personally, I consider that *fixup_get_isvalue* would have a lot more value if
it did had the option to do conversions internally, thus masking the whole flag
pvar logic behind it. It should have a prototype such as:
int fixup_get_isvalue(struct sip_msg* msg, gparam_p gp, int_str *out, enum
conv);
where conv could be { CONVERT_NONE, CONVERT_TO_INT, CONVERT_TO_STR }
---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/commit/7870f22613f2c6873177b615326e81d217e141a9#commitcomment-5509080___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] mod_fix: new helper fixup function that returns string and/or int value from a gparam_t (7870f22)
The purpose of the fixup function is to get both int and str (if possible). Since in_str is a union, that would not work. However, doing the conversion from str to int internally is a good idea. Thanks for reviewing the commit! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/commit/7870f22613f2c6873177b615326e81d217e141a9#commitcomment-5511601___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 4e3b6b: mod_fix: fixup_get_isvalue - return the int value ...
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 4e3b6b7c390aa88bdaa293cfc3f74a0d3f63c2c2 https://github.com/OpenSIPS/opensips/commit/4e3b6b7c390aa88bdaa293cfc3f74a0d3f63c2c2 Author: Ovidiu Sas o...@voipembedded.com Date: 2014-02-27 (Thu, 27 Feb 2014) Changed paths: M mod_fix.c Log Message: --- mod_fix: fixup_get_isvalue - return the int value if possible ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] bf5602: dispatcher: simplify ds_select_dst/domain params h...
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: bf560248fa6d96cb32304aa538940d6a2d6481b8 https://github.com/OpenSIPS/opensips/commit/bf560248fa6d96cb32304aa538940d6a2d6481b8 Author: Ovidiu Sas o...@voipembedded.com Date: 2014-02-27 (Thu, 27 Feb 2014) Changed paths: M modules/dispatcher/dispatcher.c Log Message: --- dispatcher: simplify ds_select_dst/domain params handling ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 52b679: mod_fix: have commit 4e3b6b7c390a work on strings ...
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 52b6793c9abef37377699bfd04b618a8f9a935a1 https://github.com/OpenSIPS/opensips/commit/52b6793c9abef37377699bfd04b618a8f9a935a1 Author: Liviu Chircu li...@opensips.org Date: 2014-02-27 (Thu, 27 Feb 2014) Changed paths: M mod_fix.c Log Message: --- mod_fix: have commit 4e3b6b7c390a work on strings and pv_elem_t as well ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] Memory Lick problem
Hello Guys, Im getting a problem with out of memory on a opensips, this opensips is running on kvm server and i have just two servers on this server, i have enough memory, can you guys try to help me to understand the debug on the link below ? http://204.16.1.50/memoryfail.txt This opensips have simple rules and load_balance I will apreciate any help. Thanks ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] d15578: dispatcher: enhance error probe
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: d15578c7524cfa93cdf48213dafde87ef59d5aea https://github.com/OpenSIPS/opensips/commit/d15578c7524cfa93cdf48213dafde87ef59d5aea Author: Ovidiu Sas o...@voipembedded.com Date: 2014-02-27 (Thu, 27 Feb 2014) Changed paths: M modules/dispatcher/dispatch.c Log Message: --- dispatcher: enhance error probe - print dispatching id for unknown dispatching algorithm ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Memory Lick problem
Hello Mike, The pkg memory hash dump you have posted looks ok. It has some parser, networking, pseudo-variable and timer memory allocated, and no obvious signs of a leak. What ERRORs do you see in the OpenSIPS logs? Are you able to extract the similar logs which show the Memory status (shm) output? Best regards, Liviu Chircu OpenSIPS Developer http://www.opensips-solutions.com On 02/27/2014 06:47 PM, Mike Tesliuk wrote: Hello Guys, Im getting a problem with out of memory on a opensips, this opensips is running on kvm server and i have just two servers on this server, i have enough memory, can you guys try to help me to understand the debug on the link below ? http://204.16.1.50/memoryfail.txt This opensips have simple rules and load_balance I will apreciate any help. Thanks ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Memory Lick problem
Hello Liviu, Thanks for you help. Im receiving messages of no memmory : WARNING:core:fm_malloc: Not enough free memory, will atempt defragmenation Feb 25 15:13:02 sipproxy1 /usr/local/opensips/sbin/opensips[8125]: ERROR:dialog:dlg_add_leg_info: Failed to resize legs array Feb 25 15:13:02 sipproxy1 /usr/local/opensips/sbin/opensips[8125]: ERROR:dialog:init_leg_info: dlg_add_leg_info failed Feb 25 15:13:02 sipproxy1 /usr/local/opensips/sbin/opensips[8125]: ERROR:dialog:dlg_create_dialog: could not add further info to the dialog Feb 25 15:13:02 sipproxy1 /usr/local/opensips/sbin/opensips[8125]: ERROR:load_balancer:do_load_balance: failed to create dialog The server is virtual host (kvm) with 8 GB dedicated memory , i got something like 600 simultaneos calls The memory status error that you ask is on the link below http://204.16.1.50/memorystatus-shm.txt and i get some ERROR messages on the next link http://204.16.1.50/process-errors.txt ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Memory Lick problem
It doesn't matter how many memory you have. OpenSIPS only uses what it is configured to start with. Restart your OpenSIPS daemon using the -m 512 -M 32 options (512MB shared between children, 32MB private for each one). It should be more than enough to handle 600 concurrent calls. Best regards, Liviu Chircu OpenSIPS Developer http://www.opensips-solutions.com On 02/27/2014 07:40 PM, Mike Tesliuk wrote: Hello Liviu, Thanks for you help. Im receiving messages of no memmory : WARNING:core:fm_malloc: Not enough free memory, will atempt defragmenation Feb 25 15:13:02 sipproxy1 /usr/local/opensips/sbin/opensips[8125]: ERROR:dialog:dlg_add_leg_info: Failed to resize legs array Feb 25 15:13:02 sipproxy1 /usr/local/opensips/sbin/opensips[8125]: ERROR:dialog:init_leg_info: dlg_add_leg_info failed Feb 25 15:13:02 sipproxy1 /usr/local/opensips/sbin/opensips[8125]: ERROR:dialog:dlg_create_dialog: could not add further info to the dialog Feb 25 15:13:02 sipproxy1 /usr/local/opensips/sbin/opensips[8125]: ERROR:load_balancer:do_load_balance: failed to create dialog The server is virtual host (kvm) with 8 GB dedicated memory , i got something like 600 simultaneos calls The memory status error that you ask is on the link below http://204.16.1.50/memorystatus-shm.txt and i get some ERROR messages on the next link http://204.16.1.50/process-errors.txt ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Memory Lick problem
Ok, i will try that, sorry my mistake with the subject so e thanks for your help, on my man opensips i didint see thes -M option (just -m) 2014-02-27 12:45 GMT-05:00 Liviu Chircu li...@opensips.org: It doesn't matter how many memory you have. OpenSIPS only uses what it is configured to start with. Restart your OpenSIPS daemon using the -m 512 -M 32 options (512MB shared between children, 32MB private for each one). It should be more than enough to handle 600 concurrent calls. Best regards, Liviu Chircu OpenSIPS Developer http://www.opensips-solutions.com On 02/27/2014 07:40 PM, Mike Tesliuk wrote: Hello Liviu, Thanks for you help. Im receiving messages of no memmory : WARNING:core:fm_malloc: Not enough free memory, will atempt defragmenation Feb 25 15:13:02 sipproxy1 /usr/local/opensips/sbin/opensips[8125]: ERROR:dialog:dlg_add_leg_info: Failed to resize legs array Feb 25 15:13:02 sipproxy1 /usr/local/opensips/sbin/opensips[8125]: ERROR:dialog:init_leg_info: dlg_add_leg_info failed Feb 25 15:13:02 sipproxy1 /usr/local/opensips/sbin/opensips[8125]: ERROR:dialog:dlg_create_dialog: could not add further info to the dialog Feb 25 15:13:02 sipproxy1 /usr/local/opensips/sbin/opensips[8125]: ERROR:load_balancer:do_load_balance: failed to create dialog The server is virtual host (kvm) with 8 GB dedicated memory , i got something like 600 simultaneos calls The memory status error that you ask is on the link below http://204.16.1.50/memorystatus-shm.txt and i get some ERROR messages on the next link http://204.16.1.50/process-errors.txt ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] abf394: mod_fix:fixup_get_isvalue - make sure that we have...
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: abf394785f08036ff3a6b330f69d554f91e2e010 https://github.com/OpenSIPS/opensips/commit/abf394785f08036ff3a6b330f69d554f91e2e010 Author: Ovidiu Sas o...@voipembedded.com Date: 2014-02-27 (Thu, 27 Feb 2014) Changed paths: M mod_fix.c Log Message: --- mod_fix:fixup_get_isvalue - make sure that we have a valid string for int converision ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
