Re: [OpenSIPS-Devel] [opensips] OpenSIPS accepts broken Contact header, then fails to start (#729)

[Saúl Ibarra Corretgé]

Actually, I was wrong. We are using a bit of custom logic to set the 
received_uri AVP manually. So it is set.

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/729#issuecomment-166305988___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

[OpenSIPS-Devel] [OpenSIPS/opensips] ef7654: Usrloc: modify invalid contacts behaviour

[ionutrazvanionita]

  Branch: refs/heads/2.1
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ef76542b84b2e3b7a682d96f34bab1ce216766d6
  
https://github.com/OpenSIPS/opensips/commit/ef76542b84b2e3b7a682d96f34bab1ce216766d6
  Author: ionutrazvanionita 
  Date:   2015-12-21 (Mon, 21 Dec 2015)

  Changed paths:
M modules/usrloc/ucontact.c
M modules/usrloc/udomain.c

  Log Message:
  ---
  Usrloc: modify invalid contacts behaviour

* stop inserting a contact even though received is OK
(call parse_uri() for each contact)
* at startup, if a bogus contact is found continue processing,
letting the user know that he has to remove that contact from
the database


___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] OpenSIPS accepts broken Contact header, then fails to start (#729)

[Ionut Ionita]

https://github.com/OpenSIPS/opensips/commit/7f37f0545b0abd74f237c7ea520662ea04b40293
 . Also, at startup, if a broken contact it's found, you receive an error which 
gives the aor, contact, received and contact_id (if trunk version used) such 
that you can be able to delete it from the database without closing OpenSIPS> 

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/729#issuecomment-166311886___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] OpenSIPS accepts broken Contact header, then fails to start (#729)

[Saúl Ibarra Corretgé]

Nice, thanks! I'll make a new build and test it out.

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/729#issuecomment-166312303___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

[OpenSIPS-Devel] [OpenSIPS/opensips] bee77b: b2b_logic: allow the initial setup to have a dummy...

[Razvan Crainea]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: bee77b20455f1a5bcbc69c8b1dbbf647e0bbd7ec
  
https://github.com/OpenSIPS/opensips/commit/bee77b20455f1a5bcbc69c8b1dbbf647e0bbd7ec
  Author: Razvan Crainea 
  Date:   2015-12-21 (Mon, 21 Dec 2015)

  Changed paths:
M modules/b2b_logic/b2b_logic.c
M modules/b2b_logic/b2b_logic.h
M modules/b2b_logic/logic.c
M modules/b2b_logic/records.c
M modules/b2b_logic/records.h

  Log Message:
  ---
  b2b_logic: allow the initial setup to have a dummy SDP


___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

[OpenSIPS-Devel] [OpenSIPS/opensips] 4c1d61: Usrloc: modify invalid contacts behaviour

[ionutrazvanionita]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 4c1d61996345d0dfa830631ea9558f87b3a089ab
  
https://github.com/OpenSIPS/opensips/commit/4c1d61996345d0dfa830631ea9558f87b3a089ab
  Author: ionutrazvanionita 
  Date:   2015-12-21 (Mon, 21 Dec 2015)

  Changed paths:
M modules/usrloc/ucontact.c
M modules/usrloc/udomain.c

  Log Message:
  ---
  Usrloc: modify invalid contacts behaviour

* stop inserting a contact even though received is OK
(call parse_uri() for each contact)
* at startup, if a bogus contact is found continue processing,
letting the user know that he has to remove that contact from
the database


___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] OpenSIPS accepts broken Contact header, then fails to start (#729)

[Ionut Ionita]

ok i see. i will add a check in usrloc which will do `parse_uri()` for each 
contact added, such that invalid contacts won't be inserted, even though the 
received is ok. 

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/729#issuecomment-166306441___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

[OpenSIPS-Devel] [OpenSIPS/opensips] 7f37f0: Usrloc: modify invalid contacts behaviour

[ionutrazvanionita]

  Branch: refs/heads/1.11
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 7f37f0545b0abd74f237c7ea520662ea04b40293
  
https://github.com/OpenSIPS/opensips/commit/7f37f0545b0abd74f237c7ea520662ea04b40293
  Author: ionutrazvanionita 
  Date:   2015-12-21 (Mon, 21 Dec 2015)

  Changed paths:
M modules/usrloc/ucontact.c
M modules/usrloc/udomain.c

  Log Message:
  ---
  Usrloc: modify invalid contacts behaviour

* stop inserting a contact even though received is OK
(call parse_uri() for each contact)
* at startup, if a bogus contact is found continue processing,
letting the user know that he has to remove that contact from
the database


___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] OpenSIPS accepts broken Contact header, then fails to start (#729)

[Saúl Ibarra Corretgé]

Hi @ionutrazvanionita,

You're right, I was using nat_traversal, so I guess the same applies.

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/729#issuecomment-166280193___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] OpenSIPS accepts broken Contact header, then fails to start (#729)

[Ionut Ionita]

Can you tell me what are you using from nat_traversal and/or nathelper modules?

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/729#issuecomment-166301242___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

[OpenSIPS-Devel] [OpenSIPS/opensips] 6110e9: ReINVITE Pinging Improvements :

[Vlad Paiu]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 6110e92353007bf1e47cfb19e1e354838f4c114a
  
https://github.com/OpenSIPS/opensips/commit/6110e92353007bf1e47cfb19e1e354838f4c114a
  Author: Vlad Paiu 
  Date:   2015-12-21 (Mon, 21 Dec 2015)

  Changed paths:
M modules/dialog/dlg_handlers.c
M modules/dialog/dlg_hash.c
M modules/dialog/dlg_hash.h
M modules/dialog/dlg_timer.c

  Log Message:
  ---
  ReINVITE Pinging Improvements :
- ensure compatibility with NAT scenarios and  Topology Hiding, by 
extract Contact on the outgoing side
- extract SDP on the outgoing side, in order to ensure compatibility 
with RTPProxy and various other SDP changes

Work still in progress :
- Properly handle late negociation between endpoints
- Ensure SDP persistency ( DB and BIN replication )


___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel