[OpenSIPS-Devel] [OpenSIPS/opensips] b61381: Ensure VERSIONTYPE is always defined
Branch: refs/heads/3.4 Home: https://github.com/OpenSIPS/opensips Commit: b61381fd7c70081852e84c4a3cc3a4724a80d836 https://github.com/OpenSIPS/opensips/commit/b61381fd7c70081852e84c4a3cc3a4724a80d836 Author: Peter Lemenkov Date: 2024-01-04 (Thu, 04 Jan 2024) Changed paths: M Makefile.defs M main.c M mi/mi_core.c Log Message: --- Ensure VERSIONTYPE is always defined Signed-off-by: Peter Lemenkov (cherry picked from commit 22ef73ed10cc08995211763293a6b87ee88a2666) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 3dbf4f: Ensure VERSIONTYPE is always defined
Branch: refs/heads/3.2 Home: https://github.com/OpenSIPS/opensips Commit: 3dbf4f91e092b8ecbb5c15dfcc2bc952b528bd7b https://github.com/OpenSIPS/opensips/commit/3dbf4f91e092b8ecbb5c15dfcc2bc952b528bd7b Author: Peter Lemenkov Date: 2024-01-04 (Thu, 04 Jan 2024) Changed paths: M Makefile.defs M main.c M mi/mi_core.c Log Message: --- Ensure VERSIONTYPE is always defined Signed-off-by: Peter Lemenkov (cherry picked from commit 22ef73ed10cc08995211763293a6b87ee88a2666) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 2a8a9a: tm: Be more verbose when async detected in non-req...
Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 2a8a9a25a39f37e8df4ea5cfba6df9b413683469 https://github.com/OpenSIPS/opensips/commit/2a8a9a25a39f37e8df4ea5cfba6df9b413683469 Author: Peter Lemenkov Date: 2021-03-15 (Mon, 15 Mar 2021) Changed paths: M modules/tm/async.c Log Message: --- tm: Be more verbose when async detected in non-request route If async operation is detected in non-request route then tm tries to switch to sync mode emmitting just a debug message. Debug messages are relatively rarely being turned on, so this switch to sync can be left unnoticed. Let's raise the severity to WARN so this situation can be spotted much easier. Signed-off-by: Peter Lemenkov (cherry picked from commit d7145869e72fd9f0763847009e761af86bbcb0fa) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 5a4029: tm: Be more verbose when async detected in non-req...
Branch: refs/heads/3.1 Home: https://github.com/OpenSIPS/opensips Commit: 5a4029c2c1cd6a1e97d2ea3e6a44a351354adb5e https://github.com/OpenSIPS/opensips/commit/5a4029c2c1cd6a1e97d2ea3e6a44a351354adb5e Author: Peter Lemenkov Date: 2021-03-15 (Mon, 15 Mar 2021) Changed paths: M modules/tm/async.c Log Message: --- tm: Be more verbose when async detected in non-request route If async operation is detected in non-request route then tm tries to switch to sync mode emmitting just a debug message. Debug messages are relatively rarely being turned on, so this switch to sync can be left unnoticed. Let's raise the severity to WARN so this situation can be spotted much easier. Signed-off-by: Peter Lemenkov (cherry picked from commit d7145869e72fd9f0763847009e761af86bbcb0fa) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 78740c: evi: More verbose about which param caused crash
Branch: refs/heads/3.1 Home: https://github.com/OpenSIPS/opensips Commit: 78740cf44e8a6db3f1e4771f16dba8fad8fdbdb3 https://github.com/OpenSIPS/opensips/commit/78740cf44e8a6db3f1e4771f16dba8fad8fdbdb3 Author: Peter Lemenkov Date: 2020-09-02 (Wed, 02 Sep 2020) Changed paths: M evi/evi_transport.c M modules/event_datagram/event_datagram.c M modules/event_rabbitmq/event_rabbitmq.c M modules/event_stream/stream_send.c Log Message: --- evi: More verbose about which param caused crash When using evi interface sometimes we need to know exactly which parameter led to failure. At least we need its name and event's name. Signed-off-by: Peter Lemenkov (cherry picked from commit 9ee8c06484dc8fa50a8c9ab44a6a9e7e7aa40e21) Commit: 72592f679dff3b0ad046df8e5e4ab0a5560b1ed4 https://github.com/OpenSIPS/opensips/commit/72592f679dff3b0ad046df8e5e4ab0a5560b1ed4 Author: Peter Lemenkov Date: 2020-09-02 (Wed, 02 Sep 2020) Changed paths: M evi/evi_transport.c Log Message: --- evi: Str params can contain NULL values. NULL value as a str param is totally fine according to JSON specification. So let's not crash when adding str parameter with NULL value. Signed-off-by: Peter Lemenkov (cherry picked from commit b801f04c4acc970e4c37bae736d0c0518ab0958b) Compare: https://github.com/OpenSIPS/opensips/compare/9cf948b22fab...72592f679dff ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 27e758: rtpengine: Remove unused defines
Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 27e758dfc0fd6ae40b2157c3535928b721c4b26f https://github.com/OpenSIPS/opensips/commit/27e758dfc0fd6ae40b2157c3535928b721c4b26f Author: Peter Lemenkov Date: 2020-07-06 (Mon, 06 Jul 2020) Changed paths: M modules/rtpengine/rtpengine.c Log Message: --- rtpengine: Remove unused defines Signed-off-by: Peter Lemenkov (cherry picked from commit 463e815cfa1835f1ef97f9b8f16a943fce0b8762) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] d2d097: rtpengine: Remove unused defines
Branch: refs/heads/3.0 Home: https://github.com/OpenSIPS/opensips Commit: d2d09737f274a94029b1d8afa5866ed3d1394914 https://github.com/OpenSIPS/opensips/commit/d2d09737f274a94029b1d8afa5866ed3d1394914 Author: Peter Lemenkov Date: 2020-07-06 (Mon, 06 Jul 2020) Changed paths: M modules/rtpengine/rtpengine.c Log Message: --- rtpengine: Remove unused defines Signed-off-by: Peter Lemenkov (cherry picked from commit 463e815cfa1835f1ef97f9b8f16a943fce0b8762) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] c9a1c4: rtpengine: Remove unused defines
Branch: refs/heads/3.1 Home: https://github.com/OpenSIPS/opensips Commit: c9a1c4e6b9834e9bae66dd83aee4391b5515d9dc https://github.com/OpenSIPS/opensips/commit/c9a1c4e6b9834e9bae66dd83aee4391b5515d9dc Author: Peter Lemenkov Date: 2020-07-06 (Mon, 06 Jul 2020) Changed paths: M modules/rtpengine/rtpengine.c Log Message: --- rtpengine: Remove unused defines Signed-off-by: Peter Lemenkov (cherry picked from commit 463e815cfa1835f1ef97f9b8f16a943fce0b8762) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Perl module - "use UNIVERSAL" is a fatal error starting with Pert 5.22 (#804)
@devjunix thanks for the patch! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/804#issuecomment-189619996___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [opensips] Perl module - "use UNIVERSAL" is a fatal error starting with Pert 5.22 (#804)
At least two places in OpenSIPS where "use UNIVERSAL" is used:
./opensips-1.10.3-tls/modules/perl/lib/perl/OpenSIPS/LDAPUtils/LDAPConnection.pm
55:use UNIVERSAL qw( isa );
188:if( isa($conf ,"OpenSIPS::LDAPUtils::LDAPConnection") ) {
./opensips-1.10.3-tls/modules/perl/lib/perl/OpenSIPS/VDB.pm
48:use UNIVERSAL qw ( can );
90: if (can($pkg, $3)) {
92: } elsif (can($v, "init")) {
95: } elsif (can($v, "new")) {
This should be fixed as according to this document it will throw a fatal error
starting with Perl 5.22:
http://search.cpan.org/~shay/perl-5.21.11/pod/perl5213delta.pod#use%C2%A0UNIVERSAL%C2%A0%27...%27_is_now_a_fatal_error
---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/804___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] rtpproxy: patch: has_sdp() does not exist (#746)
Just a note - this is just a docfix, not a code change. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/746#issuecomment-169964275___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [opensips] rtpproxy: patch: has_sdp() does not exist (#746)
Not sure how this slipped through, but we don't have a function called has_sdp. You can view, comment on, or merge this pull request online at: https://github.com/OpenSIPS/opensips/pull/746 -- Commit Summary -- * rtpproxy: patch: has_sdp() does not exist -- File Changes -- M modules/rtpproxy/README (8) M modules/rtpproxy/doc/rtpproxy_admin.xml (8) -- Patch Links -- https://github.com/OpenSIPS/opensips/pull/746.patch https://github.com/OpenSIPS/opensips/pull/746.diff --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/746 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Fails to build with gcc 5.1 - opensips-1.10.5 (#555)
Thanks, @razvancrainea ! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/555#issuecomment-120979868___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Fails to build with gcc 5.1 - opensips-1.10.5 (#555)
Related information. A ticket dedicated to that issue: * https://bugzilla.redhat.com/show_bug.cgi?id=1190820 I've tried to fix the issue in a lemenkov/opensips@e06d0587b2b91ae8749450d031a32116da0b7b67 but the proposed patch was incomplete and later we were hit by a similar issues: * https://bugzilla.redhat.com/show_bug.cgi?id=1221213 Further reading about a new approach to inline: * http://www.greenend.org.uk/rjk/tech/inline.html * https://gcc.gnu.org/gcc-5/porting_to.html (see Different semantics for inline functions) * http://www.drdobbs.com/the-new-c-inline-functions/184401540 --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/555#issuecomment-111519897___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] [RFC] An initial attempt of porting rtpproxy-ng module from your twin project to OpenSIPS. (#152)
Thanks! Meanwhile there is a bunch of patches with a new functionality and bugfixes to merge. Stay tuned! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/152#issuecomment-46319784___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] [RFC] An initial attempt of porting rtpproxy-ng module from your twin project to OpenSIPS. (#152)
@nikbyte already done - see the latest commits above ( lemenkov/opensips@a11b4091496ebd70b5eac42d3483e7d85d2c71fc ) --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/152#issuecomment-39850530___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] RTP Proxy C (Copy/Fork) audio (#189)
@DunkyG E8 means that session doesn't exist. You have either to create it first or to pass proper CallID, From/To-tags --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/189#issuecomment-39423290___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] RTP Proxy C (Copy/Fork) audio (#189)
@DunkyG @razvancrainea just fyi - latest devel Wireshark versions contains a RTPproxy dissector which makes the debugging of the issues like that much more easier. Please try it! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/189#issuecomment-39423448___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] RTP Proxy C (Copy/Fork) audio (#189)
@DunkyG yes, 0 means ok. Btw you can use recent Wireshark version and see everything in details (just another one attempt of a shameless self-promo). --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/189#issuecomment-39446380___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] [RFC] An initial attempt of porting rtpproxy-ng module from your twin project to OpenSIPS. (#152)
As for me I really dislike the idea of renaming this module. This module is named after the protocol, not after the backend. Exactly the same situation with rtpproxy module - it implements a protocol, not a particular backend support. One can use rtpproxy module not only with RTPproxy from Sippy Soft but also with mediaproxy-ng or erlrtpproxy backends as well. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/152#issuecomment-35799110___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] [RFC] An initial attempt of porting rtpproxy-ng module from your twin project to OpenSIPS. (#152)
Also I really don't like the direction this discussion is going. Folks, let's just calm down for a while and focus on a technical issues. I have a plenty of patches on top of the original module to be reviewed and I'd love to hear any feedback on them :) --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/152#issuecomment-35799150___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] [RFC] An initial attempt of porting rtpproxy-ng module from your twin project to OpenSIPS. (#152)
Hello @bogdan-iancu ! First of all do NOT merge it at least during the next few monts - it's stil in a w.i.p. stage and I see some errors and suspicious warnings during operation. Also I've got few patches from your twin project to cheryr-pick. Please give me more time to polish that. This is entirely different module from rtpproxy - it uses bencoded messages instead of plain text protocol and requires a compatible media proxy application (so far there is the only one - https://github.com/sipwise/mediaproxy-ng ). --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/152#issuecomment-35714679___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] Initial support for RTPproxy-ng protocol in Wireshark
Hello All! After finishing with RTPproxy protocol support, I'm working on a RTPproxy-ng protocol support in Wireshark. I've just submitted an initial version with a very basic functionality: https://code.wireshark.org/review/#/c/268/ So far there is no support for RTP/RTCP dissection based on a RTPproxy-ng replies, no transaction matching, no expert functionality, and the rest of functionality already existed in the RTPproxy dissector is also missing, but I plan to add it back shortly. I'm on a very early stage with RTPproxy-ng protocol support so I can't really advise anyone to try it so just fyi. Sorry for the crossposting. -- With best regards, Peter Lemenkov. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [opensips] [RFC] An initial attempt of porting rtpproxy-ng module from your twin project to OpenSIPS. (#152)
Hello All! I#39;ve made some preliminary work on porting rtpproxy-ng from Kamailio to OpenSIPS. Unfortunately I#39;m not certain about my patches#39; quality and love to get any possible feedback on this. Could anyone please review this and help me merging it into OpenSIPS? Also any testing will be highly appreciated. Also I#39;d like to say a big thanks to @rfuchs and his fellow developers from @sipwise for this module! You can merge this Pull Request by running: git pull https://github.com/lemenkov/opensips rtpproxy-ng Or you can view, comment on it, or merge it online at: https://github.com/OpenSIPS/opensips/pull/152 -- Commit Summary -- * rtpproxy-ng: initial checkin * rtpproxy-ng: implement $rtpstat and document start_recording() * rtpproxy-ng: implement second parameter to rtpproxy_offer/answer/manage * rtpproxy-ng: fix possible segfault in rtpproxy_manage * modules/rtpproxy-ng: Allow PV in second rtpproxy_manage parameter * rtpproxy(-ng): patch: has_sdp() does not exist * rtpproxy-ng: fix extraction of multipart SDP body * rtpproxy-ng: ids to sections in documentation * rtpproxy-ng: remove code artifact that broke IPv6 received-from addresses * rtpproxy-ng: remove trailing double \r\n from multipart SDP * Move MODULE_VERSION macro to a OpenSIPS defined location * Adjust decode_mime_type arity * Adjust get_body calling * Adjust HDR_TO_F parsing * Add header file which is necessary for sr in OpenSIPS * Remove header files missing in OpenSIPS * Backport msg_has_sdp from rtpproxy module * Proper arity for mi_export_t structure * Workaround for missing handy macro in OpenSIPS * No need to fee after fixup_spve_null, fixup_spve_spve * No such macro PVT_OTHER in OpenSIPS * Adapt get_via_branch function to OpenSIPS API * No such flag FL_SDP_BODY in OpenSIPS * Replace get_str_fparam with fixup_get_svalue available in OpenSIPS * Don#39;t use pvar caching API unavailable in OpenSIPS -- File Changes -- A modules/rtpproxy-ng/Makefile (19) A modules/rtpproxy-ng/README (652) A modules/rtpproxy-ng/bencode.c (703) A modules/rtpproxy-ng/bencode.h (530) A modules/rtpproxy-ng/doc/Makefile (4) A modules/rtpproxy-ng/doc/rtpproxy-ng.xml (103) A modules/rtpproxy-ng/doc/rtpproxy_admin.xml (823) A modules/rtpproxy-ng/doc/rtpproxy_faq.xml (79) A modules/rtpproxy-ng/rtpproxy.c (1959) A modules/rtpproxy-ng/rtpproxy.h (64) A modules/rtpproxy-ng/rtpproxy_funcs.c (434) A modules/rtpproxy-ng/rtpproxy_funcs.h (40) -- Patch Links -- https://github.com/OpenSIPS/opensips/pull/152.patch https://github.com/OpenSIPS/opensips/pull/152.diff ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Opensips 1.10 segfault (#113)
@bogdan-iancu this looks like duplicate of #114 or vice versa. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/113#issuecomment-30927065___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Migrating OpenSIPS to GitHub
Hello All! 2013/4/30 Răzvan Crainea raz...@opensips.org: Hi all! Following the community desires[1] to migrate OpenSIPS repository and tracker to Github, we have compiled a schedule[2] for the upcoming weeks. That's a really great news! -- With best regards, Peter Lemenkov. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [OpenSIPS-Users] [RFC] migration to GIT
2013/2/18 Bogdan-Andrei Iancu bog...@opensips.org: Hi all, I would like to get some suggestions and help on the matter of migrating the code repository from SVN to GIT - the fact that such migration will bring value is for sure :) YES! YES! YES! -- With best regards, Peter Lemenkov. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [OpenSIPS-Users] [RFC] migration to GIT
2013/2/18 Saúl Ibarra Corretgé s...@ag-projects.com: What things need to be sorted out when moving to GIT: First question: would it be a self-hosted Git repository or the GitHub service? Why can't we have both? I personally don't see any issues here - It's possible to setup a primary repo at SF and secondary at GitHub. To be honest I'd prefer GitHub. Also I'd like to propose a switch to a new issue tracker at SF.net. Just compare that one we have to use now with the newest one: * http://sourceforge.net/p/sipp/bugs/ * http://sourceforge.net/p/curl/bugs/ -- With best regards, Peter Lemenkov. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Please stop retagging versions and releasing new tarballs under the same version number.
2013/1/15 Bogdan-Andrei Iancu bog...@opensips.org: Makes sense to me, if fine with Peter too. Yes, that's absolutely fine. -- With best regards, Peter Lemenkov. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] Please stop retagging versions and releasing new tarballs under the same version number.
Hello All. I've just found that there are several different tarballs with what is called OpenSIPS 1.8.2. Latest one was released in January and contains all bugfixes (as far as I can see) from a 1.8 branch. This isn't a good release strategy and really drives maintainers mad. Could you please stop doing so. If you need to release some critical bugfixes in a 1.8.x branch then don't be shy - tag it 1.8.3, 1.8.4, and so on. -- With best regards, Peter Lemenkov. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] Is it possible to return 0 from an exported function?
Hello. I'm writing a function (extending sipmsgops actually) which returns Payload ID. Obviously it should return 0 in case of PCMU/8000/1 which seems to be impossible. As a temporary solution I'm thinking of returing PayloadID+1 but this looks really strange. Maybe there are some other ways to return actual 0 from a module's exported function? -- With best regards, Peter Lemenkov. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [OpenSIPS-Users] [Release] Planing 1.8.1 minor release
Hello All! 2012/8/13 Bogdan-Andrei Iancu bog...@opensips.org: Hello all, We plan to have 1.8.1 minor version released by Wednesday 15th of August. Once again, a minor release includes only bug fixes (on the 1.8 major branch). Great news! Speaking of me - so far I've got only three patches in a queue which could be interested for you. Two of them are just cherry-picked from trunk (so I'm not sure whether this should bother you or not). The remaining one is rather big one - a completely rewritten Oracle DB module, which is still in a w.i.p. stage and still not ready for a merge. Just for the record - currently available db_oracle module works fine now (all our critical patches were already merged - thanks for that!) so this one isn't required for normal operation. We plan to split it into smaller patches and improve it a bit - it contains some hardcoded magic and several questionable changes thus it's not ready for mass usage. First two patches (simply backported from trunk so technically OpenSIPS already has them): * https://github.com/lemenkov/OpenSIPS/commit/0c03a3e * https://github.com/lemenkov/OpenSIPS/commit/a8aebfb Oracle-related one (not ready yet - just for the reference) * https://github.com/lemenkov/OpenSIPS/commit/56b1863 And a complete tree (with unrelated stuff): * https://github.com/lemenkov/OpenSIPS/commits/1.8.x-ipport PS I still hope that you will consider switching OpenSIPS to Git someday. -- With best regards, Peter Lemenkov. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] Time to release 1.8.1?
Hello All. It have been added more than a hundred of patches (which is huge) since tagging 1.8.0. Maybe it's time to release 1.8.1? -- With best regards, Peter Lemenkov. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] SF.net SVN: opensips:[9121] trunk
Hello Razvan! 2012/6/27 Razvan Crainea raz...@opensips.org: Revision: 9121 http://opensips.svn.sourceforge.net/opensips/?rev=9121view=rev Author: razvancrainea Date: 2012-06-27 10:55:13 + (Wed, 27 Jun 2012) Log Message: --- Fixed NICER variable Could you please backport this to 1.8 branch? Looks harmless but handy. -- With best regards, Peter Lemenkov. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [PATCH 1/1] Check for stale nonce in pre_auth
Check for stale nonce in pre_auth, before actual auth request. It decreases
dramatically the number of requests to the actual auth backend thus improving
performance greatly. Take a look at the following plot where the results of
this patch can be seen clearly:
http://twitpic.com/3k66ri
Signed-off-by: Peter Lemenkov lemen...@gmail.com
---
modules/auth/api.c | 35 ++-
1 files changed, 18 insertions(+), 17 deletions(-)
diff --git a/modules/auth/api.c b/modules/auth/api.c
index f076e85..ea54f20 100644
--- a/modules/auth/api.c
+++ b/modules/auth/api.c
@@ -215,6 +215,12 @@ auth_result_t pre_auth(struct sip_msg* _m, str* _realm,
hdr_types_t _hftype,
return ERROR;
}
+ if (is_nonce_stale(c-digest.nonce)) {
+ LM_DBG(stale nonce value received\n);
+ c-stale = 1;
+ return STALE_NONCE;
+ }
+
if (check_nonce(c-digest.nonce, secret) != 0) {
LM_DBG(invalid nonce value received\n);
c-stale = 1;
@@ -240,27 +246,22 @@ auth_result_t post_auth(struct sip_msg* _m, struct
hdr_field* _h)
(_m-REQ_METHOD == METHOD_CANCEL))
return AUTHORIZED;
- if (is_nonce_stale(c-digest.nonce)) {
- LM_DBG(response is OK, but nonce is stale\n);
+ if(!disable_nonce_check) {
+ /* Verify if it is the first time this nonce is received */
+ index= get_nonce_index(c-digest.nonce);
+ if(index== -1) {
+ LM_ERR(failed to extract nonce index\n);
+ return ERROR;
+ }
+ LM_DBG(nonce index= %d\n, index);
+
+ if(!is_nonce_index_valid(index)) {
+ LM_DBG(nonce index not valid\n);
c-stale = 1;
return STALE_NONCE;
- } else {
- if(!disable_nonce_check) {
- /* Verify if it is the first time this nonce is
received */
- index= get_nonce_index(c-digest.nonce);
- if(index== -1) {
- LM_ERR(failed to extract nonce index\n);
- return ERROR;
- }
- LM_DBG(nonce index= %d\n, index);
-
- if(!is_nonce_index_valid(index)) {
- LM_DBG(nonce index not valid\n);
- c-stale = 1;
- return STALE_NONCE;
- }
}
}
+
return AUTHORIZED;
}
--
1.7.6
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [PATCH 1/1] Various cleaus and fixes to the Fedora init-script
* Proper (according to LSB) return values
* Explicitly set up PID_file and lock-file
* Check for running OpenSIPs before some operations
Signed-off-by: Peter Lemenkov lemen...@gmail.com
---
packaging/fedora/opensips.init | 39 ++-
1 files changed, 30 insertions(+), 9 deletions(-)
diff --git a/packaging/fedora/opensips.init b/packaging/fedora/opensips.init
index 40adb88..685d1ef 100644
--- a/packaging/fedora/opensips.init
+++ b/packaging/fedora/opensips.init
@@ -20,28 +20,49 @@
# Source function library.
. /etc/rc.d/init.d/functions
-oser=/usr/sbin/opensips
prog=opensips
+oser=/usr/sbin/$prog
+pidfile=/var/run/$prog.pid
+lockfile=/var/lock/subsys/$prog
+configfile=/etc/$prog/$prog.cfg
+OPTIONS=
+
RETVAL=0
[ -f /etc/sysconfig/$prog ] . /etc/sysconfig/$prog
start() {
echo -n $Starting $prog:
+
+ # check whether OpenSIPs was already started
+ if status $prog /dev/null 21 ; then
+ echo -n already running warning echo
+ return 0
+ fi
+
# there is something at end of this output which is needed to
# report proper [ OK ] status in Fedora scripts
- daemon $oser $OPTIONS 2/dev/null | tail -1
+ daemon $oser -P $pidfile -f $configfile $OPTIONS 2/dev/null | tail -1
RETVAL=$?
echo
- [ $RETVAL = 0 ] touch /var/lock/subsys/$prog
+ [ $RETVAL = 0 ] touch $lockfile
+ return $RETVAL
}
stop() {
echo -n $Stopping $prog:
- killproc $oser
+
+ # check whether OpenSIPs is running
+ if ! status $prog /dev/null 21 ; then
+ echo -n not running warning echo
+ return 0
+ fi
+
+ killproc $prog 2 /dev/null
RETVAL=$?
echo
- [ $RETVAL = 0 ] rm -f /var/lock/subsys/$prog /var/run/$prog.pid
+ [ $RETVAL = 0 ] rm -f $lockfile $pidfile
+ return $RETVAL
}
# See how we were called.
@@ -53,22 +74,22 @@ case $1 in
stop
;;
status)
- status $oser
+ status $prog
RETVAL=$?
;;
restart|reload)
stop
start
;;
- condrestart)
- if [ -f /var/run/opensips.pid ] ; then
+ condrestart|try-restart)
+ if [ -f $pidfile ] ; then
stop
start
fi
;;
*)
echo $Usage: $prog
{start|stop|reload|restart|condrestart|status|help}
- exit 1
+ RETVAL=2
esac
exit $RETVAL
--
1.7.6
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
