[OpenSIPS-Devel] [ opensips-Bugs-3574453 ] b2b_logic: too small setup timeout when topology hiding
Bugs item #3574453, was opened at 2012-10-04 05:25 Message generated for change (Comment added) made by nikbyte You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: Fixed Priority: 7 Private: No Submitted By: Nick Altmann (nikbyte) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: b2b_logic: too small setup timeout when topology hiding Initial Comment: When b2b creates topology hiding scenario, it setups too small call setup time: /* if it will not be confirmed - delete */ tuple-lifetime = 60 + get_ticks(); When alice calls bob and bob don't answer for 60 seconds, b2b send CANCEL to both sides. I think we should give possibility to configure this parameter, either in AVP or b2b_init_request flags like b2b_init_request(top hiding/t300). I'd can to write the patch after discussion about what method to use. -- Comment By: Nick Altmann (nikbyte) Date: 2012-10-30 02:27 Message: Trunk - patch works as expected. 1.8 - docs patch uploaded (opensips_1.8_b2bl_th_init_timeout_docs.patch) -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-29 05:10 Message: Nick, Please do not forget to provide patch for docs for patch v1 (used on 1.8). Thanks and regards, Bogdan -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-26 03:39 Message: Hi Nick, Thank you for your patches - for 1.8 I uploaded the fix with the minimal change (v1) - but please provide a small patch with the corresponding docs. For trunk I used the v3 patch, with some changes - please let me know if still works ok :). Regards, Bogdan -- Comment By: Nick Altmann (nikbyte) Date: 2012-10-22 04:34 Message: Look at new patch please (opensips_b2bl_tc_init_time_v3.patch). -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-21 08:01 Message: Hi Nick, I will go for v2, but I have some objection regarding your approach - I see you moved the scenario lookup from the fixup function to runtime part, which is totally inefficient - instead of doing the lookup once, you do it for each call. What I suggest here is to do both the scenario lookup and the flag detection in the fixup function. You can simply do that by replacing the param 1 (after fixup) with a structure (pkg) holding the scenario ID (as originally) plus the flag string. Or even better, the structure can already parse expend the flags, so that at runtime you have everything prepared. If you have doubts on how to do this, just let me know and I will do it as soon as I'll get available time. Regards, Bogdan -- Comment By: Nick Altmann (nikbyte) Date: 2012-10-15 05:10 Message: Here are two patches: 1. opensips_b2bl_tc_init_time_v1.patch Adds module param b2bl_th_init_timeout with default value 60 to setup initial b2b timeout for topology hiding scenario. 2. opensips_b2bl_tc_init_time_v1.patch Adds module parameter as previous patch, but also adds per b2b session flag t[number] for b2b_init_request. Usage examples: b2b_init_request(top hiding/t60), b2b_init_request(top hiding/t300). Number length is not fixed. You may choose. :-) If one or another patch will be applied, I'll add documentation patch for it. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-12 07:04 Message: Hi Nick, Normally the lifetime is controlled via the scenario XML, so it is per scenario. Of course, the TH does not have a scenario XML. I would go for a module param or by a flag-like approach - depending if we want to control this per scenario (like for other cases) or per instance of scenario. Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3574453 ] b2b_logic: too small setup timeout when topology hiding
Bugs item #3574453, was opened at 2012-10-04 05:25 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Closed Resolution: Fixed Priority: 7 Private: No Submitted By: Nick Altmann (nikbyte) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: b2b_logic: too small setup timeout when topology hiding Initial Comment: When b2b creates topology hiding scenario, it setups too small call setup time: /* if it will not be confirmed - delete */ tuple-lifetime = 60 + get_ticks(); When alice calls bob and bob don't answer for 60 seconds, b2b send CANCEL to both sides. I think we should give possibility to configure this parameter, either in AVP or b2b_init_request flags like b2b_init_request(top hiding/t300). I'd can to write the patch after discussion about what method to use. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-30 03:13 Message: Doc patch uploaded, thank you! Regards, Bogdan -- Comment By: Nick Altmann (nikbyte) Date: 2012-10-30 02:27 Message: Trunk - patch works as expected. 1.8 - docs patch uploaded (opensips_1.8_b2bl_th_init_timeout_docs.patch) -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-29 05:10 Message: Nick, Please do not forget to provide patch for docs for patch v1 (used on 1.8). Thanks and regards, Bogdan -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-26 03:39 Message: Hi Nick, Thank you for your patches - for 1.8 I uploaded the fix with the minimal change (v1) - but please provide a small patch with the corresponding docs. For trunk I used the v3 patch, with some changes - please let me know if still works ok :). Regards, Bogdan -- Comment By: Nick Altmann (nikbyte) Date: 2012-10-22 04:34 Message: Look at new patch please (opensips_b2bl_tc_init_time_v3.patch). -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-21 08:01 Message: Hi Nick, I will go for v2, but I have some objection regarding your approach - I see you moved the scenario lookup from the fixup function to runtime part, which is totally inefficient - instead of doing the lookup once, you do it for each call. What I suggest here is to do both the scenario lookup and the flag detection in the fixup function. You can simply do that by replacing the param 1 (after fixup) with a structure (pkg) holding the scenario ID (as originally) plus the flag string. Or even better, the structure can already parse expend the flags, so that at runtime you have everything prepared. If you have doubts on how to do this, just let me know and I will do it as soon as I'll get available time. Regards, Bogdan -- Comment By: Nick Altmann (nikbyte) Date: 2012-10-15 05:10 Message: Here are two patches: 1. opensips_b2bl_tc_init_time_v1.patch Adds module param b2bl_th_init_timeout with default value 60 to setup initial b2b timeout for topology hiding scenario. 2. opensips_b2bl_tc_init_time_v1.patch Adds module parameter as previous patch, but also adds per b2b session flag t[number] for b2b_init_request. Usage examples: b2b_init_request(top hiding/t60), b2b_init_request(top hiding/t300). Number length is not fixed. You may choose. :-) If one or another patch will be applied, I'll add documentation patch for it. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-12 07:04 Message: Hi Nick, Normally the lifetime is controlled via the scenario XML, so it is per scenario. Of course, the TH does not have a scenario XML. I would go for a module param or by a flag-like approach - depending if we want to control this per scenario (like for other cases) or per instance of scenario. Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3574453 ] b2b_logic: too small setup timeout when topology hiding
Bugs item #3574453, was opened at 2012-10-04 05:25 Message generated for change (Settings changed) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: Fixed Priority: 7 Private: No Submitted By: Nick Altmann (nikbyte) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: b2b_logic: too small setup timeout when topology hiding Initial Comment: When b2b creates topology hiding scenario, it setups too small call setup time: /* if it will not be confirmed - delete */ tuple-lifetime = 60 + get_ticks(); When alice calls bob and bob don't answer for 60 seconds, b2b send CANCEL to both sides. I think we should give possibility to configure this parameter, either in AVP or b2b_init_request flags like b2b_init_request(top hiding/t300). I'd can to write the patch after discussion about what method to use. -- Comment By: Nick Altmann (nikbyte) Date: 2012-10-22 04:34 Message: Look at new patch please (opensips_b2bl_tc_init_time_v3.patch). -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-21 08:01 Message: Hi Nick, I will go for v2, but I have some objection regarding your approach - I see you moved the scenario lookup from the fixup function to runtime part, which is totally inefficient - instead of doing the lookup once, you do it for each call. What I suggest here is to do both the scenario lookup and the flag detection in the fixup function. You can simply do that by replacing the param 1 (after fixup) with a structure (pkg) holding the scenario ID (as originally) plus the flag string. Or even better, the structure can already parse expend the flags, so that at runtime you have everything prepared. If you have doubts on how to do this, just let me know and I will do it as soon as I'll get available time. Regards, Bogdan -- Comment By: Nick Altmann (nikbyte) Date: 2012-10-15 05:10 Message: Here are two patches: 1. opensips_b2bl_tc_init_time_v1.patch Adds module param b2bl_th_init_timeout with default value 60 to setup initial b2b timeout for topology hiding scenario. 2. opensips_b2bl_tc_init_time_v1.patch Adds module parameter as previous patch, but also adds per b2b session flag t[number] for b2b_init_request. Usage examples: b2b_init_request(top hiding/t60), b2b_init_request(top hiding/t300). Number length is not fixed. You may choose. :-) If one or another patch will be applied, I'll add documentation patch for it. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-12 07:04 Message: Hi Nick, Normally the lifetime is controlled via the scenario XML, so it is per scenario. Of course, the TH does not have a scenario XML. I would go for a module param or by a flag-like approach - depending if we want to control this per scenario (like for other cases) or per instance of scenario. Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3574453 ] b2b_logic: too small setup timeout when topology hiding
Bugs item #3574453, was opened at 2012-10-04 05:25 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: Fixed Priority: 7 Private: No Submitted By: Nick Altmann (nikbyte) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: b2b_logic: too small setup timeout when topology hiding Initial Comment: When b2b creates topology hiding scenario, it setups too small call setup time: /* if it will not be confirmed - delete */ tuple-lifetime = 60 + get_ticks(); When alice calls bob and bob don't answer for 60 seconds, b2b send CANCEL to both sides. I think we should give possibility to configure this parameter, either in AVP or b2b_init_request flags like b2b_init_request(top hiding/t300). I'd can to write the patch after discussion about what method to use. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-26 03:39 Message: Hi Nick, Thank you for your patches - for 1.8 I uploaded the fix with the minimal change (v1) - but please provide a small patch with the corresponding docs. For trunk I used the v3 patch, with some changes - please let me know if still works ok :). Regards, Bogdan -- Comment By: Nick Altmann (nikbyte) Date: 2012-10-22 04:34 Message: Look at new patch please (opensips_b2bl_tc_init_time_v3.patch). -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-21 08:01 Message: Hi Nick, I will go for v2, but I have some objection regarding your approach - I see you moved the scenario lookup from the fixup function to runtime part, which is totally inefficient - instead of doing the lookup once, you do it for each call. What I suggest here is to do both the scenario lookup and the flag detection in the fixup function. You can simply do that by replacing the param 1 (after fixup) with a structure (pkg) holding the scenario ID (as originally) plus the flag string. Or even better, the structure can already parse expend the flags, so that at runtime you have everything prepared. If you have doubts on how to do this, just let me know and I will do it as soon as I'll get available time. Regards, Bogdan -- Comment By: Nick Altmann (nikbyte) Date: 2012-10-15 05:10 Message: Here are two patches: 1. opensips_b2bl_tc_init_time_v1.patch Adds module param b2bl_th_init_timeout with default value 60 to setup initial b2b timeout for topology hiding scenario. 2. opensips_b2bl_tc_init_time_v1.patch Adds module parameter as previous patch, but also adds per b2b session flag t[number] for b2b_init_request. Usage examples: b2b_init_request(top hiding/t60), b2b_init_request(top hiding/t300). Number length is not fixed. You may choose. :-) If one or another patch will be applied, I'll add documentation patch for it. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-12 07:04 Message: Hi Nick, Normally the lifetime is controlled via the scenario XML, so it is per scenario. Of course, the TH does not have a scenario XML. I would go for a module param or by a flag-like approach - depending if we want to control this per scenario (like for other cases) or per instance of scenario. Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3574453 ] b2b_logic: too small setup timeout when topology hiding
Bugs item #3574453, was opened at 2012-10-04 05:25 Message generated for change (Comment added) made by nikbyte You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: Accepted Priority: 5 Private: No Submitted By: Nick Altmann (nikbyte) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: b2b_logic: too small setup timeout when topology hiding Initial Comment: When b2b creates topology hiding scenario, it setups too small call setup time: /* if it will not be confirmed - delete */ tuple-lifetime = 60 + get_ticks(); When alice calls bob and bob don't answer for 60 seconds, b2b send CANCEL to both sides. I think we should give possibility to configure this parameter, either in AVP or b2b_init_request flags like b2b_init_request(top hiding/t300). I'd can to write the patch after discussion about what method to use. -- Comment By: Nick Altmann (nikbyte) Date: 2012-10-22 04:34 Message: Look at new patch please (opensips_b2bl_tc_init_time_v3.patch). -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-21 08:01 Message: Hi Nick, I will go for v2, but I have some objection regarding your approach - I see you moved the scenario lookup from the fixup function to runtime part, which is totally inefficient - instead of doing the lookup once, you do it for each call. What I suggest here is to do both the scenario lookup and the flag detection in the fixup function. You can simply do that by replacing the param 1 (after fixup) with a structure (pkg) holding the scenario ID (as originally) plus the flag string. Or even better, the structure can already parse expend the flags, so that at runtime you have everything prepared. If you have doubts on how to do this, just let me know and I will do it as soon as I'll get available time. Regards, Bogdan -- Comment By: Nick Altmann (nikbyte) Date: 2012-10-15 05:10 Message: Here are two patches: 1. opensips_b2bl_tc_init_time_v1.patch Adds module param b2bl_th_init_timeout with default value 60 to setup initial b2b timeout for topology hiding scenario. 2. opensips_b2bl_tc_init_time_v1.patch Adds module parameter as previous patch, but also adds per b2b session flag t[number] for b2b_init_request. Usage examples: b2b_init_request(top hiding/t60), b2b_init_request(top hiding/t300). Number length is not fixed. You may choose. :-) If one or another patch will be applied, I'll add documentation patch for it. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-12 07:04 Message: Hi Nick, Normally the lifetime is controlled via the scenario XML, so it is per scenario. Of course, the TH does not have a scenario XML. I would go for a module param or by a flag-like approach - depending if we want to control this per scenario (like for other cases) or per instance of scenario. Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3574453 ] b2b_logic: too small setup timeout when topology hiding
Bugs item #3574453, was opened at 2012-10-04 05:25 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: Accepted Priority: 5 Private: No Submitted By: Nick Altmann (nikbyte) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: b2b_logic: too small setup timeout when topology hiding Initial Comment: When b2b creates topology hiding scenario, it setups too small call setup time: /* if it will not be confirmed - delete */ tuple-lifetime = 60 + get_ticks(); When alice calls bob and bob don't answer for 60 seconds, b2b send CANCEL to both sides. I think we should give possibility to configure this parameter, either in AVP or b2b_init_request flags like b2b_init_request(top hiding/t300). I'd can to write the patch after discussion about what method to use. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-21 08:01 Message: Hi Nick, I will go for v2, but I have some objection regarding your approach - I see you moved the scenario lookup from the fixup function to runtime part, which is totally inefficient - instead of doing the lookup once, you do it for each call. What I suggest here is to do both the scenario lookup and the flag detection in the fixup function. You can simply do that by replacing the param 1 (after fixup) with a structure (pkg) holding the scenario ID (as originally) plus the flag string. Or even better, the structure can already parse expend the flags, so that at runtime you have everything prepared. If you have doubts on how to do this, just let me know and I will do it as soon as I'll get available time. Regards, Bogdan -- Comment By: Nick Altmann (nikbyte) Date: 2012-10-15 05:10 Message: Here are two patches: 1. opensips_b2bl_tc_init_time_v1.patch Adds module param b2bl_th_init_timeout with default value 60 to setup initial b2b timeout for topology hiding scenario. 2. opensips_b2bl_tc_init_time_v1.patch Adds module parameter as previous patch, but also adds per b2b session flag t[number] for b2b_init_request. Usage examples: b2b_init_request(top hiding/t60), b2b_init_request(top hiding/t300). Number length is not fixed. You may choose. :-) If one or another patch will be applied, I'll add documentation patch for it. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-12 07:04 Message: Hi Nick, Normally the lifetime is controlled via the scenario XML, so it is per scenario. Of course, the TH does not have a scenario XML. I would go for a module param or by a flag-like approach - depending if we want to control this per scenario (like for other cases) or per instance of scenario. Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3574453 ] b2b_logic: too small setup timeout when topology hiding
Bugs item #3574453, was opened at 2012-10-04 05:25 Message generated for change (Comment added) made by nikbyte You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nick Altmann (nikbyte) Assigned to: Nobody/Anonymous (nobody) Summary: b2b_logic: too small setup timeout when topology hiding Initial Comment: When b2b creates topology hiding scenario, it setups too small call setup time: /* if it will not be confirmed - delete */ tuple-lifetime = 60 + get_ticks(); When alice calls bob and bob don't answer for 60 seconds, b2b send CANCEL to both sides. I think we should give possibility to configure this parameter, either in AVP or b2b_init_request flags like b2b_init_request(top hiding/t300). I'd can to write the patch after discussion about what method to use. -- Comment By: Nick Altmann (nikbyte) Date: 2012-10-15 05:10 Message: Here are two patches: 1. opensips_b2bl_tc_init_time_v1.patch Adds module param b2bl_th_init_timeout with default value 60 to setup initial b2b timeout for topology hiding scenario. 2. opensips_b2bl_tc_init_time_v1.patch Adds module parameter as previous patch, but also adds per b2b session flag t[number] for b2b_init_request. Usage examples: b2b_init_request(top hiding/t60), b2b_init_request(top hiding/t300). Number length is not fixed. You may choose. :-) If one or another patch will be applied, I'll add documentation patch for it. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-12 07:04 Message: Hi Nick, Normally the lifetime is controlled via the scenario XML, so it is per scenario. Of course, the TH does not have a scenario XML. I would go for a module param or by a flag-like approach - depending if we want to control this per scenario (like for other cases) or per instance of scenario. Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3574453 ] b2b_logic: too small setup timeout when topology hiding
Bugs item #3574453, was opened at 2012-10-04 05:25 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nick Altmann (nikbyte) Assigned to: Nobody/Anonymous (nobody) Summary: b2b_logic: too small setup timeout when topology hiding Initial Comment: When b2b creates topology hiding scenario, it setups too small call setup time: /* if it will not be confirmed - delete */ tuple-lifetime = 60 + get_ticks(); When alice calls bob and bob don't answer for 60 seconds, b2b send CANCEL to both sides. I think we should give possibility to configure this parameter, either in AVP or b2b_init_request flags like b2b_init_request(top hiding/t300). I'd can to write the patch after discussion about what method to use. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2012-10-12 07:04 Message: Hi Nick, Normally the lifetime is controlled via the scenario XML, so it is per scenario. Of course, the TH does not have a scenario XML. I would go for a module param or by a flag-like approach - depending if we want to control this per scenario (like for other cases) or per instance of scenario. Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3574453 ] b2b_logic: too small setup timeout when topology hiding
Bugs item #3574453, was opened at 2012-10-04 05:25 Message generated for change (Tracker Item Submitted) made by nikbyte You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nick Altmann (nikbyte) Assigned to: Nobody/Anonymous (nobody) Summary: b2b_logic: too small setup timeout when topology hiding Initial Comment: When b2b creates topology hiding scenario, it setups too small call setup time: /* if it will not be confirmed - delete */ tuple-lifetime = 60 + get_ticks(); When alice calls bob and bob don't answer for 60 seconds, b2b send CANCEL to both sides. I think we should give possibility to configure this parameter, either in AVP or b2b_init_request flags like b2b_init_request(top hiding/t300). I'd can to write the patch after discussion about what method to use. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3574453group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
