Re: [OpenSIPS-Devel] [opensips] fix for RFC5245 15.1 compliant candidate injection (#264)

2015-01-06 Thread Bogdan Andrei IANCU
Hi @saghul - could you take a short look and validate this minor change. Thank 
you, Bogdan

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/264#issuecomment-68851342___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSIPS-Devel] [opensips] fix for RFC5245 15.1 compliant candidate injection (#264)

2015-01-06 Thread Saúl Ibarra Corretgé
LGTM :+1: 

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/264#issuecomment-68852110___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSIPS-Devel] [opensips] fix for RFC5245 15.1 compliant candidate injection (#264)

2015-01-06 Thread Bogdan Andrei IANCU
Merged #264.

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/264#event-214617574___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSIPS-Devel] [opensips] fix for RFC5245 15.1 compliant candidate injection (#264)

2015-01-06 Thread Bogdan Andrei IANCU
Thank you @saghul 

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/264#issuecomment-68853375___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


[OpenSIPS-Devel] [opensips] fix for RFC5245 15.1 compliant candidate injection (#264)

2014-07-02 Thread Eric Tamme
 lt;rel-addrgt; and lt;rel-portgt; MUST be present for server reflexive, 
peer, and relay candidates
You can merge this Pull Request by running:

  git pull https://github.com/etamme/opensips mediaproxy-rfc5245fix

Or you can view, comment on it, or merge it online at:

  https://github.com/OpenSIPS/opensips/pull/264

-- Commit Summary --

  * fix for RFC5245 15.1 lt;rel-addrgt; and lt;rel-portgt; MUST be present 
for server reflexive, peer, and relay candidates

-- File Changes --

M modules/mediaproxy/mediaproxy.c (8)

-- Patch Links --

https://github.com/OpenSIPS/opensips/pull/264.patch
https://github.com/OpenSIPS/opensips/pull/264.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/264
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel