[OpenSIPS-Devel] SF.net SVN: opensips:[6043] branches/1.5/modules/rls/subscribe.c

2009-08-28 Thread Anca Vamanu 
Revision: 6043
  http://opensips.svn.sourceforge.net/opensips/?rev=6043view=rev
Author:   anca_vamanu
Date: 2009-08-28 12:40:44 + (Fri, 28 Aug 2009)

Log Message:
---
- if an indialog Subscribe does not match a known dialog, send the Subscribe to 
presence server (reported by Juha Heinanen)

Modified Paths:
--
branches/1.5/modules/rls/subscribe.c


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

[OpenSIPS-Devel] SF.net SVN: opensips:[6043] branches/1.5/modules/rls/subscribe.c

2009-08-28 Thread Juha Heinanen 
Anca Vamanu writes:

  - if an indialog Subscribe does not match a known dialog, send the
  - Subscribe to presence server (reported by Juha Heinanen)

anca,

thanks for the fix.

after thinking a bit more this, it should be possible to distinguish in
script if an initial subscribe possibly is for rls server, because
normal subscribes are for uris of local users.  so if target of
subscribe is not for a local user, handle it with rls_handle_subscribe
and return 404 if it fails.

-- juha

___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] SF.net SVN: opensips:[6043] branches/1.5/modules/rls/subscribe.c

2009-08-28 Thread Adrian Georgescu 

On Aug 28, 2009, at 3:01 PM, Juha Heinanen wrote:

 Anca Vamanu writes:

 - if an indialog Subscribe does not match a known dialog, send the
 - Subscribe to presence server (reported by Juha Heinanen)

 anca,

 thanks for the fix.

 after thinking a bit more this, it should be possible to distinguish  
 in
 script if an initial subscribe possibly is for rls server, because
 normal subscribes are for uris of local users.

You can subscribe also to users of remote domains and they are not  
local.

  so if target of
 subscribe is not for a local user, handle it with rls_handle_subscribe
 and return 404 if it fails.

This is wrong for the reason above.

There was a reason for handling the way it was, too bad Dan is in  
holiday and could not comment.

Adrian


 -- juha

 ___
 Devel mailing list
 Devel@lists.opensips.org
 http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


--
Adrian






___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] SF.net SVN: opensips:[6043] branches/1.5/modules/rls/subscribe.c

2009-08-28 Thread Juha Heinanen 
Adrian Georgescu writes:

  You can subscribe also to users of remote domains and they are not  
  local.

sure, but in that case, i'm not calling handle_subscribe, but just
t_relay the request.

so if target of
   subscribe is not for a local user, handle it with rls_handle_subscribe
   and return 404 if it fails.
  
  This is wrong for the reason above.

sorry, i meant, user part of uri does not belong to existing user, but
host part is a local domain.

  There was a reason for handling the way it was, too bad Dan is in  
  holiday and could not comment.

the way it was does not work if you plan to call handle_subscribe after
rls_handle_subscribe.

there is two possible implementations of rls_handle_subscribe:

- do not do any smarts in the implementation, but leave it to the script
  to figure out when to call rls_subscribe

- do smarts the way they are done now

they way the smarts were done earlier, was not correct.

-- juha

___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel