Re: [OpenSIPS-Devel] Parsing the xcap-diff event
Hi Saul, On 01/20/2011 10:58 PM, Saúl Ibarra Corretgé wrote: I just uploaded the patch to the tracker: https://sourceforge.net/tracker/?func=detailaid=3162970group_id=232389atid=1086412 If you are fine with it (it was very minor actually :-) ) I can commit it and backport it to the 1.6 branch if it's appropriate. Regards, Yes, go ahead and commit it. Regards, -- Anca Vamanu www.voice-system.ro ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Parsing the xcap-diff event
Hi, Yes, sure go ahead and make the patch. I prefer also replacing xcap-change with xcap-diff. I just uploaded the patch to the tracker: https://sourceforge.net/tracker/?func=detailaid=3162970group_id=232389atid=1086412 If you are fine with it (it was very minor actually :-) ) I can commit it and backport it to the 1.6 branch if it's appropriate. Regards, -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Parsing the xcap-diff event
Hi Saul, On 01/07/2011 10:13 AM, Saúl Ibarra Corretgé wrote: Hi Anca and all, I think this came up in the mailing list a while ago, but I lost track of it, so here it goes again :-) The current OpenSIPS trunk does have code to parse the old xcap-change event but it lacks the ability to parse the xcap-diff event. Even if presence_xcapdiff is loaded the event is not recognized because seems like it needs to be defined in parse_event.c/.h so that it is parsed (please correct me if I'm wrong). My proposal is to replace xcap-change (which is an expired draft since 2005 and no module seems to use it) with event xcap-diff, which is now RFC5874. Or we can just add xcap-diff as a new event. If there are no objections I can make a patch for this. Yes, sure go ahead and make the patch. I prefer also replacing xcap-change with xcap-diff. Regards, Anca ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel