[Devel] Re: [PATCH v2 -mmotm 2/4] cgroups: remove events before destroying subsystem state objects
* Kirill A. Shutemov kir...@shutemov.name [2010-02-22 17:43:40]: Events should be removed after rmdir of cgroup directory, but before destroying subsystem state objects. Let's take reference to cgroup directory dentry to do that. Signed-off-by: Kirill A. Shutemov kir...@shutemov.name Acked-by: KAMEZAWA Hiroyuki kamezawa.hio...@jp.fujitsu.com Looks good, but remember the mem_cgroup data structure will can disappear after the rmdir -- Three Cheers, Balbir ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel
[Devel] Re: [PATCH v2 -mmotm 2/4] cgroups: remove events before destroying subsystem state objects
* Kirill A. Shutemov kir...@shutemov.name [2010-02-24 13:42:15]: On Wed, Feb 24, 2010 at 10:40 AM, Balbir Singh bal...@linux.vnet.ibm.com wrote: * Kirill A. Shutemov kir...@shutemov.name [2010-02-22 17:43:40]: Events should be removed after rmdir of cgroup directory, but before destroying subsystem state objects. Let's take reference to cgroup directory dentry to do that. Signed-off-by: Kirill A. Shutemov kir...@shutemov.name Acked-by: KAMEZAWA Hiroyuki kamezawa.hio...@jp.fujitsu.com Looks good, but remember the mem_cgroup data structure will can disappear after the rmdir IIUC, struct mem_cgroup can be freed only after -destroy(), which can be called only if there is no references to cgroup directory dentry. No.. You've got it right, it disappears after the last dput(). -- Three Cheers, Balbir ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel
[Devel] Re: [PATCH v2 -mmotm 2/4] cgroups: remove events before destroying subsystem state objects
On Wed, Feb 24, 2010 at 10:40 AM, Balbir Singh bal...@linux.vnet.ibm.com wrote: * Kirill A. Shutemov kir...@shutemov.name [2010-02-22 17:43:40]: Events should be removed after rmdir of cgroup directory, but before destroying subsystem state objects. Let's take reference to cgroup directory dentry to do that. Signed-off-by: Kirill A. Shutemov kir...@shutemov.name Acked-by: KAMEZAWA Hiroyuki kamezawa.hio...@jp.fujitsu.com Looks good, but remember the mem_cgroup data structure will can disappear after the rmdir IIUC, struct mem_cgroup can be freed only after -destroy(), which can be called only if there is no references to cgroup directory dentry. Have I missed something? ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel
[Devel] Re: [PATCH v2 -mmotm 2/4] cgroups: remove events before destroying subsystem state objects
Kirill A. Shutemov wrote: Events should be removed after rmdir of cgroup directory, but before destroying subsystem state objects. Let's take reference to cgroup directory dentry to do that. Signed-off-by: Kirill A. Shutemov kir...@shutemov.name Acked-by: KAMEZAWA Hiroyuki kamezawa.hio...@jp.fujitsu.com Looks good. Acked-by: Li Zefan l...@cn.fujitsu.com ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel
