Re: [ovirt-devel] FW: add a ***Command for a button
Hi,
Would you mind posting the code as a draft patch to gerrit.ovirt.org ?
It will allow full transparency of the the code, will allow a better
feedback and also will allow developers to apply the patch locally and
even upload a fixed version of it.
Thanks,
Moti
- Original Message -
From: 力波 王 wlblea...@126.com
To: Devel@ovirt.org
Sent: Friday, August 8, 2014 11:17:15 AM
Subject: [ovirt-devel] FW: add a ***Command for a button
发件人: 力波 王 wlblea...@126.com
日期: Fri, 08 Aug 2014 16:10:48 +0800
至: devel@ovirt.org
主题: [ovirt-devel] add a ***Command for a button
Hi, everyone:
I added a button on the Template Tab, in the client side, It’s OK,
Added the button’s callback like this:
===
private void backup()
{
BackupInfoParameters param = new BackupInfoParameters();
Frontend.RunAction(VdcActionType.Unknown, param, new
IFrontendActionAsyncCallback() {
@Override
public void executed(FrontendActionAsyncResult result) {
}
});
}
===
The BackupInfoCommand.java is :
===
package org.ovirt.engine.core.bll;
import org.ovirt.engine.core.bll.utils.PermissionSubject;
import org.ovirt.engine.core.common.action.BackupInfoParameters;
import java.io.IOException;
import java.util.Collections;
import java.util.List;
/**
* Created by leaboy on 8/7/14.
*/
public class BackupInfoCommand T extends BackupInfoParameters extends
CommandBaseT{
public BackupInfoCommand(T parameters){
super(parameters);
}
@Override
public ListPermissionSubject getPermissionCheckSubjects() {
return Collections.emptyList();
}
@Override
protected boolean canDoAction() {
return true;
}
@Override
protected void executeCommand() {
int a;
a = 1;
try{
Runtime.getRuntime().exec(touch /tmp/tmp.txt);
}catch (IOException e){
e.printStackTrace();
}
}
}
===
And the BackupInfoParameters.java is:
===
package org.ovirt.engine.core.common.action;
/**
* Created by leaboy on 8/7/14.
*/
public class BackupInfoParameters extends VdcActionParametersBase implements
java.io.Serializable{
private static final long serialVersionUID = -1363077467684414051L;
private VdcActionType _actionType;
//public BackupInfoParameters(){}
public BackupInfoParameters(){_actionType = VdcActionType.Unknown;}
public VdcActionType getActionType() {
return _actionType;
}
}
===
Built the code success, but when I clicked the button, got a dialog with the
error info:
Error while executing action: A Request to the Server failed with the
following Status Code: 500
I debug it , find the error is raised at :
protected VdcReturnValueBase evaluateCorrelationId(CommandBase?
commandBase) {
VdcReturnValueBase returnValue = null;
// Evaluate and set the correlationId on the parameters, fails on invalid
correlation id
returnValue =
ExecutionHandler.evaluateCorrelationId(commandBase.getParameters());
if (returnValue != null) {
log.warnFormat(CanDoAction of action {0} failed. Reasons: {1},
commandBase.getActionType(),
StringUtils.join(returnValue.getCanDoActionMessages(), ','));
}
// Set the correlation-id on the command
commandBase.setCorrelationId(commandBase.getParameters().getCorrelationId());
return returnValue;
}
___ Devel mailing list
Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] [ATTN] GWT Debug mode is now 2x faster!
- Original Message - From: Greg Sheremeta gsher...@redhat.com To: devel@ovirt.org Sent: Wednesday, August 6, 2014 3:09:03 PM Subject: [ovirt-devel] [ATTN] GWT Debug mode is now 2x faster! [changing the subject to be more noticeable] All, Alexander did some great work making GWT debug mode at least 2x faster. It is now *very* usable. I have previously avoided it, but now it's pretty awesome. If you have avoided it like me, give it a try! Tip: make gwt-debug DEBUG_MODULE=webadmin DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS=-Dgwt.cssResourceStyle=pretty will un-obfuscate CSS classes for you. Very helpful with debugging UI stuff. Greg Hi Well done Can the README.developer file be modified with this information? Thanks - Original Message - From: Vojtech Szocs vsz...@redhat.com To: devel@ovirt.org Cc: aw...@redhat.com, eco...@redhat.com, gsher...@redhat.com Sent: Wednesday, July 30, 2014 11:19:46 AM Subject: Re: GWT debug slowness. Hi Alex, (adding devel list to share it with others) I really appreciate that you took the time to analyze GWT EventBus activity! As we discussed on IRC, @ProxyEvent in AbstractSubTabPresenter is the most likely cause of overall UI slowness after successful user authentication. Fix for this should be rather easy and harmless, please add me as reviewer once you come up with the relevant patch. Another thing is refresh on logout for all (both) GWT applications. This is mainly due to planned SSO changes (there will be a dedicated interactive login page for entire Engine); for us it means that login section of all GWT applications will be unnecessary. Before that, however, we can already implement refresh on logout. As a nice side effect, we can remove some of our infra (UiCommonInitEvent friends) to make it more simple. Please find some more comments below (inline). Thanks, Vojtech - Original Message - From: Alexander Wels aw...@redhat.com To: vsz...@redhat.com Cc: eco...@redhat.com, gsher...@redhat.com Sent: Friday, July 25, 2014 7:59:56 PM Subject: Re: GWT debug slowness. On Friday, July 25, 2014 09:28:33 AM Alexander Wels wrote: Vojtech, I know you suggested that maybe the event bus was getting overloaded with events might be the cause of the slowness in the GWT debug mode. So I modified the event bus implementation to record the number of events, their handlers, and the occurrences of those events. This is right after the login page is loaded. +---+---+--- + |Type |handlers |fired || +---+---+--- + |event: ApplicationFocusChangeEvent:|0 |2 || event: LockInteractionEvent: |2 |2 | | event: NavigationEvent:|0 |1 || event: PlaceRequestInternalEvent: |111 || |1 | | event: ResetPresentersEvent: |1 | | |1 || event: RevealRootLayoutContentEvent: |1 ||1 | +---+---+--- + Just for clarification: * ApplicationFocusChangeEvent - fired by our infra whenever browser/window gains or looses focus (we use this to throttle UiCommon model refresh timers, i.e. when out of focus, lower the refresh rate) * LockInteractionEvent - fired by GWTP infra, indicates that UI interaction should be avoided because the application is currently in transition from one place to another (in practice, invisible glass div element covers the entire viewport during transition, see RootPresenter.RootView) Note: we had plans to provide some In progress... label (just like you see in Gmail) to make this obvious to end users, there's also RFE on this * NavigationEvent - fired by GWTP infra, it's a hook we don't use * PlaceRequestInternalEvent - fired by GWTP infra, PlaceManagerImpl fires this event to ask all proxies: which one of you can reveal a presenter with name token xxx (i.e. dataCenters-clusters) Note: handler count is high because EACH presenter proxy adds handler for this event. * ResetPresentersEvent - fired by GWTP infra, after transition to new place is complete, trigger onReset lifecycle method on all presenters present on reveal path (from leaf to root) * RevealRootLayoutContentEvent - fired by GWTP infra, this makes GWTP root presenter/view reveal within the browser/window viewport This is right after you login, and the VM main tab is displayed +---+---+--- +
[ovirt-devel] ovirt3.5 - deep dive - foreman bare metal provisioning
BEGIN:VCALENDAR PRODID:Zimbra-Calendar-Provider VERSION:2.0 METHOD:REQUEST BEGIN:VTIMEZONE TZID:Asia/Jerusalem BEGIN:STANDARD DTSTART:16010101T02 TZOFFSETTO:+0200 TZOFFSETFROM:+0300 RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=10;BYDAY=-1SU TZNAME:IST END:STANDARD BEGIN:DAYLIGHT DTSTART:16010101T02 TZOFFSETTO:+0300 TZOFFSETFROM:+0200 RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=3;BYDAY=-1FR TZNAME:IDT END:DAYLIGHT END:VTIMEZONE BEGIN:VEVENT UID:d716b750-dc83-4df2-b2ec-eb83337d6e77 SUMMARY:ovirt3.5 - deep dive - foreman bare metal provisioning ATTENDEE;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE:mailto:users@o virt.org ATTENDEE;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE:mailto:devel@o virt.org ATTENDEE;CN=ybronhei;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE:ma ilto:ybron...@redhat.com ATTENDEE;CN=Oved Ourfalli;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TR UE:mailto:ov...@redhat.com ORGANIZER;CN=Barak Azulay:mailto:bazu...@redhat.com DTSTART;TZID=Asia/Jerusalem:20140812T17 DTEND;TZID=Asia/Jerusalem:20140812T173000 STATUS:CONFIRMED CLASS:PUBLIC X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY TRANSP:OPAQUE LAST-MODIFIED:20140810T222408Z DTSTAMP:20140810T222408Z SEQUENCE:0 DESCRIPTION:The following is a new meeting request:\n\nSubject: ovirt3.5 - d eep dive - foreman bare metal provisioning \nOrganizer: Barak Azulay bazu l...@redhat.com \n\nTime: Tuesday\, August 12\, 2014\, 5:00:00 PM - 5:30:00 PM GMT +02:00 Jerusalem\n \nInvitees: us...@ovirt.org\; devel@ovirt.org\; yb ron...@redhat.com\; ov...@redhat.com \n\n\n*~*~*~*~*~*~*~*~*~*\n\nThis sessi on will introduce the integration with foreman bare metal provisioning with oVirt.\n\nDetails will be published soon.\n\n BEGIN:VALARM ACTION:DISPLAY TRIGGER;RELATED=START:-PT5M DESCRIPTION:Reminder END:VALARM END:VEVENT END:VCALENDAR___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Intro
Hi Michal On Fri, Aug 8, 2014 at 8:14 PM, Michal Skrivanek michal.skriva...@redhat.com wrote: On 8 Aug 2014, at 02:43, Colin Coe wrote: Hi all I'm a long time RHEV admin (since 2.1/2.2 days). I'm in the process of getting a dev workstation built to do some hacking to resolve some small issues that are explained below. 1) The business is moving to thin clients for specific users. We're using IGEL thin clients in appliance mode. We have a problem where if the user (in the User Portal) clicks on the Client Resources hyperlink, a new browse window comes up that the user cannot move or dismiss. I figure the easiest way to resolve this is to put a Close button on the Client Resources page. Would this be acceptable to the project? What is the browser on the IGEL client? Are you talking about RHEV or oVirt? Either way it's a branding item..you can as well disable/remove the link completely as I suppose it's not really relevant on a thin client The IGEL client runs Firefox. From memory the OS is Ubuntu 10.4. We're talking RHEV not oVirt. What do you mean a branding item? Do you mean I can change this? 2) In the power User Portal, VM descriptions are shown in parentheses. In the normal User Portal the description is not shown. I'd like to have the description shown in the normal User Portal also, maybe in parentheses on a new line between the VM name and the VM's icon. Is this acceptable to the project? should be easy enough. care to file a bug for it? Sure. BZ 1128501 3) Lastly, the normal user portal shows the VM image and to get a console, a double click is required. This is pretty much universally hated by our users :( The Power User Portal single click is loved by our users but I don't want to to give them the added capabilities in the Power User Portal. Would it be acceptable to the project to change the double click to the same single click as in the Power User Portal? there's a new button now in 3.5 Great! Thanks, michal Thanks CC -- RHCE#805007969328369 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel -- RHCE#805007969328369 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
