[ovirt-devel] engine-setup broken in master?

2015-06-25 Thread Omer Frenkel
Hi,
on latest master, engine-setup fails for me with:
[ ERROR ] Failed to execute stage 'Setup validation': Failed checking Engine 
database: [u''] 

from the setup log:

2015-06-25 10:27:51 DEBUG 
otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations 
plugin.execute:940 execute-output: 
['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu
tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost', '--port=5432', 
'--database=**FILTERED**', 
'--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506
25102702-nwwazb.log'] stderr:
ERROR:  function fn_db_validate_fks(boolean, boolean) does not exist
LINE 3: from fn_db_validate_fks(false, 0 != 0)
 ^
HINT:  No function matches the given name and argument types. You might need to 
add explicit type casts.

2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155 method 
exception
Traceback (most recent call last):
  File /usr/lib/python2.7/site-packages/otopi/context.py, line 145, in 
_executeMethod
method['method']()
  File 
/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
 line 128, in _validation
violations, issues_found = self._checkDb()
  File 
/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
 line 91, in _checkDb
output=stdout,
RuntimeError: Failed checking Engine database:
[u'']

2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164 Failed to 
execute stage 'Setup validation': Failed checking Engine database:
[u'']



looks like lately this function (fn_db_validate_fks) was moved, might be 
related?
( https://gerrit.ovirt.org/#/c/42655/ )

i even tried to completely remove my ~/ovirt-engine/ folder and create from 
scratch

anyone else experienced this?

Thanks,
Omer.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] engine-setup broken in master?

2015-06-25 Thread Oved Ourfali
Hi

I've just checked-out latest master, built the engine, targeting a new 
directory, new DB schema, and it worked well.

Can you re-test it?

Thanks,
Oved

- Original Message -
 From: Omer Frenkel ofren...@redhat.com
 To: devel@ovirt.org
 Sent: Thursday, June 25, 2015 10:37:55 AM
 Subject: [ovirt-devel] engine-setup broken in master?
 
 Hi,
 on latest master, engine-setup fails for me with:
 [ ERROR ] Failed to execute stage 'Setup validation': Failed checking Engine
 database: [u'']
 
 from the setup log:
 
 2015-06-25 10:27:51 DEBUG
 otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations
 plugin.execute:940 execute-output:
 ['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu
 tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost',
 '--port=5432', '--database=**FILTERED**',
 '--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506
 25102702-nwwazb.log'] stderr:
 ERROR:  function fn_db_validate_fks(boolean, boolean) does not exist
 LINE 3: from fn_db_validate_fks(false, 0 != 0)
  ^
 HINT:  No function matches the given name and argument types. You might need
 to add explicit type casts.
 
 2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155 method
 exception
 Traceback (most recent call last):
   File /usr/lib/python2.7/site-packages/otopi/context.py, line 145, in
   _executeMethod
 method['method']()
   File
   
 /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
   line 128, in _validation
 violations, issues_found = self._checkDb()
   File
   
 /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
   line 91, in _checkDb
 output=stdout,
 RuntimeError: Failed checking Engine database:
 [u'']
 
 2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164 Failed to
 execute stage 'Setup validation': Failed checking Engine database:
 [u'']
 
 
 
 looks like lately this function (fn_db_validate_fks) was moved, might be
 related?
 ( https://gerrit.ovirt.org/#/c/42655/ )
 
 i even tried to completely remove my ~/ovirt-engine/ folder and create from
 scratch
 
 anyone else experienced this?
 
 Thanks,
 Omer.
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] engine-setup broken in master?

2015-06-25 Thread Roy Golan

Dudi hit the same issue.

On 06/25/2015 10:37 AM, Omer Frenkel wrote:

Hi,
on latest master, engine-setup fails for me with:
[ ERROR ] Failed to execute stage 'Setup validation': Failed checking Engine 
database: [u'']

from the setup log:

2015-06-25 10:27:51 DEBUG 
otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations 
plugin.execute:940 execute-output: 
['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu
tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost', '--port=5432', 
'--database=**FILTERED**', 
'--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506
25102702-nwwazb.log'] stderr:
ERROR:  function fn_db_validate_fks(boolean, boolean) does not exist
LINE 3: from fn_db_validate_fks(false, 0 != 0)
  ^
HINT:  No function matches the given name and argument types. You might need to 
add explicit type casts.

2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155 method 
exception
Traceback (most recent call last):
   File /usr/lib/python2.7/site-packages/otopi/context.py, line 145, in 
_executeMethod
 method['method']()
   File 
/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
 line 128, in _validation
 violations, issues_found = self._checkDb()
   File 
/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
 line 91, in _checkDb
 output=stdout,
RuntimeError: Failed checking Engine database:
[u'']

2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164 Failed to 
execute stage 'Setup validation': Failed checking Engine database:
[u'']



looks like lately this function (fn_db_validate_fks) was moved, might be 
related?
( https://gerrit.ovirt.org/#/c/42655/ )

i even tried to completely remove my ~/ovirt-engine/ folder and create from 
scratch

anyone else experienced this?

Thanks,
Omer.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] vdsm_master_unit-tests_merged stuck again on JsonRpcServerTests

2015-06-25 Thread Dan Kenigsberg

I see that you have re-enabled the tests - thanks.

Please note that now I see a random

20:25:49 ==
20:25:49 ERROR: testMethodReturnsNullAndServerReturnsTrue(kw=False) 
(jsonRpcTests.JsonRpcServerTests)
20:25:49 --
20:25:49 Traceback (most recent call last):
20:25:49   File /tmp/run/vdsm/tests/testlib.py, line 64, in wrapper
20:25:49 return f(self, *args)
20:25:49   File /tmp/run/vdsm/tests/monkeypatch.py, line 133, in wrapper
20:25:49 return f(*args, **kw)
20:25:49   File /tmp/run/vdsm/tests/jsonRpcTests.py, line 186, in 
testMethodReturnsNullAndServerReturnsTrue
20:25:49 CALL_ID)
20:25:49   File /tmp/run/vdsm/tests/jsonRpcTests.py, line 89, in _callTimeout
20:25:49 raise JsonRpcNoResponseError(methodName)
20:25:49 JsonRpcNoResponseError: [-32605] No response for JSON-RPC ping request.

in http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/4096/console

can you take a look?
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] vdsm_master_unit-tests_merged stuck again on JsonRpcServerTests

2015-06-25 Thread Piotr Kliczewski


This error is thrown when the test timeouts. I reduced timeout to be sure that 
there is no issue with timeouts. We saw tests being stuck. Once we do not see 
it hanging again i will restore previos value.


Thanks,Piotr

 Oryginalna wiadomość 
Od: Dan Kenigsberg dan...@redhat.com 
Data: 25.06.2015  22:33  (GMT+01:00) 
Do: Piotr Kliczewski piotr.kliczew...@gmail.com 
DW: Piotr Kliczewski pklic...@redhat.com, infra in...@ovirt.org, 
devel@ovirt.org 
Temat: Re: [ovirt-devel] vdsm_master_unit-tests_merged stuck again on 
JsonRpcServerTests 


I see that you have re-enabled the tests - thanks.

Please note that now I see a random

20:25:49 ==
20:25:49 ERROR: testMethodReturnsNullAndServerReturnsTrue(kw=False) 
(jsonRpcTests.JsonRpcServerTests)
20:25:49 --
20:25:49 Traceback (most recent call last):
20:25:49   File /tmp/run/vdsm/tests/testlib.py, line 64, in wrapper
20:25:49 return f(self, *args)
20:25:49   File /tmp/run/vdsm/tests/monkeypatch.py, line 133, in wrapper
20:25:49 return f(*args, **kw)
20:25:49   File /tmp/run/vdsm/tests/jsonRpcTests.py, line 186, in 
testMethodReturnsNullAndServerReturnsTrue
20:25:49 CALL_ID)
20:25:49   File /tmp/run/vdsm/tests/jsonRpcTests.py, line 89, in _callTimeout
20:25:49 raise JsonRpcNoResponseError(methodName)
20:25:49 JsonRpcNoResponseError: [-32605] No response for JSON-RPC ping request.

in http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/4096/console

can you take a look?
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] [UI] New Domain dialog broken

2015-06-25 Thread Piotr Kliczewski
Hi,

I rebuilt the engine master today and get following error when opening
a dialog to add storage domain:
Can someone please take a look?

Thanks,
Piotr

Thu Jun 25 14:49:01 GMT+200 2015
SEVERE: Uncaught exception:
com.google.gwt.core.client.JavaScriptException: (TypeError)
 __gwt$exception: skipped: Tab(...) is undefined
at Unknown.Akv(Unknown Source)
at Unknown.Mjf(Unknown Source)
at Unknown.Pjf(Unknown Source)
at Unknown.Njf(Unknown Source)
at Unknown.Xjf(Unknown Source)
at Unknown.bhk(Unknown Source)
at Unknown.dhk(Unknown Source)
at Unknown.zY(Unknown Source)
at Unknown.Rkv(Unknown Source)
at Unknown.zY(Unknown Source)
at Unknown.Hkv(Unknown Source)
at Unknown.Sgk(Unknown Source)
at Unknown.rkv(Unknown Source)
at Unknown.vkv(Unknown Source)
at Unknown.fsv(Unknown Source)
at Unknown.usv(Unknown Source)
at Unknown.$jr(Unknown Source)
at Unknown.U5n(Unknown Source)
at Unknown.feq(Unknown Source)
at Unknown.$jr(Unknown Source)
at Unknown.U5n(Unknown Source)
at Unknown.o6n(Unknown Source)
at Unknown.bhk(Unknown Source)
at Unknown.thk(Unknown Source)
at Unknown.$jr(Unknown Source)
at Unknown.S5n(Unknown Source)
at Unknown.n6n(Unknown Source)
at Unknown.m6n(Unknown Source)
at Unknown.O3p(Unknown Source)
at Unknown.T3p(Unknown Source)
at Unknown.P3p(Unknown Source)
at Unknown.$5p(Unknown Source)
at Unknown.Y5p(Unknown Source)
at Unknown.Z5p(Unknown Source)
at Unknown.j6p(Unknown Source)
at Unknown.rvn(Unknown Source)
at Unknown.uvn(Unknown Source)
at Unknown.lzn(Unknown Source)
at Unknown.ozn(Unknown Source)
at Unknown.jyn(Unknown Source)
at Unknown.myn(Unknown Source)
at Unknown.RBe(Unknown Source)
at Unknown.Rhk(Unknown Source)
at Unknown.M3(Unknown Source)
at Unknown.d4(Unknown Source)
at Unknown.Lof/c.onreadystatechange(Unknown Source)
at Unknown.Xt(Unknown Source)
at Unknown._t(Unknown Source)
at Unknown.$t/(Unknown Source)
at Unknown.anonymous(Unknown Source)

http://localhost:8080/ovirt-engine/webadmin/76B50B2E63805C707DBDD2E6CC5344F7.cache.html
Line 23283
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] engine-setup broken in master?

2015-06-25 Thread Eli Mesika


- Original Message -
 From: Omer Frenkel ofren...@redhat.com
 To: Roy Golan rgo...@redhat.com
 Cc: devel@ovirt.org
 Sent: Thursday, June 25, 2015 11:16:23 AM
 Subject: Re: [ovirt-devel] engine-setup broken in master?
 
 
 
 - Original Message -
  From: Roy Golan rgo...@redhat.com
  To: Omer Frenkel ofren...@redhat.com, devel@ovirt.org
  Sent: Thursday, June 25, 2015 11:07:40 AM
  Subject: Re: [ovirt-devel] engine-setup broken in master?
  
  Dudi hit the same issue.
  
  On 06/25/2015 10:37 AM, Omer Frenkel wrote:
   Hi,
   on latest master, engine-setup fails for me with:
   [ ERROR ] Failed to execute stage 'Setup validation': Failed checking
   Engine database: [u'']
  
   from the setup log:
  
   2015-06-25 10:27:51 DEBUG
   otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations
   plugin.execute:940 execute-output:
   ['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu
   tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost',
   '--port=5432', '--database=**FILTERED**',
   '--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506
   25102702-nwwazb.log'] stderr:
   ERROR:  function fn_db_validate_fks(boolean, boolean) does not exist
   LINE 3: from fn_db_validate_fks(false, 0 != 0)
 ^
   HINT:  No function matches the given name and argument types. You might
   need to add explicit type casts.

Didi, we concluded that engine-setup is responding for installing the SPs, can 
you please check on upgrade scenario if the call for fkvalidaor script is done 
before SPs are installed 

  
   2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155 method
   exception
   Traceback (most recent call last):
  File /usr/lib/python2.7/site-packages/otopi/context.py, line 145, in
  _executeMethod
method['method']()
  File
  
   /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
  line 128, in _validation
violations, issues_found = self._checkDb()
  File
  
   /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
  line 91, in _checkDb
output=stdout,
   RuntimeError: Failed checking Engine database:
   [u'']
  
   2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164 Failed
   to execute stage 'Setup validation': Failed checking Engine database:
   [u'']
  
   
  
   looks like lately this function (fn_db_validate_fks) was moved, might be
   related?
   ( https://gerrit.ovirt.org/#/c/42655/ )
  
   i even tried to completely remove my ~/ovirt-engine/ folder and create
   from
   scratch
  
   anyone else experienced this?
  
   Thanks,
   Omer.
   ___
   Devel mailing list
   Devel@ovirt.org
   http://lists.ovirt.org/mailman/listinfo/devel
  
  
 
 
 manually running the script [1] fixed it, but upgrade is broken
 
 [1] psql -f packaging/dbscripts/fkvalidator_sp.sql
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] [VDSM] Live snapshot with ceph disks

2015-06-25 Thread Michal Skrivanek

On 19 Jun 2015, at 22:40, Nir Soffer wrote:

 Hi all,
 
 For 3.6, we will not support live vm snapshot, but this is a must for the next
 release.
 
 It is trivial to create a disk snapshot in ceph (using cinder apis). The 
 snapshot
 is transparent to libvirt, qmeu and the guest os.
 
 However, we want to create a consistent snapshot, so you can revert to the 
 disk
 snapshot and get a consistent file system state.
 
 We also want to create a complete vm snapshot, including all disks and vm 
 memory.
 Libvirt and qemu provides that when given a new disk for the active layer, but
 when using ceph disk, we don't change the active layer - we continue to use 
 the
 same disk.
 
 Since 1.2.5, libvirt provides virDomainFSFreeze and virDomainFSThaw:
 https://libvirt.org/hvsupport.html
 
 So here is possible flows (ignoring engine side stuff like locking vms and 
 disks)
 
 Disk snapshot
 -
 
 1. Engine invoke VM.freezeFileSystems
 2. Vdsm invokes libvirt.virDomainFSFreeze
 3. Engine creates snapshot via cinder
 4. Engine invokes VM.thawFileSystems
 5. Vdsm invokes livbirt.virDomainFSThaw
 
 Vm snapshot
 ---
 
 1. Engine invoke VM.freezeFileSystems
 2. Vdsm invokes libvirt.virDomainFSFreeze
 3. Engine creates snapshot via cinder
 4. Engine invokes VM.snapshot
 5. Vdsm creates snapshot, skipping ceph disks
 6. Engine invokes VM.thawFileSystems
 7. Vdsm invokes livbirt.virDomainFSThaw
 
 API changes
 ---
 
 New verbs:
 - VM.freezeFileSystems - basically invokes virDomainFSFreeze
 - VM.thawFileSystems - basically invokes virDomainFSThaw

once we do it explicitly we can drop the flag from libvirt api which does it 
atomically for us right now
also note the dependency on functional qemu-ga (that's no different from today, 
but the current behavior is that when qemu-ga is not running we are quietly 
doing an unsafe snapshot)

 
 
 What do you think?
 
 Nir
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


[ovirt-devel] [TICKET] failing gluster tests -- RefreshGlusterVolumeDetailsCommandTest

2015-06-25 Thread Greg Sheremeta
These tests appear to be randomly failing in Jenkins. Was this a
memory issue? Pretty odd error -- Could not initialize class --
never seen that one before.

It worked on a dependent patch's build, and I didn't touch any
gluster stuff.

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/40725/console

Thanks,
Greg


15:56:32 Results :
15:56:32 
15:56:32 Tests in error: 
15:56:32   
org.ovirt.engine.core.bll.gluster.RefreshGlusterVolumeDetailsCommandTest
15:56:32   
testRefreshLightWeight(org.ovirt.engine.core.bll.gluster.GlusterSyncJobTest): 
Could not initialize class org.ovirt.engine.core.bll.gluster.GlusterSyncJob
15:56:32   
testRefreshHeavyWeightFor31(org.ovirt.engine.core.bll.gluster.GlusterSyncJobTest):
 Could not initialize class org.ovirt.engine.core.bll.gluster.GlusterSyncJob
15:56:32   
testRefreshHeavyWeightFor32(org.ovirt.engine.core.bll.gluster.GlusterSyncJobTest):
 Could not initialize class org.ovirt.engine.core.bll.gluster.GlusterSyncJob
15:56:32   
testRefreshLightWeightFor33(org.ovirt.engine.core.bll.gluster.GlusterSyncJobTest):
 Could not initialize class org.ovirt.engine.core.bll.gluster.GlusterSyncJob
15:56:32 
15:56:32 Tests run: 2341, Failures: 0, Errors: 5, Skipped: 6
15:56:32 

Greg Sheremeta
Red Hat, Inc.
Sr. Software Engineer, RHEV
Cell: 919-807-1086
gsher...@redhat.com
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] [UI] New Domain dialog broken

2015-06-25 Thread Tal Nisan

quoting myself from an email sent to the UX team:

I've traced the root cause of the broken new/edit storage domain windows 
to a patch from yesterday - https://gerrit.ovirt.org/42686 specifically [1]
What happens is that after this patch the list values are set prior to 
selecting the selected element and since no element is selected the list 
is rendered with an empty list element as default which presents us with 
the immediate problem of NPE in NfsStorageView:158 and the future 
problem of actually being able to select an empty NFS version.
While I can fix this error I'm afraid I will break functionality for the 
new host/cluster dropdown rendering Alexander's patch pointless so 
Einav/Alexander I leave it up to you to sort it out, I'm here in case 
you have any further questions, needless to say that this is an urgent 
issue since the user cannot create or update a storage domain through 
the webadmin


[1] 
https://gerrit.ovirt.org/#/c/42686/5/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java 




On 06/25/2015 04:11 PM, Piotr Kliczewski wrote:

Hi,

I rebuilt the engine master today and get following error when opening
a dialog to add storage domain:
Can someone please take a look?

Thanks,
Piotr

Thu Jun 25 14:49:01 GMT+200 2015
SEVERE: Uncaught exception:
com.google.gwt.core.client.JavaScriptException: (TypeError)
  __gwt$exception: skipped: Tab(...) is undefined
at Unknown.Akv(Unknown Source)
at Unknown.Mjf(Unknown Source)
at Unknown.Pjf(Unknown Source)
at Unknown.Njf(Unknown Source)
at Unknown.Xjf(Unknown Source)
at Unknown.bhk(Unknown Source)
at Unknown.dhk(Unknown Source)
at Unknown.zY(Unknown Source)
at Unknown.Rkv(Unknown Source)
at Unknown.zY(Unknown Source)
at Unknown.Hkv(Unknown Source)
at Unknown.Sgk(Unknown Source)
at Unknown.rkv(Unknown Source)
at Unknown.vkv(Unknown Source)
at Unknown.fsv(Unknown Source)
at Unknown.usv(Unknown Source)
at Unknown.$jr(Unknown Source)
at Unknown.U5n(Unknown Source)
at Unknown.feq(Unknown Source)
at Unknown.$jr(Unknown Source)
at Unknown.U5n(Unknown Source)
at Unknown.o6n(Unknown Source)
at Unknown.bhk(Unknown Source)
at Unknown.thk(Unknown Source)
at Unknown.$jr(Unknown Source)
at Unknown.S5n(Unknown Source)
at Unknown.n6n(Unknown Source)
at Unknown.m6n(Unknown Source)
at Unknown.O3p(Unknown Source)
at Unknown.T3p(Unknown Source)
at Unknown.P3p(Unknown Source)
at Unknown.$5p(Unknown Source)
at Unknown.Y5p(Unknown Source)
at Unknown.Z5p(Unknown Source)
at Unknown.j6p(Unknown Source)
at Unknown.rvn(Unknown Source)
at Unknown.uvn(Unknown Source)
at Unknown.lzn(Unknown Source)
at Unknown.ozn(Unknown Source)
at Unknown.jyn(Unknown Source)
at Unknown.myn(Unknown Source)
at Unknown.RBe(Unknown Source)
at Unknown.Rhk(Unknown Source)
at Unknown.M3(Unknown Source)
at Unknown.d4(Unknown Source)
at Unknown.Lof/c.onreadystatechange(Unknown Source)
at Unknown.Xt(Unknown Source)
at Unknown._t(Unknown Source)
at Unknown.$t/(Unknown Source)
at Unknown.anonymous(Unknown Source)

http://localhost:8080/ovirt-engine/webadmin/76B50B2E63805C707DBDD2E6CC5344F7.cache.html
Line 23283
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] [UI] New Domain dialog broken

2015-06-25 Thread Tal Nisan
Update: A revert patch was merged (https://gerrit.ovirt.org/#/c/42886/) 
now the new/edit storage domain dialogs work correctly


On 06/25/2015 05:23 PM, Tal Nisan wrote:

quoting myself from an email sent to the UX team:

I've traced the root cause of the broken new/edit storage domain 
windows to a patch from yesterday - https://gerrit.ovirt.org/42686 
specifically [1]
What happens is that after this patch the list values are set prior to 
selecting the selected element and since no element is selected the 
list is rendered with an empty list element as default which presents 
us with the immediate problem of NPE in NfsStorageView:158 and the 
future problem of actually being able to select an empty NFS version.
While I can fix this error I'm afraid I will break functionality for 
the new host/cluster dropdown rendering Alexander's patch pointless so 
Einav/Alexander I leave it up to you to sort it out, I'm here in case 
you have any further questions, needless to say that this is an urgent 
issue since the user cannot create or update a storage domain through 
the webadmin


[1] 
https://gerrit.ovirt.org/#/c/42686/5/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java 




On 06/25/2015 04:11 PM, Piotr Kliczewski wrote:

Hi,

I rebuilt the engine master today and get following error when opening
a dialog to add storage domain:
Can someone please take a look?

Thanks,
Piotr

Thu Jun 25 14:49:01 GMT+200 2015
SEVERE: Uncaught exception:
com.google.gwt.core.client.JavaScriptException: (TypeError)
  __gwt$exception: skipped: Tab(...) is undefined
at Unknown.Akv(Unknown Source)
at Unknown.Mjf(Unknown Source)
at Unknown.Pjf(Unknown Source)
at Unknown.Njf(Unknown Source)
at Unknown.Xjf(Unknown Source)
at Unknown.bhk(Unknown Source)
at Unknown.dhk(Unknown Source)
at Unknown.zY(Unknown Source)
at Unknown.Rkv(Unknown Source)
at Unknown.zY(Unknown Source)
at Unknown.Hkv(Unknown Source)
at Unknown.Sgk(Unknown Source)
at Unknown.rkv(Unknown Source)
at Unknown.vkv(Unknown Source)
at Unknown.fsv(Unknown Source)
at Unknown.usv(Unknown Source)
at Unknown.$jr(Unknown Source)
at Unknown.U5n(Unknown Source)
at Unknown.feq(Unknown Source)
at Unknown.$jr(Unknown Source)
at Unknown.U5n(Unknown Source)
at Unknown.o6n(Unknown Source)
at Unknown.bhk(Unknown Source)
at Unknown.thk(Unknown Source)
at Unknown.$jr(Unknown Source)
at Unknown.S5n(Unknown Source)
at Unknown.n6n(Unknown Source)
at Unknown.m6n(Unknown Source)
at Unknown.O3p(Unknown Source)
at Unknown.T3p(Unknown Source)
at Unknown.P3p(Unknown Source)
at Unknown.$5p(Unknown Source)
at Unknown.Y5p(Unknown Source)
at Unknown.Z5p(Unknown Source)
at Unknown.j6p(Unknown Source)
at Unknown.rvn(Unknown Source)
at Unknown.uvn(Unknown Source)
at Unknown.lzn(Unknown Source)
at Unknown.ozn(Unknown Source)
at Unknown.jyn(Unknown Source)
at Unknown.myn(Unknown Source)
at Unknown.RBe(Unknown Source)
at Unknown.Rhk(Unknown Source)
at Unknown.M3(Unknown Source)
at Unknown.d4(Unknown Source)
at Unknown.Lof/c.onreadystatechange(Unknown Source)
at Unknown.Xt(Unknown Source)
at Unknown._t(Unknown Source)
at Unknown.$t/(Unknown Source)
at Unknown.anonymous(Unknown Source)

http://localhost:8080/ovirt-engine/webadmin/76B50B2E63805C707DBDD2E6CC5344F7.cache.html 


Line 23283
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


[ovirt-devel] Dropping Fedora 20 builds on master / 3.6 in 2 weeks

2015-06-25 Thread Sandro Bonazzola
Hi,
now that we have Wildfly support for oVirt engine and Fedora 20 reached the end 
of its life,
it's time to drop Fedora 20 builds on master.

We'll keep building for Fedora 20 on the 3.5 branch since we don't support 
Wildfly there.

If you're still developing or testing oVirt master on Fedora 20 please upgrade 
to Fedora 22
in the next 2 weeks.

Thanks,

-- 
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] engine-setup broken in master?

2015-06-25 Thread Yedidyah Bar David
- Original Message -
 From: Eli Mesika emes...@redhat.com
 To: Yedidyah Bar David d...@redhat.com
 Cc: Roy Golan rgo...@redhat.com, devel@ovirt.org, Omer Frenkel 
 ofren...@redhat.com
 Sent: Thursday, June 25, 2015 3:57:18 PM
 Subject: Re: [ovirt-devel] engine-setup broken in master?
 
 
 
 - Original Message -
  From: Omer Frenkel ofren...@redhat.com
  To: Roy Golan rgo...@redhat.com
  Cc: devel@ovirt.org
  Sent: Thursday, June 25, 2015 11:16:23 AM
  Subject: Re: [ovirt-devel] engine-setup broken in master?
  
  
  
  - Original Message -
   From: Roy Golan rgo...@redhat.com
   To: Omer Frenkel ofren...@redhat.com, devel@ovirt.org
   Sent: Thursday, June 25, 2015 11:07:40 AM
   Subject: Re: [ovirt-devel] engine-setup broken in master?
   
   Dudi hit the same issue.
   
   On 06/25/2015 10:37 AM, Omer Frenkel wrote:
Hi,
on latest master, engine-setup fails for me with:
[ ERROR ] Failed to execute stage 'Setup validation': Failed checking
Engine database: [u'']
   
from the setup log:
   
2015-06-25 10:27:51 DEBUG
otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations
plugin.execute:940 execute-output:
['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu
tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost',
'--port=5432', '--database=**FILTERED**',
'--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506
25102702-nwwazb.log'] stderr:
ERROR:  function fn_db_validate_fks(boolean, boolean) does not exist
LINE 3: from fn_db_validate_fks(false, 0 != 0)
  ^
HINT:  No function matches the given name and argument types. You might
need to add explicit type casts.
 
 Didi, we concluded that engine-setup is responding for installing the SPs,
 can you please check on upgrade scenario if the call for fkvalidaor script
 is done before SPs are installed

It is, actually. It's called during the validation stage, and the schema
is upgraded only later.

Now talked with Eli in private and we agreed to patch engine-setup to
load them prior to calling it. I'll do that next week.

 
   
2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155
method
exception
Traceback (most recent call last):
   File /usr/lib/python2.7/site-packages/otopi/context.py, line 145,
   in
   _executeMethod
 method['method']()
   File
   
/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
   line 128, in _validation
 violations, issues_found = self._checkDb()
   File
   
/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
   line 91, in _checkDb
 output=stdout,
RuntimeError: Failed checking Engine database:
[u'']
   
2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164
Failed
to execute stage 'Setup validation': Failed checking Engine database:
[u'']
   

   
looks like lately this function (fn_db_validate_fks) was moved, might
be
related?
( https://gerrit.ovirt.org/#/c/42655/ )
   
i even tried to completely remove my ~/ovirt-engine/ folder and create
from
scratch
   
anyone else experienced this?
   
Thanks,
Omer.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
   
   
  
  
  manually running the script [1] fixed it, but upgrade is broken
  
  [1] psql -f packaging/dbscripts/fkvalidator_sp.sql
  ___
  Devel mailing list
  Devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/devel
  
 

-- 
Didi

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] engine-setup broken in master?

2015-06-25 Thread Sandro Bonazzola
Il 25/06/2015 16:47, Yedidyah Bar David ha scritto:
 - Original Message -
 From: Eli Mesika emes...@redhat.com
 To: Yedidyah Bar David d...@redhat.com
 Cc: Roy Golan rgo...@redhat.com, devel@ovirt.org, Omer Frenkel 
 ofren...@redhat.com
 Sent: Thursday, June 25, 2015 3:57:18 PM
 Subject: Re: [ovirt-devel] engine-setup broken in master?



 - Original Message -
 From: Omer Frenkel ofren...@redhat.com
 To: Roy Golan rgo...@redhat.com
 Cc: devel@ovirt.org
 Sent: Thursday, June 25, 2015 11:16:23 AM
 Subject: Re: [ovirt-devel] engine-setup broken in master?



 - Original Message -
 From: Roy Golan rgo...@redhat.com
 To: Omer Frenkel ofren...@redhat.com, devel@ovirt.org
 Sent: Thursday, June 25, 2015 11:07:40 AM
 Subject: Re: [ovirt-devel] engine-setup broken in master?

 Dudi hit the same issue.

 On 06/25/2015 10:37 AM, Omer Frenkel wrote:
 Hi,
 on latest master, engine-setup fails for me with:
 [ ERROR ] Failed to execute stage 'Setup validation': Failed checking
 Engine database: [u'']

 from the setup log:

 2015-06-25 10:27:51 DEBUG
 otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations
 plugin.execute:940 execute-output:
 ['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu
 tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost',
 '--port=5432', '--database=**FILTERED**',
 '--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506
 25102702-nwwazb.log'] stderr:
 ERROR:  function fn_db_validate_fks(boolean, boolean) does not exist
 LINE 3: from fn_db_validate_fks(false, 0 != 0)
   ^
 HINT:  No function matches the given name and argument types. You might
 need to add explicit type casts.

 Didi, we concluded that engine-setup is responding for installing the SPs,
 can you please check on upgrade scenario if the call for fkvalidaor script
 is done before SPs are installed
 
 It is, actually. It's called during the validation stage, and the schema
 is upgraded only later.
 
 Now talked with Eli in private and we agreed to patch engine-setup to
 load them prior to calling it. I'll do that next week.

Looks like it's hitting more people, we have a BZ: 
https://bugzilla.redhat.com/show_bug.cgi?id=1235707
Adding Max, not sure this will block 3.6.0 second alpha or not (along with the 
other issues he already found).


 


 2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155
 method
 exception
 Traceback (most recent call last):
File /usr/lib/python2.7/site-packages/otopi/context.py, line 145,
in
_executeMethod
  method['method']()
File

 /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
line 128, in _validation
  violations, issues_found = self._checkDb()
File

 /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
line 91, in _checkDb
  output=stdout,
 RuntimeError: Failed checking Engine database:
 [u'']

 2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164
 Failed
 to execute stage 'Setup validation': Failed checking Engine database:
 [u'']

 

 looks like lately this function (fn_db_validate_fks) was moved, might
 be
 related?
 ( https://gerrit.ovirt.org/#/c/42655/ )

 i even tried to completely remove my ~/ovirt-engine/ folder and create
 from
 scratch

 anyone else experienced this?

 Thanks,
 Omer.
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel




 manually running the script [1] fixed it, but upgrade is broken

 [1] psql -f packaging/dbscripts/fkvalidator_sp.sql
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel


 


-- 
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] engine-setup broken in master?

2015-06-25 Thread Greg Sheremeta


- Original Message -
 From: Sandro Bonazzola sbona...@redhat.com
 To: Yedidyah Bar David d...@redhat.com, Eli Mesika emes...@redhat.com
 Cc: devel@ovirt.org
 Sent: Thursday, June 25, 2015 11:11:30 AM
 Subject: Re: [ovirt-devel] engine-setup broken in master?
 
 Il 25/06/2015 16:47, Yedidyah Bar David ha scritto:
  - Original Message -
  From: Eli Mesika emes...@redhat.com
  To: Yedidyah Bar David d...@redhat.com
  Cc: Roy Golan rgo...@redhat.com, devel@ovirt.org, Omer Frenkel
  ofren...@redhat.com
  Sent: Thursday, June 25, 2015 3:57:18 PM
  Subject: Re: [ovirt-devel] engine-setup broken in master?
 
 
 
  - Original Message -
  From: Omer Frenkel ofren...@redhat.com
  To: Roy Golan rgo...@redhat.com
  Cc: devel@ovirt.org
  Sent: Thursday, June 25, 2015 11:16:23 AM
  Subject: Re: [ovirt-devel] engine-setup broken in master?
 
 
 
  - Original Message -
  From: Roy Golan rgo...@redhat.com
  To: Omer Frenkel ofren...@redhat.com, devel@ovirt.org
  Sent: Thursday, June 25, 2015 11:07:40 AM
  Subject: Re: [ovirt-devel] engine-setup broken in master?
 
  Dudi hit the same issue.
 
  On 06/25/2015 10:37 AM, Omer Frenkel wrote:
  Hi,
  on latest master, engine-setup fails for me with:
  [ ERROR ] Failed to execute stage 'Setup validation': Failed checking
  Engine database: [u'']
 
  from the setup log:
 
  2015-06-25 10:27:51 DEBUG
  otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations
  plugin.execute:940 execute-output:
  ['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu
  tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost',
  '--port=5432', '--database=**FILTERED**',
  '--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506
  25102702-nwwazb.log'] stderr:
  ERROR:  function fn_db_validate_fks(boolean, boolean) does not exist
  LINE 3: from fn_db_validate_fks(false, 0 != 0)
^
  HINT:  No function matches the given name and argument types. You might
  need to add explicit type casts.
 
  Didi, we concluded that engine-setup is responding for installing the SPs,
  can you please check on upgrade scenario if the call for fkvalidaor script
  is done before SPs are installed
  
  It is, actually. It's called during the validation stage, and the schema
  is upgraded only later.
  
  Now talked with Eli in private and we agreed to patch engine-setup to
  load them prior to calling it. I'll do that next week.
 
 Looks like it's hitting more people, we have a BZ:

Yeah, it got me too. I worked around by creating a fresh DB, but I imagine most
people can't do that.

 https://bugzilla.redhat.com/show_bug.cgi?id=1235707
 Adding Max, not sure this will block 3.6.0 second alpha or not (along with
 the other issues he already found).
 
 
  
 
 
  2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155
  method
  exception
  Traceback (most recent call last):
 File /usr/lib/python2.7/site-packages/otopi/context.py, line 145,
 in
 _executeMethod
   method['method']()
 File
 
  /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
 line 128, in _validation
   violations, issues_found = self._checkDb()
 File
 
  /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
 line 91, in _checkDb
   output=stdout,
  RuntimeError: Failed checking Engine database:
  [u'']
 
  2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164
  Failed
  to execute stage 'Setup validation': Failed checking Engine database:
  [u'']
 
  
 
  looks like lately this function (fn_db_validate_fks) was moved, might
  be
  related?
  ( https://gerrit.ovirt.org/#/c/42655/ )
 
  i even tried to completely remove my ~/ovirt-engine/ folder and create
  from
  scratch
 
  anyone else experienced this?
 
  Thanks,
  Omer.
  ___
  Devel mailing list
  Devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/devel
 
 
 
 
  manually running the script [1] fixed it, but upgrade is broken
 
  [1] psql -f packaging/dbscripts/fkvalidator_sp.sql
  ___
  Devel mailing list
  Devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/devel
 
 
  
 
 
 --
 Sandro Bonazzola
 Better technology. Faster innovation. Powered by community collaboration.
 See how it works at redhat.com
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] [TICKET] failing gluster tests -- RefreshGlusterVolumeDetailsCommandTest

2015-06-25 Thread Doron Fediuck
Sahina, any idea?

On 25/06/15 18:06, Greg Sheremeta wrote:
 These tests appear to be randomly failing in Jenkins. Was this a
 memory issue? Pretty odd error -- Could not initialize class --
 never seen that one before.
 
 It worked on a dependent patch's build, and I didn't touch any
 gluster stuff.
 
 http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/40725/console
 
 Thanks,
 Greg
 
 
 15:56:32 Results :
 15:56:32 
 15:56:32 Tests in error: 
 15:56:32   
 org.ovirt.engine.core.bll.gluster.RefreshGlusterVolumeDetailsCommandTest
 15:56:32   
 testRefreshLightWeight(org.ovirt.engine.core.bll.gluster.GlusterSyncJobTest): 
 Could not initialize class org.ovirt.engine.core.bll.gluster.GlusterSyncJob
 15:56:32   
 testRefreshHeavyWeightFor31(org.ovirt.engine.core.bll.gluster.GlusterSyncJobTest):
  Could not initialize class org.ovirt.engine.core.bll.gluster.GlusterSyncJob
 15:56:32   
 testRefreshHeavyWeightFor32(org.ovirt.engine.core.bll.gluster.GlusterSyncJobTest):
  Could not initialize class org.ovirt.engine.core.bll.gluster.GlusterSyncJob
 15:56:32   
 testRefreshLightWeightFor33(org.ovirt.engine.core.bll.gluster.GlusterSyncJobTest):
  Could not initialize class org.ovirt.engine.core.bll.gluster.GlusterSyncJob
 15:56:32 
 15:56:32 Tests run: 2341, Failures: 0, Errors: 5, Skipped: 6
 15:56:32 
 
 Greg Sheremeta
 Red Hat, Inc.
 Sr. Software Engineer, RHEV
 Cell: 919-807-1086
 gsher...@redhat.com
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] [VDSM] Live snapshot with ceph disks

2015-06-25 Thread Nir Soffer
- Original Message -
 From: Michal Skrivanek michal.skriva...@redhat.com
 To: Nir Soffer nsof...@redhat.com
 Cc: devel devel@ovirt.org, Eric Blake ebl...@redhat.com
 Sent: Thursday, June 25, 2015 3:44:59 PM
 Subject: Re: [ovirt-devel] [VDSM] Live snapshot with ceph disks
 
 
 On 19 Jun 2015, at 22:40, Nir Soffer wrote:
 
  Hi all,
  
  For 3.6, we will not support live vm snapshot, but this is a must for the
  next
  release.
  
  It is trivial to create a disk snapshot in ceph (using cinder apis). The
  snapshot
  is transparent to libvirt, qmeu and the guest os.
  
  However, we want to create a consistent snapshot, so you can revert to the
  disk
  snapshot and get a consistent file system state.
  
  We also want to create a complete vm snapshot, including all disks and vm
  memory.
  Libvirt and qemu provides that when given a new disk for the active layer,
  but
  when using ceph disk, we don't change the active layer - we continue to use
  the
  same disk.
  
  Since 1.2.5, libvirt provides virDomainFSFreeze and virDomainFSThaw:
  https://libvirt.org/hvsupport.html
  
  So here is possible flows (ignoring engine side stuff like locking vms and
  disks)
  
  Disk snapshot
  -
  
  1. Engine invoke VM.freezeFileSystems
  2. Vdsm invokes libvirt.virDomainFSFreeze
  3. Engine creates snapshot via cinder
  4. Engine invokes VM.thawFileSystems
  5. Vdsm invokes livbirt.virDomainFSThaw
  
  Vm snapshot
  ---
  
  1. Engine invoke VM.freezeFileSystems
  2. Vdsm invokes libvirt.virDomainFSFreeze
  3. Engine creates snapshot via cinder
  4. Engine invokes VM.snapshot
  5. Vdsm creates snapshot, skipping ceph disks
  6. Engine invokes VM.thawFileSystems
  7. Vdsm invokes livbirt.virDomainFSThaw
  
  API changes
  ---
  
  New verbs:
  - VM.freezeFileSystems - basically invokes virDomainFSFreeze
  - VM.thawFileSystems - basically invokes virDomainFSThaw
 
 once we do it explicitly we can drop the flag from libvirt api which does it
 atomically for us right now

We plan to add a frozen key in the snapshot description. If ture, it means
that engine freezed the file systems on the guest, and vdsm will skip the 
VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag.

 also note the dependency on functional qemu-ga (that's no different from
 today, but the current behavior is that when qemu-ga is not running we are
 quietly doing an unsafe snapshot)

We plan to keep this behavior, hopefully make it better, depending on
how libvirt communicate this condition.

Current code is assuming that *any* exception calling snapshotCreateXML()
means the guest is not running :-)

Nir
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] engine-setup broken in master?

2015-06-25 Thread Oved Ourfali


- Original Message -
 From: Omer Frenkel ofren...@redhat.com
 To: Oved Ourfali ov...@redhat.com
 Cc: devel@ovirt.org
 Sent: Thursday, June 25, 2015 11:06:09 AM
 Subject: Re: [ovirt-devel] engine-setup broken in master?
 
 
 
 - Original Message -
  From: Oved Ourfali ov...@redhat.com
  To: Omer Frenkel ofren...@redhat.com
  Cc: devel@ovirt.org
  Sent: Thursday, June 25, 2015 11:03:46 AM
  Subject: Re: [ovirt-devel] engine-setup broken in master?
  
  Hi
  
  I've just checked-out latest master, built the engine, targeting a new
  directory, new DB schema, and it worked well.
  
  Can you re-test it?
  
  Thanks,
  Oved
  
 
 i dont want new db schema, you should test upgrade.
 i tested several times, on 2 different setup folders, same existing db of
 course.
 

Okay.
You haven't specified that, so I tested with a clean environment.
Eli will be around in ~2 hours (he is on half day PTO), and I'll ask him to dig 
into it.

Thanks,
Oved

  - Original Message -
   From: Omer Frenkel ofren...@redhat.com
   To: devel@ovirt.org
   Sent: Thursday, June 25, 2015 10:37:55 AM
   Subject: [ovirt-devel] engine-setup broken in master?
   
   Hi,
   on latest master, engine-setup fails for me with:
   [ ERROR ] Failed to execute stage 'Setup validation': Failed checking
   Engine
   database: [u'']
   
   from the setup log:
   
   2015-06-25 10:27:51 DEBUG
   otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations
   plugin.execute:940 execute-output:
   ['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu
   tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost',
   '--port=5432', '--database=**FILTERED**',
   '--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506
   25102702-nwwazb.log'] stderr:
   ERROR:  function fn_db_validate_fks(boolean, boolean) does not exist
   LINE 3: from fn_db_validate_fks(false, 0 != 0)
^
   HINT:  No function matches the given name and argument types. You might
   need
   to add explicit type casts.
   
   2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155 method
   exception
   Traceback (most recent call last):
 File /usr/lib/python2.7/site-packages/otopi/context.py, line 145, in
 _executeMethod
   method['method']()
 File
 
   /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
 line 128, in _validation
   violations, issues_found = self._checkDb()
 File
 
   /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
 line 91, in _checkDb
   output=stdout,
   RuntimeError: Failed checking Engine database:
   [u'']
   
   2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164 Failed
   to
   execute stage 'Setup validation': Failed checking Engine database:
   [u'']
   
   
   
   looks like lately this function (fn_db_validate_fks) was moved, might be
   related?
   ( https://gerrit.ovirt.org/#/c/42655/ )
   
   i even tried to completely remove my ~/ovirt-engine/ folder and create
   from
   scratch
   
   anyone else experienced this?
   
   Thanks,
   Omer.
   ___
   Devel mailing list
   Devel@ovirt.org
   http://lists.ovirt.org/mailman/listinfo/devel
   
  
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
 
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] engine-setup broken in master?

2015-06-25 Thread Omer Frenkel


- Original Message -
 From: Roy Golan rgo...@redhat.com
 To: Omer Frenkel ofren...@redhat.com, devel@ovirt.org
 Sent: Thursday, June 25, 2015 11:07:40 AM
 Subject: Re: [ovirt-devel] engine-setup broken in master?
 
 Dudi hit the same issue.
 
 On 06/25/2015 10:37 AM, Omer Frenkel wrote:
  Hi,
  on latest master, engine-setup fails for me with:
  [ ERROR ] Failed to execute stage 'Setup validation': Failed checking
  Engine database: [u'']
 
  from the setup log:
 
  2015-06-25 10:27:51 DEBUG
  otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations
  plugin.execute:940 execute-output:
  ['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu
  tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost',
  '--port=5432', '--database=**FILTERED**',
  '--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506
  25102702-nwwazb.log'] stderr:
  ERROR:  function fn_db_validate_fks(boolean, boolean) does not exist
  LINE 3: from fn_db_validate_fks(false, 0 != 0)
^
  HINT:  No function matches the given name and argument types. You might
  need to add explicit type casts.
 
  2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155 method
  exception
  Traceback (most recent call last):
 File /usr/lib/python2.7/site-packages/otopi/context.py, line 145, in
 _executeMethod
   method['method']()
 File
 
  /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
 line 128, in _validation
   violations, issues_found = self._checkDb()
 File
 
  /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
 line 91, in _checkDb
   output=stdout,
  RuntimeError: Failed checking Engine database:
  [u'']
 
  2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164 Failed
  to execute stage 'Setup validation': Failed checking Engine database:
  [u'']
 
  
 
  looks like lately this function (fn_db_validate_fks) was moved, might be
  related?
  ( https://gerrit.ovirt.org/#/c/42655/ )
 
  i even tried to completely remove my ~/ovirt-engine/ folder and create from
  scratch
 
  anyone else experienced this?
 
  Thanks,
  Omer.
  ___
  Devel mailing list
  Devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/devel
 
 


manually running the script [1] fixed it, but upgrade is broken

[1] psql -f packaging/dbscripts/fkvalidator_sp.sql
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] engine-setup broken in master?

2015-06-25 Thread Omer Frenkel


- Original Message -
 From: Oved Ourfali ov...@redhat.com
 To: Omer Frenkel ofren...@redhat.com
 Cc: devel@ovirt.org
 Sent: Thursday, June 25, 2015 11:03:46 AM
 Subject: Re: [ovirt-devel] engine-setup broken in master?
 
 Hi
 
 I've just checked-out latest master, built the engine, targeting a new
 directory, new DB schema, and it worked well.
 
 Can you re-test it?
 
 Thanks,
 Oved
 

i dont want new db schema, you should test upgrade.
i tested several times, on 2 different setup folders, same existing db of 
course.

 - Original Message -
  From: Omer Frenkel ofren...@redhat.com
  To: devel@ovirt.org
  Sent: Thursday, June 25, 2015 10:37:55 AM
  Subject: [ovirt-devel] engine-setup broken in master?
  
  Hi,
  on latest master, engine-setup fails for me with:
  [ ERROR ] Failed to execute stage 'Setup validation': Failed checking
  Engine
  database: [u'']
  
  from the setup log:
  
  2015-06-25 10:27:51 DEBUG
  otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations
  plugin.execute:940 execute-output:
  ['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu
  tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost',
  '--port=5432', '--database=**FILTERED**',
  '--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506
  25102702-nwwazb.log'] stderr:
  ERROR:  function fn_db_validate_fks(boolean, boolean) does not exist
  LINE 3: from fn_db_validate_fks(false, 0 != 0)
   ^
  HINT:  No function matches the given name and argument types. You might
  need
  to add explicit type casts.
  
  2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155 method
  exception
  Traceback (most recent call last):
File /usr/lib/python2.7/site-packages/otopi/context.py, line 145, in
_executeMethod
  method['method']()
File

  /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
line 128, in _validation
  violations, issues_found = self._checkDb()
File

  /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
line 91, in _checkDb
  output=stdout,
  RuntimeError: Failed checking Engine database:
  [u'']
  
  2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164 Failed
  to
  execute stage 'Setup validation': Failed checking Engine database:
  [u'']
  
  
  
  looks like lately this function (fn_db_validate_fks) was moved, might be
  related?
  ( https://gerrit.ovirt.org/#/c/42655/ )
  
  i even tried to completely remove my ~/ovirt-engine/ folder and create from
  scratch
  
  anyone else experienced this?
  
  Thanks,
  Omer.
  ___
  Devel mailing list
  Devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/devel
  
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] [vdsm][mom][jsonrpc] new VDSM interface for MOM

2015-06-25 Thread Piotr Kliczewski
On Thu, May 14, 2015 at 3:28 PM, Adam Litke ali...@redhat.com wrote:
 On 13/05/15 22:53 +0200, Piotr Kliczewski wrote:

 On Wed, May 13, 2015 at 9:52 PM, Adam Litke ali...@redhat.com wrote:

 On 11/05/15 04:28 -0400, Francesco Romani wrote:


 Hi everyone,

 I'm working to brush up and enhance my old hack
 https://gerrit.ovirt.org/#/c/37827/1

 That patch adds a new MOM interface, to talk with VDSM using the RPC
 interface.
 On top of that, I want to make efficient use of VDSM API (avoid
 redundant
 call, possibly
 issuing only one getAllVmStats call and caching the results, and so
 forth)

 Next step will be to backport optimizations to current vdsmInterface.
 Or maybe, even replacing the new vdsminterface with the new one I'm
 developing :)

 I'd like to use the blessed JSON-RPC interface, but what's the
 recommended
 way to
 do that? What is (or will be!) the official recommended VDSM external
 client interface?

 I thought about patch https://gerrit.ovirt.org/#/c/39203/

 But my _impression_ is that patch will depend on VDSM's internal
 reactor,
 thus is not very
 suitable to be used into an external process.



 I've written my own extremely crude client using the stomp library.
 Nir also has a patch [1] on gerrit to do this.  Maybe he can provide
 some insight.  It'd be nice if the vdsm-yajsonrpc package could
 provide a full-featured client class that could be easily integrated
 into projects like MOM.


 I will try to provide simple client for people to use.


 Thanks Piotr!  I'm sure you can come up with a much more  elegant way
 to stitch the existing classes together to do what we need.


I posted a patch [1] with simplified way of building stomp client. It works in
sync and async way. Can you please take a look and tell me whether it
is OK or you want me to make more improvements.

It is important to have it usable.

[1] https://gerrit.ovirt.org/#/c/42850

 --
 Adam Litke
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel