Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

[Nir Soffer]

On Mon, Aug 7, 2017 at 5:28 PM Roy Golan  wrote:

> Still someone could call conirmConnectivity, no? so the state isn't
> guarded from localhost tinkering anyhow. If you really need a solution you
> can acuire a token for this operation by setupNetworks, and confirm
> connectivity with this token passed back.
>
> I'm not sure about the severity of the problem here, I'll let other reply,
> but I'm against this kind of solution.
>
>
>
> On Mon, 7 Aug 2017 at 15:32 Petr Horacek  wrote:
>
>> Hello,
>>
>> current VDSM ping verb has a problem - it confirms network
>> connectivity as a side-effect. After Engine calls setupNetwork it
>> pings VDSM host to confirm that external network connectivity is not
>> broken. This prohibits other users to call ping from localhost since
>> it would confirm connectivity even though networking could be broken.
>>
>
Vdsm can save the client ip setting up the network. Getting a ping from this
client can confirm that the connectivity was restored. pings from other
hosts
can be ignored.

The client address is available in a thread local variable
(context.client_host)
during all api calls. see vdsm.common.api.context_string() for example
usage.

This infrastructure is available in 4.1.

Nir


>
>> In order to fix this problem ping should be split to ping2 (which just
>> returns Success with no side-effect) and confirmConnectivity. Change
>> on VDSM side was introduced in [1], we still need to expose new verbs
>> in Engine.
>>
>> Regards,
>> Petr
>>
>> [1] https://gerrit.ovirt.org/#/c/80119/
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] OST: A good way to test cluster compatibility version upgrade?

[Milan Zamazal]

Daniel Belenky  writes:

> As Barak said, I think it's a good idea to try and extend the current
> upgrade suites.
> As the upgrade suites are already running in parallel (on different hosts)
> with the basic_suite (and currently the upgrade suite is much faster than
> the basic suite),  we might end up with the same run time as the basic
> suite, which eventually won't increase the total time of change queue's
> tests.

Thank you both for the advice, under those circumstances the upgrade
suite should be a very good place, so we'll use it.

Thanks,
Milan
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] OST: A good way to test cluster compatibility version upgrade?

[Daniel Belenky]

As Barak said, I think it's a good idea to try and extend the current
upgrade suites.
As the upgrade suites are already running in parallel (on different hosts)
with the basic_suite (and currently the upgrade suite is much faster than
the basic suite),  we might end up with the same run time as the basic
suite, which eventually won't increase the total time of change queue's
tests.

On Mon, Aug 7, 2017 at 6:06 PM, Barak Korren  wrote:

> On 7 August 2017 at 18:00, Milan Zamazal  wrote:
> >
> > We could also make a separate test suite for that test, but is it
> > desirable and would anybody run it regularly?
> >
> > So what do you recommend as a good way to test cluster compatibility
> > version upgrades?
>
> Maybe we could add this to the upgrade suits? They are currently only
> running engine, but I guess hosts could be added and the suits could
> be expanded to cover the entire upgrade process and not just engine's.
>
> The upgrade suits are already getting run automatically by the change
> queue alongside the basic suit.
>
> --
> Barak Korren
> RHV DevOps team , RHCE, RHCi
> Red Hat EMEA
> redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>



-- 

DANIEL BELENKY

RHV DEVOPS

EMEA VIRTUALIZATION R

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] OST: A good way to test cluster compatibility version upgrade?

[Barak Korren]

On 7 August 2017 at 18:00, Milan Zamazal  wrote:
>
> We could also make a separate test suite for that test, but is it
> desirable and would anybody run it regularly?
>
> So what do you recommend as a good way to test cluster compatibility
> version upgrades?

Maybe we could add this to the upgrade suits? They are currently only
running engine, but I guess hosts could be added and the suits could
be expanded to cover the entire upgrade process and not just engine's.

The upgrade suits are already getting run automatically by the change
queue alongside the basic suit.

-- 
Barak Korren
RHV DevOps team , RHCE, RHCi
Red Hat EMEA
redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

[Roy Golan]

Still someone could call conirmConnectivity, no? so the state isn't guarded
from localhost tinkering anyhow. If you really need a solution you can
acuire a token for this operation by setupNetworks, and confirm
connectivity with this token passed back.

I'm not sure about the severity of the problem here, I'll let other reply,
but I'm against this kind of solution.



On Mon, 7 Aug 2017 at 15:32 Petr Horacek  wrote:

> Hello,
>
> current VDSM ping verb has a problem - it confirms network
> connectivity as a side-effect. After Engine calls setupNetwork it
> pings VDSM host to confirm that external network connectivity is not
> broken. This prohibits other users to call ping from localhost since
> it would confirm connectivity even though networking could be broken.
>
> In order to fix this problem ping should be split to ping2 (which just
> returns Success with no side-effect) and confirmConnectivity. Change
> on VDSM side was introduced in [1], we still need to expose new verbs
> in Engine.
>
> Regards,
> Petr
>
> [1] https://gerrit.ovirt.org/#/c/80119/
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

[Petr Horacek]

Hello,

current VDSM ping verb has a problem - it confirms network
connectivity as a side-effect. After Engine calls setupNetwork it
pings VDSM host to confirm that external network connectivity is not
broken. This prohibits other users to call ping from localhost since
it would confirm connectivity even though networking could be broken.

In order to fix this problem ping should be split to ping2 (which just
returns Success with no side-effect) and confirmConnectivity. Change
on VDSM side was introduced in [1], we still need to expose new verbs
in Engine.

Regards,
Petr

[1] https://gerrit.ovirt.org/#/c/80119/
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 06/08/2017 ] [template_update]

[Eyal Edri]

Just FYI, this is a new test introduced in
https://gerrit.ovirt.org/#/c/78802/.
It might also be a bug in the test itself, so adding the test author.

On Mon, Aug 7, 2017 at 9:18 AM, Barak Korren  wrote:

> Test failed: [ 004_basic_sanity.template_update ]
>
> Link to suspected patches:
> https://gerrit.ovirt.org/#/c/80222
>
> Link to Job:
> http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/1668/
>
> Link to all logs:
> http://jenkins.ovirt.org/job/ovirt-master_change-queue-
> tester/1668/artifact/exported-artifacts/basic-suit-master-
> el7/test_logs/basic-suite-master/
>
> Error snippet from log:
>
> 
>
> Traceback (most recent call last):
>   File "/usr/lib64/python2.7/unittest/case.py", line 369, in run
> testMethod()
>   File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in
> runTest
> self.test(*self.arg)
>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
> 129, in wrapped_test
> test()
>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
> 59, in wrapper
> return func(get_test_prefix(), *args, **kwargs)
>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
> 78, in wrapper
> prefix.virt_env.engine_vm().get_api(api_ver=4), *args, **kwargs
>   File "/home/jenkins/workspace/ovirt-master_change-queue-
> tester/ovirt-system-tests/basic-suite-master/test-
> scenarios/004_basic_sanity.py",
> line 635, in template_update
> nt.assert_true(templates_service.list(search=TEMPLATE_
> CIRROS)[0].comment
> == new_comment)
>   File "/usr/lib64/python2.7/unittest/case.py", line 462, in assertTrue
> raise self.failureException(msg)
> AssertionError: False is not true
>
>
> 
>
>
>
> --
> Barak Korren
> RHV DevOps team , RHCE, RHCi
> Red Hat EMEA
> redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>



-- 

Eyal edri


ASSOCIATE MANAGER

RHV DevOps

EMEA VIRTUALIZATION R


Red Hat EMEA 
 TRIED. TESTED. TRUSTED. 
phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 06/08/2017 ] [template_update]

[Barak Korren]

Test failed: [ 004_basic_sanity.template_update ]

Link to suspected patches:
https://gerrit.ovirt.org/#/c/80222

Link to Job:
http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/1668/

Link to all logs:
http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/1668/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/

Error snippet from log:



Traceback (most recent call last):
  File "/usr/lib64/python2.7/unittest/case.py", line 369, in run
testMethod()
  File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
  File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
129, in wrapped_test
test()
  File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
59, in wrapper
return func(get_test_prefix(), *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
78, in wrapper
prefix.virt_env.engine_vm().get_api(api_ver=4), *args, **kwargs
  File 
"/home/jenkins/workspace/ovirt-master_change-queue-tester/ovirt-system-tests/basic-suite-master/test-scenarios/004_basic_sanity.py",
line 635, in template_update
nt.assert_true(templates_service.list(search=TEMPLATE_CIRROS)[0].comment
== new_comment)
  File "/usr/lib64/python2.7/unittest/case.py", line 462, in assertTrue
raise self.failureException(msg)
AssertionError: False is not true






-- 
Barak Korren
RHV DevOps team , RHCE, RHCi
Red Hat EMEA
redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel