[ovirt-devel] Thank you from an oVirt user
Dear oVirt developers, I just wanted to drop you all a note to thank you for the great work you've done with oVirt. I've been using it for several years and am vastly impressed with your robust and stable solution to what is, frankly, a very complex set of problems. Thank you so much. Your efforts are greatly appreciated. Thanks and have a great day, --Scott Sobotka___ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-le...@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/KYUWNBUMNHUYDLWAXRCS6NWBUKG4UYDO/
[ovirt-devel] Re: Merge rights changes in the oVirt Engine project
On Wed, Apr 7, 2021 at 6:45 PM Michal Skrivanek wrote: > > > > > On 7. 4. 2021, at 12:04, Yedidyah Bar David wrote: > > > > On Tue, Aug 11, 2020 at 11:05 AM Tal Nisan wrote: > >> > >> Hi everyone, > >> As you probably know we are now in a mode in which we develop our next > >> zstream version on the master branch as opposed to how we worked before > >> where the master version was dedicated for the next major version. This > >> makes the rapid changes in master to be delivered to customers in a much > >> higher cadence thus affecting stability. > >> Due to that we think it's best that from now on merges in the master > >> branch will be done only by stable branch maintainers after inspecting > >> those closely. > >> > >> What you need to do in order to get your patch merged: > >> - Have it pass Jenkins > >> - Have it get code review +2 > >> - Have it mark verified +1 > >> - It's always encourage to have it tested by OST, for bigger changes it's > >> a must > >> > >> Once you have all those covered, please add me as a reviewer and I'll > >> examine it and merge if everything seems right, if I haven't done it in a > >> timely manner feel free to ping me. > > > > Is the above still the current policy? > > Hi Didi, > well, yes it is. what’s the concern? No "concern", other than I noticed a few times that people other than Tal merged patches, and yesterday I did the same [1] after getting +1 from Sandro and consulting him, seeing that I have permissions. IIRC I didn't have permissions until recently, so I wondered if anything changed. If the re-granting of permissions was a mistake, let's revert. If it's on purpose, perhaps clarify the situation. [1] https://gerrit.ovirt.org/c/ovirt-engine/+/114130 > I’d love to get to a point when we can automatically gate patches based on > OST, but it’s going slow…so for now it’s still manual. Not sure that's enough, but it would be a step in the right direction. Sometimes patches won't break OST but are still harmful. Did we ever consider going fully to Test-Driven-Development? Not certain if there are studies/methods to calculate/approximate the expected extra work this will require. Assuming you want eventually all developers to also know well-enough OST (in addition to their specific expertise) and be comfortable patching it, it might make sense. Best regards, -- Didi ___ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-le...@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/RAPSZE6V4PW6ZIDXH5F3EBN6XYUABTFO/
[ovirt-devel] Re: planned Jenkins restart
Maintenance completed, Jenkins is up and running. Both the core and plugins have been upgraded, OS updates have also been applied. If you submitted patches during this maintenance window and CI didn't run, please add a "ci please test" comment to the relevant patch in order to re-trigger CI. As always - if you see any issues please report them to Jira. Regards, Evgheni On Thu, Apr 8, 2021 at 12:16 AM Evgheni Dereveanchin wrote: > > Hi everyone, > > I'll be performing a planned Jenkins restart within the next hour. > No new CI jobs will be scheduled during this maintenance period. > I will inform you once it is back online. > > -- > Regards, > Evgheni Dereveanchin -- Regards, Evgheni Dereveanchin ___ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-le...@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/42ODF3KAR4YTGXFEX4SZECOEPDOUDWIR/
[ovirt-devel] planned Jenkins restart
Hi everyone, I'll be performing a planned Jenkins restart within the next hour. No new CI jobs will be scheduled during this maintenance period. I will inform you once it is back online. -- Regards, Evgheni Dereveanchin ___ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-le...@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/PM3BHFFPEDD5XJNM7Z7LHMG7I2D7H736/
[ovirt-devel] Re: Merge rights changes in the oVirt Engine project
> On 7. 4. 2021, at 12:04, Yedidyah Bar David wrote: > > On Tue, Aug 11, 2020 at 11:05 AM Tal Nisan wrote: >> >> Hi everyone, >> As you probably know we are now in a mode in which we develop our next >> zstream version on the master branch as opposed to how we worked before >> where the master version was dedicated for the next major version. This >> makes the rapid changes in master to be delivered to customers in a much >> higher cadence thus affecting stability. >> Due to that we think it's best that from now on merges in the master branch >> will be done only by stable branch maintainers after inspecting those >> closely. >> >> What you need to do in order to get your patch merged: >> - Have it pass Jenkins >> - Have it get code review +2 >> - Have it mark verified +1 >> - It's always encourage to have it tested by OST, for bigger changes it's a >> must >> >> Once you have all those covered, please add me as a reviewer and I'll >> examine it and merge if everything seems right, if I haven't done it in a >> timely manner feel free to ping me. > > Is the above still the current policy? Hi Didi, well, yes it is. what’s the concern? I’d love to get to a point when we can automatically gate patches based on OST, but it’s going slow…so for now it’s still manual. Thanks, michal > > Thanks, > -- > Didi > ___ > Devel mailing list -- devel@ovirt.org > To unsubscribe send an email to devel-le...@ovirt.org > Privacy Statement: https://www.ovirt.org/privacy-policy.html > oVirt Code of Conduct: > https://www.ovirt.org/community/about/community-guidelines/ > List Archives: > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/5LIRDIAACHT52K7DUFP3WWRHXEUYY6LR/ ___ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-le...@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/A7D4MIQVHGV2ASDQIJ3XQ3HU3C6SU47H/
[ovirt-devel] ovirt-engine has been tagged (ovirt-engine-4.4.6.3)
___ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-le...@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/EIYF43U4NVSCMQYX5JOGD7OV657W4XZQ/
[ovirt-devel] Re: Merge rights changes in the oVirt Engine project
On Tue, Aug 11, 2020 at 11:05 AM Tal Nisan wrote: > > Hi everyone, > As you probably know we are now in a mode in which we develop our next > zstream version on the master branch as opposed to how we worked before where > the master version was dedicated for the next major version. This makes the > rapid changes in master to be delivered to customers in a much higher cadence > thus affecting stability. > Due to that we think it's best that from now on merges in the master branch > will be done only by stable branch maintainers after inspecting those closely. > > What you need to do in order to get your patch merged: > - Have it pass Jenkins > - Have it get code review +2 > - Have it mark verified +1 > - It's always encourage to have it tested by OST, for bigger changes it's a > must > > Once you have all those covered, please add me as a reviewer and I'll examine > it and merge if everything seems right, if I haven't done it in a timely > manner feel free to ping me. Is the above still the current policy? Thanks, -- Didi ___ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-le...@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/5LIRDIAACHT52K7DUFP3WWRHXEUYY6LR/
[ovirt-devel] Re: [oVirt Jenkins] ovirt-system-tests_he-basic-suite-master - Build # 1974 - Still Failing!
On Wed, Apr 7, 2021 at 12:36 PM Marcin Sobczyk wrote: > > > > On 4/6/21 10:37 AM, Marcin Sobczyk wrote: > > > > On 4/6/21 9:55 AM, Yedidyah Bar David wrote: > >> On Tue, Apr 6, 2021 at 9:24 AM Marcin Sobczyk wrote: > >>> Hi, > >>> > >>> On 4/6/21 7:23 AM, Yedidyah Bar David wrote: > On Mon, Apr 5, 2021 at 5:53 AM wrote: > > Project: > > https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/ > > Build: > > https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/1974/ > FYI: This failed twice in a row (1973 and 1974), for the same reason. > I reproduced locally, looked a bit, failed to find the root cause. > When I connected > to host-1's console, it was stuck in emergency after reboot. I checked > a bit, there > was some error about kdump failing to read the kernel image > ( /boot/vmlinuz-4.18.0-240.15.1.el8_3.x86_64 ), when I tried manually > as root I did > manage to read it. I rebooted, and the VM came up fine. I decided to > try OST again, > cleaned up and ran it, and opened a 'lago console' on the vm after it > was up, but > OST passed. Tried again, passed again. Then I manually ran in CI 1975 > and it passed, > and also the nightly 1976 passed. So I am going to ignore for now. > > I think we need a patch to make lago/OST log consoles of all the VMs. > I might try > to work on this. > >>> Also stumbled upon this. Please take a look at > >>> https://gerrit.ovirt.org/#/c/ovirt-system-tests/+/114050/ > >> Yes, I did notice this change and wondered if it's related... > >> > >> But it's not merged yet, and still HE passed at least 4 times (two locally, > >> two on CI). Obviously this does not prove that the issue is fixed. > >> > >> Anyway, in addition to merely fixing it (which perhaps your patch does), > >> I also wanted to emphasize the importance of making it easier to fix > >> future such cases. How did you manage to find the root cause? > > My case was similar - HE suite was failing for me constantly. I noticed > > host-1 drops to emergency shell, so I just 'virsh console'd inside > > and went through the logs. That's when I spotted the problem with > > the additional '/var/tmp' disk. I tried the fix on my machine and HE > > suite started working again. Moments later I tried running HE suite > > without the patch and it was successful again. > > > > I couldn't figure out what's the real cause behind these problems, > > but removing the unnecessary additional disk from host-1 seemed > > to do the trick. > > > > +1 for logging consoles of the VMs - that should help with these kind > > of problems in the future. > Yesterday we hit this problem at least 2 times: > > https://jenkins.ovirt.org/job/ovirt-system-tests_standard-check-patch/16183 > https://jenkins.ovirt.org/job/ovirt-system-tests_standard-check-patch/16184 > > Didi, please review the patch mentioned above. If you don't have > any objections let's merge it and work on improving logging later. +1 from me. I also pushed this to log consoles, but it's not as easy as hoped: https://gerrit.ovirt.org/c/lago-ost/+/114150 When you have time, please see my comment there and reply... Thanks and best regards, -- Didi ___ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-le...@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/INUYPDJR3GESUVOS7YBKMHEAP5KO4QAH/
