- Original Message -
From: Lior Vernia lver...@redhat.com
To: devel@ovirt.org
Cc: Vojtech Szocs vsz...@redhat.com, Alexander Wels aw...@redhat.com,
Einav Cohen eco...@redhat.com
Sent: Thursday, August 7, 2014 2:15:50 PM
Subject: [GUI] Generic Event/IEventListener
Hello developers,
I've just pushed a patch which renders the Event and IEventListener
generic, parameterized by the type of event arguments they receive,
reviews are welcome (note some preceding and succeeding patches):
http://gerrit.ovirt.org/#/c/31194/
Looks good, this should have been done long time ago.
If merged, this should enable us to slowly remove unsafe casts, e.g. as
is often done with PropertyChangedEventArgs. I have used this (in
succeeding patches) to eliminate a couple of such coverity scan defects.
It will also add a lot of IDE warnings until most events and listeners
are properly parameterized, as was the case with the parameterization of
EntityModel and ListModel...
In general, the parametrization makes sense; we should just not forget
about updating existing code (as you wrote, there will be tons of new
warnings after the patch gets merged, so we need to fix them too).
Yours, Lior.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
