Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Martin Sivak]

> Afaik, you won't be able to run any tests that touch networking, or kernel
> modules (bonding and such). That is as much a limitation of travis as of
> docker, that was one of the points why we started using chroots instead of
> docker containers on ovirt ci.

You might be able to ask for the old architecture - standard or trusty
- where you can do a bit more.

https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments

Martin

On Wed, Apr 6, 2016 at 1:23 PM, David Caro  wrote:
> On 04/06 14:19, Edward Haas wrote:
>> On Wed, Apr 6, 2016 at 1:41 PM, Milan Zamazal  wrote:
>>
>> > Edward Haas  writes:
>> >
>> > > On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal 
>> > wrote:
>> > >
>> > > Thank you, Edward, this is useful not only for CI. I use docker for
>> > > building Vdsm and running its unit tests and this helped me to get
>> > the
>> > > proper updated set of packages after recent changes in Vdsm.
>> > >
>> > > BTW, it seems that the following packages should be additionally
>> > added
>> > > for `make check-all': psmisc, which, python-ioprocess
>> > >
>> > >
>> > > Are you saying that make check is passing on your local machine?
>> >
>> > When I add the packages given above, `make check-all' (as well as `make
>> > check') works for me except for 4 tests in lib/vdsm/schedule.py that
>> > produce the following errors with `make check-all':
>> >
>> > File "/home/pdm/ovirt/vdsm/vdsm-test/lib/vdsm/schedule.py", line 134,
>> > in schedule
>> >   heapq.heappush(self._calls, (deadline, call))
>> >   nose.proxy.TypeError: unorderable types: ScheduledCall() <
>> > ScheduledCall()
>> >
>> > File "/home/pdm/ovirt/vdsm/vdsm-test/tests/scheduleTests.py", line
>> > 160, in test_latency
>> >   med = ticker.latency[len(ticker.latency) / 2]
>> >   nose.proxy.TypeError: list indices must be integers, not float
>> >
>> > Those are probably Python 3 failures that should be fixed in Vdsm.
>> > The docker environment works fine for running the unit tests on my
>> > machine.
>> >
>>
>> I ran it on Travis CI with your recommended addition, and I am getting this
>> result: FAILED (SKIP=107, errors=14):
>> You can view the run here: https://travis-ci.org/EdDev/vdsm/builds/121117253
>
>
> Afaik, you won't be able to run any tests that touch networking, or kernel
> modules (bonding and such). That is as much a limitation of travis as of
> docker, that was one of the points why we started using chroots instead of
> docker containers on ovirt ci.
>
>
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>
>
> --
> David Caro
>
> Red Hat S.L.
> Continuous Integration Engineer - EMEA ENG Virtualization R
>
> Tel.: +420 532 294 605
> Email: dc...@redhat.com
> IRC: dcaro|dcaroest@{freenode|oftc|redhat}
> Web: www.redhat.com
> RHT Global #: 82-62605
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Nir Soffer]

On Wed, Apr 6, 2016 at 2:55 PM, Edward Haas  wrote:
>
>
> On Wed, Apr 6, 2016 at 2:41 PM, Nir Soffer  wrote:
>>
>> On Wed, Apr 6, 2016 at 2:33 PM, Edward Haas  wrote:
>> >
>> >
>> > On Wed, Apr 6, 2016 at 2:23 PM, Nir Soffer  wrote:
>> >>
>> >> On Wed, Apr 6, 2016 at 2:19 PM, Edward Haas  wrote:
>> >> >
>> >> >
>> >> > On Wed, Apr 6, 2016 at 1:41 PM, Milan Zamazal 
>> >> > wrote:
>> >> >>
>> >> >> Edward Haas  writes:
>> >> >>
>> >> >> > On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal
>> >> >> > 
>> >> >> > wrote:
>> >> >> >
>> >> >> > Thank you, Edward, this is useful not only for CI. I use
>> >> >> > docker
>> >> >> > for
>> >> >> > building Vdsm and running its unit tests and this helped me to
>> >> >> > get
>> >> >> > the
>> >> >> > proper updated set of packages after recent changes in Vdsm.
>> >> >> >
>> >> >> > BTW, it seems that the following packages should be
>> >> >> > additionally
>> >> >> > added
>> >> >> > for `make check-all': psmisc, which, python-ioprocess
>> >> >> >
>> >> >> >
>> >> >> > Are you saying that make check is passing on your local machine?
>> >> >>
>> >> >> When I add the packages given above, `make check-all' (as well as
>> >> >> `make
>> >> >> check') works for me except for 4 tests in lib/vdsm/schedule.py that
>> >> >> produce the following errors with `make check-all':
>> >> >>
>> >> >> File "/home/pdm/ovirt/vdsm/vdsm-test/lib/vdsm/schedule.py", line
>> >> >> 134,
>> >> >> in schedule
>> >> >>   heapq.heappush(self._calls, (deadline, call))
>> >> >>   nose.proxy.TypeError: unorderable types: ScheduledCall() <
>> >> >> ScheduledCall()
>> >> >>
>> >> >> File "/home/pdm/ovirt/vdsm/vdsm-test/tests/scheduleTests.py",
>> >> >> line
>> >> >> 160, in test_latency
>> >> >>   med = ticker.latency[len(ticker.latency) / 2]
>> >> >>   nose.proxy.TypeError: list indices must be integers, not float
>> >> >>
>> >> >> Those are probably Python 3 failures that should be fixed in Vdsm.
>> >> >> The docker environment works fine for running the unit tests on my
>> >> >> machine.
>> >> >
>> >> >
>> >> > I ran it on Travis CI with your recommended addition, and I am
>> >> > getting
>> >> > this
>> >> > result: FAILED (SKIP=107, errors=14):
>> >> > You can view the run here:
>> >> > https://travis-ci.org/EdDev/vdsm/builds/121117253
>> >>
>> >> Sure, make check in master run tests that should not run on travis.
>> >>
>> >> Try the travis branch - after adding ioprocess to the docker image,
>> >> all tests should pass:
>> >> https://gerrit.ovirt.org/55738
>> >>
>> >> Nir
>> >
>> >
>> > Ok, will check it as well.
>> > But its a bit of a lie, many tests are skipped instead of not ran at
>> > all,
>> > this needs to be fixed.
>> > In addition, I find many tests as not unit tests, all tests should pass
>> > in a
>> > few seconds not in 2 minutes.
>>
>> Storage people always lie :-)
>>
>> We have @slowtest for marking slow tests. Unfortunately, some tests are
>> slow, and there is no value in mocking the thing you want to test.
>>
>> Nir
>
>
> Well, I will like to run only the unit tests, and you seem to try and merge
> the integration tests
> in the same run.

make check run only unit tests, I'm using NOSE_EVAL_ATTR to filter out the
integration tests:
https://gerrit.ovirt.org/#/c/55728/2/tests/run_tests_local.sh.in

Some integration tests are not marked yet, we will do this later.

>I think they need to be separated.
> I would like to see the unit tests pass in a few seconds, have no surprising
> skips and
> have no dependency or other services.

I agree all goals, but it will take more time.

We should follow the general rule:
http://c2.com/cgi/wiki?MakeItWorkMakeItRightMakeItFast

Nir
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Edward Haas]

On Wed, Apr 6, 2016 at 2:41 PM, Nir Soffer  wrote:

> On Wed, Apr 6, 2016 at 2:33 PM, Edward Haas  wrote:
> >
> >
> > On Wed, Apr 6, 2016 at 2:23 PM, Nir Soffer  wrote:
> >>
> >> On Wed, Apr 6, 2016 at 2:19 PM, Edward Haas  wrote:
> >> >
> >> >
> >> > On Wed, Apr 6, 2016 at 1:41 PM, Milan Zamazal 
> >> > wrote:
> >> >>
> >> >> Edward Haas  writes:
> >> >>
> >> >> > On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal <
> mzama...@redhat.com>
> >> >> > wrote:
> >> >> >
> >> >> > Thank you, Edward, this is useful not only for CI. I use docker
> >> >> > for
> >> >> > building Vdsm and running its unit tests and this helped me to
> >> >> > get
> >> >> > the
> >> >> > proper updated set of packages after recent changes in Vdsm.
> >> >> >
> >> >> > BTW, it seems that the following packages should be
> additionally
> >> >> > added
> >> >> > for `make check-all': psmisc, which, python-ioprocess
> >> >> >
> >> >> >
> >> >> > Are you saying that make check is passing on your local machine?
> >> >>
> >> >> When I add the packages given above, `make check-all' (as well as
> `make
> >> >> check') works for me except for 4 tests in lib/vdsm/schedule.py that
> >> >> produce the following errors with `make check-all':
> >> >>
> >> >> File "/home/pdm/ovirt/vdsm/vdsm-test/lib/vdsm/schedule.py", line
> >> >> 134,
> >> >> in schedule
> >> >>   heapq.heappush(self._calls, (deadline, call))
> >> >>   nose.proxy.TypeError: unorderable types: ScheduledCall() <
> >> >> ScheduledCall()
> >> >>
> >> >> File "/home/pdm/ovirt/vdsm/vdsm-test/tests/scheduleTests.py",
> line
> >> >> 160, in test_latency
> >> >>   med = ticker.latency[len(ticker.latency) / 2]
> >> >>   nose.proxy.TypeError: list indices must be integers, not float
> >> >>
> >> >> Those are probably Python 3 failures that should be fixed in Vdsm.
> >> >> The docker environment works fine for running the unit tests on my
> >> >> machine.
> >> >
> >> >
> >> > I ran it on Travis CI with your recommended addition, and I am getting
> >> > this
> >> > result: FAILED (SKIP=107, errors=14):
> >> > You can view the run here:
> >> > https://travis-ci.org/EdDev/vdsm/builds/121117253
> >>
> >> Sure, make check in master run tests that should not run on travis.
> >>
> >> Try the travis branch - after adding ioprocess to the docker image,
> >> all tests should pass:
> >> https://gerrit.ovirt.org/55738
> >>
> >> Nir
> >
> >
> > Ok, will check it as well.
> > But its a bit of a lie, many tests are skipped instead of not ran at all,
> > this needs to be fixed.
> > In addition, I find many tests as not unit tests, all tests should pass
> in a
> > few seconds not in 2 minutes.
>
> Storage people always lie :-)
>
> We have @slowtest for marking slow tests. Unfortunately, some tests are
> slow, and there is no value in mocking the thing you want to test.
>
> Nir
>

Well, I will like to run only the unit tests, and you seem to try and merge
the integration tests
in the same run. I think they need to be separated.
I would like to see the unit tests pass in a few seconds, have no
surprising skips and
have no dependency or other services.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Nir Soffer]

On Wed, Apr 6, 2016 at 2:33 PM, Edward Haas  wrote:
>
>
> On Wed, Apr 6, 2016 at 2:23 PM, Nir Soffer  wrote:
>>
>> On Wed, Apr 6, 2016 at 2:19 PM, Edward Haas  wrote:
>> >
>> >
>> > On Wed, Apr 6, 2016 at 1:41 PM, Milan Zamazal 
>> > wrote:
>> >>
>> >> Edward Haas  writes:
>> >>
>> >> > On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal 
>> >> > wrote:
>> >> >
>> >> > Thank you, Edward, this is useful not only for CI. I use docker
>> >> > for
>> >> > building Vdsm and running its unit tests and this helped me to
>> >> > get
>> >> > the
>> >> > proper updated set of packages after recent changes in Vdsm.
>> >> >
>> >> > BTW, it seems that the following packages should be additionally
>> >> > added
>> >> > for `make check-all': psmisc, which, python-ioprocess
>> >> >
>> >> >
>> >> > Are you saying that make check is passing on your local machine?
>> >>
>> >> When I add the packages given above, `make check-all' (as well as `make
>> >> check') works for me except for 4 tests in lib/vdsm/schedule.py that
>> >> produce the following errors with `make check-all':
>> >>
>> >> File "/home/pdm/ovirt/vdsm/vdsm-test/lib/vdsm/schedule.py", line
>> >> 134,
>> >> in schedule
>> >>   heapq.heappush(self._calls, (deadline, call))
>> >>   nose.proxy.TypeError: unorderable types: ScheduledCall() <
>> >> ScheduledCall()
>> >>
>> >> File "/home/pdm/ovirt/vdsm/vdsm-test/tests/scheduleTests.py", line
>> >> 160, in test_latency
>> >>   med = ticker.latency[len(ticker.latency) / 2]
>> >>   nose.proxy.TypeError: list indices must be integers, not float
>> >>
>> >> Those are probably Python 3 failures that should be fixed in Vdsm.
>> >> The docker environment works fine for running the unit tests on my
>> >> machine.
>> >
>> >
>> > I ran it on Travis CI with your recommended addition, and I am getting
>> > this
>> > result: FAILED (SKIP=107, errors=14):
>> > You can view the run here:
>> > https://travis-ci.org/EdDev/vdsm/builds/121117253
>>
>> Sure, make check in master run tests that should not run on travis.
>>
>> Try the travis branch - after adding ioprocess to the docker image,
>> all tests should pass:
>> https://gerrit.ovirt.org/55738
>>
>> Nir
>
>
> Ok, will check it as well.
> But its a bit of a lie, many tests are skipped instead of not ran at all,
> this needs to be fixed.
> In addition, I find many tests as not unit tests, all tests should pass in a
> few seconds not in 2 minutes.

Storage people always lie :-)

We have @slowtest for marking slow tests. Unfortunately, some tests are
slow, and there is no value in mocking the thing you want to test.

Nir
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Edward Haas]

On Wed, Apr 6, 2016 at 2:23 PM, Nir Soffer  wrote:

> On Wed, Apr 6, 2016 at 2:19 PM, Edward Haas  wrote:
> >
> >
> > On Wed, Apr 6, 2016 at 1:41 PM, Milan Zamazal 
> wrote:
> >>
> >> Edward Haas  writes:
> >>
> >> > On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal 
> >> > wrote:
> >> >
> >> > Thank you, Edward, this is useful not only for CI. I use docker
> for
> >> > building Vdsm and running its unit tests and this helped me to get
> >> > the
> >> > proper updated set of packages after recent changes in Vdsm.
> >> >
> >> > BTW, it seems that the following packages should be additionally
> >> > added
> >> > for `make check-all': psmisc, which, python-ioprocess
> >> >
> >> >
> >> > Are you saying that make check is passing on your local machine?
> >>
> >> When I add the packages given above, `make check-all' (as well as `make
> >> check') works for me except for 4 tests in lib/vdsm/schedule.py that
> >> produce the following errors with `make check-all':
> >>
> >> File "/home/pdm/ovirt/vdsm/vdsm-test/lib/vdsm/schedule.py", line
> 134,
> >> in schedule
> >>   heapq.heappush(self._calls, (deadline, call))
> >>   nose.proxy.TypeError: unorderable types: ScheduledCall() <
> >> ScheduledCall()
> >>
> >> File "/home/pdm/ovirt/vdsm/vdsm-test/tests/scheduleTests.py", line
> >> 160, in test_latency
> >>   med = ticker.latency[len(ticker.latency) / 2]
> >>   nose.proxy.TypeError: list indices must be integers, not float
> >>
> >> Those are probably Python 3 failures that should be fixed in Vdsm.
> >> The docker environment works fine for running the unit tests on my
> >> machine.
> >
> >
> > I ran it on Travis CI with your recommended addition, and I am getting
> this
> > result: FAILED (SKIP=107, errors=14):
> > You can view the run here:
> https://travis-ci.org/EdDev/vdsm/builds/121117253
>
> Sure, make check in master run tests that should not run on travis.
>
> Try the travis branch - after adding ioprocess to the docker image,
> all tests should pass:
> https://gerrit.ovirt.org/55738
>
> Nir
>

Ok, will check it as well.
But its a bit of a lie, many tests are skipped instead of not ran at all,
this needs to be fixed.
In addition, I find many tests as not unit tests, all tests should pass in
a few seconds not in 2 minutes.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[David Caro]

On 04/06 14:31, Yaniv Kaul wrote:
> On Wed, Apr 6, 2016 at 2:23 PM, David Caro  wrote:
> 
> > On 04/06 14:19, Edward Haas wrote:
> > > On Wed, Apr 6, 2016 at 1:41 PM, Milan Zamazal 
> > wrote:
> > >
> > > > Edward Haas  writes:
> > > >
> > > > > On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal 
> > > > wrote:
> > > > >
> > > > > Thank you, Edward, this is useful not only for CI. I use docker
> > for
> > > > > building Vdsm and running its unit tests and this helped me to
> > get
> > > > the
> > > > > proper updated set of packages after recent changes in Vdsm.
> > > > >
> > > > > BTW, it seems that the following packages should be additionally
> > > > added
> > > > > for `make check-all': psmisc, which, python-ioprocess
> > > > >
> > > > >
> > > > > Are you saying that make check is passing on your local machine?
> > > >
> > > > When I add the packages given above, `make check-all' (as well as `make
> > > > check') works for me except for 4 tests in lib/vdsm/schedule.py that
> > > > produce the following errors with `make check-all':
> > > >
> > > > File "/home/pdm/ovirt/vdsm/vdsm-test/lib/vdsm/schedule.py", line
> > 134,
> > > > in schedule
> > > >   heapq.heappush(self._calls, (deadline, call))
> > > >   nose.proxy.TypeError: unorderable types: ScheduledCall() <
> > > > ScheduledCall()
> > > >
> > > > File "/home/pdm/ovirt/vdsm/vdsm-test/tests/scheduleTests.py", line
> > > > 160, in test_latency
> > > >   med = ticker.latency[len(ticker.latency) / 2]
> > > >   nose.proxy.TypeError: list indices must be integers, not float
> > > >
> > > > Those are probably Python 3 failures that should be fixed in Vdsm.
> > > > The docker environment works fine for running the unit tests on my
> > > > machine.
> > > >
> > >
> > > I ran it on Travis CI with your recommended addition, and I am getting
> > this
> > > result: FAILED (SKIP=107, errors=14):
> > > You can view the run here:
> > https://travis-ci.org/EdDev/vdsm/builds/121117253
> >
> >
> > Afaik, you won't be able to run any tests that touch networking, or kernel
> > modules (bonding and such). That is as much a limitation of travis as of
> > docker, that was one of the points why we started using chroots instead of
> > docker containers on ovirt ci.
> >
> 
> All of those should run fine in Lago, right?

Yep, they run ok on chroot (with some mount magic) and they should run without
any magic on lago

> Y.
> 
> 
> >
> >
> > > ___
> > > Devel mailing list
> > > Devel@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/devel
> >
> >
> > --
> > David Caro
> >
> > Red Hat S.L.
> > Continuous Integration Engineer - EMEA ENG Virtualization R
> >
> > Tel.: +420 532 294 605
> > Email: dc...@redhat.com
> > IRC: dcaro|dcaroest@{freenode|oftc|redhat}
> > Web: www.redhat.com
> > RHT Global #: 82-62605
> >
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> >

> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel


-- 
David Caro

Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R

Tel.: +420 532 294 605
Email: dc...@redhat.com
IRC: dcaro|dcaroest@{freenode|oftc|redhat}
Web: www.redhat.com
RHT Global #: 82-62605


signature.asc
Description: PGP signature
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Yaniv Kaul]

On Wed, Apr 6, 2016 at 2:23 PM, David Caro  wrote:

> On 04/06 14:19, Edward Haas wrote:
> > On Wed, Apr 6, 2016 at 1:41 PM, Milan Zamazal 
> wrote:
> >
> > > Edward Haas  writes:
> > >
> > > > On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal 
> > > wrote:
> > > >
> > > > Thank you, Edward, this is useful not only for CI. I use docker
> for
> > > > building Vdsm and running its unit tests and this helped me to
> get
> > > the
> > > > proper updated set of packages after recent changes in Vdsm.
> > > >
> > > > BTW, it seems that the following packages should be additionally
> > > added
> > > > for `make check-all': psmisc, which, python-ioprocess
> > > >
> > > >
> > > > Are you saying that make check is passing on your local machine?
> > >
> > > When I add the packages given above, `make check-all' (as well as `make
> > > check') works for me except for 4 tests in lib/vdsm/schedule.py that
> > > produce the following errors with `make check-all':
> > >
> > > File "/home/pdm/ovirt/vdsm/vdsm-test/lib/vdsm/schedule.py", line
> 134,
> > > in schedule
> > >   heapq.heappush(self._calls, (deadline, call))
> > >   nose.proxy.TypeError: unorderable types: ScheduledCall() <
> > > ScheduledCall()
> > >
> > > File "/home/pdm/ovirt/vdsm/vdsm-test/tests/scheduleTests.py", line
> > > 160, in test_latency
> > >   med = ticker.latency[len(ticker.latency) / 2]
> > >   nose.proxy.TypeError: list indices must be integers, not float
> > >
> > > Those are probably Python 3 failures that should be fixed in Vdsm.
> > > The docker environment works fine for running the unit tests on my
> > > machine.
> > >
> >
> > I ran it on Travis CI with your recommended addition, and I am getting
> this
> > result: FAILED (SKIP=107, errors=14):
> > You can view the run here:
> https://travis-ci.org/EdDev/vdsm/builds/121117253
>
>
> Afaik, you won't be able to run any tests that touch networking, or kernel
> modules (bonding and such). That is as much a limitation of travis as of
> docker, that was one of the points why we started using chroots instead of
> docker containers on ovirt ci.
>

All of those should run fine in Lago, right?
Y.


>
>
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
>
>
> --
> David Caro
>
> Red Hat S.L.
> Continuous Integration Engineer - EMEA ENG Virtualization R
>
> Tel.: +420 532 294 605
> Email: dc...@redhat.com
> IRC: dcaro|dcaroest@{freenode|oftc|redhat}
> Web: www.redhat.com
> RHT Global #: 82-62605
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Milan Zamazal]

Edward Haas  writes:

> I ran it on Travis CI with your recommended addition, and I am getting this
> result: FAILED (SKIP=107, errors=14): 
> You can view the run here: https://travis-ci.org/EdDev/vdsm/builds/121117253

I see, the difference is I don't run the tests as root in my docker.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Edward Haas]

On Wed, Apr 6, 2016 at 2:23 PM, David Caro  wrote:

> On 04/06 14:19, Edward Haas wrote:
> > On Wed, Apr 6, 2016 at 1:41 PM, Milan Zamazal 
> wrote:
> >
> > > Edward Haas  writes:
> > >
> > > > On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal 
> > > wrote:
> > > >
> > > > Thank you, Edward, this is useful not only for CI. I use docker
> for
> > > > building Vdsm and running its unit tests and this helped me to
> get
> > > the
> > > > proper updated set of packages after recent changes in Vdsm.
> > > >
> > > > BTW, it seems that the following packages should be additionally
> > > added
> > > > for `make check-all': psmisc, which, python-ioprocess
> > > >
> > > >
> > > > Are you saying that make check is passing on your local machine?
> > >
> > > When I add the packages given above, `make check-all' (as well as `make
> > > check') works for me except for 4 tests in lib/vdsm/schedule.py that
> > > produce the following errors with `make check-all':
> > >
> > > File "/home/pdm/ovirt/vdsm/vdsm-test/lib/vdsm/schedule.py", line
> 134,
> > > in schedule
> > >   heapq.heappush(self._calls, (deadline, call))
> > >   nose.proxy.TypeError: unorderable types: ScheduledCall() <
> > > ScheduledCall()
> > >
> > > File "/home/pdm/ovirt/vdsm/vdsm-test/tests/scheduleTests.py", line
> > > 160, in test_latency
> > >   med = ticker.latency[len(ticker.latency) / 2]
> > >   nose.proxy.TypeError: list indices must be integers, not float
> > >
> > > Those are probably Python 3 failures that should be fixed in Vdsm.
> > > The docker environment works fine for running the unit tests on my
> > > machine.
> > >
> >
> > I ran it on Travis CI with your recommended addition, and I am getting
> this
> > result: FAILED (SKIP=107, errors=14):
> > You can view the run here:
> https://travis-ci.org/EdDev/vdsm/builds/121117253
>
>
> Afaik, you won't be able to run any tests that touch networking, or kernel
> modules (bonding and such). That is as much a limitation of travis as of
> docker, that was one of the points why we started using chroots instead of
> docker containers on ovirt ci.
>

Yes, that is why I intended it for unit tests only, not for integration or
functional.
We may find some integration tests that do pass, that needs some more
investigation, but it's out of my original intent
.

>
>
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
>
>
> --
> David Caro
>
> Red Hat S.L.
> Continuous Integration Engineer - EMEA ENG Virtualization R
>
> Tel.: +420 532 294 605
> Email: dc...@redhat.com
> IRC: dcaro|dcaroest@{freenode|oftc|redhat}
> Web: www.redhat.com
> RHT Global #: 82-62605
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[David Caro]

On 04/06 14:19, Edward Haas wrote:
> On Wed, Apr 6, 2016 at 1:41 PM, Milan Zamazal  wrote:
> 
> > Edward Haas  writes:
> >
> > > On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal 
> > wrote:
> > >
> > > Thank you, Edward, this is useful not only for CI. I use docker for
> > > building Vdsm and running its unit tests and this helped me to get
> > the
> > > proper updated set of packages after recent changes in Vdsm.
> > >
> > > BTW, it seems that the following packages should be additionally
> > added
> > > for `make check-all': psmisc, which, python-ioprocess
> > >
> > >
> > > Are you saying that make check is passing on your local machine?
> >
> > When I add the packages given above, `make check-all' (as well as `make
> > check') works for me except for 4 tests in lib/vdsm/schedule.py that
> > produce the following errors with `make check-all':
> >
> > File "/home/pdm/ovirt/vdsm/vdsm-test/lib/vdsm/schedule.py", line 134,
> > in schedule
> >   heapq.heappush(self._calls, (deadline, call))
> >   nose.proxy.TypeError: unorderable types: ScheduledCall() <
> > ScheduledCall()
> >
> > File "/home/pdm/ovirt/vdsm/vdsm-test/tests/scheduleTests.py", line
> > 160, in test_latency
> >   med = ticker.latency[len(ticker.latency) / 2]
> >   nose.proxy.TypeError: list indices must be integers, not float
> >
> > Those are probably Python 3 failures that should be fixed in Vdsm.
> > The docker environment works fine for running the unit tests on my
> > machine.
> >
> 
> I ran it on Travis CI with your recommended addition, and I am getting this
> result: FAILED (SKIP=107, errors=14):
> You can view the run here: https://travis-ci.org/EdDev/vdsm/builds/121117253


Afaik, you won't be able to run any tests that touch networking, or kernel
modules (bonding and such). That is as much a limitation of travis as of
docker, that was one of the points why we started using chroots instead of
docker containers on ovirt ci.


> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel


-- 
David Caro

Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R

Tel.: +420 532 294 605
Email: dc...@redhat.com
IRC: dcaro|dcaroest@{freenode|oftc|redhat}
Web: www.redhat.com
RHT Global #: 82-62605


signature.asc
Description: PGP signature
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Nir Soffer]

On Wed, Apr 6, 2016 at 2:19 PM, Edward Haas  wrote:
>
>
> On Wed, Apr 6, 2016 at 1:41 PM, Milan Zamazal  wrote:
>>
>> Edward Haas  writes:
>>
>> > On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal 
>> > wrote:
>> >
>> > Thank you, Edward, this is useful not only for CI. I use docker for
>> > building Vdsm and running its unit tests and this helped me to get
>> > the
>> > proper updated set of packages after recent changes in Vdsm.
>> >
>> > BTW, it seems that the following packages should be additionally
>> > added
>> > for `make check-all': psmisc, which, python-ioprocess
>> >
>> >
>> > Are you saying that make check is passing on your local machine?
>>
>> When I add the packages given above, `make check-all' (as well as `make
>> check') works for me except for 4 tests in lib/vdsm/schedule.py that
>> produce the following errors with `make check-all':
>>
>> File "/home/pdm/ovirt/vdsm/vdsm-test/lib/vdsm/schedule.py", line 134,
>> in schedule
>>   heapq.heappush(self._calls, (deadline, call))
>>   nose.proxy.TypeError: unorderable types: ScheduledCall() <
>> ScheduledCall()
>>
>> File "/home/pdm/ovirt/vdsm/vdsm-test/tests/scheduleTests.py", line
>> 160, in test_latency
>>   med = ticker.latency[len(ticker.latency) / 2]
>>   nose.proxy.TypeError: list indices must be integers, not float
>>
>> Those are probably Python 3 failures that should be fixed in Vdsm.
>> The docker environment works fine for running the unit tests on my
>> machine.
>
>
> I ran it on Travis CI with your recommended addition, and I am getting this
> result: FAILED (SKIP=107, errors=14):
> You can view the run here: https://travis-ci.org/EdDev/vdsm/builds/121117253

Sure, make check in master run tests that should not run on travis.

Try the travis branch - after adding ioprocess to the docker image,
all tests should pass:
https://gerrit.ovirt.org/55738

Nir
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Edward Haas]

On Wed, Apr 6, 2016 at 1:41 PM, Milan Zamazal  wrote:

> Edward Haas  writes:
>
> > On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal 
> wrote:
> >
> > Thank you, Edward, this is useful not only for CI. I use docker for
> > building Vdsm and running its unit tests and this helped me to get
> the
> > proper updated set of packages after recent changes in Vdsm.
> >
> > BTW, it seems that the following packages should be additionally
> added
> > for `make check-all': psmisc, which, python-ioprocess
> >
> >
> > Are you saying that make check is passing on your local machine?
>
> When I add the packages given above, `make check-all' (as well as `make
> check') works for me except for 4 tests in lib/vdsm/schedule.py that
> produce the following errors with `make check-all':
>
> File "/home/pdm/ovirt/vdsm/vdsm-test/lib/vdsm/schedule.py", line 134,
> in schedule
>   heapq.heappush(self._calls, (deadline, call))
>   nose.proxy.TypeError: unorderable types: ScheduledCall() <
> ScheduledCall()
>
> File "/home/pdm/ovirt/vdsm/vdsm-test/tests/scheduleTests.py", line
> 160, in test_latency
>   med = ticker.latency[len(ticker.latency) / 2]
>   nose.proxy.TypeError: list indices must be integers, not float
>
> Those are probably Python 3 failures that should be fixed in Vdsm.
> The docker environment works fine for running the unit tests on my
> machine.
>

I ran it on Travis CI with your recommended addition, and I am getting this
result: FAILED (SKIP=107, errors=14):
You can view the run here: https://travis-ci.org/EdDev/vdsm/builds/121117253
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Milan Zamazal]

Nir Soffer  writes:

> Can you send a patch to add the missing packages to our travis config?

I think it's better to continue on your `travis' topic:

- `psmisc' is needed by tests/fuserTests.py (it contains /usr/sbin/fuser)

- `which' is needed by CommandPathTests.testExistingNotInPaths in 
tests/utilsTests.py"
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Nir Soffer]

On Tue, Apr 5, 2016 at 6:22 PM, Edward Haas  wrote:
> Hi All,
>
> The following patch is proposing to run VDSM unit tests on Travis CI.
> It uses Docker, GitHub and Travis CI integration.
>
> We can extend the usage and run coverage with historic information using
> coveralls.io service (or similar).
>
> https://gerrit.ovirt.org/#/c/54856
>
> Results of the run can be seen here: https://travis-ci.org/EdDev/vdsm

Thanks for this great work!

With little more work[1], we can run now the entire test suite on travis [2]!

Nir

[1] 
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:travis
[2] https://travis-ci.org/nirs/vdsm/builds/121115473
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Milan Zamazal]

Edward Haas  writes:

> On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal  wrote:
>
> Thank you, Edward, this is useful not only for CI. I use docker for
> building Vdsm and running its unit tests and this helped me to get the
> proper updated set of packages after recent changes in Vdsm.
> 
> BTW, it seems that the following packages should be additionally added
> for `make check-all': psmisc, which, python-ioprocess
> 
>
> Are you saying that make check is passing on your local machine?

When I add the packages given above, `make check-all' (as well as `make
check') works for me except for 4 tests in lib/vdsm/schedule.py that
produce the following errors with `make check-all':

File "/home/pdm/ovirt/vdsm/vdsm-test/lib/vdsm/schedule.py", line 134, in 
schedule
  heapq.heappush(self._calls, (deadline, call))
  nose.proxy.TypeError: unorderable types: ScheduledCall() < ScheduledCall()

File "/home/pdm/ovirt/vdsm/vdsm-test/tests/scheduleTests.py", line 160, in 
test_latency
  med = ticker.latency[len(ticker.latency) / 2]
  nose.proxy.TypeError: list indices must be integers, not float

Those are probably Python 3 failures that should be fixed in Vdsm.
The docker environment works fine for running the unit tests on my
machine.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Edward Haas]

On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal  wrote:

> Edward Haas  writes:
>
> > The following patch is proposing to run VDSM unit tests on Travis CI.
>
> Thank you, Edward, this is useful not only for CI.  I use docker for
> building Vdsm and running its unit tests and this helped me to get the
> proper updated set of packages after recent changes in Vdsm.
>
> BTW, it seems that the following packages should be additionally added
> for `make check-all': psmisc, which, python-ioprocess
>

Are you saying that make check is passing on your local machine?
On Travis CI I could not run the full test suite. Maybe I need to check
again.


> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Milan Zamazal]

Edward Haas  writes:

> The following patch is proposing to run VDSM unit tests on Travis CI.

Thank you, Edward, this is useful not only for CI.  I use docker for
building Vdsm and running its unit tests and this helped me to get the
proper updated set of packages after recent changes in Vdsm.

BTW, it seems that the following packages should be additionally added
for `make check-all': psmisc, which, python-ioprocess
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Dan Kenigsberg]

On Tue, Apr 05, 2016 at 06:22:20PM +0300, Edward Haas wrote:
> Hi All,
> 
> The following patch is proposing to run VDSM unit tests on Travis CI.
> It uses Docker, GitHub and Travis CI integration.
> 
> We can extend the usage and run coverage with historic information using
> coveralls.io service (or similar).
> 
> https://gerrit.ovirt.org/#/c/54856
> 
> Results of the run can be seen here: https://travis-ci.org/EdDev/vdsm

Thanks Edy.

I've merged your patch to see how this historical data accumulate in
https://travis-ci.org/EdDev/vdsm/builds

If all is well for a week or so, I suggest that infra@ovirt adds vdsm
to https://travis-ci.org/ovirt and move your el7 docker image to
https://hub.docker.com/u/ovirt/ to make this thing more official.

Regards,
Dan.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Edward Haas]

Hi All,

The following patch is proposing to run VDSM unit tests on Travis CI.
It uses Docker, GitHub and Travis CI integration.

We can extend the usage and run coverage with historic information using
coveralls.io service (or similar).

https://gerrit.ovirt.org/#/c/54856

Results of the run can be seen here: https://travis-ci.org/EdDev/vdsm

Thanks,
Edy.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel