Re: [ovirt-devel] AppErrors cleanup

[Moti Asayag]

Any removal of entries from AuditLogType enum should be followed by an
upgrade script to remove the matching entries from the audit_log table.
Without it, there will be NPEs due to AuditLogType.valueOf()

On Sun, Dec 13, 2015 at 2:46 PM, Allon Mureinik  wrote:

> Same has been done for AuditLogMessages.properties (vs. the AuditLogType
> enum).
>
> On Wed, Jul 29, 2015 at 3:51 PM, Allon Mureinik 
> wrote:
>
>> Hi all,
>>
>> A recent bug [1] reported as part of the translation effort alerted me to
>> the fact that we have a lot (and I mean a LOT - over 100 per file) of
>> deprecated, unused keys in the various AppErrors files that serve no
>> purpose and just take up space and waste translators time when they examine
>> them.
>>
>> To make a long story short - I've just merged a patch to remove all these
>> useless messages, and enforce via unit tests that EVERY key there should
>> have a corresponding constant in the EngineMessage or EngineError enums.
>>
>> Many thanks to my reviewers!
>> I know this was an tedious patch that couldn't have been too fun to
>> review.
>>
>>
>> -Allon
>>
>> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1244766
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>>
>>
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>



-- 
Regards,
Moti
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] AppErrors cleanup

[Allon Mureinik]

Same has been done for AuditLogMessages.properties (vs. the AuditLogType
enum).

On Wed, Jul 29, 2015 at 3:51 PM, Allon Mureinik  wrote:

> Hi all,
>
> A recent bug [1] reported as part of the translation effort alerted me to
> the fact that we have a lot (and I mean a LOT - over 100 per file) of
> deprecated, unused keys in the various AppErrors files that serve no
> purpose and just take up space and waste translators time when they examine
> them.
>
> To make a long story short - I've just merged a patch to remove all these
> useless messages, and enforce via unit tests that EVERY key there should
> have a corresponding constant in the EngineMessage or EngineError enums.
>
> Many thanks to my reviewers!
> I know this was an tedious patch that couldn't have been too fun to review.
>
>
> -Allon
>
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1244766
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
>
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] AppErrors cleanup

[Allon Mureinik]

Hi all,

A recent bug [1] reported as part of the translation effort alerted me to the 
fact that we have a lot (and I mean a LOT - over 100 per file) of deprecated, 
unused keys in the various AppErrors files that serve no purpose and just take 
up space and waste translators time when they examine them.

To make a long story short - I've just merged a patch to remove all these 
useless messages, and enforce via unit tests that EVERY key there should have a 
corresponding constant in the EngineMessage or EngineError enums.

Many thanks to my reviewers!
I know this was an tedious patch that couldn't have been too fun to review.


-Allon

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1244766
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel