Re: [ovirt-devel] Reported-By - giving credit to our testers
On 11/13 08:55, Sandro Bonazzola wrote: > On Thu, Nov 12, 2015 at 3:45 PM, Nir Sofferwrote: > > > Hi all, > > > > Our QE (and sometimes our users) are working hard testing and > > reporting bugs, but > > their effort is never mentioned in our code. > > > > Looking at kernel git history, I found that they are using the > > Reported-By header for > > giving credit to the person reporting a bug. I suggest we adapt this > > header. > > > > Here are some examples how we can use it: > > > > - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG > > - > > https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd > > - > > https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598 > > > infra: looking at above commit messages, can we get automatically added the > following lines? > > Reviewed-on: https://gerrit.ovirt.org/46540 > on patch creation > > Reviewed-by: Francesco Romani > on patch comment There's no easy way to plug in extra stuff, that is done on vdsm by gerrit itself because the project is set to 'cherry-pick', but that has consequences, for starters, when you submit a patch, the commit that gets in is not the same that you where reviewing (as the commit message changed) and thus you will be forced to rebase all the patches that depended on it. There's no built-in way either to change the commit on push (when updating/creating the patch) without creating a new patch. That means that to have that added, each time you send a patch a new one will be created, and each time you add a comment for the first time to the patch, another patch will be created too. Forcing the devel to refetch the commit each time he/she pushes. Not sure that smoothes up the dev process... I think that the less painful path will be to use a commit hook locally, so the commit message is changed locally first, but that will require the dev to install it (we can ease that with a script or similar though) > > > > > > > > > Thanks, > > Nir > > ___ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > -- > Sandro Bonazzola > Better technology. Faster innovation. Powered by community collaboration. > See how it works at redhat.com > ___ > Infra mailing list > in...@ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 signature.asc Description: PGP signature ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Reported-By - giving credit to our testers
Hi, I think it's nice to have some appreciation for helping (Beside a working Environment *g*), I don't have a problem with doing it automatically as my name also appears in the mailing lists and bugzilla. Till next time Christian -Ursprüngliche Nachricht- Von: Yedidyah Bar David [mailto:d...@redhat.com] Gesendet: Montag, 16. November 2015 11:12 An: Ondřej Svoboda <ond...@svobodasoft.cz> Cc: devel <devel@ovirt.org>; Grundmann, Christian <christian.grundm...@fabasoft.com> Betreff: Re: [ovirt-devel] Reported-By - giving credit to our testers On Sun, Nov 15, 2015 at 9:35 PM, Ondřej Svoboda <ond...@svobodasoft.cz> wrote: > On 13.11.2015 07:55, Sandro Bonazzola wrote: > > > > On Thu, Nov 12, 2015 at 3:45 PM, Nir Soffer <nsof...@redhat.com> wrote: >> >> Hi all, >> >> Our QE (and sometimes our users) are working hard testing and >> reporting bugs, but their effort is never mentioned in our code. >> >> Looking at kernel git history, I found that they are using the >> Reported-By header for giving credit to the person reporting a bug. I >> suggest we adapt this header. >> >> Here are some examples how we can use it: >> >> - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG >> - >> https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d9 >> 2959ebbd >> - >> https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde24331 >> 25c7b598 > > > infra: looking at above commit messages, can we get automatically > added the following lines? > > Reviewed-on: https://gerrit.ovirt.org/46540 on patch creation > > Reviewed-by: Francesco Romani <from...@redhat.com> on patch comment > > > +1 both to Nir's original idea and to Sandro's suggestions. Now encountered [1] my first such case since this thread, and not sure I agree to automatically add people. Some people might not want that at all, some would prefer to have control over their name, some might prefer an email address different from the one used for posting or no email address at all. I usually ask people to open a bug or comment on an existing bug. Isn't that enough? Are git logs so much more important than bugzilla history? Another option I can think of is: Report-Url: http://lists.ovirt.org/pipermail/users/2015-November/035947.html Adding Christian, the reporter of [1]. Christian, feel free to ignore current thread, and/or voice up your opinion, and/or say if you want to appear as "Reported-By:" in the git commit message [2]. Thanks :-) [1] http://lists.ovirt.org/pipermail/users/2015-November/035947.html [2] https://gerrit.ovirt.org/48596 Best, -- Didi ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Reported-By - giving credit to our testers
On Sun, Nov 15, 2015 at 9:35 PM, Ondřej Svobodawrote: > On 13.11.2015 07:55, Sandro Bonazzola wrote: > > > > On Thu, Nov 12, 2015 at 3:45 PM, Nir Soffer wrote: >> >> Hi all, >> >> Our QE (and sometimes our users) are working hard testing and >> reporting bugs, but >> their effort is never mentioned in our code. >> >> Looking at kernel git history, I found that they are using the >> Reported-By header for >> giving credit to the person reporting a bug. I suggest we adapt this >> header. >> >> Here are some examples how we can use it: >> >> - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG >> - >> https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd >> - >> https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598 > > > infra: looking at above commit messages, can we get automatically added the > following lines? > > Reviewed-on: https://gerrit.ovirt.org/46540 > on patch creation > > Reviewed-by: Francesco Romani > on patch comment > > > +1 both to Nir's original idea and to Sandro's suggestions. Now encountered [1] my first such case since this thread, and not sure I agree to automatically add people. Some people might not want that at all, some would prefer to have control over their name, some might prefer an email address different from the one used for posting or no email address at all. I usually ask people to open a bug or comment on an existing bug. Isn't that enough? Are git logs so much more important than bugzilla history? Another option I can think of is: Report-Url: http://lists.ovirt.org/pipermail/users/2015-November/035947.html Adding Christian, the reporter of [1]. Christian, feel free to ignore current thread, and/or voice up your opinion, and/or say if you want to appear as "Reported-By:" in the git commit message [2]. Thanks :-) [1] http://lists.ovirt.org/pipermail/users/2015-November/035947.html [2] https://gerrit.ovirt.org/48596 Best, -- Didi ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Reported-By - giving credit to our testers
+1 Let's add this to the standard commit msg template, so it won't be forgotten unintentionally. Shmuel On Thu, Nov 12, 2015 at 4:45 PM, Nir Sofferwrote: > Hi all, > > Our QE (and sometimes our users) are working hard testing and > reporting bugs, but > their effort is never mentioned in our code. > > Looking at kernel git history, I found that they are using the > Reported-By header for > giving credit to the person reporting a bug. I suggest we adapt this > header. > > Here are some examples how we can use it: > > - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG > - > https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd > - > https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598 > > Thanks, > Nir > ___ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Reported-By - giving credit to our testers
+1 Thanks, Tomer - Original Message - From: "Shmuel Melamud" <smela...@redhat.com> To: "Nir Soffer" <nsof...@redhat.com> Cc: "Piotr Kliczewski" <pklic...@redhat.com>, "devel" <devel@ovirt.org> Sent: Sunday, November 15, 2015 12:26:26 PM Subject: Re: [ovirt-devel] Reported-By - giving credit to our testers +1 Let's add this to the standard commit msg template, so it won't be forgotten unintentionally. Shmuel On Thu, Nov 12, 2015 at 4:45 PM, Nir Soffer < nsof...@redhat.com > wrote: Hi all, Our QE (and sometimes our users) are working hard testing and reporting bugs, but their effort is never mentioned in our code. Looking at kernel git history, I found that they are using the Reported-By header for giving credit to the person reporting a bug. I suggest we adapt this header. Here are some examples how we can use it: - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG - https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd - https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598 Thanks, Nir ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Reported-By - giving credit to our testers
On 13.11.2015 07:55, Sandro Bonazzola wrote: On Thu, Nov 12, 2015 at 3:45 PM, Nir Soffer> wrote: Hi all, Our QE (and sometimes our users) are working hard testing and reporting bugs, but their effort is never mentioned in our code. Looking at kernel git history, I found that they are using the Reported-By header for giving credit to the person reporting a bug. I suggest we adapt this header. Here are some examples how we can use it: - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG - https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd - https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598 infra: looking at above commit messages, can we get automatically added the following lines? Reviewed-on: https://gerrit.ovirt.org/46540 on patch creation Reviewed-by: Francesco Romani > on patch comment +1 both to Nir's original idea and to Sandro's suggestions. ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Reported-By - giving credit to our testers
+1 - Original Message - > From: "Nir Soffer" <nsof...@redhat.com> > To: "devel" <devel@ovirt.org> > Cc: "Piotr Kliczewski" <pklic...@redhat.com> > Sent: Thursday, November 12, 2015 3:45:13 PM > Subject: [ovirt-devel] Reported-By - giving credit to our testers > > Hi all, > > Our QE (and sometimes our users) are working hard testing and > reporting bugs, but > their effort is never mentioned in our code. > > Looking at kernel git history, I found that they are using the > Reported-By header for > giving credit to the person reporting a bug. I suggest we adapt this header. > > Here are some examples how we can use it: > > - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG > - > https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd > - > https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598 > > Thanks, > Nir > ___ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Reported-By - giving credit to our testers
On Thu, Nov 12, 2015 at 3:45 PM, Nir Sofferwrote: > Hi all, > > Our QE (and sometimes our users) are working hard testing and > reporting bugs, but > their effort is never mentioned in our code. > > Looking at kernel git history, I found that they are using the > Reported-By header for > giving credit to the person reporting a bug. I suggest we adapt this > header. > > Here are some examples how we can use it: > > - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG > - > https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd > - > https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598 infra: looking at above commit messages, can we get automatically added the following lines? Reviewed-on: https://gerrit.ovirt.org/46540 on patch creation Reviewed-by: Francesco Romani on patch comment > > > Thanks, > Nir > ___ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Reported-By - giving credit to our testers
- Original Message - > From: "Nir Soffer"> To: "devel" > Cc: "Dan Kenigsberg" , "Francesco Romani" > , "Piotr Kliczewski" > , "Adam Litke" , "Allon Mureinik" > > Sent: Thursday, November 12, 2015 3:45:13 PM > Subject: Reported-By - giving credit to our testers > > Hi all, > > Our QE (and sometimes our users) are working hard testing and > reporting bugs, but > their effort is never mentioned in our code. > > Looking at kernel git history, I found that they are using the > Reported-By header for > giving credit to the person reporting a bug. I suggest we adapt this header. Strongly agreed, let's do this! Bests, -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Reported-By - giving credit to our testers
On 11/12, Francesco Romani wrote: > - Original Message - > > From: "Nir Soffer"> > To: "devel" > > Cc: "Dan Kenigsberg" , "Francesco Romani" > > , "Piotr Kliczewski" > > , "Adam Litke" , "Allon Mureinik" > > > > Sent: Thursday, November 12, 2015 3:45:13 PM > > Subject: Reported-By - giving credit to our testers > > > > Hi all, > > > > Our QE (and sometimes our users) are working hard testing and > > reporting bugs, but > > their effort is never mentioned in our code. > > > > Looking at kernel git history, I found that they are using the > > Reported-By header for > > giving credit to the person reporting a bug. I suggest we adapt this header. > > Strongly agreed, let's do this! +1 > > Bests, > > -- > Francesco Romani > RedHat Engineering Virtualization R & D > Phone: 8261328 > IRC: fromani > ___ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 signature.asc Description: PGP signature ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] Reported-By - giving credit to our testers
Hi all, Our QE (and sometimes our users) are working hard testing and reporting bugs, but their effort is never mentioned in our code. Looking at kernel git history, I found that they are using the Reported-By header for giving credit to the person reporting a bug. I suggest we adapt this header. Here are some examples how we can use it: - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG - https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd - https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598 Thanks, Nir ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Reported-By - giving credit to our testers
On Thu, Nov 12, 2015 at 3:49 PM, David Carowrote: > On 11/12, Francesco Romani wrote: > > - Original Message - > > > From: "Nir Soffer" > > > To: "devel" > > > Cc: "Dan Kenigsberg" , "Francesco Romani" < > from...@redhat.com>, "Piotr Kliczewski" > > > , "Adam Litke" , "Allon > Mureinik" > > > Sent: Thursday, November 12, 2015 3:45:13 PM > > > Subject: Reported-By - giving credit to our testers > > > > > > Hi all, > > > > > > Our QE (and sometimes our users) are working hard testing and > > > reporting bugs, but > > > their effort is never mentioned in our code. > > > > > > Looking at kernel git history, I found that they are using the > > > Reported-By header for > > > giving credit to the person reporting a bug. I suggest we adapt this > header. > > > > Strongly agreed, let's do this! > > +1 > > +1 > > > > Bests, > > > > -- > > Francesco Romani > > RedHat Engineering Virtualization R & D > > Phone: 8261328 > > IRC: fromani > > ___ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > -- > David Caro > > Red Hat S.L. > Continuous Integration Engineer - EMEA ENG Virtualization R > > Tel.: +420 532 294 605 > Email: dc...@redhat.com > Web: www.redhat.com > RHT Global #: 82-62605 > ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Reported-By - giving credit to our testers
- Original Message - > From: "Yaniv Kaul" <yk...@redhat.com> > To: "Nir Soffer" <nsof...@redhat.com> > Cc: "Piotr Kliczewski" <pklic...@redhat.com>, "devel" <devel@ovirt.org> > Sent: Thursday, November 12, 2015 4:55:10 PM > Subject: Re: [ovirt-devel] Reported-By - giving credit to our testers > > On Thu, Nov 12, 2015 at 4:45 PM, Nir Soffer < nsof...@redhat.com > wrote: > > > Hi all, > > Our QE (and sometimes our users) are working hard testing and > reporting bugs, but > their effort is never mentioned in our code. > > Looking at kernel git history, I found that they are using the > Reported-By header for > giving credit to the person reporting a bug. I suggest we adapt this header. > > Here are some examples how we can use it: > > - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG > - > https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd > - > https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598 > > Thanks, > Nir > ___ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > > +1 > > In case they help with the verification of the change, I suggest adding > Tested-By which is just as important. > From https://www.kernel.org/doc/Documentation/SubmittingPatches : > > A Tested-by: tag indicates that the patch has been successfully tested (in > some environment) by the person named. This tag informs maintainers that > some testing has been performed, provides a means to locate testers for > future patches, and ensures credit for the testers. This meant to give credit for whoever is doing that in his own time, not for cooperation that pays for QA nor replace bugzilla. If you go over the logs, you will see I provide Reported-By and Tested-By two who produce significant effort in helping out a case. > > Y. > > ___ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Reported-By - giving credit to our testers
On Thu, Nov 12, 2015 at 4:45 PM, Nir Sofferwrote: > Hi all, > > Our QE (and sometimes our users) are working hard testing and > reporting bugs, but > their effort is never mentioned in our code. > > Looking at kernel git history, I found that they are using the > Reported-By header for > giving credit to the person reporting a bug. I suggest we adapt this > header. > > Here are some examples how we can use it: > > - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG > - > https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd > - > https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598 > > Thanks, > Nir > ___ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > +1 In case they help with the verification of the change, I suggest adding Tested-By which is just as important. >From https://www.kernel.org/doc/Documentation/SubmittingPatches : A Tested-by: tag indicates that the patch has been successfully tested (in some environment) by the person named. This tag informs maintainers that some testing has been performed, provides a means to locate testers for future patches, and ensures credit for the testers. Y. ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Reported-By - giving credit to our testers
+1 - Original Message - > From: "Nir Soffer" <nsof...@redhat.com> > To: "devel" <devel@ovirt.org> > Cc: "Piotr Kliczewski" <pklic...@redhat.com> > Sent: Thursday, November 12, 2015 4:45:13 PM > Subject: [ovirt-devel] Reported-By - giving credit to our testers > > Hi all, > > Our QE (and sometimes our users) are working hard testing and > reporting bugs, but > their effort is never mentioned in our code. > > Looking at kernel git history, I found that they are using the > Reported-By header for > giving credit to the person reporting a bug. I suggest we adapt this header. > > Here are some examples how we can use it: > > - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG > - > https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd > - > https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598 > > Thanks, > Nir > ___ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel