Re: [ovirt-devel] Gerrit restart
Can you provide more detailed information please? * Full command line you did run * Full ssh config for gerit.us * git remote -v * git log --graph --decorate --pretty=oneline --abbrev-commit -100 * git branch -a -v * git config --get-regexp user.* That way we can start looking into it. Thanks! On 02/24, Vered Volansky wrote: Hi, I can't push a patch: ! [remote rejected] HEAD - res/for/master (prohibited by Gerrit) error: failed to push some refs to 'gerrit.us:ovirt-engine' I also can't ssh gerrit.ovirt.org: Permission denied (publickey,gssapi-keyex,gssapi-with-mic). Obviously nothing changed in my .ssh/gerrit ssh public keys setting. Thanks, Vered - Original Message - From: David Caro dcaro...@redhat.com To: devel@ovirt.org Sent: Monday, February 23, 2015 12:31:24 PM Subject: [ovirt-devel] Gerrit restart Hi! After this morning upgrade, gerrit http access has stopped working, I'm trying to solve it but in the meantime I might have to restart gerrit a couple of times, you can still use git or ssh to clone repos. I'll update when finished. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 pgpQRztVOAfgN.pgp Description: PGP signature ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Gerrit restart
- Original Message - From: David Caro dcaro...@redhat.com To: devel@ovirt.org Sent: Monday, February 23, 2015 12:54:26 PM Subject: Re: [ovirt-devel] Gerrit restart I've done a few tests now and everything seems to work as expected, can anyone confirm that it's working for him? It seem to work but there are few issues: 1. Vertical and horizontal scrolling in the commit message pane The new version assume that the commit message is limited to about 70 characters, which is not true practically. The commit message must include sometimes much wider content, and the view should display correctly our data instead of trying to force the views of the tool authors. Example: http://gerrit.ovirt.org/36593 2. The changes view (http://gerrit.ovirt.org/#/dashboard/self) Show a new Status column, which has two issues: - Showing Draft or Merge Conflict - these are separate concepts - Showing Merge Conflict when there is no merge conflict Example: http://gerrit.ovirt.org/38044 3. The new Conflict with pane seems incorrect about patches which do not conflict (at least not when merged in the correct order of dependencies). Example: http://gerrit.ovirt.org/37727 So this seems to be a regression. Can we test such upgrades with our data before we deploy them? Nir If noone replies, I'll consider it solved cheers On 02/23, David Caro wrote: Hi! After this morning upgrade, gerrit http access has stopped working, I'm trying to solve it but in the meantime I might have to restart gerrit a couple of times, you can still use git or ssh to clone repos. I'll update when finished. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Gerrit restart
I've done a few tests now and everything seems to work as expected, can anyone confirm that it's working for him? If noone replies, I'll consider it solved cheers On 02/23, David Caro wrote: Hi! After this morning upgrade, gerrit http access has stopped working, I'm trying to solve it but in the meantime I might have to restart gerrit a couple of times, you can still use git or ssh to clone repos. I'll update when finished. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 pgpLOgtJbEWwi.pgp Description: PGP signature ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Gerrit restart
Ok, not to jinx it, but login seems to be working now :-) - Original Message - From: Martin Betak mbe...@redhat.com To: David Caro dcaro...@redhat.com Cc: devel@ovirt.org Sent: Monday, February 23, 2015 1:19:04 PM Subject: Re: [ovirt-devel] Gerrit restart I have trouble signing-in. It returns 404: The requested URL /login/#/c/32907/ was not found on this server. Martin - Original Message - From: David Caro dcaro...@redhat.com To: devel@ovirt.org Sent: Monday, February 23, 2015 11:54:26 AM Subject: Re: [ovirt-devel] Gerrit restart I've done a few tests now and everything seems to work as expected, can anyone confirm that it's working for him? If noone replies, I'll consider it solved cheers On 02/23, David Caro wrote: Hi! After this morning upgrade, gerrit http access has stopped working, I'm trying to solve it but in the meantime I might have to restart gerrit a couple of times, you can still use git or ssh to clone repos. I'll update when finished. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Gerrit restart
I have trouble signing-in. It returns 404: The requested URL /login/#/c/32907/ was not found on this server. Martin - Original Message - From: David Caro dcaro...@redhat.com To: devel@ovirt.org Sent: Monday, February 23, 2015 11:54:26 AM Subject: Re: [ovirt-devel] Gerrit restart I've done a few tests now and everything seems to work as expected, can anyone confirm that it's working for him? If noone replies, I'll consider it solved cheers On 02/23, David Caro wrote: Hi! After this morning upgrade, gerrit http access has stopped working, I'm trying to solve it but in the meantime I might have to restart gerrit a couple of times, you can still use git or ssh to clone repos. I'll update when finished. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Gerrit restart
On 02/23, Martin Perina wrote: Hi, this Cannot merge error shown in Strategy: Rebase if Necessary line is strange. For example patch [1] is rebased on top of master and locally I cannot see any path conflict, build was including tests was OK. Same as Nir patch, you can't cherry-pick that patch by itself: 01:36 PM ~/Work/redhat/ovirt/ovirt-engine (master|✔) dcaro@brete$ git fetch ssh://dc...@gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/38059/1 git cherry-pick FETCH_HEAD remote: Counting objects: 19408, done remote: Finding sources: 100% (123/123) remote: Total 123 (delta 45), reused 115 (delta 45) Receiving objects: 100% (123/123), 40.06 KiB | 0 bytes/s, done. Resolving deltas: 100% (45/45), completed with 42 local objects. From ssh://gerrit.ovirt.org:29418/ovirt-engine * branchrefs/changes/59/38059/1 - FETCH_HEAD error: could not apply 07a90af... core: Refactor FenceActionType hint: after resolving the conflicts, mark the corrected paths hint: with 'git add paths' or 'git rm paths' hint: and commit the result with 'git commit' 01:37 PM ~/Work/redhat/ovirt/ovirt-engine (master|● 19✖ 1✚ 1) dcaro@brete$ Once you merge the patch it depends on, It should stop showing that message. Martin [1] http://gerrit.ovirt.org/38059 - Original Message - From: Nir Soffer nsof...@redhat.com To: David Caro dcaro...@redhat.com Cc: devel@ovirt.org Sent: Monday, February 23, 2015 12:33:24 PM Subject: Re: [ovirt-devel] Gerrit restart - Original Message - From: David Caro dcaro...@redhat.com To: devel@ovirt.org Sent: Monday, February 23, 2015 12:54:26 PM Subject: Re: [ovirt-devel] Gerrit restart I've done a few tests now and everything seems to work as expected, can anyone confirm that it's working for him? It seem to work but there are few issues: 1. Vertical and horizontal scrolling in the commit message pane The new version assume that the commit message is limited to about 70 characters, which is not true practically. The commit message must include sometimes much wider content, and the view should display correctly our data instead of trying to force the views of the tool authors. Example: http://gerrit.ovirt.org/36593 2. The changes view (http://gerrit.ovirt.org/#/dashboard/self) Show a new Status column, which has two issues: - Showing Draft or Merge Conflict - these are separate concepts - Showing Merge Conflict when there is no merge conflict Example: http://gerrit.ovirt.org/38044 3. The new Conflict with pane seems incorrect about patches which do not conflict (at least not when merged in the correct order of dependencies). Example: http://gerrit.ovirt.org/37727 So this seems to be a regression. Can we test such upgrades with our data before we deploy them? Nir If noone replies, I'll consider it solved cheers On 02/23, David Caro wrote: Hi! After this morning upgrade, gerrit http access has stopped working, I'm trying to solve it but in the meantime I might have to restart gerrit a couple of times, you can still use git or ssh to clone repos. I'll update when finished. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 pgpOyzS4FOdZH.pgp Description: PGP signature ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Gerrit restart
On 02/23, David Caro wrote: On 02/23, Nir Soffer wrote: - Original Message - From: David Caro dcaro...@redhat.com To: Martin Perina mper...@redhat.com Cc: devel@ovirt.org, Nir Soffer nsof...@redhat.com Sent: Monday, February 23, 2015 2:39:42 PM Subject: Re: [ovirt-devel] Gerrit restart On 02/23, Martin Perina wrote: Hi, this Cannot merge error shown in Strategy: Rebase if Necessary line is strange. For example patch [1] is rebased on top of master and locally I cannot see any path conflict, build was including tests was OK. Same as Nir patch, you can't cherry-pick that patch by itself: 01:36 PM ~/Work/redhat/ovirt/ovirt-engine (master|✔) dcaro@brete$ git fetch ssh://dc...@gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/38059/1 git cherry-pick FETCH_HEAD remote: Counting objects: 19408, done remote: Finding sources: 100% (123/123) remote: Total 123 (delta 45), reused 115 (delta 45) Receiving objects: 100% (123/123), 40.06 KiB | 0 bytes/s, done. Resolving deltas: 100% (45/45), completed with 42 local objects. From ssh://gerrit.ovirt.org:29418/ovirt-engine * branchrefs/changes/59/38059/1 - FETCH_HEAD error: could not apply 07a90af... core: Refactor FenceActionType hint: after resolving the conflicts, mark the corrected paths hint: with 'git add paths' or 'git rm paths' hint: and commit the result with 'git commit' 01:37 PM ~/Work/redhat/ovirt/ovirt-engine (master|● 19✖ 1✚ 1) dcaro@brete$ Once you merge the patch it depends on, It should stop showing that message. Yea, but we do not suggest this patch alone, it is part of a series, which gerrit knows about. Maybe there is a new configuration to disable these messages? I don't see it in the config documentation. Feel free to open a bug to gerrit if it bothers you enough or if you want it changed. We can also do as openstack and have our own gerrit clone with custom patches, but as always, that requires someone/s to maintain it and develop it. That would allow us to have the nice jenkins side pannel that they have too: https://review.openstack.org/#/c/157452/ Martin [1] http://gerrit.ovirt.org/38059 - Original Message - From: Nir Soffer nsof...@redhat.com To: David Caro dcaro...@redhat.com Cc: devel@ovirt.org Sent: Monday, February 23, 2015 12:33:24 PM Subject: Re: [ovirt-devel] Gerrit restart - Original Message - From: David Caro dcaro...@redhat.com To: devel@ovirt.org Sent: Monday, February 23, 2015 12:54:26 PM Subject: Re: [ovirt-devel] Gerrit restart I've done a few tests now and everything seems to work as expected, can anyone confirm that it's working for him? It seem to work but there are few issues: 1. Vertical and horizontal scrolling in the commit message pane The new version assume that the commit message is limited to about 70 characters, which is not true practically. The commit message must include sometimes much wider content, and the view should display correctly our data instead of trying to force the views of the tool authors. Example: http://gerrit.ovirt.org/36593 2. The changes view (http://gerrit.ovirt.org/#/dashboard/self) Show a new Status column, which has two issues: - Showing Draft or Merge Conflict - these are separate concepts - Showing Merge Conflict when there is no merge conflict Example: http://gerrit.ovirt.org/38044 3. The new Conflict with pane seems incorrect about patches which do not conflict (at least not when merged in the correct order of dependencies). Example: http://gerrit.ovirt.org/37727 So this seems to be a regression. Can we test such upgrades with our data before we deploy them? Nir If noone replies, I'll consider it solved cheers On 02/23, David Caro wrote: Hi! After this morning upgrade, gerrit http access has stopped working, I'm trying to solve it but in the meantime I might have to restart gerrit a couple of times, you can still use git or ssh to clone repos. I'll update when finished. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605
Re: [ovirt-devel] Gerrit restart
On 02/23, Nir Soffer wrote: - Original Message - From: David Caro dcaro...@redhat.com To: Martin Perina mper...@redhat.com Cc: devel@ovirt.org, Nir Soffer nsof...@redhat.com Sent: Monday, February 23, 2015 2:39:42 PM Subject: Re: [ovirt-devel] Gerrit restart On 02/23, Martin Perina wrote: Hi, this Cannot merge error shown in Strategy: Rebase if Necessary line is strange. For example patch [1] is rebased on top of master and locally I cannot see any path conflict, build was including tests was OK. Same as Nir patch, you can't cherry-pick that patch by itself: 01:36 PM ~/Work/redhat/ovirt/ovirt-engine (master|✔) dcaro@brete$ git fetch ssh://dc...@gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/38059/1 git cherry-pick FETCH_HEAD remote: Counting objects: 19408, done remote: Finding sources: 100% (123/123) remote: Total 123 (delta 45), reused 115 (delta 45) Receiving objects: 100% (123/123), 40.06 KiB | 0 bytes/s, done. Resolving deltas: 100% (45/45), completed with 42 local objects. From ssh://gerrit.ovirt.org:29418/ovirt-engine * branchrefs/changes/59/38059/1 - FETCH_HEAD error: could not apply 07a90af... core: Refactor FenceActionType hint: after resolving the conflicts, mark the corrected paths hint: with 'git add paths' or 'git rm paths' hint: and commit the result with 'git commit' 01:37 PM ~/Work/redhat/ovirt/ovirt-engine (master|● 19✖ 1✚ 1) dcaro@brete$ Once you merge the patch it depends on, It should stop showing that message. Yea, but we do not suggest this patch alone, it is part of a series, which gerrit knows about. Maybe there is a new configuration to disable these messages? I don't see it in the config documentation. Feel free to open a bug to gerrit if it bothers you enough or if you want it changed. We can also do as openstack and have our own gerrit clone with custom patches, but as always, that requires someone/s to maintain it and develop it. Martin [1] http://gerrit.ovirt.org/38059 - Original Message - From: Nir Soffer nsof...@redhat.com To: David Caro dcaro...@redhat.com Cc: devel@ovirt.org Sent: Monday, February 23, 2015 12:33:24 PM Subject: Re: [ovirt-devel] Gerrit restart - Original Message - From: David Caro dcaro...@redhat.com To: devel@ovirt.org Sent: Monday, February 23, 2015 12:54:26 PM Subject: Re: [ovirt-devel] Gerrit restart I've done a few tests now and everything seems to work as expected, can anyone confirm that it's working for him? It seem to work but there are few issues: 1. Vertical and horizontal scrolling in the commit message pane The new version assume that the commit message is limited to about 70 characters, which is not true practically. The commit message must include sometimes much wider content, and the view should display correctly our data instead of trying to force the views of the tool authors. Example: http://gerrit.ovirt.org/36593 2. The changes view (http://gerrit.ovirt.org/#/dashboard/self) Show a new Status column, which has two issues: - Showing Draft or Merge Conflict - these are separate concepts - Showing Merge Conflict when there is no merge conflict Example: http://gerrit.ovirt.org/38044 3. The new Conflict with pane seems incorrect about patches which do not conflict (at least not when merged in the correct order of dependencies). Example: http://gerrit.ovirt.org/37727 So this seems to be a regression. Can we test such upgrades with our data before we deploy them? Nir If noone replies, I'll consider it solved cheers On 02/23, David Caro wrote: Hi! After this morning upgrade, gerrit http access has stopped working, I'm trying to solve it but in the meantime I might have to restart gerrit a couple of times, you can still use git or ssh to clone repos. I'll update when finished. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list
Re: [ovirt-devel] Gerrit restart
- Original Message - From: David Caro dcaro...@redhat.com To: Martin Perina mper...@redhat.com Cc: devel@ovirt.org, Nir Soffer nsof...@redhat.com Sent: Monday, February 23, 2015 2:39:42 PM Subject: Re: [ovirt-devel] Gerrit restart On 02/23, Martin Perina wrote: Hi, this Cannot merge error shown in Strategy: Rebase if Necessary line is strange. For example patch [1] is rebased on top of master and locally I cannot see any path conflict, build was including tests was OK. Same as Nir patch, you can't cherry-pick that patch by itself: 01:36 PM ~/Work/redhat/ovirt/ovirt-engine (master|✔) dcaro@brete$ git fetch ssh://dc...@gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/38059/1 git cherry-pick FETCH_HEAD remote: Counting objects: 19408, done remote: Finding sources: 100% (123/123) remote: Total 123 (delta 45), reused 115 (delta 45) Receiving objects: 100% (123/123), 40.06 KiB | 0 bytes/s, done. Resolving deltas: 100% (45/45), completed with 42 local objects. From ssh://gerrit.ovirt.org:29418/ovirt-engine * branchrefs/changes/59/38059/1 - FETCH_HEAD error: could not apply 07a90af... core: Refactor FenceActionType hint: after resolving the conflicts, mark the corrected paths hint: with 'git add paths' or 'git rm paths' hint: and commit the result with 'git commit' 01:37 PM ~/Work/redhat/ovirt/ovirt-engine (master|● 19✖ 1✚ 1) dcaro@brete$ Once you merge the patch it depends on, It should stop showing that message. Yea, but we do not suggest this patch alone, it is part of a series, which gerrit knows about. Maybe there is a new configuration to disable these messages? Martin [1] http://gerrit.ovirt.org/38059 - Original Message - From: Nir Soffer nsof...@redhat.com To: David Caro dcaro...@redhat.com Cc: devel@ovirt.org Sent: Monday, February 23, 2015 12:33:24 PM Subject: Re: [ovirt-devel] Gerrit restart - Original Message - From: David Caro dcaro...@redhat.com To: devel@ovirt.org Sent: Monday, February 23, 2015 12:54:26 PM Subject: Re: [ovirt-devel] Gerrit restart I've done a few tests now and everything seems to work as expected, can anyone confirm that it's working for him? It seem to work but there are few issues: 1. Vertical and horizontal scrolling in the commit message pane The new version assume that the commit message is limited to about 70 characters, which is not true practically. The commit message must include sometimes much wider content, and the view should display correctly our data instead of trying to force the views of the tool authors. Example: http://gerrit.ovirt.org/36593 2. The changes view (http://gerrit.ovirt.org/#/dashboard/self) Show a new Status column, which has two issues: - Showing Draft or Merge Conflict - these are separate concepts - Showing Merge Conflict when there is no merge conflict Example: http://gerrit.ovirt.org/38044 3. The new Conflict with pane seems incorrect about patches which do not conflict (at least not when merged in the correct order of dependencies). Example: http://gerrit.ovirt.org/37727 So this seems to be a regression. Can we test such upgrades with our data before we deploy them? Nir If noone replies, I'll consider it solved cheers On 02/23, David Caro wrote: Hi! After this morning upgrade, gerrit http access has stopped working, I'm trying to solve it but in the meantime I might have to restart gerrit a couple of times, you can still use git or ssh to clone repos. I'll update when finished. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Gerrit restart
- Original Message - From: David Caro dcaro...@redhat.com To: Nir Soffer nsof...@redhat.com Cc: Martin Perina mper...@redhat.com, devel@ovirt.org Sent: Monday, February 23, 2015 3:09:08 PM Subject: Re: [ovirt-devel] Gerrit restart On 02/23, David Caro wrote: On 02/23, Nir Soffer wrote: - Original Message - From: David Caro dcaro...@redhat.com To: Martin Perina mper...@redhat.com Cc: devel@ovirt.org, Nir Soffer nsof...@redhat.com Sent: Monday, February 23, 2015 2:39:42 PM Subject: Re: [ovirt-devel] Gerrit restart On 02/23, Martin Perina wrote: Hi, this Cannot merge error shown in Strategy: Rebase if Necessary line is strange. For example patch [1] is rebased on top of master and locally I cannot see any path conflict, build was including tests was OK. Same as Nir patch, you can't cherry-pick that patch by itself: 01:36 PM ~/Work/redhat/ovirt/ovirt-engine (master|✔) dcaro@brete$ git fetch ssh://dc...@gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/38059/1 git cherry-pick FETCH_HEAD remote: Counting objects: 19408, done remote: Finding sources: 100% (123/123) remote: Total 123 (delta 45), reused 115 (delta 45) Receiving objects: 100% (123/123), 40.06 KiB | 0 bytes/s, done. Resolving deltas: 100% (45/45), completed with 42 local objects. From ssh://gerrit.ovirt.org:29418/ovirt-engine * branchrefs/changes/59/38059/1 - FETCH_HEAD error: could not apply 07a90af... core: Refactor FenceActionType hint: after resolving the conflicts, mark the corrected paths hint: with 'git add paths' or 'git rm paths' hint: and commit the result with 'git commit' 01:37 PM ~/Work/redhat/ovirt/ovirt-engine (master|● 19✖ 1✚ 1) dcaro@brete$ Once you merge the patch it depends on, It should stop showing that message. Yea, but we do not suggest this patch alone, it is part of a series, which gerrit knows about. Maybe there is a new configuration to disable these messages? I don't see it in the config documentation. Feel free to open a bug to gerrit if it bothers you enough or if you want it changed. We can also do as openstack and have our own gerrit clone with custom patches, but as always, that requires someone/s to maintain it and develop it. That would allow us to have the nice jenkins side pannel that they have too: https://review.openstack.org/#/c/157452/ Reusing their efforts is an option if their version is significantly better. I don't think we have time to maintain our own patches to gerrit. Nir Martin [1] http://gerrit.ovirt.org/38059 - Original Message - From: Nir Soffer nsof...@redhat.com To: David Caro dcaro...@redhat.com Cc: devel@ovirt.org Sent: Monday, February 23, 2015 12:33:24 PM Subject: Re: [ovirt-devel] Gerrit restart - Original Message - From: David Caro dcaro...@redhat.com To: devel@ovirt.org Sent: Monday, February 23, 2015 12:54:26 PM Subject: Re: [ovirt-devel] Gerrit restart I've done a few tests now and everything seems to work as expected, can anyone confirm that it's working for him? It seem to work but there are few issues: 1. Vertical and horizontal scrolling in the commit message pane The new version assume that the commit message is limited to about 70 characters, which is not true practically. The commit message must include sometimes much wider content, and the view should display correctly our data instead of trying to force the views of the tool authors. Example: http://gerrit.ovirt.org/36593 2. The changes view (http://gerrit.ovirt.org/#/dashboard/self) Show a new Status column, which has two issues: - Showing Draft or Merge Conflict - these are separate concepts - Showing Merge Conflict when there is no merge conflict Example: http://gerrit.ovirt.org/38044 3. The new Conflict with pane seems incorrect about patches which do not conflict (at least not when merged in the correct order of dependencies). Example: http://gerrit.ovirt.org/37727 So this seems to be a regression. Can we test such upgrades with our data before we deploy them? Nir If noone replies, I'll consider it solved cheers On 02/23, David Caro wrote: Hi! After this morning upgrade, gerrit http access has stopped working, I'm trying to solve it but in the meantime I might have to restart gerrit a couple of times, you can still
Re: [ovirt-devel] Gerrit restart
Did you change anything? I've restated httpd to refresh the ssl cert (now it's a valid self-signed one). But that seems unrelated. On 02/23, Martin Betak wrote: Ok, not to jinx it, but login seems to be working now :-) - Original Message - From: Martin Betak mbe...@redhat.com To: David Caro dcaro...@redhat.com Cc: devel@ovirt.org Sent: Monday, February 23, 2015 1:19:04 PM Subject: Re: [ovirt-devel] Gerrit restart I have trouble signing-in. It returns 404: The requested URL /login/#/c/32907/ was not found on this server. Martin - Original Message - From: David Caro dcaro...@redhat.com To: devel@ovirt.org Sent: Monday, February 23, 2015 11:54:26 AM Subject: Re: [ovirt-devel] Gerrit restart I've done a few tests now and everything seems to work as expected, can anyone confirm that it's working for him? If noone replies, I'll consider it solved cheers On 02/23, David Caro wrote: Hi! After this morning upgrade, gerrit http access has stopped working, I'm trying to solve it but in the meantime I might have to restart gerrit a couple of times, you can still use git or ssh to clone repos. I'll update when finished. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 pgpTmeE7ZeWY5.pgp Description: PGP signature ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Gerrit restart
On 02/23, Nir Soffer wrote: - Original Message - From: David Caro dcaro...@redhat.com To: devel@ovirt.org Sent: Monday, February 23, 2015 12:54:26 PM Subject: Re: [ovirt-devel] Gerrit restart I've done a few tests now and everything seems to work as expected, can anyone confirm that it's working for him? It seem to work but there are few issues: 1. Vertical and horizontal scrolling in the commit message pane The new version assume that the commit message is limited to about 70 characters, which is not true practically. The commit message must include sometimes much wider content, and the view should display correctly our data instead of trying to force the views of the tool authors. Example: http://gerrit.ovirt.org/36593 This has always been like that as far as I remember. Not a new issue. Actually now it allows you to scroll instead of letting the text go all the way out the screen, I think it's an improvement. 2. The changes view (http://gerrit.ovirt.org/#/dashboard/self) Show a new Status column, which has two issues: - Showing Draft or Merge Conflict - these are separate concepts That's a design decision, nothing we can do about. Feel free to develop a ui plugin to hide it if it bothers you, this new version allows it (the old did not). - Showing Merge Conflict when there is no merge conflict Example: http://gerrit.ovirt.org/38044 You can't cherry-pick that patch into master directly (vdsm project submit type is cherry-pick): 01:16 PM ~/Work/redhat/ovirt/vdsm (master|✔) dcaro@brete$ git fetch ssh://dc...@gerrit.ovirt.org:29418/vdsm refs/changes/28/38028/1 remote: Counting objects: 745, done remote: Finding sources: 100% (29/29) remote: Total 29 (delta 3), reused 9 (delta 3) Unpacking objects: 100% (29/29), done. From ssh://gerrit.ovirt.org:29418/vdsm * branchrefs/changes/28/38028/1 - FETCH_HEAD 01:16 PM ~/Work/redhat/ovirt/vdsm (master|✔) dcaro@brete$ git cherry-pick FETCH_HEAD error: could not apply 53f59a7... virt: Extract Vm.__extendDriveReplica method hint: after resolving the conflicts, mark the corrected paths hint: with 'git add paths' or 'git rm paths' hint: and commit the result with 'git commit' 01:17 PM ~/Work/redhat/ovirt/vdsm (master|✖ 1✚ 1) dcaro@brete$ 3. The new Conflict with pane seems incorrect about patches which do not conflict (at least not when merged in the correct order of dependencies). Example: http://gerrit.ovirt.org/37727 I don't think it's taking into account the deps, the conflict seems to be calculated from path to path directly. Feel free to open a but to gerrit if you think any of those issues should not be there or it's a bug. https://code.google.com/p/gerrit/issues/list So this seems to be a regression. Can we test such upgrades with our data before we deploy them? Sure, I'll ping you to do the testing next time we plan an upgrade, I'll have to trim down some of the data but I'll gladly spend some time on it to provide you with a working dataset you can install and test before the upgrade. Nir If noone replies, I'll consider it solved cheers On 02/23, David Caro wrote: Hi! After this morning upgrade, gerrit http access has stopped working, I'm trying to solve it but in the meantime I might have to restart gerrit a couple of times, you can still use git or ssh to clone repos. I'll update when finished. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 pgpw7m6KjpCgf.pgp Description: PGP signature ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Gerrit restart
Hi, When I try to click on a file within a patch that I've just submitted (or for any other file) I receive the following error message, with a dark background: Code Review - Error The page you requested was not found, or you do not have permission to view this page. Any idea ? Thanks, Moti - Original Message - From: David Caro dcaro...@redhat.com To: devel@ovirt.org Sent: Monday, February 23, 2015 12:31:24 PM Subject: [ovirt-devel] Gerrit restart Hi! After this morning upgrade, gerrit http access has stopped working, I'm trying to solve it but in the meantime I might have to restart gerrit a couple of times, you can still use git or ssh to clone repos. I'll update when finished. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Gerrit restart
I found out a few sec ago, that if you change the protocol from https to http in gerrit URL, everything works fine. Martin - Original Message - From: Moti Asayag masa...@redhat.com To: David Caro dcaro...@redhat.com Cc: devel@ovirt.org Sent: Monday, February 23, 2015 4:42:03 PM Subject: Re: [ovirt-devel] Gerrit restart Hi, When I try to click on a file within a patch that I've just submitted (or for any other file) I receive the following error message, with a dark background: Code Review - Error The page you requested was not found, or you do not have permission to view this page. Any idea ? Thanks, Moti - Original Message - From: David Caro dcaro...@redhat.com To: devel@ovirt.org Sent: Monday, February 23, 2015 12:31:24 PM Subject: [ovirt-devel] Gerrit restart Hi! After this morning upgrade, gerrit http access has stopped working, I'm trying to solve it but in the meantime I might have to restart gerrit a couple of times, you can still use git or ssh to clone repos. I'll update when finished. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
