Re: [ovirt-devel] Alternatives to automatically move bugs to MODIFIED

2016-08-17 Thread Nir Soffer
On Wed, Aug 17, 2016 at 1:45 PM, Eyal Edri  wrote:
> I still thinks its a very valuable hook and we are aware of the fact it has
> bugs,  especially with patches on master branch and 4.0.
>
> Shlomi from the infra team is working on a solution for it as we speak and
> we hope to have a solution in the next few days,  however it's not trival to
> test and requires setting up a staging env and improve loga for the hooks
> system.

How do you plan to solve this?

Only the owner of the bug knows if the all the required patches are merged
and backported to the correct repositories.

> On Aug 17, 2016 12:06 PM, "Eli Mesika"  wrote:
>>
>> I also got this, especially when bugs should be back-ported
>> +1 for option #1
>>
>> On Wed, Aug 17, 2016 at 10:10 AM, Yedidyah Bar David 
>> wrote:
>>>
>>> Hi all,
>>>
>>> We currently have a bot that automatically moves bugs from POST to
>>> MODIFIED
>>> if all linked patches on gerrit are merged.
>>>
>>> It happened to me personally several times that this was a wrong thing to
>>> do,
>>> either because a new patch was still needed but not pushed yet, or
>>> because
>>> an existing patch should have been back-ported to another branch and
>>> wasn't
>>> yet. Since I usually pay more attention to my bug in POST, I sometimes
>>> missed
>>> this and handled the missing patches (backports, usually) later than I
>>> could
>>> if left on POST.
>>>
>>> I have a feeling I am not the only one. So I suggest to stop doing this.
>>>
>>> I can think of several alternatives:
>>>
>>> 1. Do nothing. I think that's reasonable - I think most people pay more
>>> attention to POST bugs anyway.
>>>
>>> 2. Set needinfo on bug owner.
>>>
>>> 3. Send some alert email to relevant people (bug owner, existing patches
>>> owners,
>>> perhaps others - e.g. reviewers of existing patches, perhaps those
>>> that actually reviewed, etc.). Need to think how to make it not too
>>> annoying for others but
>>> still effective also if owner is on long PTO or something like that. New
>>> flag
>>> doesn't have to be very specific - can be called something like
>>> 'attention
>>> needed' or something like that.
>>>
>>> 4. Add a new flag for that and set it. This will allow easier
>>> filtering/reporting.
>>>
>>> What do you think?
>>> --
>>> Didi
>>> ___
>>> Devel mailing list
>>> Devel@ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>>
>>
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] Alternatives to automatically move bugs to MODIFIED

2016-08-17 Thread Sven Kieske
On 17/08/16 13:25, Nir Soffer wrote:
> Only the owner of the bug knows if the all the required patches are merged
> and backported to the correct repositories.

Why not just set needinfo on bug assignee when all linked patches
are merged? this would ensure that missing patches get uploaded
asap and once this is done and all patches are merged you can clear
needinfo and move the bug to modified manually?

-- 
Mit freundlichen Grüßen / Regards

Sven Kieske

Systemadministrator
Mittwald CM Service GmbH & Co. KG
Königsberger Straße 6
32339 Espelkamp
T: +495772 293100
F: +495772 29
https://www.mittwald.de
Geschäftsführer: Robert Meyer
St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen
Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen



signature.asc
Description: OpenPGP digital signature
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Alternatives to automatically move bugs to MODIFIED

2016-08-17 Thread Eyal Edri
I still thinks its a very valuable hook and we are aware of the fact it has
bugs,  especially with patches on master branch and 4.0.

Shlomi from the infra team is working on a solution for it as we speak and
we hope to have a solution in the next few days,  however it's not trival
to test and requires setting up a staging env and improve loga for the
hooks system.

On Aug 17, 2016 12:06 PM, "Eli Mesika"  wrote:

> I also got this, especially when bugs should be back-ported
> +1 for option #1
>
> On Wed, Aug 17, 2016 at 10:10 AM, Yedidyah Bar David 
> wrote:
>
>> Hi all,
>>
>> We currently have a bot that automatically moves bugs from POST to
>> MODIFIED
>> if all linked patches on gerrit are merged.
>>
>> It happened to me personally several times that this was a wrong thing to
>> do,
>> either because a new patch was still needed but not pushed yet, or because
>> an existing patch should have been back-ported to another branch and
>> wasn't
>> yet. Since I usually pay more attention to my bug in POST, I sometimes
>> missed
>> this and handled the missing patches (backports, usually) later than I
>> could
>> if left on POST.
>>
>> I have a feeling I am not the only one. So I suggest to stop doing this.
>>
>> I can think of several alternatives:
>>
>> 1. Do nothing. I think that's reasonable - I think most people pay more
>> attention to POST bugs anyway.
>>
>> 2. Set needinfo on bug owner.
>>
>> 3. Send some alert email to relevant people (bug owner, existing patches
>> owners,
>> perhaps others - e.g. reviewers of existing patches, perhaps those
>> that actually reviewed, etc.). Need to think how to make it not too
>> annoying for others but
>> still effective also if owner is on long PTO or something like that. New
>> flag
>> doesn't have to be very specific - can be called something like 'attention
>> needed' or something like that.
>>
>> 4. Add a new flag for that and set it. This will allow easier
>> filtering/reporting.
>>
>> What do you think?
>> --
>> Didi
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Alternatives to automatically move bugs to MODIFIED

2016-08-17 Thread Shlomo Ben David
Hi All,

I'm currently working to solve this issue.
I will update you when done :)

Best Regards,

Shlomi Ben-David | Software Engineer | Red Hat ISRAEL
Red Hat Certified System Administrator | Red Hat Certified Engineer
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Wed, Aug 17, 2016 at 10:10 AM, Yedidyah Bar David 
wrote:

> Hi all,
>
> We currently have a bot that automatically moves bugs from POST to MODIFIED
> if all linked patches on gerrit are merged.
>
> It happened to me personally several times that this was a wrong thing to
> do,
> either because a new patch was still needed but not pushed yet, or because
> an existing patch should have been back-ported to another branch and wasn't
> yet. Since I usually pay more attention to my bug in POST, I sometimes
> missed
> this and handled the missing patches (backports, usually) later than I
> could
> if left on POST.
>
> I have a feeling I am not the only one. So I suggest to stop doing this.
>
> I can think of several alternatives:
>
> 1. Do nothing. I think that's reasonable - I think most people pay more
> attention to POST bugs anyway.
>
> 2. Set needinfo on bug owner.
>
> 3. Send some alert email to relevant people (bug owner, existing patches
> owners,
> perhaps others - e.g. reviewers of existing patches, perhaps those
> that actually reviewed, etc.). Need to think how to make it not too
> annoying for others but
> still effective also if owner is on long PTO or something like that. New
> flag
> doesn't have to be very specific - can be called something like 'attention
> needed' or something like that.
>
> 4. Add a new flag for that and set it. This will allow easier
> filtering/reporting.
>
> What do you think?
> --
> Didi
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Alternatives to automatically move bugs to MODIFIED

2016-08-17 Thread Eyal Edri
On Wed, Aug 17, 2016 at 2:25 PM, Nir Soffer  wrote:

> On Wed, Aug 17, 2016 at 1:45 PM, Eyal Edri  wrote:
> > I still thinks its a very valuable hook and we are aware of the fact it
> has
> > bugs,  especially with patches on master branch and 4.0.
> >
> > Shlomi from the infra team is working on a solution for it as we speak
> and
> > we hope to have a solution in the next few days,  however it's not
> trival to
> > test and requires setting up a staging env and improve loga for the hooks
> > system.
>
> How do you plan to solve this?
>
> Only the owner of the bug knows if the all the required patches are merged
>

The authors should use Bug-Url on the main bug and related-to: on other
patches that are related.


> and backported to the correct repositories.
>

This is done with logic according to the bug target milestone.

for e.g - a patch on branch 'ovirt-engine-4.0' was merged to bug targeted
to ovirt-4.0.2.
The hook should check if branch 4.0.2 exists or not, if it exists then the
bug should NOT move to MODIFIED,
since it needs still backporting to ovirt-engine-4.0.2 branch.


>
> > On Aug 17, 2016 12:06 PM, "Eli Mesika"  wrote:
> >>
> >> I also got this, especially when bugs should be back-ported
> >> +1 for option #1
> >>
> >> On Wed, Aug 17, 2016 at 10:10 AM, Yedidyah Bar David 
> >> wrote:
> >>>
> >>> Hi all,
> >>>
> >>> We currently have a bot that automatically moves bugs from POST to
> >>> MODIFIED
> >>> if all linked patches on gerrit are merged.
> >>>
> >>> It happened to me personally several times that this was a wrong thing
> to
> >>> do,
> >>> either because a new patch was still needed but not pushed yet, or
> >>> because
> >>> an existing patch should have been back-ported to another branch and
> >>> wasn't
> >>> yet. Since I usually pay more attention to my bug in POST, I sometimes
> >>> missed
> >>> this and handled the missing patches (backports, usually) later than I
> >>> could
> >>> if left on POST.
> >>>
> >>> I have a feeling I am not the only one. So I suggest to stop doing
> this.
> >>>
> >>> I can think of several alternatives:
> >>>
> >>> 1. Do nothing. I think that's reasonable - I think most people pay more
> >>> attention to POST bugs anyway.
> >>>
> >>> 2. Set needinfo on bug owner.
> >>>
> >>> 3. Send some alert email to relevant people (bug owner, existing
> patches
> >>> owners,
> >>> perhaps others - e.g. reviewers of existing patches, perhaps those
> >>> that actually reviewed, etc.). Need to think how to make it not too
> >>> annoying for others but
> >>> still effective also if owner is on long PTO or something like that.
> New
> >>> flag
> >>> doesn't have to be very specific - can be called something like
> >>> 'attention
> >>> needed' or something like that.
> >>>
> >>> 4. Add a new flag for that and set it. This will allow easier
> >>> filtering/reporting.
> >>>
> >>> What do you think?
> >>> --
> >>> Didi
> >>> ___
> >>> Devel mailing list
> >>> Devel@ovirt.org
> >>> http://lists.ovirt.org/mailman/listinfo/devel
> >>
> >>
> >>
> >> ___
> >> Devel mailing list
> >> Devel@ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/devel
> >
> >
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
>



-- 
Eyal Edri
Associate Manager
RHV DevOps
EMEA ENG Virtualization R
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Alternatives to automatically move bugs to MODIFIED

2016-08-17 Thread Eyal Edri
On Wed, Aug 17, 2016 at 2:52 PM, Sven Kieske  wrote:

> On 17/08/16 13:25, Nir Soffer wrote:
> > Only the owner of the bug knows if the all the required patches are
> merged
> > and backported to the correct repositories.
>
> Why not just set needinfo on bug assignee when all linked patches
> are merged? this would ensure that missing patches get uploaded
> asap and once this is done and all patches are merged you can clear
> needinfo and move the bug to modified manually?
>

You're optimistic that you'll get the info in time before a build.
If you want a certain bug to be included in a release then you have to make
sure that bug
is on MODIFIED before build time, waiting on human to do instead of bot has
its cons:
 - the person can be on PTO / Leave and won't see the email - thus a bug
will miss a release
 - people miss emails all the time, especially if you have multiple work
with bugzilla, I remember more than once
bugs left with NEEDINFO for quite a long time.


In the end, I think we should still make an effort to find the right logic
to do with bot,
keeping this task manual will cause more bugs to be left on POST from my
experience (we used to do it in the past)


>
> --
> Mit freundlichen Grüßen / Regards
>
> Sven Kieske
>
> Systemadministrator
> Mittwald CM Service GmbH & Co. KG
> Königsberger Straße 6
> 32339 Espelkamp
> T: +495772 293100
> F: +495772 29
> https://www.mittwald.de
> Geschäftsführer: Robert Meyer
> St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen
> Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
>
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>



-- 
Eyal Edri
Associate Manager
RHV DevOps
EMEA ENG Virtualization R
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Alternatives to automatically move bugs to MODIFIED

2016-08-17 Thread Nir Soffer
On Wed, Aug 17, 2016 at 2:47 PM, Eyal Edri  wrote:
>
>
> On Wed, Aug 17, 2016 at 2:25 PM, Nir Soffer  wrote:
>>
>> On Wed, Aug 17, 2016 at 1:45 PM, Eyal Edri  wrote:
>> > I still thinks its a very valuable hook and we are aware of the fact it
>> > has
>> > bugs,  especially with patches on master branch and 4.0.
>> >
>> > Shlomi from the infra team is working on a solution for it as we speak
>> > and
>> > we hope to have a solution in the next few days,  however it's not
>> > trival to
>> > test and requires setting up a staging env and improve loga for the
>> > hooks
>> > system.
>>
>> How do you plan to solve this?
>>
>> Only the owner of the bug knows if the all the required patches are merged
>
>
> The authors should use Bug-Url on the main bug and related-to: on other
> patches that are related.

This is not possible. Many times you need series of patches to fix a bug, and
you the number of patches may change during development. You start with one
patch, and later you find that you need another one, so all of them will have
a bug url.

Practically, you should expect that all patches in the series will
have a bug-url.
If the hook will change the bug incorrectly someone will have to fix this, and
it is very unlikely that a developer will go to clean after the hook.

>> and backported to the correct repositories.
>
>
> This is done with logic according to the bug target milestone.
>
> for e.g - a patch on branch 'ovirt-engine-4.0' was merged to bug targeted to
> ovirt-4.0.2.
> The hook should check if branch 4.0.2 exists or not, if it exists then the
> bug should NOT move to MODIFIED,
> since it needs still backporting to ovirt-engine-4.0.2 branch.

This is too fragile. For example, maybe a 4.0.2 branch is created after
the patch was merged to 4.0 branch, and the patch will be missing, although
the bug is already set to modified.

Setting to modified should be done by the owner of the bug, after verifying
that the patches exists in correct branch.

I'm not suggesting to remove the hook, just disable the feature of making
a bug modified.

Nir
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] [VDSM] Build failure because missing ioprocess package in ovirt repos - solved

2016-08-17 Thread Nir Soffer
I posted this patch, changing python-ioprocess to require
ioprocess-version (instead of version-release). This seem to resolve
the issue and is more correct, we don't really need ioprocess from the
same build.

Please review
https://gerrit.ovirt.org/62464

Nir

On Wed, Aug 17, 2016 at 12:05 PM, Nir Soffer  wrote:
> בתאריך 17 באוג׳ 2016 8:54 לפנה״צ,‏ "Sandro Bonazzola" 
> כתב:
>>
>> The issue is different:
>> both x86_64 and ppc64le builds python-ioprocess package so a newer
>> python-ioprocess may come from ppc64le build not corresponding to an exact
>> nvr on x86_64.
>> Solution may be to chance the ioprocess build to drop the timestamp or
>> make the ioprocess build a matrix job building from the same src.rpm.
>> Another solution may be relax the nvr requirements in the python-ioprocess
>> package to not require the exact nvr but only the same version.
>> Another solution may be competely separate x86_64 and ppc64le repos.
>
> I think the issue is the requiring the a version with the timestamp and git
> commit, it sould only require the same version.
>
>
>>
>>
>>
>> On Sun, Aug 14, 2016 at 8:12 AM, Eyal Edri  wrote:
>>>
>>> Was the broken build replaced by new one that is working?
>>>
>>> On Fri, Aug 12, 2016 at 9:10 PM, Nir Soffer  wrote:

 Hi all,

 There was a broken build of ioprocess in ovirt repos, causing vdsm all
 vdsm master builds to fail with this error:

 ERROR: Command failed. See logs for output.

 If you have failed builds, please retrigger them in jenkins:
 http://jenkins.ovirt.org/gerrit_manual_trigger/

 Nir
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel


>>>
>>>
>>>
>>> --
>>> Eyal Edri
>>> Associate Manager
>>> RHV DevOps
>>> EMEA ENG Virtualization R
>>> Red Hat Israel
>>>
>>> phone: +972-9-7692018
>>> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>>
>>> ___
>>> Devel mailing list
>>> Devel@ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>>
>>
>>
>> --
>> Sandro Bonazzola
>> Better technology. Faster innovation. Powered by community collaboration.
>> See how it works at redhat.com
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Alternatives to automatically move bugs to MODIFIED

2016-08-17 Thread Nir Soffer
בתאריך 17 באוג׳ 2016 12:06 אחה״צ,‏ "Eli Mesika"  כתב:
>
> I also got this, especially when bugs should be back-ported
> +1 for option #1
>
> On Wed, Aug 17, 2016 at 10:10 AM, Yedidyah Bar David 
wrote:
>>
>> Hi all,
>>
>> We currently have a bot that automatically moves bugs from POST to
MODIFIED
>> if all linked patches on gerrit are merged.
>>
>> It happened to me personally several times that this was a wrong thing
to do,
>> either because a new patch was still needed but not pushed yet, or
because
>> an existing patch should have been back-ported to another branch and
wasn't
>> yet. Since I usually pay more attention to my bug in POST, I sometimes
missed
>> this and handled the missing patches (backports, usually) later than I
could
>> if left on POST.
>>
>> I have a feeling I am not the only one. So I suggest to stop doing this.
>>
>> I can think of several alternatives:
>>
>> 1. Do nothing. I think that's reasonable - I think most people pay more
>> attention to POST bugs anyway.

+1

>>
>> 2. Set needinfo on bug owner.
>>
>> 3. Send some alert email to relevant people (bug owner, existing patches
owners,
>> perhaps others - e.g. reviewers of existing patches, perhaps those
>> that actually reviewed, etc.). Need to think how to make it not too
>> annoying for others but
>> still effective also if owner is on long PTO or something like that. New
flag
>> doesn't have to be very specific - can be called something like
'attention
>> needed' or something like that.
>>
>> 4. Add a new flag for that and set it. This will allow easier
>> filtering/reporting.
>>
>> What do you think?
>> --
>> Didi
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>
>
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Alternatives to automatically move bugs to MODIFIED

2016-08-17 Thread Eli Mesika
I also got this, especially when bugs should be back-ported
+1 for option #1

On Wed, Aug 17, 2016 at 10:10 AM, Yedidyah Bar David 
wrote:

> Hi all,
>
> We currently have a bot that automatically moves bugs from POST to MODIFIED
> if all linked patches on gerrit are merged.
>
> It happened to me personally several times that this was a wrong thing to
> do,
> either because a new patch was still needed but not pushed yet, or because
> an existing patch should have been back-ported to another branch and wasn't
> yet. Since I usually pay more attention to my bug in POST, I sometimes
> missed
> this and handled the missing patches (backports, usually) later than I
> could
> if left on POST.
>
> I have a feeling I am not the only one. So I suggest to stop doing this.
>
> I can think of several alternatives:
>
> 1. Do nothing. I think that's reasonable - I think most people pay more
> attention to POST bugs anyway.
>
> 2. Set needinfo on bug owner.
>
> 3. Send some alert email to relevant people (bug owner, existing patches
> owners,
> perhaps others - e.g. reviewers of existing patches, perhaps those
> that actually reviewed, etc.). Need to think how to make it not too
> annoying for others but
> still effective also if owner is on long PTO or something like that. New
> flag
> doesn't have to be very specific - can be called something like 'attention
> needed' or something like that.
>
> 4. Add a new flag for that and set it. This will allow easier
> filtering/reporting.
>
> What do you think?
> --
> Didi
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [VDSM] Build failure because missing ioprocess package in ovirt repos - solved

2016-08-17 Thread Nir Soffer
בתאריך 17 באוג׳ 2016 8:54 לפנה״צ,‏ "Sandro Bonazzola" 
כתב:
>
> The issue is different:
> both x86_64 and ppc64le builds python-ioprocess package so a newer
python-ioprocess may come from ppc64le build not corresponding to an exact
nvr on x86_64.
> Solution may be to chance the ioprocess build to drop the timestamp or
make the ioprocess build a matrix job building from the same src.rpm.
> Another solution may be relax the nvr requirements in the
python-ioprocess package to not require the exact nvr but only the same
version.
> Another solution may be competely separate x86_64 and ppc64le repos.

I think the issue is the requiring the a version with the timestamp and git
commit, it sould only require the same version.
>
>
>
> On Sun, Aug 14, 2016 at 8:12 AM, Eyal Edri  wrote:
>>
>> Was the broken build replaced by new one that is working?
>>
>> On Fri, Aug 12, 2016 at 9:10 PM, Nir Soffer  wrote:
>>>
>>> Hi all,
>>>
>>> There was a broken build of ioprocess in ovirt repos, causing vdsm all
>>> vdsm master builds to fail with this error:
>>>
>>> ERROR: Command failed. See logs for output.
>>>
>>> If you have failed builds, please retrigger them in jenkins:
>>> http://jenkins.ovirt.org/gerrit_manual_trigger/
>>>
>>> Nir
>>> ___
>>> Devel mailing list
>>> Devel@ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>
>>>
>>
>>
>>
>> --
>> Eyal Edri
>> Associate Manager
>> RHV DevOps
>> EMEA ENG Virtualization R
>> Red Hat Israel
>>
>> phone: +972-9-7692018
>> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>
>
>
>
> --
> Sandro Bonazzola
> Better technology. Faster innovation. Powered by community collaboration.
> See how it works at redhat.com
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] Alternatives to automatically move bugs to MODIFIED

2016-08-17 Thread Yedidyah Bar David
Hi all,

We currently have a bot that automatically moves bugs from POST to MODIFIED
if all linked patches on gerrit are merged.

It happened to me personally several times that this was a wrong thing to do,
either because a new patch was still needed but not pushed yet, or because
an existing patch should have been back-ported to another branch and wasn't
yet. Since I usually pay more attention to my bug in POST, I sometimes missed
this and handled the missing patches (backports, usually) later than I could
if left on POST.

I have a feeling I am not the only one. So I suggest to stop doing this.

I can think of several alternatives:

1. Do nothing. I think that's reasonable - I think most people pay more
attention to POST bugs anyway.

2. Set needinfo on bug owner.

3. Send some alert email to relevant people (bug owner, existing patches owners,
perhaps others - e.g. reviewers of existing patches, perhaps those
that actually reviewed, etc.). Need to think how to make it not too
annoying for others but
still effective also if owner is on long PTO or something like that. New flag
doesn't have to be very specific - can be called something like 'attention
needed' or something like that.

4. Add a new flag for that and set it. This will allow easier
filtering/reporting.

What do you think?
-- 
Didi
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel