Re: [PATCH 00/10] Raspberry Pi 2 (BCM2836) SMP support

2016-09-11 Thread Pavel Pisa
Hello Chris and others,

On Sunday 11 of September 2016 08:53:09 Chris Johns wrote:
> On 09/09/2016 17:47, Sebastian Huber wrote:
> > On 09/09/16 09:43, Pavel Pisa wrote:
> >> Hello Chris and others,
> >>
> >> On Friday 09 of September 2016 02:06:19 Chris Johns wrote:
> >>> >On 09/09/2016 07:46, Pavel Pisa wrote:
>  > >I have provided simple bsp_reset() for Raspberry Pi and pushed it
> 
>  into
> 
>  > >master.
> >>> >
> >>> >Thank you. Is the reset on exit on by default? I rebuilt without a BSP
> >>> >opt and the Rpi2 did not reset. I see a reference to
> >>> >BSP_RESET_BOARD_AT_EXIT but I do not know what the default is.
> >>> >
> >>> >I think*all*  RTEMS BSPs should reset on exit and shut-down by
> >>> > default. It is the normal production setting for most systems.
> >>
> >> Mainly for others, the BSP default cleanup operations
> >> selection mechanism is defined in
> >>
> >>rtems/c/src/aclocal/bsp-bspcleanup-options.m4
> >>
> >> RTEMS_BSP_CLEANUP_OPTIONS
> >> dnl USAGE:
> >> dnlRTEMS_BSP_CLEANUP_OPTIONS([0|1], [0|1], [0|1])
> >> dnl WHERE:
> >> dnlargument 1 indicates the default value for
> >> BSP_PRESS_KEY_FOR_RESET dnlargument 2 indicates the default value
> >> for BSP_RESET_BOARD_AT_EXIT dnlargument 3 indicates the default
> >> value for
> >> BSP_PRINT_EXCEPTION_CONTEXT
> >
> > Maybe it makes sense to remove the ability to change the default, so
> > what all BSPs have the same defaults. You can change the behaviour via
> > the configure command line if needed.
>
> Yes I think this is the way we should head. Any BSP which does not reset
> and start again by default needs to be changed making the default state
> for a BSP production ready. This statement covers this configure option
> plus it covers things like pressing a key which the PC BSP has on by
> default and should be defaulted to off.

May it be that RTEMS_BSP_CLEANUP_OPTIONS should not define
default but provide information which options are supported
for given BSP.

Best wishes,

  Pavel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: [PATCH 00/10] Raspberry Pi 2 (BCM2836) SMP support

2016-09-11 Thread Chris Johns

On 09/09/2016 17:47, Sebastian Huber wrote:

On 09/09/16 09:43, Pavel Pisa wrote:

Hello Chris and others,

On Friday 09 of September 2016 02:06:19 Chris Johns wrote:

>On 09/09/2016 07:46, Pavel Pisa wrote:

> >I have provided simple bsp_reset() for Raspberry Pi and pushed it
into
> >master.

>
>Thank you. Is the reset on exit on by default? I rebuilt without a BSP
>opt and the Rpi2 did not reset. I see a reference to
>BSP_RESET_BOARD_AT_EXIT but I do not know what the default is.
>
>I think*all*  RTEMS BSPs should reset on exit and shut-down by default.
>It is the normal production setting for most systems.

Mainly for others, the BSP default cleanup operations
selection mechanism is defined in

   rtems/c/src/aclocal/bsp-bspcleanup-options.m4

RTEMS_BSP_CLEANUP_OPTIONS
dnl USAGE:
dnlRTEMS_BSP_CLEANUP_OPTIONS([0|1], [0|1], [0|1])
dnl WHERE:
dnlargument 1 indicates the default value for BSP_PRESS_KEY_FOR_RESET
dnlargument 2 indicates the default value for BSP_RESET_BOARD_AT_EXIT
dnlargument 3 indicates the default value for
BSP_PRINT_EXCEPTION_CONTEXT


Maybe it makes sense to remove the ability to change the default, so
what all BSPs have the same defaults. You can change the behaviour via
the configure command line if needed.



Yes I think this is the way we should head. Any BSP which does not reset 
and start again by default needs to be changed making the default state 
for a BSP production ready. This statement covers this configure option 
plus it covers things like pressing a key which the PC BSP has on by 
default and should be defaulted to off.


Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel