Re: [PATCH 1/1] user/rsb/configuration.rst: Complete review on the text

2020-04-16 Thread Gedare Bloom 
It would be great to get the DTC corrections also, to close the ticket.

On Wed, Apr 8, 2020 at 10:56 AM  wrote:
>
> From: Cláudio Maia 
>
> ---
>  user/rsb/configuration.rst | 424 +++--
>  1 file changed, 215 insertions(+), 209 deletions(-)
>
> diff --git a/user/rsb/configuration.rst b/user/rsb/configuration.rst
> index 4b21dee..561ae60 100644
> --- a/user/rsb/configuration.rst
> +++ b/user/rsb/configuration.rst
> @@ -8,23 +8,25 @@
>  Configuration
>  -
>
> -The RTEMS Source Builder has two types of configuration data:
> +The RTEMS Source Builder (RSB) has two types of configuration data:
>
> -- Build Sets
> +- Build Sets (see :ref:`bsets` for more info)
>
>  - Package Build Configurations
>
> -By default these files can be located in two separate directories and
> -searched. The first directory is ``config`` in your current working directory
> -(``_topdir``) and the second is ``config`` located in the base directory of 
> the
> -RTEMS Source Builder command you run (``_sbdir``). The RTEMS directory
> -``rtems``` located at the top of the RTEMS Source Builder source code is an
> -example of a specific build configuration directory. You can create custom or
> -private build configurations and if you run the RTEMS Source Builder command
> -from that directory your configurations will be used.
> +By default this type of files can be located and searched in two separate
Use "this type of file" (or "these types of files")

> +directories. The first directory is the ``config`` directory existing inside
> +your current working directory (``_topdir``) and the second is the ``config``
> +directory located inside the base directory of the RTEMS Source Builder 
> command
> +you run (``_sbdir``).
>
> -The configuration search path is a macro variable and is reference as
> -``%{_configdir}``. It's default is defined as:
> +The ``rtems`` directory located at the top of the RTEMS Source Builder source
> +code is an example of a specific build configuration directory. You can 
> create
> +custom or private build configurations and if you run the RTEMS Source 
> Builder
> +command from that directory your configurations will be used.
> +
> +The configuration search path is a macro variable and is referenced as
> +``%{_configdir}``. Its default is defined as:
>
>  .. code-block:: spec
>
> @@ -39,8 +41,8 @@ The configuration search path is a macro variable and is 
> reference as
>   constraint and the definition.
>
>  Build set files have the file extension ``.bset`` and the package build
> -configuration files have the file extension of ``.cfg``. The 
> ``sb-set-builder``
> -command will search for *build sets* and the ``sb-builder`` commands works 
> with
> +configuration files have the file extension ``.cfg``. The ``sb-set-builder``
> +command will search for *build sets* and the ``sb-builder`` command works 
> with
>  package build configuration files.
>
>  Both types of configuration files use the ``#`` character as a comment
> @@ -50,13 +52,13 @@ block comment.
>  Source and Patches
>  ^^
>
> -The RTEMS Source Builder provides a flexible way to manage source. Source and
> -patches are declare in configurations file using the ``source`` and ``patch``
> -directives. These are a single line containing a Universal Resource Location 
> or
> -URL and can contain macros and shell expansions. The :ref:`prep` section
> -details the *source* and *patch* directives
> +The RTEMS Source Builder provides a flexible way to manage the files source.
Replace "the files source." with "source and patch files."

> +Source and patches are declared in configuration files using the ``source`` 
> and
> +``patch`` directives. These are defined in a single line containing a Uniform
> +Resource Locator (URL) and can contain macros and shell expansions. The
> +:ref:`prep` section details the ``source`` and ``patch`` directives.
>
> -The URL can reference remote and local source and patch resources. The
> +The URL can reference remote and local sources and patch resources. The
>  following schemes are provided:
>
>  ``http``:
> @@ -75,21 +77,22 @@ following schemes are provided:
>Remote access to a patch management repository.
>
>  ``file``:
> - Local access to an existing source directory.
> +  Local access to an existing source directory.
>
>  HTTP, HTTPS, and FTP
>  
>
> -Remote access to TAR or ZIP files is provided using HTTP, HTTPS and FTP
> +Remote access to TAR or ZIP files is provided using HTTP, HTTPS or FTP
>  protocols. The full URL provided is used to access the remote file including
>  any query components. The URL is parsed to extract the file component and the
> -local source directory is checked for that file. If the file is located 
> locally
> -the remote file is not downloaded. Currently no other checks are made. If a
> -download fails you need to manually remove the file from the source directory
> +local source directory is checked for

AW: [PATCH rtems-libbsd v2 06/14] regulator: Import from FreeBSD.

2020-04-16 Thread Jan.Sommer 
I have a question:
I just rebased my working tree for the i386 target to the current 5-freebsd-12 
branch.
The compilation now fails in regulator related files.
It seems that I am missing the FDT define and that comments out some includes.
Could you tell me what FDT means in this context and do you know where I can 
activate it?

Cheers,

   Jan

> -Ursprüngliche Nachricht-
> Von: devel [mailto:devel-boun...@rtems.org] Im Auftrag von Christian
> Mauderer
> Gesendet: Dienstag, 14. April 2020 16:51
> An: devel@rtems.org
> Betreff: [PATCH rtems-libbsd v2 06/14] regulator: Import from FreeBSD.
> 
> Update #3869.
> ---
>  freebsd/sys/dev/extres/regulator/regulator.c   | 1321
> 
>  freebsd/sys/dev/extres/regulator/regulator.h   |  156 +++
>  freebsd/sys/dev/extres/regulator/regulator_bus.c   |   89 ++
>  freebsd/sys/dev/extres/regulator/regulator_fixed.c |  502 
>  freebsd/sys/dev/extres/regulator/regulator_fixed.h |   44 +
>  freebsd/sys/dev/gpio/gpioregulator.c   |  350 ++
>  6 files changed, 2462 insertions(+)
>  create mode 100644 freebsd/sys/dev/extres/regulator/regulator.c
>  create mode 100644 freebsd/sys/dev/extres/regulator/regulator.h
>  create mode 100644 freebsd/sys/dev/extres/regulator/regulator_bus.c
>  create mode 100644 freebsd/sys/dev/extres/regulator/regulator_fixed.c
>  create mode 100644 freebsd/sys/dev/extres/regulator/regulator_fixed.h
>  create mode 100644 freebsd/sys/dev/gpio/gpioregulator.c
> 
> diff --git a/freebsd/sys/dev/extres/regulator/regulator.c
> b/freebsd/sys/dev/extres/regulator/regulator.c
> new file mode 100644
> index ..4ad6e94a
> --- /dev/null
> +++ b/freebsd/sys/dev/extres/regulator/regulator.c
> @@ -0,0 +1,1321 @@
> +#include 
> +
> +/*-
> + * Copyright 2016 Michal Meloun 
> + * All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *notice, this list of conditions and the following disclaimer in the
> + *documentation and/or other materials provided with the distribution.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS
> IS'' AND
> + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
> TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
> PARTICULAR PURPOSE
> + * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS
> BE LIABLE
> + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> CONSEQUENTIAL
> + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> SUBSTITUTE GOODS
> + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> INTERRUPTION)
> + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> CONTRACT, STRICT
> + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
> IN ANY WAY
> + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF
> + * SUCH DAMAGE.
> + */
> +
> +#include 
> +__FBSDID("$FreeBSD$");
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +#ifdef FDT
> +#include 
> +#include 
> +#include 
> +#endif
> +#include 
> +
> +#include 
> +
> +SYSCTL_NODE(_hw, OID_AUTO, regulator, CTLFLAG_RD, NULL,
> "Regulators");
> +
> +MALLOC_DEFINE(M_REGULATOR, "regulator", "Regulator framework");
> +
> +#define  DIV_ROUND_UP(n,d) howmany(n, d)
> +
> +/* Forward declarations. */
> +struct regulator;
> +struct regnode;
> +
> +typedef TAILQ_HEAD(regnode_list, regnode) regnode_list_t;
> +typedef TAILQ_HEAD(regulator_list, regulator) regulator_list_t;
> +
> +/* Default regulator methods. */
> +static int regnode_method_init(struct regnode *regnode);
> +static int regnode_method_enable(struct regnode *regnode, bool enable,
> +int *udelay);
> +static int regnode_method_status(struct regnode *regnode, int *status);
> +static int regnode_method_set_voltage(struct regnode *regnode, int
> min_uvolt,
> +int max_uvolt, int *udelay);
> +static int regnode_method_get_voltage(struct regnode *regnode, int
> *uvolt);
> +static void regulator_constraint(void *dummy);
> +static void regulator_shutdown(void *dummy);
> +
> +/*
> + * Regulator controller methods.
> + */
> +static regnode_method_t regnode_methods[] = {
> + REGNODEMETHOD(regnode_init,
>   regnode_method_init),
> + REGNODEMETHOD(regnode_enable,
>   regnode_method_enable),
> + REGNODEMETHOD(regnode_status,
>   regnode_method_status),
> + REGNODEMETHOD(regnode_set_voltage,
>   regnode_method_set_voltage),
> + REGNODEMETHOD(regnode_get_voltage,
>   regnode_method_get_voltage),
> +

Re: Missing link on the RTEMS website

2020-04-16 Thread Joel Sherrill 
On Thu, Apr 16, 2020 at 2:20 PM Gedare Bloom  wrote:

> On Thu, Apr 16, 2020 at 12:37 PM Joel Sherrill  wrote:
> >
> >
> >
> > On Thu, Apr 16, 2020 at 1:36 AM Sebastian Huber <
> sebastian.hu...@embedded-brains.de> wrote:
> >>
> >> On 15/04/2020 15:01, Joel Sherrill wrote:
> >>
> >>
> >>
> >> On Wed, Apr 15, 2020, 7:59 AM Sebastian Huber <
> sebastian.hu...@embedded-brains.de> wrote:
> >>>
> >>> On 15/04/2020 14:55, Joel Sherrill wrote:
> >>>
> >>>
> >>>
> >>> On Wed, Apr 15, 2020 at 6:11 AM Sebastian Huber <
> sebastian.hu...@embedded-brains.de> wrote:
> 
>  Hello,
> 
>  On 15/04/2020 13:03, Kuan-Hsun Chen wrote:
> 
>  Hello all,
> 
>  I just notice that https://www.rtems.org/ page has a link point to,
> which is missing:
>  https://devel.rtems.org/wiki/TBR/Website/Mission_Statement
> 
>  I am writing some descriptions regarding RTEMS at meanwhile, should I
> just report here or directly update the website somehow?
> 
>  I moved the mission statement to the engineering manual:
> 
>  https://docs.rtems.org/branches/master/eng/mission.html
> 
>  It would be nice if someone can fix the link on www.rtems.org.
> >>>
> >>>
> >>> I think this is done now. Please check and confirm.
> >>>
> >>> Thanks, this one is fixed. There are a couple of other links which
> point to the wiki and should instead point to the documentation.
> >>
> >>
> >> Could you provide specifics? There are a lot of links there.
> >>
> >> I am to fix them if I know what to fix.
> >>
> >> I just hovered over some links.
> >>
> >> Quick Start
> >>
> >> http://devel.rtems.org/wiki/TBR/UserManual/Quick_Start
> >>
> >> https://docs.rtems.org/branches/master/user/start/index.html
> >>
> >> Contributing
> >>
> >> http://devel.rtems.org/wiki/Developer/Contributing
> >>
> >> https://docs.rtems.org/branches/master/user/support/contrib.html
> >>
> >> GIT Read Access -> Git Read Access (maybe also move one level up)
> >>
> >> http://devel.rtems.org/wiki/Developer/Git#GitAccessforUsers
> >>
> >> https://docs.rtems.org/branches/master/eng/vc-users.html
> >
> >
> > I have fixed all these. Do we think all of these pages can be removed
> > from the wiki? Assuming care is taken to fix references to them.
> >
> Yes. Do a search for the page name in the wiki first, or replace the
> wiki content with a link to the relevant docs page for now.
>

I've done the first one, filed a ticket for Chris to evaluate a Mingw tools
instruction page and deleted a number of pages as a side-effect. I updated
https://devel.rtems.org/ticket/3954
 to show this.

Hopefully someone will take a swing at the others.  I was swinging a
sledgehammer. :)

--joel

>
> > --joel
> > ___
> > devel mailing list
> > devel@rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: Missing link on the RTEMS website

2020-04-16 Thread Gedare Bloom 
On Thu, Apr 16, 2020 at 12:37 PM Joel Sherrill  wrote:
>
>
>
> On Thu, Apr 16, 2020 at 1:36 AM Sebastian Huber 
>  wrote:
>>
>> On 15/04/2020 15:01, Joel Sherrill wrote:
>>
>>
>>
>> On Wed, Apr 15, 2020, 7:59 AM Sebastian Huber 
>>  wrote:
>>>
>>> On 15/04/2020 14:55, Joel Sherrill wrote:
>>>
>>>
>>>
>>> On Wed, Apr 15, 2020 at 6:11 AM Sebastian Huber 
>>>  wrote:

 Hello,

 On 15/04/2020 13:03, Kuan-Hsun Chen wrote:

 Hello all,

 I just notice that https://www.rtems.org/ page has a link point to, which 
 is missing:
 https://devel.rtems.org/wiki/TBR/Website/Mission_Statement

 I am writing some descriptions regarding RTEMS at meanwhile, should I just 
 report here or directly update the website somehow?

 I moved the mission statement to the engineering manual:

 https://docs.rtems.org/branches/master/eng/mission.html

 It would be nice if someone can fix the link on www.rtems.org.
>>>
>>>
>>> I think this is done now. Please check and confirm.
>>>
>>> Thanks, this one is fixed. There are a couple of other links which point to 
>>> the wiki and should instead point to the documentation.
>>
>>
>> Could you provide specifics? There are a lot of links there.
>>
>> I am to fix them if I know what to fix.
>>
>> I just hovered over some links.
>>
>> Quick Start
>>
>> http://devel.rtems.org/wiki/TBR/UserManual/Quick_Start
>>
>> https://docs.rtems.org/branches/master/user/start/index.html
>>
>> Contributing
>>
>> http://devel.rtems.org/wiki/Developer/Contributing
>>
>> https://docs.rtems.org/branches/master/user/support/contrib.html
>>
>> GIT Read Access -> Git Read Access (maybe also move one level up)
>>
>> http://devel.rtems.org/wiki/Developer/Git#GitAccessforUsers
>>
>> https://docs.rtems.org/branches/master/eng/vc-users.html
>
>
> I have fixed all these. Do we think all of these pages can be removed
> from the wiki? Assuming care is taken to fix references to them.
>
Yes. Do a search for the page name in the wiki first, or replace the
wiki content with a link to the relevant docs page for now.

> --joel
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: ticket #3356 add support for CLOCK_THREAD_CPU_TIME_ID

2020-04-16 Thread Gedare Bloom 
https://pubs.opengroup.org/onlinepubs/9699919799/functions/clock_getres.html

On Thu, Apr 16, 2020 at 12:19 PM Eshan Dhawan  wrote:
>
> Hello everyone,
> There is no much description related to this ticket.
> If I could get more information about it
>
> thanks
> -Eshan
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems v2] bsps/arm: Fix uninitialized value in generic timer

2020-04-16 Thread Gedare Bloom 
You can push this to 5.1, update the ticket milestone if you do.

On Thu, Apr 16, 2020 at 9:27 AM Sebastian Huber
 wrote:
>
> On 16/04/2020 15:29, Christian Mauderer wrote:
> > _CPU_Counter_frequency() can be called by the rtems_counter
> > initialization before arm_gt_clock_initialize() initializes the value
> > used in _CPU_Counter_frequency().
> >
> > Update #3456.
> Thanks, looks good.
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: Missing link on the RTEMS website

2020-04-16 Thread Joel Sherrill 
On Thu, Apr 16, 2020 at 1:36 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:

> On 15/04/2020 15:01, Joel Sherrill wrote:
>
>
>
> On Wed, Apr 15, 2020, 7:59 AM Sebastian Huber <
> sebastian.hu...@embedded-brains.de> wrote:
>
>> On 15/04/2020 14:55, Joel Sherrill wrote:
>>
>>
>>
>> On Wed, Apr 15, 2020 at 6:11 AM Sebastian Huber <
>> sebastian.hu...@embedded-brains.de> wrote:
>>
>>> Hello,
>>> On 15/04/2020 13:03, Kuan-Hsun Chen wrote:
>>>
>>> Hello all,
>>>
>>> I just notice that https://www.rtems.org/ page has a link point to,
>>> which is missing:
>>> https://devel.rtems.org/wiki/TBR/Website/Mission_Statement
>>>
>>> I am writing some descriptions regarding RTEMS at meanwhile, should I
>>> just report here or directly update the website somehow?
>>>
>>> I moved the mission statement to the engineering manual:
>>>
>>> https://docs.rtems.org/branches/master/eng/mission.html
>>>
>>> It would be nice if someone can fix the link on www.rtems.org.
>>>
>>
>> I think this is done now. Please check and confirm.
>>
>> Thanks, this one is fixed. There are a couple of other links which point
>> to the wiki and should instead point to the documentation.
>>
>
> Could you provide specifics? There are a lot of links there.
>
> I am to fix them if I know what to fix.
>
> I just hovered over some links.
>
> Quick Start
>
> http://devel.rtems.org/wiki/TBR/UserManual/Quick_Start
>
> https://docs.rtems.org/branches/master/user/start/index.html
>
> Contributing
>
> http://devel.rtems.org/wiki/Developer/Contributing
>
> https://docs.rtems.org/branches/master/user/support/contrib.html
>
> GIT Read Access -> Git Read Access (maybe also move one level up)
>
> http://devel.rtems.org/wiki/Developer/Git#GitAccessforUsers
>
> https://docs.rtems.org/branches/master/eng/vc-users.html
>

I have fixed all these. Do we think all of these pages can be removed
from the wiki? Assuming care is taken to fix references to them.

--joel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

ticket #3356 add support for CLOCK_THREAD_CPU_TIME_ID

2020-04-16 Thread Eshan Dhawan 
Hello everyone,
There is no much description related to this ticket.
If I could get more information about it

thanks
-Eshan
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems v2] bsps/arm: Fix uninitialized value in generic timer

2020-04-16 Thread Sebastian Huber 

On 16/04/2020 15:29, Christian Mauderer wrote:

_CPU_Counter_frequency() can be called by the rtems_counter
initialization before arm_gt_clock_initialize() initializes the value
used in _CPU_Counter_frequency().

Update #3456.

Thanks, looks good.
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 0/1] user/rsb/configuration.rst: Complete review on the text

2020-04-16 Thread clrrm 
Dear all,

I’ve sent this patch last week but I didn’t receive any feedback on it.
Could please someone review the patch?

Regards,
Cláudio

> On 8 Apr 2020, at 17:55, Cláudio Maia (clrrm)  wrote:
> 
> From: Cláudio Maia 
> 
> This patch proposes several fixes in the rsb/configuration.rst file.
> The document was reviewed from top to bottom with the following
> modifications being proposed:
> 
> - moved the paragraph describing the %source directive closer to where
>  the directive is introduced in the text, for readability purposes;
> - corrected several typos;
> - added two cross-references _bsets and _new-configs;
> - restructured several sentences.
> 
> There are still some changes to be made concerning the DTC example as
> the ones described in the following ticket (submitted as suggested by
> Gedare Bloom):
> 
> - https://devel.rtems.org/ticket/3945
> 
> Cláudio Maia (1):
>  user/rsb/configuration.rst: Complete review on the text
> 
> user/rsb/configuration.rst | 424 +++--
> 1 file changed, 215 insertions(+), 209 deletions(-)
> 
> -- 
> 2.17.1
> 

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH rtems v2] bsps/arm: Fix uninitialized value in generic timer

2020-04-16 Thread Christian Mauderer 
_CPU_Counter_frequency() can be called by the rtems_counter
initialization before arm_gt_clock_initialize() initializes the value
used in _CPU_Counter_frequency().

Update #3456.
---
 bsps/arm/shared/clock/clock-generic-timer.c | 14 ++
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/bsps/arm/shared/clock/clock-generic-timer.c 
b/bsps/arm/shared/clock/clock-generic-timer.c
index 1f39632ba6..072583473e 100644
--- a/bsps/arm/shared/clock/clock-generic-timer.c
+++ b/bsps/arm/shared/clock/clock-generic-timer.c
@@ -148,7 +148,8 @@ static void arm_gt_clock_initialize(void)
   uint64_t cval;
   struct timecounter *tc;
 
-  frequency = arm_gt_clock_instance.interval;
+  tc = _gt_clock_instance.tc;
+  frequency = tc->tc_frequency;
   us_per_tick = rtems_configuration_get_microseconds_per_tick();
   interval = (uint32_t) ((frequency * us_per_tick) / 100);
   cval = arm_gt_clock_get_count();
@@ -158,10 +159,8 @@ static void arm_gt_clock_initialize(void)
   arm_gt_clock_gt_init(cval);
   arm_gt_clock_secondary_initialization(cval);
 
-  tc = _gt_clock_instance.tc;
   tc->tc_get_timecount = arm_gt_clock_get_timecount;
   tc->tc_counter_mask = 0x;
-  tc->tc_frequency = frequency;
   tc->tc_quality = RTEMS_TIMECOUNTER_QUALITY_CLOCK_DRIVER;
   rtems_timecounter_install(tc);
 }
@@ -178,12 +177,19 @@ CPU_Counter_ticks _CPU_Counter_read(void)
 
 static void arm_gt_clock_early_init(void)
 {
+  uint32_t frequency;
   arm_gt_clock_set_control(0x3);
 
   arm_generic_timer_get_config(
-_gt_clock_instance.interval,
+,
 _gt_clock_instance.irq
   );
+
+  /*
+   * Used by _CPU_Counter_frequency() before arm_gt_clock_initialize() is
+   * called.
+   */
+  arm_gt_clock_instance.tc.tc_frequency = frequency;
 }
 
 RTEMS_SYSINIT_ITEM(
-- 
2.16.4

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems] bsps/arm: Fix uninitialized value in generic timer

2020-04-16 Thread Sebastian Huber 



On 16/04/2020 14:21, Christian Mauderer wrote:

_CPU_Counter_frequency() can be called by the rtems_counter
initialization before arm_gt_clock_initialize() initializes the value
used in _CPU_Counter_frequency().

Update #3456.
---
  bsps/arm/shared/clock/clock-generic-timer.c | 10 --
  1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/bsps/arm/shared/clock/clock-generic-timer.c 
b/bsps/arm/shared/clock/clock-generic-timer.c
index 1f39632ba6..a0efb9c7ed 100644
--- a/bsps/arm/shared/clock/clock-generic-timer.c
+++ b/bsps/arm/shared/clock/clock-generic-timer.c
@@ -161,7 +161,6 @@ static void arm_gt_clock_initialize(void)
tc = _gt_clock_instance.tc;
tc->tc_get_timecount = arm_gt_clock_get_timecount;
tc->tc_counter_mask = 0x;
-  tc->tc_frequency = frequency;
tc->tc_quality = RTEMS_TIMECOUNTER_QUALITY_CLOCK_DRIVER;
rtems_timecounter_install(tc);
  }
@@ -178,12 +177,19 @@ CPU_Counter_ticks _CPU_Counter_read(void)
  
  static void arm_gt_clock_early_init(void)

  {
+  uint32_t frequency;
arm_gt_clock_set_control(0x3);
  
arm_generic_timer_get_config(

-_gt_clock_instance.interval,
+,
  _gt_clock_instance.irq
);
+
+  /* Used by _CPU_Counter_frequency before arm_gt_clock_initialize is called */

Please use func() in the comments.

+  arm_gt_clock_instance.tc.tc_frequency = frequency;
+
+  /* overwritten with the calculated interval by arm_gt_clock_initialize */
+  arm_gt_clock_instance.interval = frequency;
I would remove this assignment here and read the frequency in 
arm_gt_clock_initialize() like this:


  tc = _gt_clock_instance.tc;
  frequency = (uint32_t) tc->tc_frequency;
 


  }
  
  RTEMS_SYSINIT_ITEM(

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH rtems] bsps/arm: Fix uninitialized value in generic timer

2020-04-16 Thread Christian Mauderer 
_CPU_Counter_frequency() can be called by the rtems_counter
initialization before arm_gt_clock_initialize() initializes the value
used in _CPU_Counter_frequency().

Update #3456.
---
 bsps/arm/shared/clock/clock-generic-timer.c | 10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/bsps/arm/shared/clock/clock-generic-timer.c 
b/bsps/arm/shared/clock/clock-generic-timer.c
index 1f39632ba6..a0efb9c7ed 100644
--- a/bsps/arm/shared/clock/clock-generic-timer.c
+++ b/bsps/arm/shared/clock/clock-generic-timer.c
@@ -161,7 +161,6 @@ static void arm_gt_clock_initialize(void)
   tc = _gt_clock_instance.tc;
   tc->tc_get_timecount = arm_gt_clock_get_timecount;
   tc->tc_counter_mask = 0x;
-  tc->tc_frequency = frequency;
   tc->tc_quality = RTEMS_TIMECOUNTER_QUALITY_CLOCK_DRIVER;
   rtems_timecounter_install(tc);
 }
@@ -178,12 +177,19 @@ CPU_Counter_ticks _CPU_Counter_read(void)
 
 static void arm_gt_clock_early_init(void)
 {
+  uint32_t frequency;
   arm_gt_clock_set_control(0x3);
 
   arm_generic_timer_get_config(
-_gt_clock_instance.interval,
+,
 _gt_clock_instance.irq
   );
+
+  /* Used by _CPU_Counter_frequency before arm_gt_clock_initialize is called */
+  arm_gt_clock_instance.tc.tc_frequency = frequency;
+
+  /* overwritten with the calculated interval by arm_gt_clock_initialize */
+  arm_gt_clock_instance.interval = frequency;
 }
 
 RTEMS_SYSINIT_ITEM(
-- 
2.16.4

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH v3] Tests for pthread_getcpuclockid method. Ticket:3891

2020-04-16 Thread Eshan dhawan 
Hello,
As Dr Joel suggested
I have added the .5 seconds cpu time delay on the clock id of the thread and 
calculated the
wall time using CLOCK_REALTIME but this will return error as there is no 
support for
CLOCK_THREAD_CPU_TIME_ID.
If we use CLOCK_REALTIME then it returns the time in nanoseconds.
Also I didn't know what changes to make to the .scn file since the time can 
change for different
architectures.
I request everyone to have a look at it.

thanks
Eshan
---
 testsuites/psxtests/Makefile.am   |  10 ++
 testsuites/psxtests/configure.ac  |   1 +
 testsuites/psxtests/psxgetcpuclockid01/init.c | 149 ++
 .../psxgetcpuclockid01/psxgetcpuclockid01.doc |  23 +++
 .../psxgetcpuclockid01/psxgetcpuclockid01.scn |   4 +
 5 files changed, 187 insertions(+)
 create mode 100644 testsuites/psxtests/psxgetcpuclockid01/init.c
 create mode 100644 
testsuites/psxtests/psxgetcpuclockid01/psxgetcpuclockid01.doc
 create mode 100644 
testsuites/psxtests/psxgetcpuclockid01/psxgetcpuclockid01.scn

diff --git a/testsuites/psxtests/Makefile.am b/testsuites/psxtests/Makefile.am
index 1f9e4233ec..ffadff16e7 100755
--- a/testsuites/psxtests/Makefile.am
+++ b/testsuites/psxtests/Makefile.am
@@ -462,6 +462,16 @@ psxgetattrnp01_CPPFLAGS = $(AM_CPPFLAGS) 
$(TEST_FLAGS_psxgetattrnp01) \
$(support_includes) -I$(top_srcdir)/include
 endif
 
+if TEST_psxgetcpuclockid01
+psx_tests += psxgetcpuclockid01
+psx_screens += psxgetcpuclockid01/psxgetcpuclockid01.scn
+psx_docs += psxgetcpuclockid01/psxgetcpuclockid01.doc
+psxgetcpuclockid01_SOURCES = psxgetcpuclockid01/init.c
+psxgetcpuclockid01_CPPFLAGS = $(AM_CPPFLAGS) $(TEST_FLAGS_psxgetcpuclockid01) \
+   $(support_includes)
+endif
+
+
 if TEST_psxgetrusage01
 psx_tests += psxgetrusage01
 psx_screens += psxgetrusage01/psxgetrusage01.scn
diff --git a/testsuites/psxtests/configure.ac b/testsuites/psxtests/configure.ac
index 139787cccb..c509086abc 100644
--- a/testsuites/psxtests/configure.ac
+++ b/testsuites/psxtests/configure.ac
@@ -91,6 +91,7 @@ RTEMS_TEST_CHECK([psxfile01])
 RTEMS_TEST_CHECK([psxfile02])
 RTEMS_TEST_CHECK([psxfilelock01])
 RTEMS_TEST_CHECK([psxgetattrnp01])
+RTEMS_TEST_CHECK([psxgetcpuclockid01])
 RTEMS_TEST_CHECK([psxgetrusage01])
 RTEMS_TEST_CHECK([psxglobalcon01])
 RTEMS_TEST_CHECK([psxglobalcon02])
diff --git a/testsuites/psxtests/psxgetcpuclockid01/init.c 
b/testsuites/psxtests/psxgetcpuclockid01/init.c
new file mode 100644
index 00..29fcc2c932
--- /dev/null
+++ b/testsuites/psxtests/psxgetcpuclockid01/init.c
@@ -0,0 +1,149 @@
+/*
+ *  @file
+ *  @brief Test suite for getcpuclockid methods
+ */
+
+/*
+ * SPDX-License-Identifier: BSD-2-Clause
+ *
+ * Copyright (C) 2020 Eshan Dhawan, Vaibhav Gupta
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "tmacros.h"
+#include "test_support.h"
+
+const char rtems_test_name[] = "PSXGETCPUCLOCKID 1";
+
+/* Forward declaration to avoid warnings */
+void *POSIX_Init (void * argument);
+void *test_pthread(void *);
+/*structure timespec */
+
+/* test_pthread function begins */
+void *test_pthread(void *arg)
+{
+  int r;
+  clockid_t cid;
+  struct timespec start, start1, finish;
+  long time_passed = 0;
+
+  r = pthread_getcpuclockid( pthread_self(),  );
+  if ( r ) {
+printf( "pthread_getcpuclockid : %d", r );
+  }
+  rtems_test_assert( r == 0 );
+
+  r = clock_gettime( CLOCK_REALTIME,  );
+  if ( r ) {
+printf( "clock_gettime : %d \n", r );
+if ( r == EINVAL || r == ESRCH ) {
+  printf( "the clockid returned is invalid" );
+}
+  }
+  rtems_test_assert( r

Re: [PATCH rtems-libbsd] imx: Fix build for all other BSPs.

2020-04-16 Thread Christian Mauderer 
Hello Vijay and Sebastian,

thanks for the review and test. I pushed the patch and updated RSB.
Sorry for breaking stuff in the first place.

Best regards

Christian

On 16/04/2020 10:45, Vijay Kumar Banerjee wrote:
> Hi,
> 
> I could successfully build libbsd for arm/beagleboneblack with this path.
> 
> Thanks and regards,
> Vijay
> 
> On Thu, Apr 16, 2020 at 2:08 PM Christian Mauderer
>  > wrote:
> 
> ---
>  freebsd/sys/arm/freescale/imx/imx6_ccm.c    | 7 +++
>  freebsd/sys/arm/freescale/imx/imx6_usbphy.c | 4 
>  freebsd/sys/dev/usb/controller/ehci_imx.c   | 2 ++
>  3 files changed, 13 insertions(+)
> 
> diff --git a/freebsd/sys/arm/freescale/imx/imx6_ccm.c
> b/freebsd/sys/arm/freescale/imx/imx6_ccm.c
> index cef79933..78bbd5c1 100644
> --- a/freebsd/sys/arm/freescale/imx/imx6_ccm.c
> +++ b/freebsd/sys/arm/freescale/imx/imx6_ccm.c
> @@ -51,7 +51,14 @@ __FBSDID("$FreeBSD$");
>  #include 
>  #include 
>  #include 
> +#ifndef __rtems__
> +#include 
> +#else /* __rtems__ */
> +#include 
> +#ifdef LIBBSP_ARM_IMX_BSP_H
>  #include 
> +#endif /* LIBBSP_ARM_IMX_BSP_H */
> +#endif /* __rtems__ */
> 
>  #ifndef CCGR_CLK_MODE_ALWAYS
>  #define        CCGR_CLK_MODE_OFF               0
> diff --git a/freebsd/sys/arm/freescale/imx/imx6_usbphy.c
> b/freebsd/sys/arm/freescale/imx/imx6_usbphy.c
> index 7df2e124..3a3495bb 100644
> --- a/freebsd/sys/arm/freescale/imx/imx6_usbphy.c
> +++ b/freebsd/sys/arm/freescale/imx/imx6_usbphy.c
> @@ -49,7 +49,11 @@ __FBSDID("$FreeBSD$");
> 
>  #include 
> 
> +#ifndef __rtems__
>  #include 
> +#else /* __rtems__ */
> +void imx_ccm_usbphy_enable(device_t _phydev);
> +#endif /* __rtems__ */
>  #include 
>  #include 
>  #ifdef __rtems__
> diff --git a/freebsd/sys/dev/usb/controller/ehci_imx.c
> b/freebsd/sys/dev/usb/controller/ehci_imx.c
> index 544a63b5..23f7e3a9 100644
> --- a/freebsd/sys/dev/usb/controller/ehci_imx.c
> +++ b/freebsd/sys/dev/usb/controller/ehci_imx.c
> @@ -67,7 +67,9 @@ __FBSDID("$FreeBSD$");
>  #include 
>  #include 
> 
> +#ifndef __rtems__
>  #include 
> +#endif /* __rtems__ */
> 
>  #include 
> 
> -- 
> 2.16.4
> 

-- 

embedded brains GmbH
Herr Christian Mauderer
Dornierstr. 4
D-82178 Puchheim
Germany
email: christian.maude...@embedded-brains.de
Phone: +49-89-18 94 741 - 18
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems-libbsd v2 12/14] ehci_imx: Add to build.

2020-04-16 Thread Christian Mauderer 
On 16/04/2020 10:44, Vijay Kumar Banerjee wrote:
> 
> 
> On Thu, Apr 16, 2020 at 2:08 PM Christian Mauderer
>  > wrote:
> 
> On 16/04/2020 10:27, Vijay Kumar Banerjee wrote:
> >
> >
> > On Thu, Apr 16, 2020 at 1:51 PM Christian Mauderer
> >  
> >  >> wrote:
> >
> >
> >
> >     On 16/04/2020 09:41, Christian Mauderer wrote:
> >     > On 16/04/2020 09:21, Vijay Kumar Banerjee wrote:
> >     >>
> >     >>
> >     >> On Thu, Apr 16, 2020 at 12:41 PM Christian Mauderer
> >     >>  
> >      >
> >     >>  
> >       >     >>
> >     >>     Hello Vijay,
> >     >>
> >     >>     On 16/04/2020 09:04, Vijay Kumar Banerjee wrote:
> >     >>     > Hi Christian,
> >     >>     >
> >     >>     > I'm not able to build libbsd with this patch. I'm
> getting the
> >     >>     following
> >     >>     > error:
> >     >>     > ```
> >     >>     > ../../freebsd/sys/dev/usb/controller/ehci_imx.c:70:10:
> >     fatal error:
> >     >>     > arm/freescale/imx/imx_ccmvar.h: No such file or directory
> >     >>     >  #include 
> >     >>     > ```
> >     >>     > From git blame I got to know that this file was
> introduced
> >     by the
> >     >>     commit
> >     >>     > from this patch.
> >     >>     > Am I missing something or is it really a bug?
> >     >>
> >     >>     Thanks for the report. On what BSP and which exact
> commit did
> >     you try to
> >     >>     build? I had no trouble building the patch set from a clean
> >     checkout
> >     >>     yesterday before committing it.
> >     >>
> >     >> I did a pull from the upstream master and tried the build on
> >     >> arm/beagleboneblack
> >     >> I see that the header file is not present in the freebsd/
> directory
> >     >> ```
> >     >> rtems-libbsd $>find -iname imx_ccmvar.h
> >     >> ./freebsd-org/sys/arm/freescale/imx/imx_ccmvar.h
> >     >> ```
> >     >
> >     > Hello Vijay,
> >     >
> >     > that's quite clearly a bug that I introduced. I'll create a
> patch.
> >     >
> >     > The imx_ccmvar.h is a file that is provided by the BSP I
> used for
> >     testing.
> >     >
> >     > Best regards
> >     >
> >     > Christian
> >
> >     I've sent a patch. Can you test it?
> >
> > Sure. I don't see the patch on the list yet, I'll test it as soon
> as it
> > comes :)
> 
> Odd. It's already sent out and I CCd you directly. But the archive
> hasn't seen it either. To be sure, I attached the patch here.
> 
> This patch fixed the issue and the build completes successfully. Thanks.
> I'll also comment on the patch when it hits the list. 

Should have reached the list now:

https://lists.rtems.org/pipermail/devel/2020-April/059395.html

> 
> >
> >     >
> >     >>
> >     >>     >
> >     >>     > Sorry for commenting on the patch that has already been
> >     committed,
> >     >>     > please let me know of
> >     >>     > the preferred way to comment on a commit if this is
> not the
> >     right way.
> >     >>
> >     >>     No problem. That's exactly the right way to do it. If there
> >     is a bug it
> >     >>     has to be solved and everyone should know that someone is
> >     having a look
> >     >>     at it.
> >     >>
> >     >>     Best regards
> >     >>
> >     >>     Christian
> >     >>
> [...]
> 
> -- 
> 
> embedded brains GmbH
> Herr Christian Mauderer
> Dornierstr. 4
> D-82178 Puchheim
> Germany
> email: christian.maude...@embedded-brains.de
> 
> Phone: +49-89-18 94 741 - 18
> Fax:   +49-89-18 94 741 - 08
> PGP: Public key available on request.
> 
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
> 

-- 

embedded brains GmbH
Herr Christian Mauderer
Dornierstr. 4
D-82178 Puchheim
Germany
email: christian.maude...@embedded-brains.de
Phone: +49-89-18 94 741 - 18
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des

Re: [PATCH rtems-libbsd] imx: Fix build for all other BSPs.

2020-04-16 Thread Sebastian Huber 

Looks good.

In the new build system, we could more easily control this at build 
system level.


___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems-libbsd] imx: Fix build for all other BSPs.

2020-04-16 Thread Vijay Kumar Banerjee 
Hi,

I could successfully build libbsd for arm/beagleboneblack with this path.

Thanks and regards,
Vijay

On Thu, Apr 16, 2020 at 2:08 PM Christian Mauderer <
christian.maude...@embedded-brains.de> wrote:

> ---
>  freebsd/sys/arm/freescale/imx/imx6_ccm.c| 7 +++
>  freebsd/sys/arm/freescale/imx/imx6_usbphy.c | 4 
>  freebsd/sys/dev/usb/controller/ehci_imx.c   | 2 ++
>  3 files changed, 13 insertions(+)
>
> diff --git a/freebsd/sys/arm/freescale/imx/imx6_ccm.c
> b/freebsd/sys/arm/freescale/imx/imx6_ccm.c
> index cef79933..78bbd5c1 100644
> --- a/freebsd/sys/arm/freescale/imx/imx6_ccm.c
> +++ b/freebsd/sys/arm/freescale/imx/imx6_ccm.c
> @@ -51,7 +51,14 @@ __FBSDID("$FreeBSD$");
>  #include 
>  #include 
>  #include 
> +#ifndef __rtems__
> +#include 
> +#else /* __rtems__ */
> +#include 
> +#ifdef LIBBSP_ARM_IMX_BSP_H
>  #include 
> +#endif /* LIBBSP_ARM_IMX_BSP_H */
> +#endif /* __rtems__ */
>
>  #ifndef CCGR_CLK_MODE_ALWAYS
>  #defineCCGR_CLK_MODE_OFF   0
> diff --git a/freebsd/sys/arm/freescale/imx/imx6_usbphy.c
> b/freebsd/sys/arm/freescale/imx/imx6_usbphy.c
> index 7df2e124..3a3495bb 100644
> --- a/freebsd/sys/arm/freescale/imx/imx6_usbphy.c
> +++ b/freebsd/sys/arm/freescale/imx/imx6_usbphy.c
> @@ -49,7 +49,11 @@ __FBSDID("$FreeBSD$");
>
>  #include 
>
> +#ifndef __rtems__
>  #include 
> +#else /* __rtems__ */
> +void imx_ccm_usbphy_enable(device_t _phydev);
> +#endif /* __rtems__ */
>  #include 
>  #include 
>  #ifdef __rtems__
> diff --git a/freebsd/sys/dev/usb/controller/ehci_imx.c
> b/freebsd/sys/dev/usb/controller/ehci_imx.c
> index 544a63b5..23f7e3a9 100644
> --- a/freebsd/sys/dev/usb/controller/ehci_imx.c
> +++ b/freebsd/sys/dev/usb/controller/ehci_imx.c
> @@ -67,7 +67,9 @@ __FBSDID("$FreeBSD$");
>  #include 
>  #include 
>
> +#ifndef __rtems__
>  #include 
> +#endif /* __rtems__ */
>
>  #include 
>
> --
> 2.16.4
>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems-libbsd v2 12/14] ehci_imx: Add to build.

2020-04-16 Thread Vijay Kumar Banerjee 
On Thu, Apr 16, 2020 at 2:08 PM Christian Mauderer <
christian.maude...@embedded-brains.de> wrote:

> On 16/04/2020 10:27, Vijay Kumar Banerjee wrote:
> >
> >
> > On Thu, Apr 16, 2020 at 1:51 PM Christian Mauderer
> >  > > wrote:
> >
> >
> >
> > On 16/04/2020 09:41, Christian Mauderer wrote:
> > > On 16/04/2020 09:21, Vijay Kumar Banerjee wrote:
> > >>
> > >>
> > >> On Thu, Apr 16, 2020 at 12:41 PM Christian Mauderer
> > >>  > 
> > >>  > >> wrote:
> > >>
> > >> Hello Vijay,
> > >>
> > >> On 16/04/2020 09:04, Vijay Kumar Banerjee wrote:
> > >> > Hi Christian,
> > >> >
> > >> > I'm not able to build libbsd with this patch. I'm getting
> the
> > >> following
> > >> > error:
> > >> > ```
> > >> > ../../freebsd/sys/dev/usb/controller/ehci_imx.c:70:10:
> > fatal error:
> > >> > arm/freescale/imx/imx_ccmvar.h: No such file or directory
> > >> >  #include 
> > >> > ```
> > >> > From git blame I got to know that this file was introduced
> > by the
> > >> commit
> > >> > from this patch.
> > >> > Am I missing something or is it really a bug?
> > >>
> > >> Thanks for the report. On what BSP and which exact commit did
> > you try to
> > >> build? I had no trouble building the patch set from a clean
> > checkout
> > >> yesterday before committing it.
> > >>
> > >> I did a pull from the upstream master and tried the build on
> > >> arm/beagleboneblack
> > >> I see that the header file is not present in the freebsd/
> directory
> > >> ```
> > >> rtems-libbsd $>find -iname imx_ccmvar.h
> > >> ./freebsd-org/sys/arm/freescale/imx/imx_ccmvar.h
> > >> ```
> > >
> > > Hello Vijay,
> > >
> > > that's quite clearly a bug that I introduced. I'll create a patch.
> > >
> > > The imx_ccmvar.h is a file that is provided by the BSP I used for
> > testing.
> > >
> > > Best regards
> > >
> > > Christian
> >
> > I've sent a patch. Can you test it?
> >
> > Sure. I don't see the patch on the list yet, I'll test it as soon as it
> > comes :)
>
> Odd. It's already sent out and I CCd you directly. But the archive
> hasn't seen it either. To be sure, I attached the patch here.
>
> This patch fixed the issue and the build completes successfully. Thanks.
I'll also comment on the patch when it hits the list.

> >
> > >
> > >>
> > >> >
> > >> > Sorry for commenting on the patch that has already been
> > committed,
> > >> > please let me know of
> > >> > the preferred way to comment on a commit if this is not the
> > right way.
> > >>
> > >> No problem. That's exactly the right way to do it. If there
> > is a bug it
> > >> has to be solved and everyone should know that someone is
> > having a look
> > >> at it.
> > >>
> > >> Best regards
> > >>
> > >> Christian
> > >>
> [...]
>
> --
> 
> embedded brains GmbH
> Herr Christian Mauderer
> Dornierstr. 4
> D-82178 Puchheim
> Germany
> email: christian.maude...@embedded-brains.de
> Phone: +49-89-18 94 741 - 18
> Fax:   +49-89-18 94 741 - 08
> PGP: Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems-libbsd v2 12/14] ehci_imx: Add to build.

2020-04-16 Thread Christian Mauderer 
On 16/04/2020 10:27, Vijay Kumar Banerjee wrote:
> 
> 
> On Thu, Apr 16, 2020 at 1:51 PM Christian Mauderer
>  > wrote:
> 
> 
> 
> On 16/04/2020 09:41, Christian Mauderer wrote:
> > On 16/04/2020 09:21, Vijay Kumar Banerjee wrote:
> >>
> >>
> >> On Thu, Apr 16, 2020 at 12:41 PM Christian Mauderer
> >>  
> >>  >> wrote:
> >>
> >>     Hello Vijay,
> >>
> >>     On 16/04/2020 09:04, Vijay Kumar Banerjee wrote:
> >>     > Hi Christian,
> >>     >
> >>     > I'm not able to build libbsd with this patch. I'm getting the
> >>     following
> >>     > error:
> >>     > ```
> >>     > ../../freebsd/sys/dev/usb/controller/ehci_imx.c:70:10:
> fatal error:
> >>     > arm/freescale/imx/imx_ccmvar.h: No such file or directory
> >>     >  #include 
> >>     > ```
> >>     > From git blame I got to know that this file was introduced
> by the
> >>     commit
> >>     > from this patch.
> >>     > Am I missing something or is it really a bug?
> >>
> >>     Thanks for the report. On what BSP and which exact commit did
> you try to
> >>     build? I had no trouble building the patch set from a clean
> checkout
> >>     yesterday before committing it.
> >>
> >> I did a pull from the upstream master and tried the build on
> >> arm/beagleboneblack
> >> I see that the header file is not present in the freebsd/ directory
> >> ```
> >> rtems-libbsd $>find -iname imx_ccmvar.h
> >> ./freebsd-org/sys/arm/freescale/imx/imx_ccmvar.h
> >> ```
> >
> > Hello Vijay,
> >
> > that's quite clearly a bug that I introduced. I'll create a patch.
> >
> > The imx_ccmvar.h is a file that is provided by the BSP I used for
> testing.
> >
> > Best regards
> >
> > Christian
> 
> I've sent a patch. Can you test it?
> 
> Sure. I don't see the patch on the list yet, I'll test it as soon as it
> comes :) 

Odd. It's already sent out and I CCd you directly. But the archive
hasn't seen it either. To be sure, I attached the patch here.

> 
> >
> >>
> >>     >
> >>     > Sorry for commenting on the patch that has already been
> committed,
> >>     > please let me know of
> >>     > the preferred way to comment on a commit if this is not the
> right way.
> >>
> >>     No problem. That's exactly the right way to do it. If there
> is a bug it
> >>     has to be solved and everyone should know that someone is
> having a look
> >>     at it.
> >>
> >>     Best regards
> >>
> >>     Christian
> >>
[...]

-- 

embedded brains GmbH
Herr Christian Mauderer
Dornierstr. 4
D-82178 Puchheim
Germany
email: christian.maude...@embedded-brains.de
Phone: +49-89-18 94 741 - 18
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>From cc3ab6266ef0e0d037f45016e35190631177dd80 Mon Sep 17 00:00:00 2001
From: Christian Mauderer 
Date: Thu, 16 Apr 2020 09:52:12 +0200
Subject: [PATCH rtems-libbsd] imx: Fix build for all other BSPs.

---
 freebsd/sys/arm/freescale/imx/imx6_ccm.c| 7 +++
 freebsd/sys/arm/freescale/imx/imx6_usbphy.c | 4 
 freebsd/sys/dev/usb/controller/ehci_imx.c   | 2 ++
 3 files changed, 13 insertions(+)

diff --git a/freebsd/sys/arm/freescale/imx/imx6_ccm.c b/freebsd/sys/arm/freescale/imx/imx6_ccm.c
index cef79933..78bbd5c1 100644
--- a/freebsd/sys/arm/freescale/imx/imx6_ccm.c
+++ b/freebsd/sys/arm/freescale/imx/imx6_ccm.c
@@ -51,7 +51,14 @@ __FBSDID("$FreeBSD$");
 #include 
 #include 
 #include 
+#ifndef __rtems__
+#include 
+#else /* __rtems__ */
+#include 
+#ifdef LIBBSP_ARM_IMX_BSP_H
 #include 
+#endif /* LIBBSP_ARM_IMX_BSP_H */
+#endif /* __rtems__ */
 
 #ifndef CCGR_CLK_MODE_ALWAYS
 #define	CCGR_CLK_MODE_OFF		0
diff --git a/freebsd/sys/arm/freescale/imx/imx6_usbphy.c b/freebsd/sys/arm/freescale/imx/imx6_usbphy.c
index 7df2e124..3a3495bb 100644
--- a/freebsd/sys/arm/freescale/imx/imx6_usbphy.c
+++ b/freebsd/sys/arm/freescale/imx/imx6_usbphy.c
@@ -49,7 +49,11 @@ __FBSDID("$FreeBSD$");
 
 #include 
 
+#ifndef __rtems__
 #include 
+#else /* __rtems__ */
+void imx_ccm_usbphy_enable(device_t _phydev);
+#endif /* __rtems__ */
 #include 
 #include 
 #ifdef __rtems__
diff --git a/freebsd/sys/dev/usb/controller/ehci_imx.c b/freebsd/sys/dev/usb/controller/ehci_imx.c
index 544a63b5..23f7e3a9 100644
--- a/freebsd/sys/dev/usb/controller/ehci_imx.c
+++ b/freebsd/sys/dev/usb/controller/ehci_imx.c
@@ -67,7 +67,9 @@ __FBSDID("$FreeBSD$");
 #include 
 #include 
 
+#ifndef __rtems__
 #include 
+#endif /* __rtems__ */
 
 #include 
 
-- 
2.16.4

[PATCH rtems-libbsd] imx: Fix build for all other BSPs.

2020-04-16 Thread Christian Mauderer 
---
 freebsd/sys/arm/freescale/imx/imx6_ccm.c| 7 +++
 freebsd/sys/arm/freescale/imx/imx6_usbphy.c | 4 
 freebsd/sys/dev/usb/controller/ehci_imx.c   | 2 ++
 3 files changed, 13 insertions(+)

diff --git a/freebsd/sys/arm/freescale/imx/imx6_ccm.c 
b/freebsd/sys/arm/freescale/imx/imx6_ccm.c
index cef79933..78bbd5c1 100644
--- a/freebsd/sys/arm/freescale/imx/imx6_ccm.c
+++ b/freebsd/sys/arm/freescale/imx/imx6_ccm.c
@@ -51,7 +51,14 @@ __FBSDID("$FreeBSD$");
 #include 
 #include 
 #include 
+#ifndef __rtems__
+#include 
+#else /* __rtems__ */
+#include 
+#ifdef LIBBSP_ARM_IMX_BSP_H
 #include 
+#endif /* LIBBSP_ARM_IMX_BSP_H */
+#endif /* __rtems__ */
 
 #ifndef CCGR_CLK_MODE_ALWAYS
 #defineCCGR_CLK_MODE_OFF   0
diff --git a/freebsd/sys/arm/freescale/imx/imx6_usbphy.c 
b/freebsd/sys/arm/freescale/imx/imx6_usbphy.c
index 7df2e124..3a3495bb 100644
--- a/freebsd/sys/arm/freescale/imx/imx6_usbphy.c
+++ b/freebsd/sys/arm/freescale/imx/imx6_usbphy.c
@@ -49,7 +49,11 @@ __FBSDID("$FreeBSD$");
 
 #include 
 
+#ifndef __rtems__
 #include 
+#else /* __rtems__ */
+void imx_ccm_usbphy_enable(device_t _phydev);
+#endif /* __rtems__ */
 #include 
 #include 
 #ifdef __rtems__
diff --git a/freebsd/sys/dev/usb/controller/ehci_imx.c 
b/freebsd/sys/dev/usb/controller/ehci_imx.c
index 544a63b5..23f7e3a9 100644
--- a/freebsd/sys/dev/usb/controller/ehci_imx.c
+++ b/freebsd/sys/dev/usb/controller/ehci_imx.c
@@ -67,7 +67,9 @@ __FBSDID("$FreeBSD$");
 #include 
 #include 
 
+#ifndef __rtems__
 #include 
+#endif /* __rtems__ */
 
 #include 
 
-- 
2.16.4

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems-libbsd v2 12/14] ehci_imx: Add to build.

2020-04-16 Thread Vijay Kumar Banerjee 
On Thu, Apr 16, 2020 at 1:51 PM Christian Mauderer <
christian.maude...@embedded-brains.de> wrote:

>
>
> On 16/04/2020 09:41, Christian Mauderer wrote:
> > On 16/04/2020 09:21, Vijay Kumar Banerjee wrote:
> >>
> >>
> >> On Thu, Apr 16, 2020 at 12:41 PM Christian Mauderer
> >>  >> > wrote:
> >>
> >> Hello Vijay,
> >>
> >> On 16/04/2020 09:04, Vijay Kumar Banerjee wrote:
> >> > Hi Christian,
> >> >
> >> > I'm not able to build libbsd with this patch. I'm getting the
> >> following
> >> > error:
> >> > ```
> >> > ../../freebsd/sys/dev/usb/controller/ehci_imx.c:70:10: fatal
> error:
> >> > arm/freescale/imx/imx_ccmvar.h: No such file or directory
> >> >  #include 
> >> > ```
> >> > From git blame I got to know that this file was introduced by the
> >> commit
> >> > from this patch.
> >> > Am I missing something or is it really a bug?
> >>
> >> Thanks for the report. On what BSP and which exact commit did you
> try to
> >> build? I had no trouble building the patch set from a clean checkout
> >> yesterday before committing it.
> >>
> >> I did a pull from the upstream master and tried the build on
> >> arm/beagleboneblack
> >> I see that the header file is not present in the freebsd/ directory
> >> ```
> >> rtems-libbsd $>find -iname imx_ccmvar.h
> >> ./freebsd-org/sys/arm/freescale/imx/imx_ccmvar.h
> >> ```
> >
> > Hello Vijay,
> >
> > that's quite clearly a bug that I introduced. I'll create a patch.
> >
> > The imx_ccmvar.h is a file that is provided by the BSP I used for
> testing.
> >
> > Best regards
> >
> > Christian
>
> I've sent a patch. Can you test it?
>
> Sure. I don't see the patch on the list yet, I'll test it as soon as it
comes :)

> >
> >>
> >> >
> >> > Sorry for commenting on the patch that has already been committed,
> >> > please let me know of
> >> > the preferred way to comment on a commit if this is not the right
> way.
> >>
> >> No problem. That's exactly the right way to do it. If there is a
> bug it
> >> has to be solved and everyone should know that someone is having a
> look
> >> at it.
> >>
> >> Best regards
> >>
> >> Christian
> >>
> >> >
> >> >
> >> > Best regards,
> >> > Vijay
> >> > On Tue, Apr 14, 2020 at 8:21 PM Christian Mauderer
> >> >  >> 
> >> >  >> >> wrote:
> >> >
> >> > ---
> >> >  libbsd.py| 2 ++
> >> >  rtemsbsd/include/bsp/nexus-devices.h | 5 +
> >> >  2 files changed, 7 insertions(+)
> >> >
> >> > diff --git a/libbsd.py b/libbsd.py
> >> > index 4f8fb4d2..ed6493b2 100644
> >> > --- a/libbsd.py
> >> > +++ b/libbsd.py
> >> > @@ -5028,6 +5028,8 @@ class imx(builder.Module):
> >> >  self.addKernelSpaceSourceFiles(
> >> >  [
> >> >  'sys/arm/freescale/imx/imx6_ccm.c',
> >> > +'sys/arm/freescale/imx/imx6_usbphy.c',
> >> > +'sys/dev/usb/controller/ehci_imx.c',
> >> >  ],
> >> >  mm.generator['source']()
> >> >  )
> >> > diff --git a/rtemsbsd/include/bsp/nexus-devices.h
> >> > b/rtemsbsd/include/bsp/nexus-devices.h
> >> > index 0a210bd9..d2ceab8e 100644
> >> > --- a/rtemsbsd/include/bsp/nexus-devices.h
> >> > +++ b/rtemsbsd/include/bsp/nexus-devices.h
> >> > @@ -128,6 +128,11 @@ RTEMS_BSD_DEFINE_NEXUS_DEVICE(ofwbus, 0,
> >> 0, NULL);
> >> >  SYSINIT_DRIVER_REFERENCE(simplebus, ofwbus);
> >> >
> >> >  SYSINIT_DRIVER_REFERENCE(ccm, simplebus);
> >> > +SYSINIT_DRIVER_REFERENCE(ehci, simplebus);
> >> > +SYSINIT_DRIVER_REFERENCE(usbphy, simplebus);
> >> > +SYSINIT_DRIVER_REFERENCE(usbus, ehci);
> >> > +RTEMS_BSD_DRIVER_USB;
> >> > +RTEMS_BSD_DRIVER_USB_MASS;
> >> >
> >> >  SYSINIT_DRIVER_REFERENCE(ffec, simplebus);
> >> >  SYSINIT_DRIVER_REFERENCE(ukphy, miibus);
> >> > --
> >> > 2.16.4
> >> >
> >> > ___
> >> > devel mailing list
> >> > devel@rtems.org 
> >> >
> >> > http://lists.rtems.org/mailman/listinfo/devel
> >> >
> >>
> >> --
> >> 
> >> embedded brains GmbH
> >> Herr Christian Mauderer
> >> Dornierstr. 4
> >> D-82178 Puchheim
> >> Germany
> >> email: christian.maude...@embedded-brains.de
> >> 
> >> Phone: +49-89-18 94 741 - 18
> >> Fax:

Re: [PATCH rtems-libbsd v2 12/14] ehci_imx: Add to build.

2020-04-16 Thread Christian Mauderer 


On 16/04/2020 09:41, Christian Mauderer wrote:
> On 16/04/2020 09:21, Vijay Kumar Banerjee wrote:
>>
>>
>> On Thu, Apr 16, 2020 at 12:41 PM Christian Mauderer
>> > > wrote:
>>
>> Hello Vijay,
>>
>> On 16/04/2020 09:04, Vijay Kumar Banerjee wrote:
>> > Hi Christian,
>> >
>> > I'm not able to build libbsd with this patch. I'm getting the
>> following
>> > error:
>> > ```
>> > ../../freebsd/sys/dev/usb/controller/ehci_imx.c:70:10: fatal error:
>> > arm/freescale/imx/imx_ccmvar.h: No such file or directory
>> >  #include 
>> > ```
>> > From git blame I got to know that this file was introduced by the
>> commit
>> > from this patch.
>> > Am I missing something or is it really a bug?
>>
>> Thanks for the report. On what BSP and which exact commit did you try to
>> build? I had no trouble building the patch set from a clean checkout
>> yesterday before committing it.
>>
>> I did a pull from the upstream master and tried the build on
>> arm/beagleboneblack
>> I see that the header file is not present in the freebsd/ directory
>> ```
>> rtems-libbsd $>find -iname imx_ccmvar.h
>> ./freebsd-org/sys/arm/freescale/imx/imx_ccmvar.h
>> ``` 
> 
> Hello Vijay,
> 
> that's quite clearly a bug that I introduced. I'll create a patch.
> 
> The imx_ccmvar.h is a file that is provided by the BSP I used for testing.
> 
> Best regards
> 
> Christian

I've sent a patch. Can you test it?

> 
>>
>> >
>> > Sorry for commenting on the patch that has already been committed,
>> > please let me know of
>> > the preferred way to comment on a commit if this is not the right way.
>>
>> No problem. That's exactly the right way to do it. If there is a bug it
>> has to be solved and everyone should know that someone is having a look
>> at it.
>>
>> Best regards
>>
>> Christian
>>
>> >
>> >
>> > Best regards,
>> > Vijay
>> > On Tue, Apr 14, 2020 at 8:21 PM Christian Mauderer
>> > > 
>> > > >> wrote:
>> >
>> >     ---
>> >      libbsd.py                            | 2 ++
>> >      rtemsbsd/include/bsp/nexus-devices.h | 5 +
>> >      2 files changed, 7 insertions(+)
>> >
>> >     diff --git a/libbsd.py b/libbsd.py
>> >     index 4f8fb4d2..ed6493b2 100644
>> >     --- a/libbsd.py
>> >     +++ b/libbsd.py
>> >     @@ -5028,6 +5028,8 @@ class imx(builder.Module):
>> >              self.addKernelSpaceSourceFiles(
>> >                  [
>> >                      'sys/arm/freescale/imx/imx6_ccm.c',
>> >     +                'sys/arm/freescale/imx/imx6_usbphy.c',
>> >     +                'sys/dev/usb/controller/ehci_imx.c',
>> >                  ],
>> >                  mm.generator['source']()
>> >              )
>> >     diff --git a/rtemsbsd/include/bsp/nexus-devices.h
>> >     b/rtemsbsd/include/bsp/nexus-devices.h
>> >     index 0a210bd9..d2ceab8e 100644
>> >     --- a/rtemsbsd/include/bsp/nexus-devices.h
>> >     +++ b/rtemsbsd/include/bsp/nexus-devices.h
>> >     @@ -128,6 +128,11 @@ RTEMS_BSD_DEFINE_NEXUS_DEVICE(ofwbus, 0,
>> 0, NULL);
>> >      SYSINIT_DRIVER_REFERENCE(simplebus, ofwbus);
>> >
>> >      SYSINIT_DRIVER_REFERENCE(ccm, simplebus);
>> >     +SYSINIT_DRIVER_REFERENCE(ehci, simplebus);
>> >     +SYSINIT_DRIVER_REFERENCE(usbphy, simplebus);
>> >     +SYSINIT_DRIVER_REFERENCE(usbus, ehci);
>> >     +RTEMS_BSD_DRIVER_USB;
>> >     +RTEMS_BSD_DRIVER_USB_MASS;
>> >
>> >      SYSINIT_DRIVER_REFERENCE(ffec, simplebus);
>> >      SYSINIT_DRIVER_REFERENCE(ukphy, miibus);
>> >     --
>> >     2.16.4
>> >
>> >     ___
>> >     devel mailing list
>> >     devel@rtems.org 
>> >
>> >     http://lists.rtems.org/mailman/listinfo/devel
>> >
>>
>> -- 
>> 
>> embedded brains GmbH
>> Herr Christian Mauderer
>> Dornierstr. 4
>> D-82178 Puchheim
>> Germany
>> email: christian.maude...@embedded-brains.de
>> 
>> Phone: +49-89-18 94 741 - 18
>> Fax:   +49-89-18 94 741 - 08
>> PGP: Public key available on request.
>>
>> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>>
> 

-- 

embedded brains GmbH
Herr Christian Mauderer
Dornierstr. 4
D-82178 Puchheim
Germany
email: christian.maude...@embedded-brains.de
Phone: +49-89-18 94 741 - 18
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

Diese Nachricht ist keine

Re: [PATCH rtems-libbsd v2 12/14] ehci_imx: Add to build.

2020-04-16 Thread Christian Mauderer 
On 16/04/2020 09:21, Vijay Kumar Banerjee wrote:
> 
> 
> On Thu, Apr 16, 2020 at 12:41 PM Christian Mauderer
>  > wrote:
> 
> Hello Vijay,
> 
> On 16/04/2020 09:04, Vijay Kumar Banerjee wrote:
> > Hi Christian,
> >
> > I'm not able to build libbsd with this patch. I'm getting the
> following
> > error:
> > ```
> > ../../freebsd/sys/dev/usb/controller/ehci_imx.c:70:10: fatal error:
> > arm/freescale/imx/imx_ccmvar.h: No such file or directory
> >  #include 
> > ```
> > From git blame I got to know that this file was introduced by the
> commit
> > from this patch.
> > Am I missing something or is it really a bug?
> 
> Thanks for the report. On what BSP and which exact commit did you try to
> build? I had no trouble building the patch set from a clean checkout
> yesterday before committing it.
> 
> I did a pull from the upstream master and tried the build on
> arm/beagleboneblack
> I see that the header file is not present in the freebsd/ directory
> ```
> rtems-libbsd $>find -iname imx_ccmvar.h
> ./freebsd-org/sys/arm/freescale/imx/imx_ccmvar.h
> ``` 

Hello Vijay,

that's quite clearly a bug that I introduced. I'll create a patch.

The imx_ccmvar.h is a file that is provided by the BSP I used for testing.

Best regards

Christian

> 
> >
> > Sorry for commenting on the patch that has already been committed,
> > please let me know of
> > the preferred way to comment on a commit if this is not the right way.
> 
> No problem. That's exactly the right way to do it. If there is a bug it
> has to be solved and everyone should know that someone is having a look
> at it.
> 
> Best regards
> 
> Christian
> 
> >
> >
> > Best regards,
> > Vijay
> > On Tue, Apr 14, 2020 at 8:21 PM Christian Mauderer
> >  
> >  >> wrote:
> >
> >     ---
> >      libbsd.py                            | 2 ++
> >      rtemsbsd/include/bsp/nexus-devices.h | 5 +
> >      2 files changed, 7 insertions(+)
> >
> >     diff --git a/libbsd.py b/libbsd.py
> >     index 4f8fb4d2..ed6493b2 100644
> >     --- a/libbsd.py
> >     +++ b/libbsd.py
> >     @@ -5028,6 +5028,8 @@ class imx(builder.Module):
> >              self.addKernelSpaceSourceFiles(
> >                  [
> >                      'sys/arm/freescale/imx/imx6_ccm.c',
> >     +                'sys/arm/freescale/imx/imx6_usbphy.c',
> >     +                'sys/dev/usb/controller/ehci_imx.c',
> >                  ],
> >                  mm.generator['source']()
> >              )
> >     diff --git a/rtemsbsd/include/bsp/nexus-devices.h
> >     b/rtemsbsd/include/bsp/nexus-devices.h
> >     index 0a210bd9..d2ceab8e 100644
> >     --- a/rtemsbsd/include/bsp/nexus-devices.h
> >     +++ b/rtemsbsd/include/bsp/nexus-devices.h
> >     @@ -128,6 +128,11 @@ RTEMS_BSD_DEFINE_NEXUS_DEVICE(ofwbus, 0,
> 0, NULL);
> >      SYSINIT_DRIVER_REFERENCE(simplebus, ofwbus);
> >
> >      SYSINIT_DRIVER_REFERENCE(ccm, simplebus);
> >     +SYSINIT_DRIVER_REFERENCE(ehci, simplebus);
> >     +SYSINIT_DRIVER_REFERENCE(usbphy, simplebus);
> >     +SYSINIT_DRIVER_REFERENCE(usbus, ehci);
> >     +RTEMS_BSD_DRIVER_USB;
> >     +RTEMS_BSD_DRIVER_USB_MASS;
> >
> >      SYSINIT_DRIVER_REFERENCE(ffec, simplebus);
> >      SYSINIT_DRIVER_REFERENCE(ukphy, miibus);
> >     --
> >     2.16.4
> >
> >     ___
> >     devel mailing list
> >     devel@rtems.org 
> >
> >     http://lists.rtems.org/mailman/listinfo/devel
> >
> 
> -- 
> 
> embedded brains GmbH
> Herr Christian Mauderer
> Dornierstr. 4
> D-82178 Puchheim
> Germany
> email: christian.maude...@embedded-brains.de
> 
> Phone: +49-89-18 94 741 - 18
> Fax:   +49-89-18 94 741 - 08
> PGP: Public key available on request.
> 
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
> 

-- 

embedded brains GmbH
Herr Christian Mauderer
Dornierstr. 4
D-82178 Puchheim
Germany
email: christian.maude...@embedded-brains.de
Phone: +49-89-18 94 741 - 18
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems-libbsd v2 12/14] ehci_imx: Add to build.

2020-04-16 Thread Vijay Kumar Banerjee 
On Thu, Apr 16, 2020 at 12:41 PM Christian Mauderer <
christian.maude...@embedded-brains.de> wrote:

> Hello Vijay,
>
> On 16/04/2020 09:04, Vijay Kumar Banerjee wrote:
> > Hi Christian,
> >
> > I'm not able to build libbsd with this patch. I'm getting the following
> > error:
> > ```
> > ../../freebsd/sys/dev/usb/controller/ehci_imx.c:70:10: fatal error:
> > arm/freescale/imx/imx_ccmvar.h: No such file or directory
> >  #include 
> > ```
> > From git blame I got to know that this file was introduced by the commit
> > from this patch.
> > Am I missing something or is it really a bug?
>
> Thanks for the report. On what BSP and which exact commit did you try to
> build? I had no trouble building the patch set from a clean checkout
> yesterday before committing it.
>
> I did a pull from the upstream master and tried the build on
arm/beagleboneblack
I see that the header file is not present in the freebsd/ directory
```
rtems-libbsd $>find -iname imx_ccmvar.h
./freebsd-org/sys/arm/freescale/imx/imx_ccmvar.h
```

> >
> > Sorry for commenting on the patch that has already been committed,
> > please let me know of
> > the preferred way to comment on a commit if this is not the right way.
>
> No problem. That's exactly the right way to do it. If there is a bug it
> has to be solved and everyone should know that someone is having a look
> at it.
>
> Best regards
>
> Christian
>
> >
> >
> > Best regards,
> > Vijay
> > On Tue, Apr 14, 2020 at 8:21 PM Christian Mauderer
> >  > > wrote:
> >
> > ---
> >  libbsd.py| 2 ++
> >  rtemsbsd/include/bsp/nexus-devices.h | 5 +
> >  2 files changed, 7 insertions(+)
> >
> > diff --git a/libbsd.py b/libbsd.py
> > index 4f8fb4d2..ed6493b2 100644
> > --- a/libbsd.py
> > +++ b/libbsd.py
> > @@ -5028,6 +5028,8 @@ class imx(builder.Module):
> >  self.addKernelSpaceSourceFiles(
> >  [
> >  'sys/arm/freescale/imx/imx6_ccm.c',
> > +'sys/arm/freescale/imx/imx6_usbphy.c',
> > +'sys/dev/usb/controller/ehci_imx.c',
> >  ],
> >  mm.generator['source']()
> >  )
> > diff --git a/rtemsbsd/include/bsp/nexus-devices.h
> > b/rtemsbsd/include/bsp/nexus-devices.h
> > index 0a210bd9..d2ceab8e 100644
> > --- a/rtemsbsd/include/bsp/nexus-devices.h
> > +++ b/rtemsbsd/include/bsp/nexus-devices.h
> > @@ -128,6 +128,11 @@ RTEMS_BSD_DEFINE_NEXUS_DEVICE(ofwbus, 0, 0,
> NULL);
> >  SYSINIT_DRIVER_REFERENCE(simplebus, ofwbus);
> >
> >  SYSINIT_DRIVER_REFERENCE(ccm, simplebus);
> > +SYSINIT_DRIVER_REFERENCE(ehci, simplebus);
> > +SYSINIT_DRIVER_REFERENCE(usbphy, simplebus);
> > +SYSINIT_DRIVER_REFERENCE(usbus, ehci);
> > +RTEMS_BSD_DRIVER_USB;
> > +RTEMS_BSD_DRIVER_USB_MASS;
> >
> >  SYSINIT_DRIVER_REFERENCE(ffec, simplebus);
> >  SYSINIT_DRIVER_REFERENCE(ukphy, miibus);
> > --
> > 2.16.4
> >
> > ___
> > devel mailing list
> > devel@rtems.org 
> > http://lists.rtems.org/mailman/listinfo/devel
> >
>
> --
> 
> embedded brains GmbH
> Herr Christian Mauderer
> Dornierstr. 4
> D-82178 Puchheim
> Germany
> email: christian.maude...@embedded-brains.de
> Phone: +49-89-18 94 741 - 18
> Fax:   +49-89-18 94 741 - 08
> PGP: Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems-libbsd v2 12/14] ehci_imx: Add to build.

2020-04-16 Thread Christian Mauderer 
Hello Vijay,

On 16/04/2020 09:04, Vijay Kumar Banerjee wrote:
> Hi Christian,
> 
> I'm not able to build libbsd with this patch. I'm getting the following
> error:
> ```
> ../../freebsd/sys/dev/usb/controller/ehci_imx.c:70:10: fatal error:
> arm/freescale/imx/imx_ccmvar.h: No such file or directory
>  #include 
> ```
> From git blame I got to know that this file was introduced by the commit
> from this patch.
> Am I missing something or is it really a bug?

Thanks for the report. On what BSP and which exact commit did you try to
build? I had no trouble building the patch set from a clean checkout
yesterday before committing it.

> 
> Sorry for commenting on the patch that has already been committed,
> please let me know of
> the preferred way to comment on a commit if this is not the right way.

No problem. That's exactly the right way to do it. If there is a bug it
has to be solved and everyone should know that someone is having a look
at it.

Best regards

Christian

> 
> 
> Best regards,
> Vijay
> On Tue, Apr 14, 2020 at 8:21 PM Christian Mauderer
>  > wrote:
> 
> ---
>  libbsd.py                            | 2 ++
>  rtemsbsd/include/bsp/nexus-devices.h | 5 +
>  2 files changed, 7 insertions(+)
> 
> diff --git a/libbsd.py b/libbsd.py
> index 4f8fb4d2..ed6493b2 100644
> --- a/libbsd.py
> +++ b/libbsd.py
> @@ -5028,6 +5028,8 @@ class imx(builder.Module):
>          self.addKernelSpaceSourceFiles(
>              [
>                  'sys/arm/freescale/imx/imx6_ccm.c',
> +                'sys/arm/freescale/imx/imx6_usbphy.c',
> +                'sys/dev/usb/controller/ehci_imx.c',
>              ],
>              mm.generator['source']()
>          )
> diff --git a/rtemsbsd/include/bsp/nexus-devices.h
> b/rtemsbsd/include/bsp/nexus-devices.h
> index 0a210bd9..d2ceab8e 100644
> --- a/rtemsbsd/include/bsp/nexus-devices.h
> +++ b/rtemsbsd/include/bsp/nexus-devices.h
> @@ -128,6 +128,11 @@ RTEMS_BSD_DEFINE_NEXUS_DEVICE(ofwbus, 0, 0, NULL);
>  SYSINIT_DRIVER_REFERENCE(simplebus, ofwbus);
> 
>  SYSINIT_DRIVER_REFERENCE(ccm, simplebus);
> +SYSINIT_DRIVER_REFERENCE(ehci, simplebus);
> +SYSINIT_DRIVER_REFERENCE(usbphy, simplebus);
> +SYSINIT_DRIVER_REFERENCE(usbus, ehci);
> +RTEMS_BSD_DRIVER_USB;
> +RTEMS_BSD_DRIVER_USB_MASS;
> 
>  SYSINIT_DRIVER_REFERENCE(ffec, simplebus);
>  SYSINIT_DRIVER_REFERENCE(ukphy, miibus);
> -- 
> 2.16.4
> 
> ___
> devel mailing list
> devel@rtems.org 
> http://lists.rtems.org/mailman/listinfo/devel
> 

-- 

embedded brains GmbH
Herr Christian Mauderer
Dornierstr. 4
D-82178 Puchheim
Germany
email: christian.maude...@embedded-brains.de
Phone: +49-89-18 94 741 - 18
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems-libbsd v2 12/14] ehci_imx: Add to build.

2020-04-16 Thread Vijay Kumar Banerjee 
Hi Christian,

I'm not able to build libbsd with this patch. I'm getting the following
error:
```
../../freebsd/sys/dev/usb/controller/ehci_imx.c:70:10: fatal error:
arm/freescale/imx/imx_ccmvar.h: No such file or directory
 #include 
```
>From git blame I got to know that this file was introduced by the commit
from this patch.
Am I missing something or is it really a bug?

Sorry for commenting on the patch that has already been committed, please
let me know of
the preferred way to comment on a commit if this is not the right way.


Best regards,
Vijay
On Tue, Apr 14, 2020 at 8:21 PM Christian Mauderer <
christian.maude...@embedded-brains.de> wrote:

> ---
>  libbsd.py| 2 ++
>  rtemsbsd/include/bsp/nexus-devices.h | 5 +
>  2 files changed, 7 insertions(+)
>
> diff --git a/libbsd.py b/libbsd.py
> index 4f8fb4d2..ed6493b2 100644
> --- a/libbsd.py
> +++ b/libbsd.py
> @@ -5028,6 +5028,8 @@ class imx(builder.Module):
>  self.addKernelSpaceSourceFiles(
>  [
>  'sys/arm/freescale/imx/imx6_ccm.c',
> +'sys/arm/freescale/imx/imx6_usbphy.c',
> +'sys/dev/usb/controller/ehci_imx.c',
>  ],
>  mm.generator['source']()
>  )
> diff --git a/rtemsbsd/include/bsp/nexus-devices.h
> b/rtemsbsd/include/bsp/nexus-devices.h
> index 0a210bd9..d2ceab8e 100644
> --- a/rtemsbsd/include/bsp/nexus-devices.h
> +++ b/rtemsbsd/include/bsp/nexus-devices.h
> @@ -128,6 +128,11 @@ RTEMS_BSD_DEFINE_NEXUS_DEVICE(ofwbus, 0, 0, NULL);
>  SYSINIT_DRIVER_REFERENCE(simplebus, ofwbus);
>
>  SYSINIT_DRIVER_REFERENCE(ccm, simplebus);
> +SYSINIT_DRIVER_REFERENCE(ehci, simplebus);
> +SYSINIT_DRIVER_REFERENCE(usbphy, simplebus);
> +SYSINIT_DRIVER_REFERENCE(usbus, ehci);
> +RTEMS_BSD_DRIVER_USB;
> +RTEMS_BSD_DRIVER_USB_MASS;
>
>  SYSINIT_DRIVER_REFERENCE(ffec, simplebus);
>  SYSINIT_DRIVER_REFERENCE(ukphy, miibus);
> --
> 2.16.4
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: Missing link on the RTEMS website

2020-04-16 Thread Sebastian Huber 

On 15/04/2020 15:01, Joel Sherrill wrote:




On Wed, Apr 15, 2020, 7:59 AM Sebastian Huber 
> wrote:


On 15/04/2020 14:55, Joel Sherrill wrote:




On Wed, Apr 15, 2020 at 6:11 AM Sebastian Huber
mailto:sebastian.hu...@embedded-brains.de>> wrote:

Hello,

On 15/04/2020 13:03, Kuan-Hsun Chen wrote:

Hello all,

I just notice that https://www.rtems.org/page has a link
point to, which is missing:
https://devel.rtems.org/wiki/TBR/Website/Mission_Statement

I am writing some descriptions regarding RTEMS at meanwhile,
should I just report here or directly update the website
somehow?


I moved the mission statement to the engineering manual:

https://docs.rtems.org/branches/master/eng/mission.html

It would be nice if someone can fix the link on www.rtems.org
.


I think this is done now. Please check and confirm.

Thanks, this one is fixed. There are a couple of other links which
point to the wiki and should instead point to the documentation.


Could you provide specifics? There are a lot of links there.

I am to fix them if I know what to fix.


I just hovered over some links.

Quick Start

http://devel.rtems.org/wiki/TBR/UserManual/Quick_Start

https://docs.rtems.org/branches/master/user/start/index.html

Contributing

http://devel.rtems.org/wiki/Developer/Contributing

https://docs.rtems.org/branches/master/user/support/contrib.html

GIT Read Access -> Git Read Access (maybe also move one level up)

http://devel.rtems.org/wiki/Developer/Git#GitAccessforUsers

https://docs.rtems.org/branches/master/eng/vc-users.html

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel