Re: AW: [PATCH 12/12] spec/build/cpukit: Add option for enabling PPS synchronization

2022-04-11 Thread Chris Johns
On 8/4/2022 3:48 pm, Sebastian Huber wrote:
> On 08/04/2022 02:45, Chris Johns wrote:
>> On 7/4/2022 9:56 pm, Sebastian Huber wrote:
>>> We should avoid new CPU options in general.
>> Is this documented with a suitable rational?
> 
> This could be something for:
> 
> https://docs.rtems.org/branches/master/eng/coding-conventions.html
> 

I do not know the reason so I cannot say :)

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: [PATCH 0/1] libbsd: Add TFTP filesystem to test media01

2022-04-11 Thread Chris Johns
Hi Frank,

I am OK with this change.

Thanks
Chris

On 9/4/2022 12:05 am, Frank Kuehndel wrote:
> From: Frank Kühndel 
> 
> Hello,
> 
> I would like to ask the community whether it would be possible
> to accept the little patch which follows?  The patch permits to
> mount and use the TFTP filesystem through the RTEMS shell of test
> media01.  It serves demonstration purposes and permits users
> to try out TFTP without modifying any code before.
> 
> Greetings,
> 
> Frank Kühndel (1):
>   libbsd: Add TFTP filesystem to test media01
> 
>  libbsd.py | 2 +-
>  testsuite/media01/test_main.c | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

CAN driver message structure

2022-04-11 Thread Prashanth S
Hi All,

This is to query on CAN message format for CAN drivers.

I want to implement a CAN driver for BeagleBone Black in RTEMS(GSoC).

As I looked through the RTEMS Source Tree, found
https://devel.rtems.org/browser/rtems/bsps/arm/lpc176x/can

, https://devel.rtems.org/browser/rtems/bsps/powerpc/gen5200/mscan

CAN drivers, which have driver specific CAN message structure.

https://devel.rtems.org/browser/rtems/bsps/powerpc/gen5200/include/bsp/mscan.h
struct can_message {
  /* uint16_t mess_len; */
  uint16_t mess_id;
  uint16_t mess_time_stamp;
  uint8_t  mess_data[MSCAN_MAX_DATA_BYTES];
  uint8_t  mess_len;
  uint8_t  mess_rtr;
  uint32_t toucan_tx_idx;
};

https://devel.rtems.org/browser/rtems/bsps/arm/lpc176x/include/bsp/can.h
typedef union {
  low_level_can_message low_level;
  registers_can_message registers;
 } can_message;

I would like to know if I should define a driver dependent CAN message
structure or use one of the existing ones.

Ideally, I think a generic (driver independent) CAN message structure will
help applications to be portable.

Regards
Prashanth S
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: List third party files in cpukit and testsuites

2022-04-11 Thread Joel Sherrill
On Mon, Apr 11, 2022 at 9:46 AM Gedare Bloom  wrote:

> On Fri, Apr 8, 2022 at 12:35 PM Ryan Long  wrote:
> >
> > This is the set of files in the source code that are all third party.
> > This means they should not be re-licensed or re-formatted.
> >
> > If anything on this list is wrong, or if I missed some, please comment.
> >
> > Thanks,
> >
> > Ryan
> >
> > David Gibson, IBM Corporation
> > cpukit/dtc/libfdt/fdt.c
> > cpukit/dtc/libfdt/fdt_empty_tree.c
> > cpukit/dtc/libfdt/fdt_ro.c
> > cpukit/dtc/libfdt/fdt_rw.c
> > cpukit/dtc/libfdt/fdt_strerror.c
> > cpukit/dtc/libfdt/fdt_sw.c
> > cpukit/dtc/libfdt/fdt_wip.c
> > cpukit/dtc/libfdt/libfdt_internal.h
> > cpukit/include/fdt.h
> > cpukit/include/libfdt.h
> > cpukit/include/libfdt_env.h
> >
> ok, the dtc/libfdt is 3rd party. It should be specified as cpukit/dtc
>
> > The Regents of the University of California
> > cpukit/include/arpa/ftp.h
> > cpukit/include/machine/_kernel_in.h
> > cpukit/include/machine/_kernel_mman.h
> > .cpukit/libmisc/shell/dd-args.c
> > cpukit/libmisc/shell/dd-conv.c
> > cpukit/libmisc/shell/dd-conv_tab.c
> > cpukit/libmisc/shell/dd-misc.c
> > cpukit/libmisc/shell/dd-position.c
> > cpukit/libmisc/shell/dd.h
> > cpukit/libmisc/shell/err.c
> > cpukit/libmisc/shell/err.h
> > cpukit/libmisc/shell/errx.c
> > cpukit/libmisc/shell/extern-cp.h
> > cpukit/libmisc/shell/extern-dd.h
> > cpukit/libmisc/shell/extern-ls.h
> > cpukit/libmisc/shell/filemode.c
> > cpukit/libmisc/shell/fts.c
> > cpukit/libmisc/shell/fts.h
> > cpukit/libmisc/shell/hexdump-conv.c
> > cpukit/libmisc/shell/hexdump-display.c
> > cpukit/libmisc/shell/hexdump-odsyntax.c
> > cpukit/libmisc/shell/hexdump-parse.c
> > cpukit/libmisc/shell/hexdump.h
> > cpukit/libmisc/shell/hexsyntax.c
> > cpukit/libmisc/shell/main_cp.c
> > cpukit/libmisc/shell/main_dd.c
> > cpukit/libmisc/shell/main_echo.c
> > cpukit/libmisc/shell/main_hexdump.c
> > cpukit/libmisc/shell/main_mv.c
> > cpukit/libmisc/shell/main_ln.c
> > cpukit/libmisc/shell/main_ls.c
> > cpukit/libmisc/shell/main_rm.c
> > cpukit/libmisc/shell/pathnames-mv.h
> > cpukit/libmisc/shell/print-ls.c
> > cpukit/libmisc/shell/pwcache.c
> > cpukit/libmisc/shell/sysexits.h
> > cpukit/libmisc/shell/utils-cp.c
> > cpukit/libmisc/shell/utils-ls.c
> > cpukit/libmisc/shell/verr.c
> > cpukit/libmisc/shell/verrx.c
> > cpukit/libmisc/shell/vis.c
> > cpukit/libmisc/shell/vis.h
> > cpukit/libmisc/shell/vwarn.c
> > cpukit/libmisc/shell/vwarnx.c
> > cpukit/libmisc/shell/warn.c
> > cpukit/libmisc/shell/warnx.c
> > cpukit/score/src/iovprintf.c
> > cpukit/libcsupport/src/cfmakeraw.c
> > cpukit/libcsupport/src/cfmakesane.c
> > /include/machine/_kernel_uio.h
> >
> I've had this question in the past about whether or not 'shell' is 3rd
> party. I never had a great answer. The question about not touching 3rd
> party sources is more about whether or not there is someone upstream
> that maintains them. If there's not any update path, then we
> effectively own the code now (clone and own).
>

A lot (68/104) files in shell have RTEMS GPL so most of the code is
really ours. There often is enough hacking to argue clone and own on
some but it is still possible to compare and update. I think Ryan did a
fair bit of this and reporting upstream when addressing Coverity issues.


> That said, everything that is copyrighted by The Regents of the
> University of California can be licensed to 3-BSD.
>

I politely ask you to make this change. You understand the why
and how.

>
> Meanwhile, this list has me thinking that you should also use grep
> "\$FreeBSD" to find source files imported from there. Ditto for
> NetBSD. I think it makes more sense to track 3rd party software based
> on where it comes from rather than based on the contributor/copyright
> holder.
>

That was a manual flag for third party but I don't think it ever got to
a grep.

>
> > Mark Murray
> > cpukit/include/crypt.h
> For example, this would be better identified as being part of the
> NetBSD libcrypt
>

Where it came from is just for discussion now. Ultimately we only
care that it is third party.

>
> >
> > NetBSD
> > cpukit/include/dlfcn.h
> > cpukit/include/link.h
> > cpukit/include/link_elf.h
> > cpukit/libmisc/shell/cmp-ls.c
> > cpukit/libdl/rtl-mdreloc-arm.c
> > cpukit/libdl/rtl-mdreloc-i386.c
> > cpukit/libdl/rtl-mdreloc-m68k.c
> > cpukit/libdl/rtl-mdreloc-riscv.c
> > cpukit/libdl/rtl-mdreloc-sparc.c
> > cpukit/libmisc/shell/main_mknod.c
> > cpukit/libmisc/shell/mknod-pack_dev.c
> > cpukit/libmisc/shell/mknod-pack_dev.h
> > cpukit/score/cpu/i386/include/machine/elf_machdep.h
> > cpukit/score/cpu/m68k/include/machine/elf_machdep.h
> > cpukit/score/cpu/mips/include/machine/elf_machdep.h
> > cpukit/score/cpu/nios2/include/machine/elf_machdep.h
> > cpukit/score/cpu/sparc/include/machine/elf_machdep.h
> > cpukit/score/cpu/x86_64/include/machine/elf_machdep.h
> > cpukit/include/sys/cdefs_elf.h
> > cpukit/include/sys/exec_elf.h
> > cpukit/telnetd/des.c
> >
> > WIDE Project
> > 

Re: List third party files in cpukit and testsuites

2022-04-11 Thread Gedare Bloom
On Fri, Apr 8, 2022 at 12:35 PM Ryan Long  wrote:
>
> This is the set of files in the source code that are all third party.
> This means they should not be re-licensed or re-formatted.
>
> If anything on this list is wrong, or if I missed some, please comment.
>
> Thanks,
>
> Ryan
>
> David Gibson, IBM Corporation
> cpukit/dtc/libfdt/fdt.c
> cpukit/dtc/libfdt/fdt_empty_tree.c
> cpukit/dtc/libfdt/fdt_ro.c
> cpukit/dtc/libfdt/fdt_rw.c
> cpukit/dtc/libfdt/fdt_strerror.c
> cpukit/dtc/libfdt/fdt_sw.c
> cpukit/dtc/libfdt/fdt_wip.c
> cpukit/dtc/libfdt/libfdt_internal.h
> cpukit/include/fdt.h
> cpukit/include/libfdt.h
> cpukit/include/libfdt_env.h
>
ok, the dtc/libfdt is 3rd party. It should be specified as cpukit/dtc

> The Regents of the University of California
> cpukit/include/arpa/ftp.h
> cpukit/include/machine/_kernel_in.h
> cpukit/include/machine/_kernel_mman.h
> .cpukit/libmisc/shell/dd-args.c
> cpukit/libmisc/shell/dd-conv.c
> cpukit/libmisc/shell/dd-conv_tab.c
> cpukit/libmisc/shell/dd-misc.c
> cpukit/libmisc/shell/dd-position.c
> cpukit/libmisc/shell/dd.h
> cpukit/libmisc/shell/err.c
> cpukit/libmisc/shell/err.h
> cpukit/libmisc/shell/errx.c
> cpukit/libmisc/shell/extern-cp.h
> cpukit/libmisc/shell/extern-dd.h
> cpukit/libmisc/shell/extern-ls.h
> cpukit/libmisc/shell/filemode.c
> cpukit/libmisc/shell/fts.c
> cpukit/libmisc/shell/fts.h
> cpukit/libmisc/shell/hexdump-conv.c
> cpukit/libmisc/shell/hexdump-display.c
> cpukit/libmisc/shell/hexdump-odsyntax.c
> cpukit/libmisc/shell/hexdump-parse.c
> cpukit/libmisc/shell/hexdump.h
> cpukit/libmisc/shell/hexsyntax.c
> cpukit/libmisc/shell/main_cp.c
> cpukit/libmisc/shell/main_dd.c
> cpukit/libmisc/shell/main_echo.c
> cpukit/libmisc/shell/main_hexdump.c
> cpukit/libmisc/shell/main_mv.c
> cpukit/libmisc/shell/main_ln.c
> cpukit/libmisc/shell/main_ls.c
> cpukit/libmisc/shell/main_rm.c
> cpukit/libmisc/shell/pathnames-mv.h
> cpukit/libmisc/shell/print-ls.c
> cpukit/libmisc/shell/pwcache.c
> cpukit/libmisc/shell/sysexits.h
> cpukit/libmisc/shell/utils-cp.c
> cpukit/libmisc/shell/utils-ls.c
> cpukit/libmisc/shell/verr.c
> cpukit/libmisc/shell/verrx.c
> cpukit/libmisc/shell/vis.c
> cpukit/libmisc/shell/vis.h
> cpukit/libmisc/shell/vwarn.c
> cpukit/libmisc/shell/vwarnx.c
> cpukit/libmisc/shell/warn.c
> cpukit/libmisc/shell/warnx.c
> cpukit/score/src/iovprintf.c
> cpukit/libcsupport/src/cfmakeraw.c
> cpukit/libcsupport/src/cfmakesane.c
> /include/machine/_kernel_uio.h
>
I've had this question in the past about whether or not 'shell' is 3rd
party. I never had a great answer. The question about not touching 3rd
party sources is more about whether or not there is someone upstream
that maintains them. If there's not any update path, then we
effectively own the code now (clone and own).

That said, everything that is copyrighted by The Regents of the
University of California can be licensed to 3-BSD.

Meanwhile, this list has me thinking that you should also use grep
"\$FreeBSD" to find source files imported from there. Ditto for
NetBSD. I think it makes more sense to track 3rd party software based
on where it comes from rather than based on the contributor/copyright
holder.

> Mark Murray
> cpukit/include/crypt.h
For example, this would be better identified as being part of the
NetBSD libcrypt

>
> NetBSD
> cpukit/include/dlfcn.h
> cpukit/include/link.h
> cpukit/include/link_elf.h
> cpukit/libmisc/shell/cmp-ls.c
> cpukit/libdl/rtl-mdreloc-arm.c
> cpukit/libdl/rtl-mdreloc-i386.c
> cpukit/libdl/rtl-mdreloc-m68k.c
> cpukit/libdl/rtl-mdreloc-riscv.c
> cpukit/libdl/rtl-mdreloc-sparc.c
> cpukit/libmisc/shell/main_mknod.c
> cpukit/libmisc/shell/mknod-pack_dev.c
> cpukit/libmisc/shell/mknod-pack_dev.h
> cpukit/score/cpu/i386/include/machine/elf_machdep.h
> cpukit/score/cpu/m68k/include/machine/elf_machdep.h
> cpukit/score/cpu/mips/include/machine/elf_machdep.h
> cpukit/score/cpu/nios2/include/machine/elf_machdep.h
> cpukit/score/cpu/sparc/include/machine/elf_machdep.h
> cpukit/score/cpu/x86_64/include/machine/elf_machdep.h
> cpukit/include/sys/cdefs_elf.h
> cpukit/include/sys/exec_elf.h
> cpukit/telnetd/des.c
>
> WIDE Project
> cpukit/include/machine/_kernel_in6.h
>
> RSA Data Security, Inc.
> cpukit/include/md4.h
> cpukit/include/md5.h
>
> Sergey Lyubka
> cpukit/include/mghttpd/mongoose.h
> cpukit/mghttpd/mongoose.c
>
> FreeBSD
> cpukit/include/pci/pcireg.h
> cpukit/libstdthreads/call_once.c
> cpukit/libstdthreads/thrd.c
> cpukit/libstdthreads/tss.c
> cpukit/include/sys/endian.h
> cpukit/include/sys/event.h
> cpukit/include/sys/poll.h
> cpukit/include/sys/priority.h
> cpukit/include/sys/timepps.h
> cpukit/include/sys/timetc.h
> cpukit/include/sys/timex.h
> cpukit/libcrypt/crypt-sha256.c
> cpukit/libcrypt/crypt-sha512.c
> cpukit/score/src/kern_ntptime.c
> cpukit/score/src/kern_tc.c
> cpukit/include/sha256.h
> cpukit/include/sha512.h
> cpukit/include/sys/_ffcounter.h
> cpukit/include/sys/timeffc.h
>
> Public Software Group
> cpukit/include/utf8proc/utf8proc.h
>