Re: [PATCH] Canonicalize config.h include
On 15/04/2020 15:59, Gedare Bloom wrote: This is fine with me to go in 5.1 or defer to 6 it doesn't really matter. It reduces a bit the probability for merge conflicts. So, I will push it after a compile run. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH] Canonicalize config.h include
This is fine with me to go in 5.1 or defer to 6 it doesn't really matter. On Wed, Apr 15, 2020 at 1:55 AM Sebastian Huber wrote: > > Use the following variant which was already used by most source files: > > #ifdef HAVE_CONFIG_H > #include "config.h" > #endif > --- > cpukit/dev/i2c/eeprom.c | 4 ++-- > cpukit/dev/i2c/fpga-i2c-slave.c | 4 ++-- > cpukit/dev/i2c/gpio-nxp-pca9535.c | 4 ++-- > cpukit/dev/i2c/i2c-bus.c| 4 ++-- > cpukit/dev/i2c/i2c-dev.c| 4 ++-- > cpukit/dev/i2c/sensor-lm75a.c | 2 +- > cpukit/dev/i2c/switch-nxp-pca9548a.c| 4 ++-- > cpukit/dev/i2c/ti-ads-16bit-adc.c | 4 ++-- > cpukit/dev/i2c/ti-lm25066a.c| 4 ++-- > cpukit/dev/i2c/ti-tmp112.c | 4 ++-- > cpukit/dev/spi/spi-bus.c| 4 ++-- > cpukit/ftpd/ftpd-init.c | 2 +- > cpukit/ftpd/ftpd.c | 2 +- > cpukit/libblock/src/bdbuf.c | 2 +- > cpukit/libblock/src/bdpart-register.c | 2 +- > cpukit/libblock/src/blkdev-blkstats.c | 4 ++-- > cpukit/libblock/src/blkdev-imfs.c | 4 ++-- > cpukit/libblock/src/blkdev-ioctl.c | 4 ++-- > cpukit/libblock/src/blkdev-print-stats.c| 4 ++-- > cpukit/libblock/src/blkdev.c| 2 +- > cpukit/libblock/src/diskdevs-init.c | 4 ++-- > cpukit/libblock/src/diskdevs.c | 2 +- > cpukit/libblock/src/flashdisk.c | 2 +- > cpukit/libblock/src/ide_part_table.c| 2 +- > cpukit/libblock/src/nvdisk-sram.c | 2 +- > cpukit/libblock/src/nvdisk.c| 2 +- > cpukit/libblock/src/ramdisk-init.c | 2 +- > cpukit/libblock/src/ramdisk-register.c | 2 +- > cpukit/libblock/src/show_bdbuf.c| 2 +- > cpukit/libcsupport/src/__assert.c | 2 +- > cpukit/libcsupport/src/__getpid.c | 2 +- > cpukit/libcsupport/src/__gettod.c | 2 +- > cpukit/libcsupport/src/__times.c| 2 +- > cpukit/libcsupport/src/__usrenv.c | 4 ++-- > cpukit/libcsupport/src/_calloc_r.c | 2 +- > cpukit/libcsupport/src/_free_r.c| 2 +- > cpukit/libcsupport/src/_malloc_r.c | 2 +- > cpukit/libcsupport/src/_realloc_r.c | 2 +- > cpukit/libcsupport/src/_rename_r.c | 2 +- > cpukit/libcsupport/src/access.c | 2 +- > cpukit/libcsupport/src/alignedalloc.c | 2 +- > cpukit/libcsupport/src/assoc32tostring.c| 2 +- > cpukit/libcsupport/src/assoclocalbyname.c | 2 +- > cpukit/libcsupport/src/assoclocalbyremote.c | 2 +- > cpukit/libcsupport/src/assoclocalbyremotebitfield.c | 2 +- > cpukit/libcsupport/src/assocnamebad.c | 2 +- > cpukit/libcsupport/src/assocnamebylocal.c | 2 +- > cpukit/libcsupport/src/assocnamebylocalbitfield.c | 2 +- > cpukit/libcsupport/src/assocnamebyremote.c | 2 +- > cpukit/libcsupport/src/assocnamebyremotebitfield.c | 2 +- > cpukit/libcsupport/src/assocptrbylocal.c| 2 +- > cpukit/libcsupport/src/assocptrbyname.c | 2 +- > cpukit/libcsupport/src/assocptrbyremote.c | 2 +- > cpukit/libcsupport/src/assocremotebylocal.c | 2 +- > cpukit/libcsupport/src/assocremotebylocalbitfield.c | 2 +- > cpukit/libcsupport/src/assocremotebyname.c | 2 +- > cpukit/libcsupport/src/assocthreadstatestostring.c | 2 +- > cpukit/libcsupport/src/base_fs.c| 2 +- > cpukit/libcsupport/src/cachecoherentalloc.c | 4 ++-- > cpukit/libcsupport/src/calloc.c | 2 +- > cpukit/libcsupport/src/cfgetispeed.c| 2 +- > cpukit/libcsupport/src/cfgetospeed.c| 2 +- > cpukit/libcsupport/src/cfmakeraw.c | 2 +- > cpukit/libcsupport/src/cfmakesane.c | 2 +- > cpukit/libcsupport/src/cfsetispeed.c| 2 +- > cpukit/libcsupport/src/cfsetospeed.c| 2 +- > cpukit/libcsupport/src/cfsetspeed.c | 2 +-
[PATCH] Canonicalize config.h include
Use the following variant which was already used by most source files: #ifdef HAVE_CONFIG_H #include "config.h" #endif --- cpukit/dev/i2c/eeprom.c | 4 ++-- cpukit/dev/i2c/fpga-i2c-slave.c | 4 ++-- cpukit/dev/i2c/gpio-nxp-pca9535.c | 4 ++-- cpukit/dev/i2c/i2c-bus.c| 4 ++-- cpukit/dev/i2c/i2c-dev.c| 4 ++-- cpukit/dev/i2c/sensor-lm75a.c | 2 +- cpukit/dev/i2c/switch-nxp-pca9548a.c| 4 ++-- cpukit/dev/i2c/ti-ads-16bit-adc.c | 4 ++-- cpukit/dev/i2c/ti-lm25066a.c| 4 ++-- cpukit/dev/i2c/ti-tmp112.c | 4 ++-- cpukit/dev/spi/spi-bus.c| 4 ++-- cpukit/ftpd/ftpd-init.c | 2 +- cpukit/ftpd/ftpd.c | 2 +- cpukit/libblock/src/bdbuf.c | 2 +- cpukit/libblock/src/bdpart-register.c | 2 +- cpukit/libblock/src/blkdev-blkstats.c | 4 ++-- cpukit/libblock/src/blkdev-imfs.c | 4 ++-- cpukit/libblock/src/blkdev-ioctl.c | 4 ++-- cpukit/libblock/src/blkdev-print-stats.c| 4 ++-- cpukit/libblock/src/blkdev.c| 2 +- cpukit/libblock/src/diskdevs-init.c | 4 ++-- cpukit/libblock/src/diskdevs.c | 2 +- cpukit/libblock/src/flashdisk.c | 2 +- cpukit/libblock/src/ide_part_table.c| 2 +- cpukit/libblock/src/nvdisk-sram.c | 2 +- cpukit/libblock/src/nvdisk.c| 2 +- cpukit/libblock/src/ramdisk-init.c | 2 +- cpukit/libblock/src/ramdisk-register.c | 2 +- cpukit/libblock/src/show_bdbuf.c| 2 +- cpukit/libcsupport/src/__assert.c | 2 +- cpukit/libcsupport/src/__getpid.c | 2 +- cpukit/libcsupport/src/__gettod.c | 2 +- cpukit/libcsupport/src/__times.c| 2 +- cpukit/libcsupport/src/__usrenv.c | 4 ++-- cpukit/libcsupport/src/_calloc_r.c | 2 +- cpukit/libcsupport/src/_free_r.c| 2 +- cpukit/libcsupport/src/_malloc_r.c | 2 +- cpukit/libcsupport/src/_realloc_r.c | 2 +- cpukit/libcsupport/src/_rename_r.c | 2 +- cpukit/libcsupport/src/access.c | 2 +- cpukit/libcsupport/src/alignedalloc.c | 2 +- cpukit/libcsupport/src/assoc32tostring.c| 2 +- cpukit/libcsupport/src/assoclocalbyname.c | 2 +- cpukit/libcsupport/src/assoclocalbyremote.c | 2 +- cpukit/libcsupport/src/assoclocalbyremotebitfield.c | 2 +- cpukit/libcsupport/src/assocnamebad.c | 2 +- cpukit/libcsupport/src/assocnamebylocal.c | 2 +- cpukit/libcsupport/src/assocnamebylocalbitfield.c | 2 +- cpukit/libcsupport/src/assocnamebyremote.c | 2 +- cpukit/libcsupport/src/assocnamebyremotebitfield.c | 2 +- cpukit/libcsupport/src/assocptrbylocal.c| 2 +- cpukit/libcsupport/src/assocptrbyname.c | 2 +- cpukit/libcsupport/src/assocptrbyremote.c | 2 +- cpukit/libcsupport/src/assocremotebylocal.c | 2 +- cpukit/libcsupport/src/assocremotebylocalbitfield.c | 2 +- cpukit/libcsupport/src/assocremotebyname.c | 2 +- cpukit/libcsupport/src/assocthreadstatestostring.c | 2 +- cpukit/libcsupport/src/base_fs.c| 2 +- cpukit/libcsupport/src/cachecoherentalloc.c | 4 ++-- cpukit/libcsupport/src/calloc.c | 2 +- cpukit/libcsupport/src/cfgetispeed.c| 2 +- cpukit/libcsupport/src/cfgetospeed.c| 2 +- cpukit/libcsupport/src/cfmakeraw.c | 2 +- cpukit/libcsupport/src/cfmakesane.c | 2 +- cpukit/libcsupport/src/cfsetispeed.c| 2 +- cpukit/libcsupport/src/cfsetospeed.c| 2 +- cpukit/libcsupport/src/cfsetspeed.c | 2 +- cpukit/libcsupport/src/chdir.c | 4 ++-- cpukit/libcsupport/src/chmod.c | 4 ++-- cpukit/libcsupport/src/chown.c | 4 ++-- cpukit/libcsupport/src/chroot.c | 4
