Re: [PATCH 1/5] bsps: Use bsps/aarch64/xilinx-zynqmp
On 19.03.24 18:34, Chris Johns wrote: I will build the BSPs for each commit today. Thanks. The reason I raised this is GitLab can squash merges to `main` and the reason is always being able to bisect `main` so it is an issue being considered. This patch set made me wonder what we do now? I would definitely not squash commits when they are merged. This would make the history more difficult to review and would also complicate things if a specific commit breaks something. The more commits you have the easier it is to single out the trouble maker. -- embedded brains GmbH & Co. KG Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 1/5] bsps: Use bsps/aarch64/xilinx-zynqmp
On 19/3/2024 5:59 pm, Sebastian Huber wrote: > On 19.03.24 03:21, Chris Johns wrote: >> Does this patch series build at the per commit level? > > I used > > ./waf bspdefaults > a.txt > apply patch > ./waf bspdefaults > b.txt > diff a.txt b.txt > > to check that the defaults don't change. Great. > I will build the BSPs for each commit today. Thanks. The reason I raised this is GitLab can squash merges to `main` and the reason is always being able to bisect `main` so it is an issue being considered. This patch set made me wonder what we do now? Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 1/5] bsps: Use bsps/aarch64/xilinx-zynqmp
On 19.03.24 03:21, Chris Johns wrote: Does this patch series build at the per commit level? I used ./waf bspdefaults > a.txt apply patch ./waf bspdefaults > b.txt diff a.txt b.txt to check that the defaults don't change. I will build the BSPs for each commit today. -- embedded brains GmbH & Co. KG Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 1/5] bsps: Use bsps/aarch64/xilinx-zynqmp
Does this patch series build at the per commit level? Chris On 19/3/2024 3:30 am, Sebastian Huber wrote: > --- > spec/build/bsps/dev/irq/optarmgic-icc-bpr0.yml| 6 +- > spec/build/bsps/dev/irq/optarmgic-icc-igrpen0.yml | 6 +- > spec/build/cpukit/optsmp.yml | 6 +- > 3 files changed, 3 insertions(+), 15 deletions(-) > > diff --git a/spec/build/bsps/dev/irq/optarmgic-icc-bpr0.yml > b/spec/build/bsps/dev/irq/optarmgic-icc-bpr0.yml > index 5338538de0..44d2671eb6 100644 > --- a/spec/build/bsps/dev/irq/optarmgic-icc-bpr0.yml > +++ b/spec/build/bsps/dev/irq/optarmgic-icc-bpr0.yml > @@ -15,11 +15,7 @@ default: >- aarch64/xilinx_versal_aiedge >- aarch64/xilinx_versal_qemu >- aarch64/xilinx_versal_vck190 > - - aarch64/xilinx_zynqmp_ilp32_qemu > - - aarch64/xilinx_zynqmp_ilp32_zu3eg > - - aarch64/xilinx_zynqmp_lp64_cfc400x > - - aarch64/xilinx_zynqmp_lp64_qemu > - - aarch64/xilinx_zynqmp_lp64_zu3eg > + - bsps/aarch64/xilinx-zynqmp >value: null > - enabled-by: true >value: 0x0002 > diff --git a/spec/build/bsps/dev/irq/optarmgic-icc-igrpen0.yml > b/spec/build/bsps/dev/irq/optarmgic-icc-igrpen0.yml > index fbc2dd9227..9b552c3f96 100644 > --- a/spec/build/bsps/dev/irq/optarmgic-icc-igrpen0.yml > +++ b/spec/build/bsps/dev/irq/optarmgic-icc-igrpen0.yml > @@ -15,11 +15,7 @@ default: >- aarch64/xilinx_versal_aiedge >- aarch64/xilinx_versal_qemu >- aarch64/xilinx_versal_vck190 > - - aarch64/xilinx_zynqmp_ilp32_qemu > - - aarch64/xilinx_zynqmp_ilp32_zu3eg > - - aarch64/xilinx_zynqmp_lp64_cfc400x > - - aarch64/xilinx_zynqmp_lp64_qemu > - - aarch64/xilinx_zynqmp_lp64_zu3eg > + - bsps/aarch64/xilinx-zynqmp >value: null > - enabled-by: true >value: 0x0001 > diff --git a/spec/build/cpukit/optsmp.yml b/spec/build/cpukit/optsmp.yml > index 45d41299da..f78558d6eb 100644 > --- a/spec/build/cpukit/optsmp.yml > +++ b/spec/build/cpukit/optsmp.yml > @@ -13,11 +13,6 @@ default: > description: | >Enable the Symmetric Multiprocessing (SMP) support > enabled-by: > -- aarch64/xilinx_zynqmp_ilp32_qemu > -- aarch64/xilinx_zynqmp_ilp32_zu3eg > -- aarch64/xilinx_zynqmp_lp64_cfc400x > -- aarch64/xilinx_zynqmp_lp64_qemu > -- aarch64/xilinx_zynqmp_lp64_zu3eg > - arm/altcycv_devkit > - arm/fvp_cortex_r52 > - arm/imx7 > @@ -33,6 +28,7 @@ enabled-by: > - arm/xilinx_zynq_picozed > - arm/xilinx_zynq_pynq > - arm/xilinx_zynq_microzed > +- bsps/aarch64/xilinx-zynqmp > - i386/pc386 > - i386/pc486 > - i386/pc586 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
[PATCH 1/5] bsps: Use bsps/aarch64/xilinx-zynqmp
--- spec/build/bsps/dev/irq/optarmgic-icc-bpr0.yml| 6 +- spec/build/bsps/dev/irq/optarmgic-icc-igrpen0.yml | 6 +- spec/build/cpukit/optsmp.yml | 6 +- 3 files changed, 3 insertions(+), 15 deletions(-) diff --git a/spec/build/bsps/dev/irq/optarmgic-icc-bpr0.yml b/spec/build/bsps/dev/irq/optarmgic-icc-bpr0.yml index 5338538de0..44d2671eb6 100644 --- a/spec/build/bsps/dev/irq/optarmgic-icc-bpr0.yml +++ b/spec/build/bsps/dev/irq/optarmgic-icc-bpr0.yml @@ -15,11 +15,7 @@ default: - aarch64/xilinx_versal_aiedge - aarch64/xilinx_versal_qemu - aarch64/xilinx_versal_vck190 - - aarch64/xilinx_zynqmp_ilp32_qemu - - aarch64/xilinx_zynqmp_ilp32_zu3eg - - aarch64/xilinx_zynqmp_lp64_cfc400x - - aarch64/xilinx_zynqmp_lp64_qemu - - aarch64/xilinx_zynqmp_lp64_zu3eg + - bsps/aarch64/xilinx-zynqmp value: null - enabled-by: true value: 0x0002 diff --git a/spec/build/bsps/dev/irq/optarmgic-icc-igrpen0.yml b/spec/build/bsps/dev/irq/optarmgic-icc-igrpen0.yml index fbc2dd9227..9b552c3f96 100644 --- a/spec/build/bsps/dev/irq/optarmgic-icc-igrpen0.yml +++ b/spec/build/bsps/dev/irq/optarmgic-icc-igrpen0.yml @@ -15,11 +15,7 @@ default: - aarch64/xilinx_versal_aiedge - aarch64/xilinx_versal_qemu - aarch64/xilinx_versal_vck190 - - aarch64/xilinx_zynqmp_ilp32_qemu - - aarch64/xilinx_zynqmp_ilp32_zu3eg - - aarch64/xilinx_zynqmp_lp64_cfc400x - - aarch64/xilinx_zynqmp_lp64_qemu - - aarch64/xilinx_zynqmp_lp64_zu3eg + - bsps/aarch64/xilinx-zynqmp value: null - enabled-by: true value: 0x0001 diff --git a/spec/build/cpukit/optsmp.yml b/spec/build/cpukit/optsmp.yml index 45d41299da..f78558d6eb 100644 --- a/spec/build/cpukit/optsmp.yml +++ b/spec/build/cpukit/optsmp.yml @@ -13,11 +13,6 @@ default: description: | Enable the Symmetric Multiprocessing (SMP) support enabled-by: -- aarch64/xilinx_zynqmp_ilp32_qemu -- aarch64/xilinx_zynqmp_ilp32_zu3eg -- aarch64/xilinx_zynqmp_lp64_cfc400x -- aarch64/xilinx_zynqmp_lp64_qemu -- aarch64/xilinx_zynqmp_lp64_zu3eg - arm/altcycv_devkit - arm/fvp_cortex_r52 - arm/imx7 @@ -33,6 +28,7 @@ enabled-by: - arm/xilinx_zynq_picozed - arm/xilinx_zynq_pynq - arm/xilinx_zynq_microzed +- bsps/aarch64/xilinx-zynqmp - i386/pc386 - i386/pc486 - i386/pc586 -- 2.35.3 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
