Re: [PATCH rtems-tools v1 05/10] CoverageWriterRTEMS.cc: Fix formatting

[Chris Johns]

On 9/9/21 2:44 am, Ryan Long wrote:
> ---
>  tester/covoar/CoverageWriterRTEMS.cc | 23 +++
>  1 file changed, 11 insertions(+), 12 deletions(-)
> 
> diff --git a/tester/covoar/CoverageWriterRTEMS.cc 
> b/tester/covoar/CoverageWriterRTEMS.cc
> index 3332cd4..d6c6ca3 100644
> --- a/tester/covoar/CoverageWriterRTEMS.cc
> +++ b/tester/covoar/CoverageWriterRTEMS.cc
> @@ -30,9 +30,9 @@ namespace Coverage {
>  
>void CoverageWriterRTEMS::writeFile(
>  const std::string& file,
> -CoverageMapBase*  coverage,
> -uint32_t  lowAddress,
> -uint32_t  highAddress
> +CoverageMapBase*   coverage,
> +uint32_t   lowAddress,
> +uint32_t   highAddress
>)
>{
>  std::ofstream   coverageFile;
> @@ -52,9 +52,9 @@ namespace Coverage {
>  }
>  
>  /* clear out the header and fill it in */
> -memset( , 0, sizeof(header) );
> +memset( , 0, sizeof( header ) );
>  header.ver   = 0x1;
> -header.header_length = sizeof(header);
> +header.header_length = sizeof( header );
>  header.start = lowAddress;
>  header.end   = highAddress;
>  strcpy( header.desc, "RTEMS Coverage Data" );
> @@ -68,8 +68,8 @@ namespace Coverage {
>throw rld::error( what, "CoverageWriterRTEMS::writeFile" );
>  }
>  
> -for ( a=lowAddress ; a < highAddress ; a++ ) {
> -  cover  = ((coverage->wasExecuted( a )) ? 0x01 : 0);
> +for ( a = lowAddress; a < highAddress; a++ ) {
> +  cover  = ( ( coverage->wasExecuted( a ) ) ? 0x01 : 0 );
>  
>bytes_before = coverageFile.tellp();
>  
> @@ -78,11 +78,10 @@ namespace Coverage {
>  std::cerr << "CoverageWriterRTEMS::writeFile - write to "
><< file
><< " at address 0x%"
> -  << std::hex << std::setfill('0')
> -  << std::setw(8) << a
> -  << std::setfill(' ') << std::dec
> -  << " failed"
> -  << std::endl;
> +  << std::hex << std::setfill( '0' )
> +  << std::setw( 8 ) << a
> +  << std::setfill( ' ' ) << std::dec
> +  << " failed\n";

The "\n" should be std::endl.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH rtems-tools v1 05/10] CoverageWriterRTEMS.cc: Fix formatting

[Ryan Long]

---
 tester/covoar/CoverageWriterRTEMS.cc | 23 +++
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/tester/covoar/CoverageWriterRTEMS.cc 
b/tester/covoar/CoverageWriterRTEMS.cc
index 3332cd4..d6c6ca3 100644
--- a/tester/covoar/CoverageWriterRTEMS.cc
+++ b/tester/covoar/CoverageWriterRTEMS.cc
@@ -30,9 +30,9 @@ namespace Coverage {
 
   void CoverageWriterRTEMS::writeFile(
 const std::string& file,
-CoverageMapBase*  coverage,
-uint32_t  lowAddress,
-uint32_t  highAddress
+CoverageMapBase*   coverage,
+uint32_t   lowAddress,
+uint32_t   highAddress
   )
   {
 std::ofstream   coverageFile;
@@ -52,9 +52,9 @@ namespace Coverage {
 }
 
 /* clear out the header and fill it in */
-memset( , 0, sizeof(header) );
+memset( , 0, sizeof( header ) );
 header.ver   = 0x1;
-header.header_length = sizeof(header);
+header.header_length = sizeof( header );
 header.start = lowAddress;
 header.end   = highAddress;
 strcpy( header.desc, "RTEMS Coverage Data" );
@@ -68,8 +68,8 @@ namespace Coverage {
   throw rld::error( what, "CoverageWriterRTEMS::writeFile" );
 }
 
-for ( a=lowAddress ; a < highAddress ; a++ ) {
-  cover  = ((coverage->wasExecuted( a )) ? 0x01 : 0);
+for ( a = lowAddress; a < highAddress; a++ ) {
+  cover  = ( ( coverage->wasExecuted( a ) ) ? 0x01 : 0 );
 
   bytes_before = coverageFile.tellp();
 
@@ -78,11 +78,10 @@ namespace Coverage {
 std::cerr << "CoverageWriterRTEMS::writeFile - write to "
   << file
   << " at address 0x%"
-  << std::hex << std::setfill('0')
-  << std::setw(8) << a
-  << std::setfill(' ') << std::dec
-  << " failed"
-  << std::endl;
+  << std::hex << std::setfill( '0' )
+  << std::setw( 8 ) << a
+  << std::setfill( ' ' ) << std::dec
+  << " failed\n";
   }
 }
 
-- 
1.8.3.1

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel