Re: [PATCH v3] user: Document patch review process
On 28/10/2019 22:03, Chris Johns wrote: On 29/10/19 1:42 am, Sebastian Huber wrote: Any objections to commit this patch? Should "Must be done by an RTEMS Maintainer" be "Push performed by an approved RTEMS Committer" ? This covers "Maintainers" and those with commit access to a specific area. Otherwise this look good. Thanks for having a look at it. I checked in the patches. The last one with your changes. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key available on request. Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH v3] user: Document patch review process
On 29/10/19 1:42 am, Sebastian Huber wrote: > Any objections to commit this patch? Should "Must be done by an RTEMS Maintainer" be "Push performed by an approved RTEMS Committer" ? This covers "Maintainers" and those with commit access to a specific area. Otherwise this look good. Chris > > On 02/10/2019 08:21, Sebastian Huber wrote: >> --- >> v2: >> >> * Added ticket comments to checklist for patches. >> >> * Added checklist for patches step to figure: >> >> http://www.plantuml.com/plantuml/uml/dL71Yjim4BthAnwcXuJYXRscXwRG7dhOiEosXq8kMdiSgskDtD4u8NzVUrH8sa0BFGYacVVUwBtPPlMYKnoSivjpcmyYdW-4Sve4JR_SCmBlsJF8vpCqGUWOw0JFxPwRr9CGAqQlJOzC4YY_MuJ6SPZHFSqgrBmE8Ikw90LN89_vc5vfWwew16j6hxNrgshfFnEtfd2j3KrewKZ3LfHYlajoCDtogK9Jx1RO_VmwzM4Wh9wiIvBHKlJSNbcxcV1-ZP2n-aPvxO3DnsG8eHzJ4BemJKN8Ay63wVH70WlrwzWkRGiXnHWKaNBsncwQ96tWmt0ks7_d1LoixV3Mx05_IH7r4MzsbgNvQAP8h2WpYebEKiIH98V4sA76lQdl-RTSkYL3toc95QkwhYiCWScK_szFC-VNRdPfxLpei7gyff-yXKIZKekNCmgFP5cFziIN1JrEkRyPlsTDfIZfEpKAeJ7be4bAtfoK8E7GgmE0XoahNWXjObgcURRoqvTF3y-8Fh3EX-JE0SIjiHqDkVpUqWsvyN8RWnaDdNDPq-ZSTdvDSVW9 >> >> >> v3: >> >> * Add missing content from stray rebase commit. > ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH v3] user: Document patch review process
Any objections to commit this patch? On 02/10/2019 08:21, Sebastian Huber wrote: --- v2: * Added ticket comments to checklist for patches. * Added checklist for patches step to figure: http://www.plantuml.com/plantuml/uml/dL71Yjim4BthAnwcXuJYXRscXwRG7dhOiEosXq8kMdiSgskDtD4u8NzVUrH8sa0BFGYacVVUwBtPPlMYKnoSivjpcmyYdW-4Sve4JR_SCmBlsJF8vpCqGUWOw0JFxPwRr9CGAqQlJOzC4YY_MuJ6SPZHFSqgrBmE8Ikw90LN89_vc5vfWwew16j6hxNrgshfFnEtfd2j3KrewKZ3LfHYlajoCDtogK9Jx1RO_VmwzM4Wh9wiIvBHKlJSNbcxcV1-ZP2n-aPvxO3DnsG8eHzJ4BemJKN8Ay63wVH70WlrwzWkRGiXnHWKaNBsncwQ96tWmt0ks7_d1LoixV3Mx05_IH7r4MzsbgNvQAP8h2WpYebEKiIH98V4sA76lQdl-RTSkYL3toc95QkwhYiCWScK_szFC-VNRdPfxLpei7gyff-yXKIZKekNCmgFP5cFziIN1JrEkRyPlsTDfIZfEpKAeJ7be4bAtfoK8E7GgmE0XoahNWXjObgcURRoqvTF3y-8Fh3EX-JE0SIjiHqDkVpUqWsvyN8RWnaDdNDPq-ZSTdvDSVW9 v3: * Add missing content from stray rebase commit. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key available on request. Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
[PATCH v3] user: Document patch review process
---
v2:
* Added ticket comments to checklist for patches.
* Added checklist for patches step to figure:
http://www.plantuml.com/plantuml/uml/dL71Yjim4BthAnwcXuJYXRscXwRG7dhOiEosXq8kMdiSgskDtD4u8NzVUrH8sa0BFGYacVVUwBtPPlMYKnoSivjpcmyYdW-4Sve4JR_SCmBlsJF8vpCqGUWOw0JFxPwRr9CGAqQlJOzC4YY_MuJ6SPZHFSqgrBmE8Ikw90LN89_vc5vfWwew16j6hxNrgshfFnEtfd2j3KrewKZ3LfHYlajoCDtogK9Jx1RO_VmwzM4Wh9wiIvBHKlJSNbcxcV1-ZP2n-aPvxO3DnsG8eHzJ4BemJKN8Ay63wVH70WlrwzWkRGiXnHWKaNBsncwQ96tWmt0ks7_d1LoixV3Mx05_IH7r4MzsbgNvQAP8h2WpYebEKiIH98V4sA76lQdl-RTSkYL3toc95QkwhYiCWScK_szFC-VNRdPfxLpei7gyff-yXKIZKekNCmgFP5cFziIN1JrEkRyPlsTDfIZfEpKAeJ7be4bAtfoK8E7GgmE0XoahNWXjObgcURRoqvTF3y-8Fh3EX-JE0SIjiHqDkVpUqWsvyN8RWnaDdNDPq-ZSTdvDSVW9
v3:
* Add missing content from stray rebase commit.
images/user/patch-review.png | Bin 0 -> 63668 bytes
images/user/patch-review.puml | 48 ++
user/support/contrib.rst | 111 --
3 files changed, 156 insertions(+), 3 deletions(-)
create mode 100644 images/user/patch-review.png
create mode 100644 images/user/patch-review.puml
diff --git a/images/user/patch-review.png b/images/user/patch-review.png
new file mode 100644
index
..40ee0a99894c03537c2f01f1296018b0f089c662
GIT binary patch
literal 63668
zcmZsDWmr^Qqqc=~2}pN?gmfby4FiaDgVN2=rF2M3Nr{w-l!!D)cMjdsL#H%+Yt-jG
z}I%gfE)Yp=cXt~KGR5Lrw#60}>lZehyHJ$-iT*6saUx9*Oh+yPg(ijzaYKg>{R
zZK#=pqo?glbLcJEm-a86O`tDdP?>sCSwf+XLL3~9wkGyaS36sFGY30dPC>F;x9+^R
zdae!q=lZSNpcs$z40UCPX-h6~MvRF4U!opiJ!^9M5%tO
zf5#d2O5?o~+a5ucQZkpCp!M5_EcOXx7}l>>)fF`~kbb(*Q79RrnLK)-P}#}0o~B<&
z_$C{sgL+fD%y$$9DUg1onxFZyF~EkljrZZ>o>pe9on4xx$?B_K|Hjo1PuAzW
z?^#Qo(aTTZd8)3sU}WS%vML0-JgUM_?OC$Dk6oT7Bwqv7
z=Bpf@D7lkqPrnDU*xaLGOoOO%S3Ga;BhG1BV-K0fi|g>wK?h`4@v3yWDloyF{8v
zGJ7+&#g-%T555Vtg8wiE79D9lRHruq05R})@z@oeb*H|>=%-`h$y=
z8V?Ml*{4shT0ClA#iLunCCIBw)wfaP6imKzrH?k#=~D^~TR+tC#@1MwTf^Vi;!Yvd
zpXz{bUx;Y)te2O66yKP$ysbX>!x&}jk@=N};~lM~wz~pPIMxk@+BC3AKj;@
z*fMPt>FSM}$H{hVtfb|=owc_5J7X8$TMCWQ9MZO%YLce>KEemm8(~KHqJ@YU)6w
zqNweM_DD=f$D81MKB9*N!X`ri?EdD5ZMW|r5FXV7#Sk=!H6yEsh)
z!!Y?L17TrN_7ggnU)@^CQL|W_-hc?*C*E!L+w>vZ+ycTurIZ9G{&=)S!RA@pj9`
z8$9Q!1IgWK-mz;+2Q3k4?RNP(g2|M`1{*
zDCYX+9_n-gd2cjou2m^V{T4(qT7
zI9*nIQ^%j{WaPBps)8}%d1W<*Uq6=nFp#)HN!tY7oTt0y?q691;I}3qZ
z#A9Ko0aT~2(;?t?>}6;G6^b8K0p2}{y}N=L3$bbZ4qo2g*u-49YB@4_3W=X}%FU<0
z+gbFzBOoMXWK+QLk$^B(E$%OMP*6~4e16Uxhv|Fq>+1SqH?I))9tSAgugdr0dwF^J
z$RZcZ^N;Ug@LX2BdxYQ*kj~D|^~v@-nu8=G1y7(+tW+oYsldq1VD4DPAfQWxN*
zbJ~nO`c&<5Z_-Onu5+^7LjBpZVHm7y>mDU2fTGIrrzCthFK?NPxDhzQHhAm7;~m5F?ijT!gue4KP_7u`K10#Lr*yri`>W8
zw?fzM`Ez{5(Yy-0r)2@@5Pa{<4mi26+tL2M$tN#KNl68Th;MEIOq#KUWo#=y{S$)jMy7-otDdf~Oj^`oV+
zBE2s7Jr%@vdwjnU+?cJcgcQE8|^5ct^`jj7t;a~4I)9}h$A2OXFm8y7c}uT1)>
zy1c2q-F@SAFt0K00pfwv+u?2(zqa$PlhnT3PR59xhoOp6QN0rDk=wfmUKm<#
zF(4x&6HO@&$~<@$ccZ*HR+P+PRNO`_g~EDeYZ^
z+a?+N=3u5*;nv2&(QvvLOD=BrE1WwUU0x^(^U2$RJ|?;*P*QIMCHs+5l>*5r8JLo=Koi&23P=UxHmq)ae;
ztpmXav3H;8^?5
zkGn%cz_sUh5Z6d$RDijE4kI94e{@L30
zo^dn0NCz@fUTlcC(4zX;2UC0jbmGcg1r=-wCNMa2b7ja>QVw2fUo|y{$}mMpZhhkB
z^jo}~55Rh1E)t)~9dJtOEVPe3j+Gg=4e1F-2bm>5nr;j>Mh=H2{k=}O_1aVu
zUJ{0HyM8q=FE@hIi>;eCuphrkV;H|Dy*Ic1$h)#c9{9l+Dt@NtBACqocll`jBPr
zbAyUl*r?*UAYQs3vt`;0E`A%UlHZ&_VuPX0-Me>bX==gXtwdz@LqUC=LwTu!W6E
z31```rLF|^Lyw(B`EY5f+~io@g9JW&;B(&?`D{I^z|1^!kS8Lo=6GI?1fhZC
znP=95HNpGJlq>b02Tk)}^IknKn*zFWWCW{g2aH`X?kkTM+mVq^)A+|kUFoJ=FU9O8
zv8By^kZ$36sZeP;I9jK_$j_jOr{kDR2|%0#(^a-n7vtHxJw|9B!R
zGUr-n963kh%v*vMp6^UnoFvR6)!rxFt9?daRI_JdsYQo}O@~Gpls8n;_#X0ec9J)K
zHT7}j3OO3s)5!FQfPAbz{;nCOgRfKsy!`vNa_tK@$k%eNb>%+muVDi
zcTV)a8A+7MAd`MVsul4xdc-5O53O_co5cnfnj*fJRUC9LxulJYnAK~YcM
z8~x@ogk|3=b`o;?Upf&!M_S9zr`Q@=BFJxCUS_gorF%i3(4Q{o*BnH>m_#O0m8YC$
zZhJoKE^9me3rSa_NO$Gxf`7JwoZoe0v)BLR?<4zJK;gM
z1P$u7m!L-TB{FZ;BT*;FKG`VsYPuxR*o=H^Mhh!wdmXRTx2HxYp+0q4m!e9B+t0NprfOVm?C0uUiRy((
zZ9%zM?w|Q9prbaf}I&!(X7{KI#ji(W|saRIN{kW4=Iza_it=rB2v
zU_$1b6aSw|{`U5}VUd4fe9fJm*zZR38{Mtq!TJkYop%TCk7Y0n;VE5XNCNXOySVCVunA
zqS3GhU#G!G2L=3J-5kZrlK^V!v9((3!hJjDW)RIZ3V5vV08Z2lc@7Mf?J
zDV6;0MA^zrb;5UBoiHO?SxI45eH^<|?9nojsEQezIFi>^q1q>{6apV$YV|Exb
zbJmZ1W+)uZ)Q%xxTv(dSPUlI;^unL
zswXQT@a>aM`Nr|)<1g_FiCb7?6VSE(xKHXvp*xSc>FH}gH}CC^79x|APp>W<
zRev>remmKob~5tiwVNn4jDQTpWE>p46ZP?+oFR9Z5g4iWz9?xlr27^D7I(%!%?SGN
