Re: [PATCH v5 2/2] covoar/Target_i386: Add NOP patterns

2021-03-25 Thread Gedare Bloom 
This patch looks fine.

On Thu, Mar 18, 2021 at 12:05 PM Alex White  wrote:
>
> A couple of NOP patterns found with the pc686 BSP were not detected.
> This has been fixed.
> ---
>  tester/covoar/Target_i386.cc | 9 +
>  1 file changed, 9 insertions(+)
>
> diff --git a/tester/covoar/Target_i386.cc b/tester/covoar/Target_i386.cc
> index e0c9c0f..4567c1e 100644
> --- a/tester/covoar/Target_i386.cc
> +++ b/tester/covoar/Target_i386.cc
> @@ -87,6 +87,15 @@ namespace Target {
>size = 3;
>return true;
>  }
> +if (!strncmp( [strlen(line)-28], "lea0x0(%esi,%eiz,1),%esi", 
> 28)) {
> +  // Could be 4 or 7 bytes of padding.
> +  if (!strncmp( [strlen(line)-32], "00", 2)) {
> +size = 7;
> +  } else {
> +size = 4;
> +  }
> +  return true;
> +}
>
>  return false;
>}
> --
> 2.27.0
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH v5 2/2] covoar/Target_i386: Add NOP patterns

2021-03-18 Thread Alex White 
A couple of NOP patterns found with the pc686 BSP were not detected.
This has been fixed.
---
 tester/covoar/Target_i386.cc | 9 +
 1 file changed, 9 insertions(+)

diff --git a/tester/covoar/Target_i386.cc b/tester/covoar/Target_i386.cc
index e0c9c0f..4567c1e 100644
--- a/tester/covoar/Target_i386.cc
+++ b/tester/covoar/Target_i386.cc
@@ -87,6 +87,15 @@ namespace Target {
   size = 3;
   return true;
 }
+if (!strncmp( [strlen(line)-28], "lea0x0(%esi,%eiz,1),%esi", 28)) 
{
+  // Could be 4 or 7 bytes of padding.
+  if (!strncmp( [strlen(line)-32], "00", 2)) {
+size = 7;
+  } else {
+size = 4;
+  }
+  return true;
+}
 
 return false;
   }
-- 
2.27.0

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel