Re: RTEMS-libbsd copyright question

[punit vara]

Hi Sichen

On Wed, Jun 21, 2017 at 11:05 AM, Sebastian Huber
 wrote:
> On 19/06/17 15:45, Sichen Zhao wrote:
>
>> Ok, so i think most of my ported file shouldn't add copyright.
>> But some file in the rtemsbsd folder , i think i modified some new
>> code.  The link is below:
>>
>> https://github.com/hahchenchen/rtems-libbsd/blob/usb2.0/rtemsbsd/include/bsp/nexus-devices.h#L49
>>
>>
>> https://github.com/hahchenchen/rtems-libbsd/blob/usb2.0/rtemsbsd/include/machine/rtems-bsd-nexus-bus.h#L260
>
>
> It would be easier to look at patches, so that you can see what is actually
> changed.
>
> In general, changes in the "freebsd" subdirectory should be as small and
> mechanical as possible. There should be simply nothing to do that deserves a
> copyright.
>
>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax : +49 89 189 47 41-09
> E-Mail  : sebastian.hu...@embedded-brains.de
> PGP : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
Don't add copy right as of now. You can always show off your commits
if someone ask you to show your work. Any way once it is merged with
rtems , it will be represented as green dot ;)
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: RTEMS-libbsd copyright question

[Sebastian Huber]

On 19/06/17 15:45, Sichen Zhao wrote:


Ok, so i think most of my ported file shouldn't add copyright.
But some file in the rtemsbsd folder , i think i modified some new
code.  The link is below:
https://github.com/hahchenchen/rtems-libbsd/blob/usb2.0/rtemsbsd/include/bsp/nexus-devices.h#L49

https://github.com/hahchenchen/rtems-libbsd/blob/usb2.0/rtemsbsd/include/machine/rtems-bsd-nexus-bus.h#L260


It would be easier to look at patches, so that you can see what is 
actually changed.


In general, changes in the "freebsd" subdirectory should be as small and 
mechanical as possible. There should be simply nothing to do that 
deserves a copyright.


--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail  : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: RTEMS-libbsd copyright question

[Sebastian Huber]

On 19/06/17 08:57, Sichen Zhao wrote:


I have a question about copyright in rtems-libbsd: i ported some usb driver 
files from FreeBSD, i modified somewhere in these files to suit with 
rtems-libbsd. Should i add my copyright in these file?


This depends on your modifications. If you put only #ifdef __rtems__ 
stuff into the drivers, then this is no work with a copyright from my 
point of view. If you do more than adding #ifdef __rtems to the driver 
files we should first check why this is necessary and if there is a way 
to avoid these modifications at all or reduce them.


--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail  : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: RTEMS-libbsd copyright question

[Gedare Bloom]

Hello Sichen Zhao,

Copyright applies to any new code that you personally author. The
conventional wisdom is that if you make 3 or more lines of new code in
a file, then you have expressed some original thoughts/ideas in the
code and a copyright existss so you can/should add your name. Changing
existing code does not necessarily give you a copyright on it, and
neither do mechanical changes i.e., code changes that do not express a
thought. This is a fairly large grey area.

Gedare


On Mon, Jun 19, 2017 at 2:57 AM, Sichen Zhao  wrote:
> Hi all,
>
> I have a question about copyright in rtems-libbsd: i ported some usb driver 
> files from FreeBSD, i modified somewhere in these files to suit with 
> rtems-libbsd. Should i add my copyright in these file?
> Besides, I also modified some files in the rtemsbsd folder,. Should i add my 
> copyright in these file?
>
> Best Regards
> Sichen Zhao
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

RTEMS-libbsd copyright question

[Sichen Zhao]

Hi all,

I have a question about copyright in rtems-libbsd: i ported some usb driver 
files from FreeBSD, i modified somewhere in these files to suit with 
rtems-libbsd. Should i add my copyright in these file?
Besides, I also modified some files in the rtemsbsd folder,. Should i add my 
copyright in these file?

Best Regards
Sichen Zhao
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel