Re: [PATCH] update rtems_waf

[Chris Johns]

On 17/9/19 6:49 pm, Christian Mauderer wrote:
> On 17/09/2019 08:51, Vijay Kumar Banerjee wrote:
>> On Fri, Sep 13, 2019 at 9:00 AM Chris Johns > > wrote:
>>
>> On 11/9/19 6:14 pm, Vijay Kumar Banerjee wrote:
>> > ping :)
>>
>> Sorry about the delay. OK to push.
>>
>> Hi,
>> Thanks for the review!
>> Can you please push this. :)
> 
> Pushed it.
> 

Thanks and I have fixed the commit email repo name in the git hook.

>> Also, the github descript for rtems-examples has the wrong link,
>> it needs to be updated to https://git.rtems.org/rtems-examples.
> 
> I don't have access to these. So I can't update it. Chris: Do you have
> access?

Yes and fixed. Thanks.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] update rtems_waf

[Christian Mauderer]

On 17/09/2019 08:51, Vijay Kumar Banerjee wrote:
> 
> 
> 
> On Fri, Sep 13, 2019 at 9:00 AM Chris Johns  > wrote:
> 
> On 11/9/19 6:14 pm, Vijay Kumar Banerjee wrote:
> > ping :)
> 
> Sorry about the delay. OK to push.
> 
> Hi,
> Thanks for the review!
> Can you please push this. :)

Pushed it.

> Also, the github descript for rtems-examples has the wrong link,
> it needs to be updated to https://git.rtems.org/rtems-examples.

I don't have access to these. So I can't update it. Chris: Do you have
access?

> 
> Best regards,
> Vijay>
> Chris
> 
> >
> >
> > On Tue, Sep 3, 2019 at 7:04 PM Vijay Kumar Banerjee
> mailto:vijaykumar9...@gmail.com>
> >  >> wrote:
> >
> >     ---
> >      file_io/crc/wscript            | 6 +++---
> >      filesystem/fat_ramdisk/wscript | 6 +++---
> >      rtems_waf                      | 2 +-
> >      3 files changed, 7 insertions(+), 7 deletions(-)
> >
> >     diff --git a/file_io/crc/wscript b/file_io/crc/wscript
> >     index f7b0f5b..531da20 100644
> >     --- a/file_io/crc/wscript
> >     +++ b/file_io/crc/wscript
> >     @@ -26,9 +26,9 @@ def build(bld):
> >          #
> >          # Package the root file system as a C file.
> >          #
> >     -    rootfs.build(bld,
> >     -                 name = 'fs-root',
> >     -                 root = 'rootfs')
> >     +    rootfs.build_from_src_root(bld,
> >     +                               name = 'fs-root',
> >     +                               root = 'rootfs')
> >
> >          bld(features = 'c cprogram',
> >              target = 'crc.exe',
> >     diff --git a/filesystem/fat_ramdisk/wscript
> b/filesystem/fat_ramdisk/wscript
> >     index de806c1..a980187 100644
> >     --- a/filesystem/fat_ramdisk/wscript
> >     +++ b/filesystem/fat_ramdisk/wscript
> >     @@ -26,9 +26,9 @@ def build(bld):
> >          #
> >          # Package the root file system as a C file.
> >          #
> >     -    rootfs.build(bld,
> >     -                 name = 'fs-root',
> >     -                 root = 'rootfs')
> >     +    rootfs.build_from_src_root(bld,
> >     +                               name = 'fs-root',
> >     +                               root = 'rootfs')
> >
> >          bld(features = 'c cprogram',
> >              target = 'fat_ramdisk.exe',
> >     diff --git a/rtems_waf b/rtems_waf
> >     index 1b89636..ad6c6e8 16
> >     --- a/rtems_waf
> >     +++ b/rtems_waf
> >     @@ -1 +1 @@
> >     -Subproject commit 1b896361d302aeda0145af90972aea863e28898f
> >     +Subproject commit ad6c6e8771b95dffa73a7dc1167d98d208f17cb0
> >     --
> >     2.20.1
> >
> 
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] update rtems_waf

[Vijay Kumar Banerjee]

On Fri, Sep 13, 2019 at 9:00 AM Chris Johns  wrote:

> On 11/9/19 6:14 pm, Vijay Kumar Banerjee wrote:
> > ping :)
>
> Sorry about the delay. OK to push.
>
> Hi,
Thanks for the review!
Can you please push this. :)
Also, the github descript for rtems-examples has the wrong link,
it needs to be updated to https://git.rtems.org/rtems-examples.

Best regards,
Vijay

> Chris
>
> >
> >
> > On Tue, Sep 3, 2019 at 7:04 PM Vijay Kumar Banerjee <
> vijaykumar9...@gmail.com
> > > wrote:
> >
> > ---
> >  file_io/crc/wscript| 6 +++---
> >  filesystem/fat_ramdisk/wscript | 6 +++---
> >  rtems_waf  | 2 +-
> >  3 files changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/file_io/crc/wscript b/file_io/crc/wscript
> > index f7b0f5b..531da20 100644
> > --- a/file_io/crc/wscript
> > +++ b/file_io/crc/wscript
> > @@ -26,9 +26,9 @@ def build(bld):
> >  #
> >  # Package the root file system as a C file.
> >  #
> > -rootfs.build(bld,
> > - name = 'fs-root',
> > - root = 'rootfs')
> > +rootfs.build_from_src_root(bld,
> > +   name = 'fs-root',
> > +   root = 'rootfs')
> >
> >  bld(features = 'c cprogram',
> >  target = 'crc.exe',
> > diff --git a/filesystem/fat_ramdisk/wscript
> b/filesystem/fat_ramdisk/wscript
> > index de806c1..a980187 100644
> > --- a/filesystem/fat_ramdisk/wscript
> > +++ b/filesystem/fat_ramdisk/wscript
> > @@ -26,9 +26,9 @@ def build(bld):
> >  #
> >  # Package the root file system as a C file.
> >  #
> > -rootfs.build(bld,
> > - name = 'fs-root',
> > - root = 'rootfs')
> > +rootfs.build_from_src_root(bld,
> > +   name = 'fs-root',
> > +   root = 'rootfs')
> >
> >  bld(features = 'c cprogram',
> >  target = 'fat_ramdisk.exe',
> > diff --git a/rtems_waf b/rtems_waf
> > index 1b89636..ad6c6e8 16
> > --- a/rtems_waf
> > +++ b/rtems_waf
> > @@ -1 +1 @@
> > -Subproject commit 1b896361d302aeda0145af90972aea863e28898f
> > +Subproject commit ad6c6e8771b95dffa73a7dc1167d98d208f17cb0
> > --
> > 2.20.1
> >
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] update rtems_waf

[Chris Johns]

On 11/9/19 6:14 pm, Vijay Kumar Banerjee wrote:
> ping :)

Sorry about the delay. OK to push.

Chris

> 
> 
> On Tue, Sep 3, 2019 at 7:04 PM Vijay Kumar Banerjee  > wrote:
> 
> ---
>  file_io/crc/wscript            | 6 +++---
>  filesystem/fat_ramdisk/wscript | 6 +++---
>  rtems_waf                      | 2 +-
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/file_io/crc/wscript b/file_io/crc/wscript
> index f7b0f5b..531da20 100644
> --- a/file_io/crc/wscript
> +++ b/file_io/crc/wscript
> @@ -26,9 +26,9 @@ def build(bld):
>      #
>      # Package the root file system as a C file.
>      #
> -    rootfs.build(bld,
> -                 name = 'fs-root',
> -                 root = 'rootfs')
> +    rootfs.build_from_src_root(bld,
> +                               name = 'fs-root',
> +                               root = 'rootfs')
> 
>      bld(features = 'c cprogram',
>          target = 'crc.exe',
> diff --git a/filesystem/fat_ramdisk/wscript 
> b/filesystem/fat_ramdisk/wscript
> index de806c1..a980187 100644
> --- a/filesystem/fat_ramdisk/wscript
> +++ b/filesystem/fat_ramdisk/wscript
> @@ -26,9 +26,9 @@ def build(bld):
>      #
>      # Package the root file system as a C file.
>      #
> -    rootfs.build(bld,
> -                 name = 'fs-root',
> -                 root = 'rootfs')
> +    rootfs.build_from_src_root(bld,
> +                               name = 'fs-root',
> +                               root = 'rootfs')
> 
>      bld(features = 'c cprogram',
>          target = 'fat_ramdisk.exe',
> diff --git a/rtems_waf b/rtems_waf
> index 1b89636..ad6c6e8 16
> --- a/rtems_waf
> +++ b/rtems_waf
> @@ -1 +1 @@
> -Subproject commit 1b896361d302aeda0145af90972aea863e28898f
> +Subproject commit ad6c6e8771b95dffa73a7dc1167d98d208f17cb0
> -- 
> 2.20.1
> 
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] update rtems_waf

[Vijay Kumar Banerjee]

ping :)


On Tue, Sep 3, 2019 at 7:04 PM Vijay Kumar Banerjee <
vijaykumar9...@gmail.com> wrote:

> ---
>  file_io/crc/wscript| 6 +++---
>  filesystem/fat_ramdisk/wscript | 6 +++---
>  rtems_waf  | 2 +-
>  3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/file_io/crc/wscript b/file_io/crc/wscript
> index f7b0f5b..531da20 100644
> --- a/file_io/crc/wscript
> +++ b/file_io/crc/wscript
> @@ -26,9 +26,9 @@ def build(bld):
>  #
>  # Package the root file system as a C file.
>  #
> -rootfs.build(bld,
> - name = 'fs-root',
> - root = 'rootfs')
> +rootfs.build_from_src_root(bld,
> +   name = 'fs-root',
> +   root = 'rootfs')
>
>  bld(features = 'c cprogram',
>  target = 'crc.exe',
> diff --git a/filesystem/fat_ramdisk/wscript
> b/filesystem/fat_ramdisk/wscript
> index de806c1..a980187 100644
> --- a/filesystem/fat_ramdisk/wscript
> +++ b/filesystem/fat_ramdisk/wscript
> @@ -26,9 +26,9 @@ def build(bld):
>  #
>  # Package the root file system as a C file.
>  #
> -rootfs.build(bld,
> - name = 'fs-root',
> - root = 'rootfs')
> +rootfs.build_from_src_root(bld,
> +   name = 'fs-root',
> +   root = 'rootfs')
>
>  bld(features = 'c cprogram',
>  target = 'fat_ramdisk.exe',
> diff --git a/rtems_waf b/rtems_waf
> index 1b89636..ad6c6e8 16
> --- a/rtems_waf
> +++ b/rtems_waf
> @@ -1 +1 @@
> -Subproject commit 1b896361d302aeda0145af90972aea863e28898f
> +Subproject commit ad6c6e8771b95dffa73a7dc1167d98d208f17cb0
> --
> 2.20.1
>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] update rtems_waf

[Vijay Kumar Banerjee]

On Thu, Sep 5, 2019 at 3:00 PM Christian Mauderer <
christian.maude...@embedded-brains.de> wrote:

> Hello Vijay,
>
> from the content I assume that's for rtems-examples.
>
> Out of curiosity: Is there some specific problem that is solved with
> that patch or is it just to be on the latest version? If there is a
> problem, it would be good to mention that in the commit message. If
> someone else has the same problem, he might be able to find the message
> and see that the commit solves it.
>
> Hi Christian,

The current build works fine, the intention behind updating is to use the
rtems_bsd checks that are present in the latest HEAD of rtems_waf. I was
using the new features in the lvgl example, but since that one has a pending
discussion, I sent a separate patch to just update the rtems_waf.

Best regards,
Vijay

> To be honest: I haven't really built the examples yet (maybe sometimes
> way back). So I won't be able to do a test of the patch in the next
> days. I hope that someone else will be able to test it till then so that
> it can be commited.
>
> Best regards
>
> Christian
>
> On 03/09/2019 15:33, Vijay Kumar Banerjee wrote:
> > ---
> >  file_io/crc/wscript| 6 +++---
> >  filesystem/fat_ramdisk/wscript | 6 +++---
> >  rtems_waf  | 2 +-
> >  3 files changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/file_io/crc/wscript b/file_io/crc/wscript
> > index f7b0f5b..531da20 100644
> > --- a/file_io/crc/wscript
> > +++ b/file_io/crc/wscript
> > @@ -26,9 +26,9 @@ def build(bld):
> >  #
> >  # Package the root file system as a C file.
> >  #
> > -rootfs.build(bld,
> > - name = 'fs-root',
> > - root = 'rootfs')
> > +rootfs.build_from_src_root(bld,
> > +   name = 'fs-root',
> > +   root = 'rootfs')
> >
> >  bld(features = 'c cprogram',
> >  target = 'crc.exe',
> > diff --git a/filesystem/fat_ramdisk/wscript
> b/filesystem/fat_ramdisk/wscript
> > index de806c1..a980187 100644
> > --- a/filesystem/fat_ramdisk/wscript
> > +++ b/filesystem/fat_ramdisk/wscript
> > @@ -26,9 +26,9 @@ def build(bld):
> >  #
> >  # Package the root file system as a C file.
> >  #
> > -rootfs.build(bld,
> > - name = 'fs-root',
> > - root = 'rootfs')
> > +rootfs.build_from_src_root(bld,
> > +   name = 'fs-root',
> > +   root = 'rootfs')
> >
> >  bld(features = 'c cprogram',
> >  target = 'fat_ramdisk.exe',
> > diff --git a/rtems_waf b/rtems_waf
> > index 1b89636..ad6c6e8 16
> > --- a/rtems_waf
> > +++ b/rtems_waf
> > @@ -1 +1 @@
> > -Subproject commit 1b896361d302aeda0145af90972aea863e28898f
> > +Subproject commit ad6c6e8771b95dffa73a7dc1167d98d208f17cb0
> >
>
> --
> 
> embedded brains GmbH
> Herr Christian Mauderer
> Dornierstr. 4
> D-82178 Puchheim
> Germany
> email: christian.maude...@embedded-brains.de
> Phone: +49-89-18 94 741 - 18
> Fax:   +49-89-18 94 741 - 08
> PGP: Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] update rtems_waf

[Christian Mauderer]

Hello Vijay,

from the content I assume that's for rtems-examples.

Out of curiosity: Is there some specific problem that is solved with
that patch or is it just to be on the latest version? If there is a
problem, it would be good to mention that in the commit message. If
someone else has the same problem, he might be able to find the message
and see that the commit solves it.

To be honest: I haven't really built the examples yet (maybe sometimes
way back). So I won't be able to do a test of the patch in the next
days. I hope that someone else will be able to test it till then so that
it can be commited.

Best regards

Christian

On 03/09/2019 15:33, Vijay Kumar Banerjee wrote:
> ---
>  file_io/crc/wscript| 6 +++---
>  filesystem/fat_ramdisk/wscript | 6 +++---
>  rtems_waf  | 2 +-
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/file_io/crc/wscript b/file_io/crc/wscript
> index f7b0f5b..531da20 100644
> --- a/file_io/crc/wscript
> +++ b/file_io/crc/wscript
> @@ -26,9 +26,9 @@ def build(bld):
>  #
>  # Package the root file system as a C file.
>  #
> -rootfs.build(bld,
> - name = 'fs-root',
> - root = 'rootfs')
> +rootfs.build_from_src_root(bld,
> +   name = 'fs-root',
> +   root = 'rootfs')
>  
>  bld(features = 'c cprogram',
>  target = 'crc.exe',
> diff --git a/filesystem/fat_ramdisk/wscript b/filesystem/fat_ramdisk/wscript
> index de806c1..a980187 100644
> --- a/filesystem/fat_ramdisk/wscript
> +++ b/filesystem/fat_ramdisk/wscript
> @@ -26,9 +26,9 @@ def build(bld):
>  #
>  # Package the root file system as a C file.
>  #
> -rootfs.build(bld,
> - name = 'fs-root',
> - root = 'rootfs')
> +rootfs.build_from_src_root(bld,
> +   name = 'fs-root',
> +   root = 'rootfs')
>  
>  bld(features = 'c cprogram',
>  target = 'fat_ramdisk.exe',
> diff --git a/rtems_waf b/rtems_waf
> index 1b89636..ad6c6e8 16
> --- a/rtems_waf
> +++ b/rtems_waf
> @@ -1 +1 @@
> -Subproject commit 1b896361d302aeda0145af90972aea863e28898f
> +Subproject commit ad6c6e8771b95dffa73a7dc1167d98d208f17cb0
> 

-- 

embedded brains GmbH
Herr Christian Mauderer
Dornierstr. 4
D-82178 Puchheim
Germany
email: christian.maude...@embedded-brains.de
Phone: +49-89-18 94 741 - 18
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel