Re: [PATCH 2/3] textproc/gsed: Add GNU sed build support

2022-09-15 Thread Chris Johns
On 14/9/2022 5:02 pm, chr...@rtems.org wrote:
> From: Chris Johns 
> diff --git a/bare/config/textproc/gsed-internal.bset 
> b/bare/config/textproc/gsed-internal.bset
> new file mode 100644
> index 000..e93e1a5
> --- /dev/null
> +++ b/bare/config/textproc/gsed-internal.bset
> @@ -0,0 +1,12 @@
> +#
> +# Internal GNU sed
> +#
> +
> +%define _internal_gsed  yes
> +%define _internal_gsed_path %{_tmppath}/sb-%{_uid}/${SB_PREFIX_CLEAN}
> +%define _disable_collecting yes
> +%define _disable_packaging  yes
> +%define _disable_reporting  yes
> +%define _disable_installing yes

Another issue is the explictic '%include' of this buildset in
rtems-default-tools.bset made these defines appear in the global macro space of
the packages being built and that stops them being packaged and installed. I
used an explicit include to try and share the '_internal_gsed_path' define. I
will need to find another solution to this.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


[PATCH rtems-libbsd] rtemsbsd/arasan_sd: Prevent disabled device probe

2022-09-15 Thread Kinsey Moore
Probing a SDIO/SDHCI interface that has been disabled by system init via
holding it in reset can cause a CPU hang. This prevents probing of
devices that have been disabled in such a manner on ZynqMP systems.
---
 rtemsbsd/sys/dev/sdhci/arasan_sdhci.c | 25 +
 1 file changed, 25 insertions(+)

diff --git a/rtemsbsd/sys/dev/sdhci/arasan_sdhci.c 
b/rtemsbsd/sys/dev/sdhci/arasan_sdhci.c
index ccdcb09b..6332260a 100644
--- a/rtemsbsd/sys/dev/sdhci/arasan_sdhci.c
+++ b/rtemsbsd/sys/dev/sdhci/arasan_sdhci.c
@@ -246,6 +246,31 @@ arasan_sdhci_attach(device_t dev)
goto fail;
}
 
+   /*
+* These devices may be disabled by being held in reset. If this is the
+* case, a read attempt in its register range will result in a CPU hang.
+* Detect this situation and avoid probing the device in this situation.
+*/
+#if defined(LIBBSP_AARCH64_XILINX_ZYNQMP_BSP_H)
+   volatile uint32_t *RST_LPD_IOU2_ptr = (uint32_t*)0xFF5E0238;
+   uint32_t RST_LPD_IOU2 = *RST_LPD_IOU2_ptr;
+   uint32_t SDIO0_disabled = RST_LPD_IOU2 & (1 << 5);
+   uint32_t SDIO1_disabled = RST_LPD_IOU2 & (1 << 6);
+   if ( sc->mem_res == 0xFF16 ) {
+   if ( SDIO0_disabled != 0 ) {
+   device_printf(dev, "SDIO0 disabled\n");
+   err = ENXIO;
+   goto fail;
+   }
+   } else {
+   if ( SDIO1_disabled != 0 ) {
+   device_printf(dev, "SDIO1 disabled\n");
+   err = ENXIO;
+   goto fail;
+   }
+   }
+#endif
+
rid = 0;
sc->irq_res = bus_alloc_resource_any(dev, SYS_RES_IRQ, ,
RF_ACTIVE);
-- 
2.30.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: [PATCH 1/3] sb/setbuilder: Do not install if --no-install option is used

2022-09-15 Thread Chris Johns
Hi,

There is a bug in this change. I will sort it out today.

Sorry about this.

Chris

On 14/9/22 5:02 pm, chr...@rtems.org wrote:
> From: Chris Johns 
> 
> - This is a bug introduced in the recent bset tar file changes
> ---
>  source-builder/sb/setbuilder.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/source-builder/sb/setbuilder.py b/source-builder/sb/setbuilder.py
> index 67b66f5..f24ac87 100644
> --- a/source-builder/sb/setbuilder.py
> +++ b/source-builder/sb/setbuilder.py
> @@ -560,7 +560,8 @@ class buildset:
>  buildroot = 
> path.join(b.config.expand('%{buildroot}'), prefix)
>  if self.staging():
>  prefix = b.config.expand('%{stagingroot}')
> -self.install(self.install_mode(), b.name(), 
> buildroot, prefix)
> +if not self.opts.no_install():
> +self.install(self.install_mode(), b.name(), 
> buildroot, prefix)
>  #
>  # Sizes ...
>  #
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: [PATCH 3/3] devel/gcc: Check and build GNU sed if not available on build host

2022-09-15 Thread Frank Kühndel

Hello Chris,

our CI build the tools (rtems-source-builder git) for revision

c0edd80bcd27b3dad7ee7acf5ea129e81e6a6f64 "rtems/jpeg: Update the checksum"

OK and failed for revision

468fc79e8c7c8076e8b65be82ba2009e41dd6c8e "devel/gcc: Check and build GNU 
sed if not available on build host"


with missing dependencies for expat-devel (and as followup gmp-devel). 
Excerpt from the source-builder log:


checking size of unsigned __int128... 16
checking for library containing dlopen... none required
checking whether to use expat... yes
checking for libexpat... no
configure: error: expat is missing or unusable
make[2]: *** [Makefile:10085: configure-gdb] Error 1
make[2]: *** Waiting for unfinished jobs

This happens in an opensuse leap 15.4 container within a build for RTEMS 
6 and ARM BSP. I tested on an almalinux container too and got the same 
error.


"expat" and "gmp" are usually build by the source-builder itself. Hence, 
I wonder whether these new additional dependencies on "expat-devel" and 
"gmp-devel" packages are added by intention or whether this may be a 
unwanted side effect of the patches?


Greetings
Frank

--
embedded brains GmbH
Herr Frank KÜHNDEL
Dornierstr. 4
82178 Puchheim
Germany
email: frank.kuehn...@embedded-brains.de
phone:  +49-89-18 94 741 - 23
mobile: +49-176-15 22 06 - 11
fax:+49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 3/3] devel/gcc: Check and build GNU sed if not available on build host

2022-09-15 Thread Chris Johns
On 15/9/22 9:21 pm, Frank Kühndel wrote:
> Hello Chris,
> 
> our CI build the tools (rtems-source-builder git) for revision
> 
> c0edd80bcd27b3dad7ee7acf5ea129e81e6a6f64 "rtems/jpeg: Update the checksum"
> 
> OK and failed for revision
> 
> 468fc79e8c7c8076e8b65be82ba2009e41dd6c8e "devel/gcc: Check and build GNU sed 
> if
> not available on build host"
> 
> with missing dependencies for expat-devel (and as followup gmp-devel). Excerpt
> from the source-builder log:
> 
> checking size of unsigned __int128... 16
> checking for library containing dlopen... none required
> checking whether to use expat... yes
> checking for libexpat... no
> configure: error: expat is missing or unusable
> make[2]: *** [Makefile:10085: configure-gdb] Error 1
> make[2]: *** Waiting for unfinished jobs
> 
> This happens in an opensuse leap 15.4 container within a build for RTEMS 6 and
> ARM BSP. I tested on an almalinux container too and got the same error.
> 
> "expat" and "gmp" are usually build by the source-builder itself. Hence, I
> wonder whether these new additional dependencies on "expat-devel" and
> "gmp-devel" packages are added by intention or whether this may be a unwanted
> side effect of the patches?

It is an unwanted side effect of my recent changes. My fix to stop installing
with --no-install was too aggressive. It also stopped installing the staged
output. Staging is used to collect the build output prior to installing and it
is used internally with dependent builds, ie gdb depends on expat.

Thanks for the report.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel